From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 02 03:52:42 2011 Received: (at submit) by debbugs.gnu.org; 2 Mar 2011 08:52:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuhnV-0001dt-UX for submit@debbugs.gnu.org; Wed, 02 Mar 2011 03:52:42 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuhnS-0001dg-U3 for submit@debbugs.gnu.org; Wed, 02 Mar 2011 03:52:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuhnM-000707-71 for submit@debbugs.gnu.org; Wed, 02 Mar 2011 03:52:34 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:42407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuhnM-000702-2P for submit@debbugs.gnu.org; Wed, 02 Mar 2011 03:52:32 -0500 Received: from [140.186.70.92] (port=44420 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuhnK-0008HP-7r for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2011 03:52:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuhnH-0006yr-P9 for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2011 03:52:29 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:42779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuhnH-0006xz-Ke for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2011 03:52:27 -0500 X-Authority-Analysis: v=1.1 cv=+c36koQ5Dcj/1qolKHjtkYAGXvrVJRRiKMp+84F5sLg= c=1 sm=0 a=mlNl6qZtYd0A:10 a=syinx_Tw3_MA:10 a=kj9zAlcOel0A:10 a=8YMtuzaJ5FE3wtSInqJrPg==:17 a=aR16PxjQAAAA:8 a=Gwz4RaZoH6lk74y5dg0A:9 a=eRyvQof6PKPOuUXBfLsA:7 a=7h7dhaXLjQWh6LZMGlxRqT7PBmAA:4 a=CjuIK1q_8ugA:10 a=CiSHi91Bn78A:10 a=G5XneTc65qgz7ujN:21 a=nH2RQaCahZeXip9a:21 a=8YMtuzaJ5FE3wtSInqJrPg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 76.175.234.46 Received: from [76.175.234.46] ([76.175.234.46:39337] helo=smart) by hrndva-oedge03.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id 17/54-24070-8450E6D4; Wed, 02 Mar 2011 08:52:25 +0000 Received: from dkogan by smart with local (Exim 4.72) (envelope-from ) id 1PuhnE-00072l-59 for bug-gnu-emacs@gnu.org; Wed, 02 Mar 2011 00:52:24 -0800 From: Dima Kogan To: bug-gnu-emacs@gnu.org Subject: 23.2; cperl-uncomment-region is NOT an inverse of cperl-comment-region Date: Wed, 02 Mar 2011 00:52:24 -0800 Message-ID: <878vwxgb07.fsf@cds.caltech.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) If I have a buffer in CPerl mode containing #!/usr/bin/perl use strict; use warnings; cperl-comment-region on the whole buffer makes # #!/usr/bin/perl # use strict; # use warnings; cperl-uncomment-region makes #!/usr/bin/perl use strict; use warnings; There's now an extra space at the start of the line. cperl-uncomment-region is essentially the same as (comment-region beg end -1) This produces the erroneous behavior. (uncomment-region beg end) does work, though. Thus, there may be a bug in (comment-region) In GNU Emacs 23.2.1 (x86_64-pc-linux-gnu, GTK+ Version 2.20.1) of 2010-12-11 on brahms, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.10707000 configured using `configure '--build' 'x86_64-linux-gnu' '--build' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.2/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: global-subword-mode: t subword-mode: t show-paren-mode: t shell-dirtrack-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t hs-minor-mode: t Recent input: M-x r e p o r t SPC b u Recent messages: Loading /etc/emacs/site-start.d/51semi.el (source)...done Loading /etc/emacs/site-start.d/51speedbar.el (source)...done Loading /etc/emacs/site-start.d/65wl-beta.el (source)...done Loading /usr/share/emacs/23.2/lisp/progmodes/hideshow.el.gz... uncompressing hideshow.el.gz...done Loading /usr/share/emacs/23.2/lisp/progmodes/hideshow.el.gz...done Loading shell...done Loading paren...done Loading `~/.emacs': old-style backquotes detected! For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: /usr/share/emacs/23.2/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar /usr/share/emacs/23.2/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl /usr/share/emacs/23.2/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf /usr/share/emacs/23.2/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp /usr/share/emacs/23.2/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex /usr/share/emacs/23.2/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik /usr/share/emacs/23.2/site-lisp/auctex/tex-fptex hides /usr/share/emacs/site-lisp/auctex/tex-fptex /usr/share/emacs/23.2/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite /usr/share/emacs/23.2/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info /usr/share/emacs/23.2/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp /usr/share/emacs/23.2/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font /usr/share/emacs/23.2/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x /usr/share/emacs/23.2/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex /usr/share/emacs/23.2/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex /usr/share/emacs/23.2/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold /usr/share/emacs/23.2/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context /usr/share/emacs/23.2/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en /usr/share/emacs/23.2/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt /usr/share/emacs/23.2/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style /usr/local/share/emacs/site-lisp/imaxima-autoconf-variables hides /usr/share/emacs/23.2/site-lisp/maxima/imaxima-autoconf-variables /usr/local/share/emacs/site-lisp/imaxima hides /usr/share/emacs/23.2/site-lisp/maxima/imaxima /usr/local/share/emacs/site-lisp/imath hides /usr/share/emacs/23.2/site-lisp/maxima/imath /usr/share/emacs/site-lisp/autoconf/autotest-mode hides /usr/share/emacs/site-lisp/autotest-mode /usr/share/emacs/23.2/site-lisp/magit hides /usr/share/emacs/site-lisp/magit /usr/share/emacs/23.2/site-lisp/cscope/xcscope hides /usr/share/emacs/site-lisp/xcscope /usr/share/emacs/23.2/site-lisp/cmake-data/cmake-mode hides /usr/share/emacs/site-lisp/cmake-mode /usr/share/emacs/23.2/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup /usr/share/emacs23/site-lisp/semi/pgg-pgp5 hides /usr/share/emacs/23.2/lisp/pgg-pgp5 /usr/share/emacs23/site-lisp/speedbar/sb-image hides /usr/share/emacs/23.2/lisp/sb-image /usr/share/emacs23/site-lisp/semi/pgg hides /usr/share/emacs/23.2/lisp/pgg /usr/share/emacs23/site-lisp/semi/pgg-parse hides /usr/share/emacs/23.2/lisp/pgg-parse /usr/share/emacs23/site-lisp/cedet-common/ezimage hides /usr/share/emacs/23.2/lisp/ezimage /usr/share/emacs23/site-lisp/flim/md4 hides /usr/share/emacs/23.2/lisp/md4 /usr/share/emacs23/site-lisp/semi/pgg-gpg hides /usr/share/emacs/23.2/lisp/pgg-gpg /usr/share/emacs23/site-lisp/speedbar/speedbar hides /usr/share/emacs/23.2/lisp/speedbar /usr/share/emacs23/site-lisp/flim/sha1 hides /usr/share/emacs/23.2/lisp/sha1 /usr/share/emacs23/site-lisp/semi/pgg-pgp hides /usr/share/emacs/23.2/lisp/pgg-pgp /usr/share/emacs23/site-lisp/flim/hex-util hides /usr/share/emacs/23.2/lisp/hex-util /usr/share/emacs23/site-lisp/speedbar/dframe hides /usr/share/emacs/23.2/lisp/dframe /usr/share/emacs23/site-lisp/semi/pgg-def hides /usr/share/emacs/23.2/lisp/pgg-def /usr/share/emacs23/site-lisp/dictionaries-common/flyspell hides /usr/share/emacs/23.2/lisp/textmodes/flyspell /usr/share/emacs23/site-lisp/dictionaries-common/ispell hides /usr/share/emacs/23.2/lisp/textmodes/ispell /usr/share/emacs/23.2/site-lisp/octave3.1-emacsen/octave-inf hides /usr/share/emacs/23.2/lisp/progmodes/octave-inf /usr/share/emacs/23.2/site-lisp/octave3.1-emacsen/octave-mod hides /usr/share/emacs/23.2/lisp/progmodes/octave-mod /usr/share/emacs23/site-lisp/org-mode/org-archive hides /usr/share/emacs/23.2/lisp/org/org-archive /usr/share/emacs23/site-lisp/org-mode/org-mobile hides /usr/share/emacs/23.2/lisp/org/org-mobile /usr/share/emacs23/site-lisp/org-mode/org-ascii hides /usr/share/emacs/23.2/lisp/org/org-ascii /usr/share/emacs23/site-lisp/org-mode/org-clock hides /usr/share/emacs/23.2/lisp/org/org-clock /usr/share/emacs23/site-lisp/org-mode/org-gnus hides /usr/share/emacs/23.2/lisp/org/org-gnus /usr/share/emacs23/site-lisp/org-mode/org-indent hides /usr/share/emacs/23.2/lisp/org/org-indent /usr/share/emacs23/site-lisp/org-mode/org-wl hides /usr/share/emacs/23.2/lisp/org/org-wl /usr/share/emacs23/site-lisp/org-mode/org-exp-blocks hides /usr/share/emacs/23.2/lisp/org/org-exp-blocks /usr/share/emacs23/site-lisp/org-mode/org-list hides /usr/share/emacs/23.2/lisp/org/org-list /usr/share/emacs23/site-lisp/org-mode/org-w3m hides /usr/share/emacs/23.2/lisp/org/org-w3m /usr/share/emacs23/site-lisp/org-mode/org-colview hides /usr/share/emacs/23.2/lisp/org/org-colview /usr/share/emacs23/site-lisp/org-mode/org-freemind hides /usr/share/emacs/23.2/lisp/org/org-freemind /usr/share/emacs23/site-lisp/org-mode/org-macs hides /usr/share/emacs/23.2/lisp/org/org-macs /usr/share/emacs23/site-lisp/org-mode/org-crypt hides /usr/share/emacs/23.2/lisp/org/org-crypt /usr/share/emacs23/site-lisp/org-mode/org-mhe hides /usr/share/emacs/23.2/lisp/org/org-mhe /usr/share/emacs23/site-lisp/org-mode/org-table hides /usr/share/emacs/23.2/lisp/org/org-table /usr/share/emacs23/site-lisp/org-mode/org hides /usr/share/emacs/23.2/lisp/org/org /usr/share/emacs23/site-lisp/org-mode/org-bibtex hides /usr/share/emacs/23.2/lisp/org/org-bibtex /usr/share/emacs23/site-lisp/org-mode/org-src hides /usr/share/emacs/23.2/lisp/org/org-src /usr/share/emacs23/site-lisp/org-mode/org-compat hides /usr/share/emacs/23.2/lisp/org/org-compat /usr/share/emacs23/site-lisp/org-mode/org-publish hides /usr/share/emacs/23.2/lisp/org/org-publish /usr/share/emacs23/site-lisp/org-mode/org-id hides /usr/share/emacs/23.2/lisp/org/org-id /usr/share/emacs23/site-lisp/org-mode/org-feed hides /usr/share/emacs/23.2/lisp/org/org-feed /usr/share/emacs23/site-lisp/org-mode/org-habit hides /usr/share/emacs/23.2/lisp/org/org-habit /usr/share/emacs23/site-lisp/org-mode/org-rmail hides /usr/share/emacs/23.2/lisp/org/org-rmail /usr/share/emacs23/site-lisp/org-mode/org-plot hides /usr/share/emacs/23.2/lisp/org/org-plot /usr/share/emacs23/site-lisp/org-mode/org-protocol hides /usr/share/emacs/23.2/lisp/org/org-protocol /usr/share/emacs23/site-lisp/org-mode/org-faces hides /usr/share/emacs/23.2/lisp/org/org-faces /usr/share/emacs23/site-lisp/org-mode/org-latex hides /usr/share/emacs/23.2/lisp/org/org-latex /usr/share/emacs23/site-lisp/org-mode/org-jsinfo hides /usr/share/emacs/23.2/lisp/org/org-jsinfo /usr/share/emacs23/site-lisp/org-mode/org-xoxo hides /usr/share/emacs/23.2/lisp/org/org-xoxo /usr/share/emacs23/site-lisp/org-mode/org-vm hides /usr/share/emacs/23.2/lisp/org/org-vm /usr/share/emacs23/site-lisp/org-mode/org-mouse hides /usr/share/emacs/23.2/lisp/org/org-mouse /usr/share/emacs23/site-lisp/org-mode/org-timer hides /usr/share/emacs/23.2/lisp/org/org-timer /usr/share/emacs23/site-lisp/org-mode/org-footnote hides /usr/share/emacs/23.2/lisp/org/org-footnote /usr/share/emacs23/site-lisp/org-mode/org-html hides /usr/share/emacs/23.2/lisp/org/org-html /usr/share/emacs23/site-lisp/org-mode/org-inlinetask hides /usr/share/emacs/23.2/lisp/org/org-inlinetask /usr/share/emacs23/site-lisp/org-mode/org-attach hides /usr/share/emacs/23.2/lisp/org/org-attach /usr/share/emacs23/site-lisp/org-mode/org-agenda hides /usr/share/emacs/23.2/lisp/org/org-agenda /usr/share/emacs23/site-lisp/org-mode/org-datetree hides /usr/share/emacs/23.2/lisp/org/org-datetree /usr/share/emacs23/site-lisp/org-mode/org-bbdb hides /usr/share/emacs/23.2/lisp/org/org-bbdb /usr/share/emacs23/site-lisp/org-mode/org-irc hides /usr/share/emacs/23.2/lisp/org/org-irc /usr/share/emacs23/site-lisp/org-mode/org-mew hides /usr/share/emacs/23.2/lisp/org/org-mew /usr/share/emacs23/site-lisp/org-mode/org-mac-message hides /usr/share/emacs/23.2/lisp/org/org-mac-message /usr/share/emacs23/site-lisp/org-mode/org-docbook hides /usr/share/emacs/23.2/lisp/org/org-docbook /usr/share/emacs23/site-lisp/org-mode/org-info hides /usr/share/emacs/23.2/lisp/org/org-info /usr/share/emacs23/site-lisp/org-mode/org-exp hides /usr/share/emacs/23.2/lisp/org/org-exp /usr/share/emacs23/site-lisp/org-mode/org-install hides /usr/share/emacs/23.2/lisp/org/org-install /usr/share/emacs23/site-lisp/org-mode/org-icalendar hides /usr/share/emacs/23.2/lisp/org/org-icalendar /usr/share/emacs23/site-lisp/org-mode/org-remember hides /usr/share/emacs/23.2/lisp/org/org-remember /usr/share/emacs23/site-lisp/flim/hmac-def hides /usr/share/emacs/23.2/lisp/net/hmac-def /usr/share/emacs23/site-lisp/flim/sasl-ntlm hides /usr/share/emacs/23.2/lisp/net/sasl-ntlm /usr/share/emacs23/site-lisp/flim/sasl hides /usr/share/emacs/23.2/lisp/net/sasl /usr/share/emacs23/site-lisp/flim/sasl-digest hides /usr/share/emacs/23.2/lisp/net/sasl-digest /usr/share/emacs23/site-lisp/flim/hmac-md5 hides /usr/share/emacs/23.2/lisp/net/hmac-md5 /usr/share/emacs23/site-lisp/flim/ntlm hides /usr/share/emacs/23.2/lisp/net/ntlm /usr/share/emacs23/site-lisp/flim/sasl-cram hides /usr/share/emacs/23.2/lisp/net/sasl-cram /usr/share/emacs23/site-lisp/wl/rfc2368 hides /usr/share/emacs/23.2/lisp/mail/rfc2368 /usr/share/emacs23/site-lisp/cedet-common/cedet-files hides /usr/share/emacs/23.2/lisp/cedet/cedet-files /usr/share/emacs23/site-lisp/cedet-common/mode-local hides /usr/share/emacs/23.2/lisp/cedet/mode-local /usr/share/emacs23/site-lisp/cedet-common/inversion hides /usr/share/emacs/23.2/lisp/cedet/inversion /usr/share/emacs23/site-lisp/cedet-common/cedet hides /usr/share/emacs/23.2/lisp/cedet/cedet Features: (shadow sort mail-extr message sendmail ecomplete rfc822 mml mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc time-date mm-util mail-prsvr gmm-utils mailheader canlock sha1 sha1-el hex-util hashcash mail-utils home-end emacsbug commit-patch-amend-buffer commit-patch-buffer log-edit pcvs-util add-log vc vc-dispatcher cc-styles cc-align cc-engine cc-vars cc-defs regexp-opt cus-edit wid-edit subword paren cus-start cus-load shell comint hideshow jka-compr edmacro kmacro rect cperl-mode shell-command xcscope ring easymenu iswitchb w3m-load org-install muse-autoloads emacs-goodies-el emacs-goodies-custom emacs-goodies-loaddefs easy-mmode cedet-autogen advice advice-preload autoload help-fns preview-latex tex-site auto-loads tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind system-font-setting font-render-setting gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 02 12:30:56 2011 Received: (at 8150) by debbugs.gnu.org; 2 Mar 2011 17:30:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pupt2-0006LN-Ia for submit@debbugs.gnu.org; Wed, 02 Mar 2011 12:30:56 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pupt1-0006L7-02 for 8150@debbugs.gnu.org; Wed, 02 Mar 2011 12:30:55 -0500 Received: from localhost ([127.0.0.1]:47717) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pupsu-0005oV-UR; Wed, 02 Mar 2011 12:30:49 -0500 From: Glenn Morris To: Dima Kogan Subject: Re: bug#8150: 23.2; cperl-uncomment-region is NOT an inverse of cperl-comment-region References: <878vwxgb07.fsf@cds.caltech.edu> X-Spook: ANZUS Ron Brown InfoSec underground MP5K-SD strategic X-Ran: lo+>%M3vnU}rtqz#ZEklm(TQ}remHYi,O+3-1!3)X.by[O1j+{l> (Dima Kogan's message of "Wed, 02 Mar 2011 00:52:24 -0800") Message-ID: <0aipw177lj.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 8150 Cc: 8150@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Dima Kogan wrote: > cperl-comment-region on the whole buffer makes [...] > cperl-uncomment-region makes The standard commands comment-region and uncomment-region seem to work fine; can you use those instead? From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 02 23:38:27 2011 Received: (at 8150) by debbugs.gnu.org; 3 Mar 2011 04:38:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv0J1-0004zK-26 for submit@debbugs.gnu.org; Wed, 02 Mar 2011 23:38:27 -0500 Received: from ibar.cds.caltech.edu ([131.215.42.49]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv0Iy-0004z7-VD for 8150@debbugs.gnu.org; Wed, 02 Mar 2011 23:38:25 -0500 Received: from smart (cpe-76-175-234-46.socal.res.rr.com [76.175.234.46]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ibar.cds.caltech.edu (Postfix) with ESMTP id 6984ABA8276 for <8150@debbugs.gnu.org>; Wed, 2 Mar 2011 20:38:18 -0800 (PST) Date: Wed, 2 Mar 2011 20:38:16 -0800 From: Dima Kogan To: 8150@debbugs.gnu.org Subject: Re: bug#8150: 23.2; cperl-uncomment-region is NOT an inverse of cperl-comment-region Message-ID: <20110302203816.7e8e2fa1@smart> In-Reply-To: <0aipw177lj.fsf@fencepost.gnu.org> References: <878vwxgb07.fsf@cds.caltech.edu> <0aipw177lj.fsf@fencepost.gnu.org> X-Mailer: Claws Mail 3.7.8 (GTK+ 2.24.0; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8150 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) I can and I do, but the current behavior seems wrong. If (comment-region beg end -1) is no longer supported, it should generate an error instead of succeeding badly. Should we simply call (uncomment-region beg end 1) in that case? I can make the patch, but would need to know what the current plan is. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 03 05:07:22 2011 Received: (at submit) by debbugs.gnu.org; 3 Mar 2011 10:07:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv5RK-0004ci-9h for submit@debbugs.gnu.org; Thu, 03 Mar 2011 05:07:22 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pv5RH-0004cU-J9 for submit@debbugs.gnu.org; Thu, 03 Mar 2011 05:07:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pv5RB-0005cM-73 for submit@debbugs.gnu.org; Thu, 03 Mar 2011 05:07:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:49040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pv5RB-0005cI-4d for submit@debbugs.gnu.org; Thu, 03 Mar 2011 05:07:13 -0500 Received: from [140.186.70.92] (port=48924 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pv5R9-0001F0-Rt for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2011 05:07:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pv5R8-0005bl-5Z for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2011 05:07:11 -0500 Received: from lo.gmane.org ([80.91.229.12]:54689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pv5R7-0005aq-Qs for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2011 05:07:10 -0500 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Pv5R4-0003QO-TT for bug-gnu-emacs@gnu.org; Thu, 03 Mar 2011 11:07:06 +0100 Received: from e4300lm.epcc.ed.ac.uk ([129.215.63.156]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 03 Mar 2011 11:07:06 +0100 Received: from wence by e4300lm.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 03 Mar 2011 11:07:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Lawrence Mitchell Subject: Re: bug#8150: 23.2; cperl-uncomment-region is NOT an inverse of cperl-comment-region Date: Thu, 03 Mar 2011 10:06:53 +0000 Lines: 89 Message-ID: References: <878vwxgb07.fsf@cds.caltech.edu> <0aipw177lj.fsf@fencepost.gnu.org> <20110302203816.7e8e2fa1@smart> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: e4300lm.epcc.ed.ac.uk User-Agent: Gnus/5.110012 (No Gnus v0.12) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:37L4ehk22k6X4GTJrJeKiFoc7BQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) Dima Kogan wrote: > I can and I do, but the current behavior seems wrong. If > (comment-region beg end -1) is no longer supported, it should generate > an error instead of succeeding badly. Should we simply call > (uncomment-region beg end 1) in that case? I can make the patch, but > would need to know what the current plan is. Note that the problem is that (uncomment-region A B 1) is not the inverse of (comment-region A B 1). Irrespective of the major mode in effect: emacs -Q C-x h C-1 M-x comment-region RET C-x h C-1 M-x uncomment-region RET Note how there is now a space at the beginning of every line in the *scratch* buffer. This is due to the following code in uncomment-region-default: | (if (null arg) (delete-region (point-min) (point)) | (skip-syntax-backward " ") | (delete-char (- numarg)) # foo bar ^ point is here when the above code is called. If an argument is supplied, arg is non-nil and so to delete the comment we first move backwards over whitespace and then delete as many comment characters as specified by the argument (1 in this case). This patch appears to do the right thing from my minimal testing, but I don't know if it will have any unfortunate side-effects: 2011-03-03 Lawrence Mitchell Make uncomment-region the inverse of comment-region. * newcomment.el (uncomment-region-default): Delete skipped-over whitespace if all comment characters have been removed. This makes M-1 M-x uncomment-region RET the inverse of M-1 M-x comment-region RET. Previously, commenting and then uncommenting a region with an argument would leave a space at the beginning of each line. diff --git a/lisp/newcomment.el b/lisp/newcomment.el index d88b76a..bcdc1e6 100644 --- a/lisp/newcomment.el +++ b/lisp/newcomment.el @@ -871,15 +871,20 @@ comment markers." (when (and sre (looking-at (concat "\\s-*\n\\s-*" srei))) (goto-char (match-end 0))) (if (null arg) (delete-region (point-min) (point)) - (skip-syntax-backward " ") - (delete-char (- numarg)) - (unless (or (bobp) - (save-excursion (goto-char (point-min)) - (looking-at comment-start-skip))) - ;; If there's something left but it doesn't look like - ;; a comment-start any more, just remove it. - (delete-region (point-min) (point)))) - + (let* ((opoint (point-marker)) + (nchar (skip-syntax-backward " "))) + (delete-char (- numarg)) + (unless (or (bobp) + (save-excursion (goto-char (point-min)) + (looking-at comment-start-skip))) + ;; If there's something left but it doesn't look like + ;; a comment-start any more, just remove it. + (delete-region (point-min) (point))) + (save-excursion + (goto-char (point-min)) + (unless (looking-at comment-start-skip) + (goto-char opoint) + (delete-char nchar))))) ;; Remove the end-comment (and leading padding and such). (goto-char (point-max)) (comment-enter-backward) ;; Check for special `=' used sometimes in comment-box. -- Lawrence Mitchell From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 07:49:26 2012 Received: (at 8150) by debbugs.gnu.org; 17 Feb 2012 12:49:26 +0000 Received: from localhost ([127.0.0.1]:43435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RyNFa-0002Ek-Fc for submit@debbugs.gnu.org; Fri, 17 Feb 2012 07:49:24 -0500 Received: from treacle.ucs.ed.ac.uk ([129.215.16.102]:57365) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RyNFQ-0002ER-Ll for 8150@debbugs.gnu.org; Fri, 17 Feb 2012 07:49:20 -0500 Received: from lmtp1.ucs.ed.ac.uk (lmtp1.ucs.ed.ac.uk [129.215.149.64]) by treacle.ucs.ed.ac.uk (8.13.8/8.13.4) with ESMTP id q1HCl3j6013877 for <8150@debbugs.gnu.org>; Fri, 17 Feb 2012 12:47:08 GMT Received: from e4300lm (e4300lm.epcc.ed.ac.uk [129.215.63.156]) (authenticated user=lmitche4 mech=PLAIN bits=0) by lmtp1.ucs.ed.ac.uk (8.13.8/8.13.7) with ESMTP id q1HCkl3H006519 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for <8150@debbugs.gnu.org>; Fri, 17 Feb 2012 12:47:02 GMT From: Lawrence Mitchell To: 8150@debbugs.gnu.org Subject: Re: bug#8150: 23.2; cperl-uncomment-region is NOT an inverse of cperl-comment-region References: <878vwxgb07.fsf@cds.caltech.edu> <0aipw177lj.fsf@fencepost.gnu.org> <20110302203816.7e8e2fa1@smart> Date: Fri, 17 Feb 2012 12:47:10 +0000 In-Reply-To: (Lawrence Mitchell's message of "Thu, 03 Mar 2011 10:06:53 +0000") Message-ID: <87d39dsk35.fsf@ed.ac.uk> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Edinburgh-Scanned: at treacle.ucs.ed.ac.uk with MIMEDefang 2.60, Sophie, Sophos Anti-Virus, Clam AntiVirus X-Scanned-By: MIMEDefang 2.60 on 129.215.16.102 X-Scanned-By: MIMEDefang 2.52 on 129.215.149.64 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 8150 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) I'm chasing up open bugs I've participated in, probably too late for 24.1, but just to see if anything's doing. Is there any objection to applying the patch in this bug report? Lawrence Mitchell wrote: [...] > Note that the problem is that (uncomment-region A B 1) is not the > inverse of (comment-region A B 1). Irrespective of the major > mode in effect: > emacs -Q > C-x h > C-1 M-x comment-region RET > C-x h > C-1 M-x uncomment-region RET > Note how there is now a space at the beginning of every line in > the *scratch* buffer. > This is due to the following code in uncomment-region-default: > | (if (null arg) (delete-region (point-min) (point)) > | (skip-syntax-backward " ") > | (delete-char (- numarg)) > # foo bar > ^ point is here when the above code is called. > If an argument is supplied, arg is non-nil and so to delete the > comment we first move backwards over whitespace and then delete > as many comment characters as specified by the argument (1 in > this case). From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 10:47:24 2012 Received: (at 8150-done) by debbugs.gnu.org; 17 Feb 2012 15:47:24 +0000 Received: from localhost ([127.0.0.1]:43850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RyQ1s-0007MZ-0d for submit@debbugs.gnu.org; Fri, 17 Feb 2012 10:47:24 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53305) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RyQ1n-0007MP-Ac for 8150-done@debbugs.gnu.org; Fri, 17 Feb 2012 10:47:21 -0500 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q1HFjN0Y016448; Fri, 17 Feb 2012 10:45:23 -0500 Received: by pastel.home (Postfix, from userid 20848) id 2A04C593DD; Fri, 17 Feb 2012 10:45:23 -0500 (EST) From: Stefan Monnier To: Lawrence Mitchell Subject: Re: bug#8150: 23.2; cperl-uncomment-region is NOT an inverse of cperl-comment-region Message-ID: References: <878vwxgb07.fsf@cds.caltech.edu> <0aipw177lj.fsf@fencepost.gnu.org> <20110302203816.7e8e2fa1@smart> <87d39dsk35.fsf@ed.ac.uk> Date: Fri, 17 Feb 2012 10:45:23 -0500 In-Reply-To: <87d39dsk35.fsf@ed.ac.uk> (Lawrence Mitchell's message of "Fri, 17 Feb 2012 12:47:10 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4135=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4135> : streams <729573> : uri <1067200> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 8150-done Cc: 8150-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > I'm chasing up open bugs I've participated in, probably too late > for 24.1, but just to see if anything's doing. Is there any > objection to applying the patch in this bug report? I've simplified the patch and installed it (see below), Stefan --- lisp/newcomment.el 2012-01-19 07:21:25 +0000 +++ lisp/newcomment.el 2012-02-17 15:41:15 +0000 @@ -872,14 +872,15 @@ (when (and sre (looking-at (concat "\\s-*\n\\s-*" srei))) (goto-char (match-end 0))) (if (null arg) (delete-region (point-min) (point)) - (skip-syntax-backward " ") + (let* ((opoint (point-marker)) + (nchar (skip-syntax-backward " "))) (delete-char (- numarg)) - (unless (or (bobp) + (unless (and (not (bobp)) (save-excursion (goto-char (point-min)) (looking-at comment-start-skip))) ;; If there's something left but it doesn't look like ;; a comment-start any more, just remove it. - (delete-region (point-min) (point)))) + (delete-region (point-min) opoint)))) ;; Remove the end-comment (and leading padding and such). (goto-char (point-max)) (comment-enter-backward) From unknown Thu Aug 14 21:56:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 17 Mar 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator