From unknown Sat Jun 14 03:52:42 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#8141 <8141@debbugs.gnu.org> To: bug#8141 <8141@debbugs.gnu.org> Subject: Status: 23.2.94; python-fill-paragraph Reply-To: bug#8141 <8141@debbugs.gnu.org> Date: Sat, 14 Jun 2025 10:52:42 +0000 retitle 8141 23.2.94; python-fill-paragraph reassign 8141 emacs submitter 8141 Andreas R=C3=B6hler severity 8141 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 28 15:52:31 2011 Received: (at submit) by debbugs.gnu.org; 28 Feb 2011 20:52:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuA50-00052j-PC for submit@debbugs.gnu.org; Mon, 28 Feb 2011 15:52:30 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuA4y-00052W-JY for submit@debbugs.gnu.org; Mon, 28 Feb 2011 15:52:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuA4s-0007CZ-7C for submit@debbugs.gnu.org; Mon, 28 Feb 2011 15:52:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:44419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuA4q-0007Bu-Tf for submit@debbugs.gnu.org; Mon, 28 Feb 2011 15:52:22 -0500 Received: from [140.186.70.92] (port=47816 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuA4j-0006Ks-T9 for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2011 15:52:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuA4h-00079v-0n for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2011 15:52:12 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:53372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuA4g-000797-GO for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2011 15:52:10 -0500 Received: from [192.168.178.29] (brln-d9ba3489.pool.mediaWays.net [217.186.52.137]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0MM2cS-1PvH462R36-008Efz; Mon, 28 Feb 2011 21:52:07 +0100 Message-ID: <4D6C0BF0.3050001@easy-emacs.de> Date: Mon, 28 Feb 2011 21:56:16 +0100 From: =?ISO-8859-15?Q?Andreas_R=F6hler?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.11) Gecko/20100711 Thunderbird/3.0.6 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 23.2.94; python-fill-paragraph Content-Type: multipart/mixed; boundary="------------080504060007070502070409" X-Provags-ID: V02:K0:GvFcj4Rc+b7FO3KTqRGiULfe0UUJSGEWHEP1sTEW/g9 JOM8H7FkcuX0GsABNRfMoeJLG8DO4i1JQPQ5ACG+N0bAxuK5WU wIXN0NacOVc6ScZRUk7oD5CN8LqI1fwhgnNk2jwmz+26lXh7x2 rHJMlyVg26QxZysgCH7LYry7p+oTSisBxN3P/opbHUFt/CLVt1 ++svXutwAwXxtNCr/vqFr1qR5LL8oKn1jG1e9lCqMo= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) This is a multi-part message in MIME format. --------------080504060007070502070409 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Hi, attached a test file, revealing a bug in python-fill-paragraph already reported at lp, which pertains to python.el and python-mode.el likewise. Patch attached. Andreas -- https://code.launchpad.net/~a-roehler/python-mode/python-mode-components https://code.launchpad.net/s-x-emacs-werkstatt/ --------------080504060007070502070409 Content-Type: text/x-emacs-lisp; name="fill-paragraph-problems-lp710373-test.el" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fill-paragraph-problems-lp710373-test.el" (defun py-fill-paragraph-problems-lp:710373-test (&optional arg load-branch-function) (interactive "p") (when load-branch-function (funcall load-branch-function)) (py-fill-paragraph-problems-lp:710373-test-intern arg)) (defun py-fill-paragraph-problems-lp:710373-test-intern (&optional arg) "If no `load-branch-function' is specified, make sure the appropriate branch is loaded. Otherwise default python-mode will be checked. " (let ((tmp-dir "/tmp/") (fpp-exec-buffer "fill-paragraph-problems-lp:710373") (diff-buffer "fpp-lp:710373-old") (fpp-teststring " \"\"\" triple-quoted string containing \"quotation\" marks. triple-quoted string containing \"quotation\" marks. triple-quoted string containing \"quotation\" marks. triple-quoted string containing \"quotation\" marks. triple-quoted string containing \"quotation\" marks. \"\"\" ") erg) (set-buffer (get-buffer-create diff-buffer)) (erase-buffer) (insert fpp-teststring) (write-file (concat tmp-dir diff-buffer)) (if arg (progn (set-buffer (get-buffer-create fpp-exec-buffer)) (when arg (switch-to-buffer (current-buffer))) (erase-buffer) (py-fill-paragraph-problems-lp:710373-test-base)) (with-temp-buffer (py-fill-paragraph-problems-lp:710373-test-base))))) (defun py-fill-paragraph-problems-lp:710373-test-base () (python-mode) (insert fpp-teststring) (set-buffer fpp-exec-buffer) (font-lock-mode 1) (font-lock-fontify-buffer) (goto-char (point-min)) (forward-line 3) (message "I'm here: %s" (point)) (set-buffer-modified-p nil) ;; (describe-function 'py-fill-paragraph) (setq fill-column 55) (if (functionp 'py-fill-paragraph) (py-fill-paragraph) (python-fill-paragraph)) (write-file (concat tmp-dir fpp-exec-buffer)) (setq erg (diff (concat tmp-dir fpp-exec-buffer) (concat tmp-dir diff-buffer) "-u")) (if (featurep 'xemacs) (progn (set-buffer "*Diff Output*") (switch-to-buffer (current-buffer))) (set-buffer erg) (sit-for 1) (assert (numberp (progn (goto-char (point-min))(search-forward "no differences" nil t 1))) t) (message "%s" "py-fill-paragraph-problems-lp:710373 passed"))) --------------080504060007070502070409 Content-Type: text/x-patch; name="python.el.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="python.el.diff" --- python.el 2011/02/28 20:22:31 1.1 +++ python.el 2011/02/28 20:24:23 @@ -2022,7 +2022,9 @@ ;; current line. ((eq t (nth 3 syntax)) ; in fenced string (goto-char (nth 8 syntax)) ; string start - (setq start (line-beginning-position)) + (if (looking-at "\\(?:'''\\|\"\"\"\\|'\\|\"\\)\\\\?\n?") + (setq start (match-end 0)) + (setq start (line-beginning-position))) (setq end (condition-case () ; for unbalanced quotes (progn (forward-sexp) (- (point) 3)) --------------080504060007070502070409-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 28 21:59:29 2011 Received: (at 8141) by debbugs.gnu.org; 1 Mar 2011 02:59:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuFo9-0005UR-9h for submit@debbugs.gnu.org; Mon, 28 Feb 2011 21:59:29 -0500 Received: from mail-vw0-f44.google.com ([209.85.212.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuFo7-0005UF-Co for 8141@debbugs.gnu.org; Mon, 28 Feb 2011 21:59:27 -0500 Received: by vws6 with SMTP id 6so3576277vws.3 for <8141@debbugs.gnu.org>; Mon, 28 Feb 2011 18:59:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type :content-transfer-encoding; bh=OjxHMNEguKWjQWqNaFYX6zjFYBkxrr/6Ulmz89CU2mg=; b=oH0TGUb80gv/l691L80q+CytVuPbaRjdi5+bQNNYjNMPobcTgT6M6NMe5M1ztl9teY vxifQVZzHF/Dcz++LvJL/ajacKhRCmViO5T4jKOGroEhWaJ5mPmZo0lTrBxwv/CirWRq nK8sucYJxwAOSg7lg5DKlzC5iZg5IbmLgfdxM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type:content-transfer-encoding; b=Gq5mjZ5690w1gGFFBE/Qb2qG517IMdC++RzdIKfOmtXrAT40mXCev13ga5Cp53b6+t QO7CRY2tigdTI0WFGshbXkt3Gry/oB/2wuOxZL/Oe/3ZqliybI72EmzzZwEURB6GJbWo tD+urKA7eJ/kzSaFFlFZksRFnwMLicPNkRKHI= Received: by 10.220.184.75 with SMTP id cj11mr1576170vcb.81.1298948361591; Mon, 28 Feb 2011 18:59:21 -0800 (PST) Received: from localhost (71-208-196-83.hlrn.qwest.net [71.208.196.83]) by mx.google.com with ESMTPS id l6sm2006280vcp.14.2011.02.28.18.59.19 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Feb 2011 18:59:20 -0800 (PST) From: Christoph Scholtes To: Andreas =?iso-8859-1?Q?R=F6hler?= Subject: Re: bug#8141: 23.2.94; python-fill-paragraph In-Reply-To: <4D6C0BF0.3050001@easy-emacs.de> ("Andreas =?iso-8859-1?Q?R?= =?iso-8859-1?Q?=F6hler=22's?= message of "Mon, 28 Feb 2011 21:56:16 +0100") References: <4D6C0BF0.3050001@easy-emacs.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (windows-nt) Date: Mon, 28 Feb 2011 19:59:16 -0700 Message-ID: <86fwr7a6m3.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: 8141 Cc: 8141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) Andreas R=F6hler writes: > attached a test file, revealing a bug in python-fill-paragraph already > reported at lp, which pertains to python.el and python-mode.el > likewise. > > Patch attached. Thanks for the bug report and the patch. However, I would like to understand first what the problem is/was. The initial bug report on Launchpad included a file (kn.py), whose doc-string caused problems, right? I can open this file and use python-fill-paragraph and fill-paragraph with no problem in emacs 23.2 and the latest trunk. There is no error and the doc string looks formatted correctly, also. What is the problem with the code in python.el/python-mode.el? Regards, Christoph From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 01 05:41:51 2011 Received: (at 8141) by debbugs.gnu.org; 1 Mar 2011 10:41:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuN1b-0004Ha-Hj for submit@debbugs.gnu.org; Tue, 01 Mar 2011 05:41:51 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PuN1Z-0004HN-Kl for 8141@debbugs.gnu.org; Tue, 01 Mar 2011 05:41:50 -0500 Received: from [192.168.178.29] (brln-4db9ef68.pool.mediaWays.net [77.185.239.104]) by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis) id 0M21V9-1QANfp3935-00taLI; Tue, 01 Mar 2011 11:41:43 +0100 Message-ID: <4D6CCE64.8060203@easy-emacs.de> Date: Tue, 01 Mar 2011 11:45:56 +0100 From: =?ISO-8859-1?Q?Andreas_R=F6hler?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.11) Gecko/20100711 Thunderbird/3.0.6 MIME-Version: 1.0 To: Christoph Scholtes Subject: Re: bug#8141: 23.2.94; python-fill-paragraph References: <4D6C0BF0.3050001@easy-emacs.de> <86fwr7a6m3.fsf@gmail.com> In-Reply-To: <86fwr7a6m3.fsf@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:LeX0wOxTyWZ2Gt9Ch7T79UYa98AvOxohp9h+Bjv5GOR pYVUVZ4y2u7MDzJtM/OY3fit+WK1kEgJTXQ1ARCeg9HQa3HMP/ 3cKz+4yx2EV3FUZ6/ksTJOX19jbM6W8a0vzpCASxsZRSe4PaEM l/RXB47sF4zY2spUAwxEq/PB+PtDZqmsyUZVbXY/5CUm34gXrM RiPjA/JF8iJ88xhfFx6UEZ8P5/HpJxJmf6l+8EK7O0= X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: 8141 Cc: 8141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) Am 01.03.2011 03:59, schrieb Christoph Scholtes: > Andreas Röhler writes: > >> attached a test file, revealing a bug in python-fill-paragraph already >> reported at lp, which pertains to python.el and python-mode.el >> likewise. >> >> Patch attached. > > Thanks for the bug report and the patch. > > However, I would like to understand first what the problem is/was. The > initial bug report on Launchpad included a file (kn.py), whose > doc-string caused problems, right? > > I can open this file and use python-fill-paragraph and fill-paragraph > with no problem in emacs 23.2 and the latest trunk. There is no error > and the doc string looks formatted correctly, also. > > What is the problem with the code in python.el/python-mode.el? > > Regards, > Christoph > Hi, with M-q resp. fill-paragraph it's fine here too. python-fill-paragraph displays the bug. Did you try the test delivered? AFAIS bug basically might reside in fill-paragraph, where ;; 2. Try fill-paragraph-function. (and (not (eq fill-paragraph-function t)) (or fill-paragraph-function (and (minibufferp (current-buffer)) (= 1 (point-min)))) (let ((function (or fill-paragraph-function should be written like (cond (fill-paragraph-function DTRT) (t everything else Unless I'm wrong... Thanks Andreas From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 07 21:08:23 2011 Received: (at 8141) by debbugs.gnu.org; 8 Mar 2011 02:08:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwmLX-0004Qy-Gp for submit@debbugs.gnu.org; Mon, 07 Mar 2011 21:08:23 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwmLW-0004Qn-5c for 8141@debbugs.gnu.org; Mon, 07 Mar 2011 21:08:22 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEABMedU3O+LEt/2dsb2JhbACmVnW+O4ViBIUdj3U X-IronPort-AV: E=Sophos;i="4.62,281,1297054800"; d="scan'208";a="94952396" Received: from 206-248-177-45.dsl.teksavvy.com (HELO ceviche.home) ([206.248.177.45]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 07 Mar 2011 21:08:16 -0500 Received: by ceviche.home (Postfix, from userid 20848) id E5467660D6; Mon, 7 Mar 2011 21:08:15 -0500 (EST) From: Stefan Monnier To: Andreas =?iso-8859-1?Q?R=F6hler?= Subject: Re: bug#8141: 23.2.94; python-fill-paragraph Message-ID: References: <4D6C0BF0.3050001@easy-emacs.de> <86fwr7a6m3.fsf@gmail.com> <4D6CCE64.8060203@easy-emacs.de> Date: Mon, 07 Mar 2011 21:08:15 -0500 In-Reply-To: <4D6CCE64.8060203@easy-emacs.de> ("Andreas =?iso-8859-1?Q?R?= =?iso-8859-1?Q?=F6hler=22's?= message of "Tue, 01 Mar 2011 11:45:56 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 8141 Cc: Christoph Scholtes , 8141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > with M-q resp. fill-paragraph it's fine here too. > python-fill-paragraph displays the bug. [...] > AFAIS bug basically might reside in > fill-paragraph, where If calling fill-paragraph works while python-fill-paragraph doesn't, it would rather seem to indicate that the bug is in python-fill-paragraph (maybe the bug is that python-fill-paragraph should never be called directly as a command, for example). > ;; 2. Try fill-paragraph-function. > (and (not (eq fill-paragraph-function t)) > (or fill-paragraph-function > (and (minibufferp (current-buffer)) > (= 1 (point-min)))) > (let ((function (or fill-paragraph-function > should be written like > (cond (fill-paragraph-function > DTRT) > (t everything else No, the current definition is on purpose. As the docstring of fill-paragraph-function indicates: ... If the function returns nil, then `fill-paragraph' does its normal work. ... -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 07:21:46 2011 Received: (at 8141) by debbugs.gnu.org; 8 Mar 2011 12:21:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pwvv7-0001qS-Nn for submit@debbugs.gnu.org; Tue, 08 Mar 2011 07:21:46 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pwvv5-0001qF-3k for 8141@debbugs.gnu.org; Tue, 08 Mar 2011 07:21:44 -0500 Received: from [192.168.178.29] (brln-4dbc6d81.pool.mediaWays.net [77.188.109.129]) by mrelayeu.kundenserver.de (node=mrbap2) with ESMTP (Nemesis) id 0MCx2B-1PntF83COx-0098dS; Tue, 08 Mar 2011 13:21:34 +0100 Message-ID: <4D762069.7080604@easy-emacs.de> Date: Tue, 08 Mar 2011 13:26:17 +0100 From: =?ISO-8859-15?Q?Andreas_R=F6hler?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.9.1.11) Gecko/20100711 Thunderbird/3.0.6 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#8141: 23.2.94; python-fill-paragraph References: <4D6C0BF0.3050001@easy-emacs.de> <86fwr7a6m3.fsf@gmail.com> <4D6CCE64.8060203@easy-emacs.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:zr2vgQF2SDFtysMK5jfFasyE7Qr23CmQi1SpokmBBbu /FgsdIcS3qceHvNt+jwgU4zcsfzsRF9x3CwEkx55RvvQ4+YuaT 1gcgDrizO/GeP9QFGL+BUOucIsHZMhGeBl3n/0hm1TzArZevy/ TCGw73NSobd6jePGdwOEycXALx+fAaDXVR3N38fV5vdCmflohX A/QEGJjr4fKJ+KZg7dk1edDKugWbfn4Y8daOeP+Tgk= X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 8141 Cc: Christoph Scholtes , 8141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Am 08.03.2011 03:08, schrieb Stefan Monnier: >> with M-q resp. fill-paragraph it's fine here too. >> python-fill-paragraph displays the bug. > [...] >> AFAIS bug basically might reside in >> fill-paragraph, where > > If calling fill-paragraph works while python-fill-paragraph doesn't, it > would rather seem to indicate that the bug is in python-fill-paragraph > (maybe the bug is that python-fill-paragraph should never be called > directly as a command, for example). > >> ;; 2. Try fill-paragraph-function. >> (and (not (eq fill-paragraph-function t)) >> (or fill-paragraph-function >> (and (minibufferp (current-buffer)) >> (= 1 (point-min)))) >> (let ((function (or fill-paragraph-function > > >> should be written like > >> (cond (fill-paragraph-function >> DTRT) > >> (t everything else > > No, the current definition is on purpose. Hi Stefan, IMHO that introduces complexity, even if there are reasons for. If modes introduce their own fill-function, it's better to leave them than. If the modes need some later stuff from fill.el, they may take it. Andreas As the docstring of > fill-paragraph-function indicates: > > ... > If the function returns nil, then `fill-paragraph' does its normal work. > ... > > > -- Stefan > From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 08 16:18:17 2011 Received: (at 8141) by debbugs.gnu.org; 8 Mar 2011 21:18:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Px4IK-0006Gn-SU for submit@debbugs.gnu.org; Tue, 08 Mar 2011 16:18:17 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Px4IJ-0006Gb-Iy for 8141@debbugs.gnu.org; Tue, 08 Mar 2011 16:18:15 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p28LI9tW015317; Tue, 8 Mar 2011 16:18:09 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id DF6D61300D7; Tue, 8 Mar 2011 16:18:08 -0500 (EST) From: Stefan Monnier To: Andreas =?iso-8859-1?Q?R=F6hler?= Subject: Re: bug#8141: 23.2.94; python-fill-paragraph Message-ID: References: <4D6C0BF0.3050001@easy-emacs.de> <86fwr7a6m3.fsf@gmail.com> <4D6CCE64.8060203@easy-emacs.de> <4D762069.7080604@easy-emacs.de> Date: Tue, 08 Mar 2011 16:18:08 -0500 In-Reply-To: <4D762069.7080604@easy-emacs.de> ("Andreas =?iso-8859-1?Q?R?= =?iso-8859-1?Q?=F6hler=22's?= message of "Tue, 08 Mar 2011 13:26:17 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3735=0 X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 8141 Cc: Christoph Scholtes , 8141@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) >> No, the current definition is on purpose. > IMHO that introduces complexity, even if there are reasons for. > If modes introduce their own fill-function, it's better to leave them > than. If the modes need some later stuff from fill.el, they may take it. What complexity? If the mode's fill function wants to do it all itself, than it just needs to return a non-nil value. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 18 22:22:44 2012 Received: (at 8141) by debbugs.gnu.org; 19 Jun 2012 02:22:44 +0000 Received: from localhost ([127.0.0.1]:47531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sgo5c-0005i5-AW for submit@debbugs.gnu.org; Mon, 18 Jun 2012 22:22:44 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56480) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sgo5a-0005hx-J3 for 8141@debbugs.gnu.org; Mon, 18 Jun 2012 22:22:43 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Sgo2N-0002kD-2v; Mon, 18 Jun 2012 22:19:23 -0400 From: Glenn Morris To: 8141@debbugs.gnu.org Subject: Re: bug#8141: 23.2.94; python-fill-paragraph References: <4D6C0BF0.3050001@easy-emacs.de> <86fwr7a6m3.fsf@gmail.com> <4D6CCE64.8060203@easy-emacs.de> <4D762069.7080604@easy-emacs.de> X-Spook: [Hello to all my friends and fans in domestic X-Ran: 3toxA^lppG17wBZ)jQBtKR@hUb4Oui==oc:t-}l]v*:8J_tnkv,k4dQCbT&.o7jJY].|4B X-Hue: black X-Attribution: GM Date: Mon, 18 Jun 2012 22:19:23 -0400 In-Reply-To: (Stefan Monnier's message of "Tue, 08 Mar 2011 16:18:08 -0500") Message-ID: <2k7gv46o2c.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 8141 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) I have no idea what this report was supposed to be about. It may have been about filling the following: """ triple-quoted string containing "quotation" marks. triple-quoted string containing "quotation" marks. triple-quoted string containing "quotation" marks. triple-quoted string containing "quotation" marks. triple-quoted string containing "quotation" marks. """ In 24.1, using M-x fill-paragraph and M-x python-fill-paragraph give slightly different results. In the current trunk, using M-x fill-paragraph and M-x python-fill-paragraph-function (why is this interactive?) obviously give the same results. However, the result is not the same as either form in 24.1. It looks like this, with an empty line at the end that presumably should not be there? """triple-quoted string containing "quotation" marks. triple-quoted string containing "quotation" marks. triple-quoted string containing "quotation" marks. triple-quoted string containing "quotation" marks. triple-quoted string containing "quotation" marks. """ From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 07 09:26:20 2012 Received: (at 8141) by debbugs.gnu.org; 7 Oct 2012 13:26:21 +0000 Received: from localhost ([127.0.0.1]:59207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKqs7-0001xv-W0 for submit@debbugs.gnu.org; Sun, 07 Oct 2012 09:26:20 -0400 Received: from mail-yh0-f44.google.com ([209.85.213.44]:48414) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKqs5-0001xj-Jx for 8141@debbugs.gnu.org; Sun, 07 Oct 2012 09:26:18 -0400 Received: by mail-yh0-f44.google.com with SMTP id 56so744935yhq.3 for <8141@debbugs.gnu.org>; Sun, 07 Oct 2012 06:25:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding:x-gm-message-state; bh=niiJius6yLPooaJqFVFX+DFnRsVUNAz6gNLUu7Qzb8A=; b=D70Z2uQetwe9xFoRoCweMg3RaYv18nprYdmQU2owfEJviuDSY+SeQrYSlWvYjlnI7T BugRAMajCUSgaUd0+WCodLEAaEF7pfzyhcYMeQ5Y6YqopdbXDVbgTRTDtj4EdKBqVbaX VZnApbhT4nhbYaIagh5KQBQriaIVdBcZo4P3ifT2103ALh0RdLXhASF3cB31wkwR/VBi vN0+MDRME0RuH6eKth5UHQZoBJXmgevg/uzJZhLFAtn3RHK9cLtBdR7AAFjcoMtlw5WX 7Sw+/uNMdwt54NBRKMoyTPqQ94JiF866HFOTKlqIzvwjcC7Hw5zpls6dtnJJHjCukBuR PKVA== Received: by 10.236.143.131 with SMTP id l3mr12997207yhj.108.1349616349775; Sun, 07 Oct 2012 06:25:49 -0700 (PDT) Received: from [192.168.1.25] (host17.181-14-226.telecom.net.ar. [181.14.226.17]) by mx.google.com with ESMTPS id j70sm22070914yhm.11.2012.10.07.06.25.48 (version=SSLv3 cipher=OTHER); Sun, 07 Oct 2012 06:25:49 -0700 (PDT) Message-ID: <507182F9.1020006@anue.biz> Date: Sun, 07 Oct 2012 10:26:17 -0300 From: =?ISO-8859-1?Q?Fabi=E1n_Ezequiel_Gallina?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120910 Thunderbird/15.0.1 MIME-Version: 1.0 To: 8141@debbugs.gnu.org Subject: 23.2.94; python-fill-paragraph Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQkn3MZk+NjhY4SsrywQ69SUcfvy2Kd1XegM9kPiJhxdAnK7bwrPzOfL1Co5EMFlMTiqED/s X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 8141 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) This works fine on current trunk, notice there's a new option that allow users to set the style for docstrings. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 07 09:27:01 2012 Received: (at control) by debbugs.gnu.org; 7 Oct 2012 13:27:01 +0000 Received: from localhost ([127.0.0.1]:59210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKqsm-0001yr-Ul for submit@debbugs.gnu.org; Sun, 07 Oct 2012 09:27:01 -0400 Received: from mail-yh0-f44.google.com ([209.85.213.44]:33714) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKqsk-0001ya-AM for control@debbugs.gnu.org; Sun, 07 Oct 2012 09:26:58 -0400 Received: by mail-yh0-f44.google.com with SMTP id 56so745001yhq.3 for ; Sun, 07 Oct 2012 06:26:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:content-type :content-transfer-encoding:x-gm-message-state; bh=P+h0YyQfbtVTMGzuy3EaktJCZJm1M/W4rbQEflMsMkc=; b=CGy9MHlMCLV3ua9eY/XpN/xP/LDLAEbEb37+OGWBQP+zCBcNOcaBJfNtGTYRM5kf9R vVAPO3u7i094nPP/xhl/hTto+N3PbSg1DsiBVcmr92uC5Ob4gQq2eKTVe1YY6RlsbVh6 dlyjXhQbJoDS1hQH2Sj5LoJ5F31itaYVrCuyT+pEyFy3LRF70k0i0/2zGOc87KtXh3Gq ha900rbNUeBu7IqLyjSrEcZMDYi+zfTCFrzBG3riYyDMmuWfLL6lCMAc/tKEUzNvRxT9 t0ponqR3TyeRLnd1rdTuTdaH3TCyr+W2v6KZtF1Wb4OwVWyja57AU+fPxmPlb6FXrwnm V8Mg== Received: by 10.101.142.28 with SMTP id u28mr4118377ann.12.1349616391117; Sun, 07 Oct 2012 06:26:31 -0700 (PDT) Received: from [192.168.1.25] (host17.181-14-226.telecom.net.ar. [181.14.226.17]) by mx.google.com with ESMTPS id o25sm22069221yhm.14.2012.10.07.06.26.29 (version=SSLv3 cipher=OTHER); Sun, 07 Oct 2012 06:26:30 -0700 (PDT) Message-ID: <50718323.9090102@anue.biz> Date: Sun, 07 Oct 2012 10:26:59 -0300 From: =?ISO-8859-1?Q?Fabi=E1n_Ezequiel_Gallina?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120910 Thunderbird/15.0.1 MIME-Version: 1.0 To: control@debbugs.gnu.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQk7OeWnCiCD0c55UbNwb3cle4qq6HR0r/tyk8/SzOg+7ReNppSxs/KXJWp3yGz3YXb8oRop X-Spam-Score: 4.9 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close #8141 [...] Content analysis details: (4.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.213.44 listed in list.dnswl.org] 3.0 GOT_NO_SUBJECT No real subject 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] 1.8 MISSING_SUBJECT Missing Subject: header X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 4.9 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close #8141 [...] Content analysis details: (4.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.213.44 listed in list.dnswl.org] 3.0 GOT_NO_SUBJECT No real subject 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.5000] 1.8 MISSING_SUBJECT Missing Subject: header 0.0 TVD_SPACE_RATIO TVD_SPACE_RATIO close #8141 From unknown Sat Jun 14 03:52:42 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 05 Nov 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator