Subject: Re: bug#8141: 23.2.94; python-fill-paragraph

From: Andreas Röhler <[email-masked]>
Date: Tue, 08 Mar 2011 13:26:17 +0100

Am 08.03.2011 03:08, schrieb Stefan Monnier:
>> with M-q resp. fill-paragraph it's fine here too.
>> python-fill-paragraph displays the bug.
> [...]
>> AFAIS bug basically might reside in
>> fill-paragraph, where
>
> If calling fill-paragraph works while python-fill-paragraph doesn't, it
> would rather seem to indicate that the bug is in python-fill-paragraph
> (maybe the bug is that python-fill-paragraph should never be called
> directly as a command, for example).
>
>>     ;; 2. Try fill-paragraph-function.
>>     (and (not (eq fill-paragraph-function t))
>>          (or fill-paragraph-function
>>              (and (minibufferp (current-buffer))
>>                   (= 1 (point-min))))
>>          (let ((function (or fill-paragraph-function
>
>
>> should be written like
>
>> (cond (fill-paragraph-function
>>         DTRT)
>
>>        (t everything else
>
> No, the current definition is on purpose.

Hi Stefan,

IMHO that introduces complexity, even if there are reasons for.
If modes introduce their own fill-function, it's better to leave them 
than. If the modes need some later stuff from fill.el, they may take it.

Andreas

   As the docstring of
> fill-paragraph-function indicates:
>
>     ...
>     If the function returns nil, then `fill-paragraph' does its normal work.
>     ...
>
>
> -- Stefan
>