From unknown Sat Jun 14 05:08:55 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8139: 23.2.94; [PATCH] fix broken whitepsace support in diff-mode Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: viniciusjl@ig.com.br, cyd@stupidchicken.com, bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Feb 2011 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8139 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 8139@debbugs.gnu.org Cc: Vinicius Jose Latorre , Chong Yidong X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Vinicius Jose Latorre , Chong Yidong Received: via spool by submit@debbugs.gnu.org id=B.129890300412556 (code B ref -1); Mon, 28 Feb 2011 14:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Feb 2011 14:23:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pu40S-0003GT-E4 for submit@debbugs.gnu.org; Mon, 28 Feb 2011 09:23:24 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pu40P-0003GF-C1 for submit@debbugs.gnu.org; Mon, 28 Feb 2011 09:23:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pu40J-0005k1-DM for submit@debbugs.gnu.org; Mon, 28 Feb 2011 09:23:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:35903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pu40J-0005jx-At for submit@debbugs.gnu.org; Mon, 28 Feb 2011 09:23:15 -0500 Received: from [140.186.70.92] (port=44286 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pu40I-0003G7-85 for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2011 09:23:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pu40H-0005jY-49 for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2011 09:23:14 -0500 Received: from mail-iw0-f169.google.com ([209.85.214.169]:55081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pu40G-0005jR-VS for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2011 09:23:13 -0500 Received: by iwl42 with SMTP id 42so4243574iwl.0 for ; Mon, 28 Feb 2011 06:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=8ki2+Md7tm2kEXwBWn3HACK5sQAY+ZAM/CTd/nRvxiU=; b=ejCvNozYS4mKWSTUnDmqDuKUNu5+tZL0MR8trpZJSxPuiL3TjOjD6MgkDQOqihOGhi a723Rh4EB3ZBWoZrc8DRJS9Pzei8F3in3pdVAgJL4maDGuyryLMcACzly0Bje6zhSXx2 L7QYrz3N+btUIbVt/LKW6krIgeVkfynrVJ3Sg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; b=NMleSkJD8BIkiq5RA6k2pdLO67n06wuelIqnhIplppz8mxIfVqQ32YT29iKeSTgamJ LdzF5cYWl03Nf0fr48eTctGENkk5G8C7yqFj8NjdTiNHaNFzExR5m7bPL13HWHegZE81 GmHwj40oNu5nO8d87yMUzUoEo9Q7C1C/53QGE= Received: by 10.231.12.131 with SMTP id x3mr5518029ibx.76.1298902991977; Mon, 28 Feb 2011 06:23:11 -0800 (PST) Received: from Victoria.local ([120.37.103.176]) by mx.google.com with ESMTPS id 8sm4656152iba.10.2011.02.28.06.23.08 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Feb 2011 06:23:10 -0800 (PST) From: Leo Date: Mon, 28 Feb 2011 22:22:57 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Turning whitespace-mode on in diff buffers no longer shows trailing white spaces, which is due to change in whitespace-style. >From f67012f57be0ee57281f2553030e04c3c17bc709 Mon Sep 17 00:00:00 2001 Date: Mon, 28 Feb 2011 22:17:51 +0800 Subject: [PATCH] Adapt diff-mode to change in whitespace-style --- lisp/diff-mode.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lisp/diff-mode.el b/lisp/diff-mode.el index b02c5d91..79a80c81 100644 --- a/lisp/diff-mode.el +++ b/lisp/diff-mode.el @@ -1267,7 +1267,7 @@ (define-derived-mode diff-mode fundamental-mode "Diff" ;; Set up `whitespace-mode' so that turning it on will show trailing ;; whitespace problems on the modified lines of the diff. - (set (make-local-variable 'whitespace-style) '(trailing)) + (set (make-local-variable 'whitespace-style) '(face trailing)) (set (make-local-variable 'whitespace-trailing-regexp) "^[-\+!<>].*?\\([\t ]+\\)$") -- 1.7.4 From unknown Sat Jun 14 05:08:55 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Subject: bug#8139: closed (Re: 23.2.94; [PATCH] fix broken whitepsace support in diff-mode) Message-ID: References: X-Gnu-PR-Message: they-closed 8139 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 8139@debbugs.gnu.org Date: Fri, 04 Mar 2011 08:01:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1299225662-9740-1" This is a multi-part message in MIME format... ------------=_1299225662-9740-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8139: 23.2.94; [PATCH] fix broken whitepsace support in diff-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8139@debbugs.gnu.org. --=20 8139: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8139 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1299225662-9740-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8139-done) by debbugs.gnu.org; 4 Mar 2011 08:00:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvPwT-0002Wc-Mv for submit@debbugs.gnu.org; Fri, 04 Mar 2011 03:00:53 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PvPwS-0002WQ-MK for 8139-done@debbugs.gnu.org; Fri, 04 Mar 2011 03:00:53 -0500 Received: from localhost ([127.0.0.1]:35823) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PvPwM-0000F4-Uy; Fri, 04 Mar 2011 03:00:47 -0500 From: Glenn Morris To: 8139-done@debbugs.gnu.org Subject: Re: 23.2.94; [PATCH] fix broken whitepsace support in diff-mode References: X-Spook: Agfa Security Council cryptographic Peking SEAL Team 6 X-Ran: n)2/8`.{#Wd)SBMs';=g`KBXr8,j-`EuSe[Ew+8^rc9][~sN(8b~LtloJ_#)]`~xEjmcs~ X-Hue: white X-Attribution: GM Date: Fri, 04 Mar 2011 03:00:46 -0500 In-Reply-To: (Leo's message of "Mon, 28 Feb 2011 22:22:57 +0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 8139-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Version: 24.1 Thanks; applied. ------------=_1299225662-9740-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Feb 2011 14:23:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pu40S-0003GT-E4 for submit@debbugs.gnu.org; Mon, 28 Feb 2011 09:23:24 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pu40P-0003GF-C1 for submit@debbugs.gnu.org; Mon, 28 Feb 2011 09:23:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pu40J-0005k1-DM for submit@debbugs.gnu.org; Mon, 28 Feb 2011 09:23:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:35903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pu40J-0005jx-At for submit@debbugs.gnu.org; Mon, 28 Feb 2011 09:23:15 -0500 Received: from [140.186.70.92] (port=44286 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pu40I-0003G7-85 for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2011 09:23:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pu40H-0005jY-49 for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2011 09:23:14 -0500 Received: from mail-iw0-f169.google.com ([209.85.214.169]:55081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pu40G-0005jR-VS for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2011 09:23:13 -0500 Received: by iwl42 with SMTP id 42so4243574iwl.0 for ; Mon, 28 Feb 2011 06:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=8ki2+Md7tm2kEXwBWn3HACK5sQAY+ZAM/CTd/nRvxiU=; b=ejCvNozYS4mKWSTUnDmqDuKUNu5+tZL0MR8trpZJSxPuiL3TjOjD6MgkDQOqihOGhi a723Rh4EB3ZBWoZrc8DRJS9Pzei8F3in3pdVAgJL4maDGuyryLMcACzly0Bje6zhSXx2 L7QYrz3N+btUIbVt/LKW6krIgeVkfynrVJ3Sg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:x-debbugs-cc:date:message-id:mime-version :content-type; b=NMleSkJD8BIkiq5RA6k2pdLO67n06wuelIqnhIplppz8mxIfVqQ32YT29iKeSTgamJ LdzF5cYWl03Nf0fr48eTctGENkk5G8C7yqFj8NjdTiNHaNFzExR5m7bPL13HWHegZE81 GmHwj40oNu5nO8d87yMUzUoEo9Q7C1C/53QGE= Received: by 10.231.12.131 with SMTP id x3mr5518029ibx.76.1298902991977; Mon, 28 Feb 2011 06:23:11 -0800 (PST) Received: from Victoria.local ([120.37.103.176]) by mx.google.com with ESMTPS id 8sm4656152iba.10.2011.02.28.06.23.08 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Feb 2011 06:23:10 -0800 (PST) From: Leo To: bug-gnu-emacs@gnu.org Subject: 23.2.94; [PATCH] fix broken whitepsace support in diff-mode X-Debbugs-CC: Vinicius Jose Latorre , Chong Yidong Date: Mon, 28 Feb 2011 22:22:57 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Turning whitespace-mode on in diff buffers no longer shows trailing white spaces, which is due to change in whitespace-style. >From f67012f57be0ee57281f2553030e04c3c17bc709 Mon Sep 17 00:00:00 2001 Date: Mon, 28 Feb 2011 22:17:51 +0800 Subject: [PATCH] Adapt diff-mode to change in whitespace-style --- lisp/diff-mode.el | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lisp/diff-mode.el b/lisp/diff-mode.el index b02c5d91..79a80c81 100644 --- a/lisp/diff-mode.el +++ b/lisp/diff-mode.el @@ -1267,7 +1267,7 @@ (define-derived-mode diff-mode fundamental-mode "Diff" ;; Set up `whitespace-mode' so that turning it on will show trailing ;; whitespace problems on the modified lines of the diff. - (set (make-local-variable 'whitespace-style) '(trailing)) + (set (make-local-variable 'whitespace-style) '(face trailing)) (set (make-local-variable 'whitespace-trailing-regexp) "^[-\+!<>].*?\\([\t ]+\\)$") -- 1.7.4 ------------=_1299225662-9740-1--