GNU bug report logs - #8134
(Some special files were saved without asking)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8134 in the body.
You can then email your comments to 8134 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: bug-gnu-emacs <at> gnu.org
Subject: (Some special files were saved without asking)
Date: Mon, 28 Feb 2011 10:09:07 +0800

Encountered new message "(Some special files were saved without asking)".
Well at least in C-h e mention what they were.

Message #8 received at 8134 <at> debbugs.gnu.org (full text, mbox):

From: David Engster <deng <at> randomsample.de>
To: 8134 <at> debbugs.gnu.org
Cc: jidanni <at> jidanni.org
Subject: Re: bug#8134: (Some special files were saved without asking)
Date: Sat, 05 Mar 2011 12:33:56 +0100

'jidanni' writes:
> Encountered new message "(Some special files were saved without asking)".
> Well at least in C-h e mention what they were.

I agree.

That you're suddenly seeing this message is due to a change in Gnus,
which now saves the .newsrc-dribble file without asking when you invoke
stuff like 'compile' and other functions which call `save-some-buffers'.

I'm proposing the following change (against trunk):

--- lisp/files.el	2011-03-05 08:48:52 +0000
+++ lisp/files.el	2011-03-05 11:03:02 +0000
@@ -4616,7 +4616,7 @@
 	;; That way the following code won't ask about them.
 	(with-current-buffer buffer
 	  (when (and buffer-save-without-query (buffer-modified-p))
-	    (setq some-automatic t)
+	    (setq some-automatic (append some-automatic (list (buffer-name))))
 	    (save-buffer))))
       ;; Ask about those buffers that merit it,
       ;; and record the number thus saved.
@@ -4663,7 +4663,9 @@
 	     (setq abbrevs-done t)))
       (or queried (> files-done 0) abbrevs-done
 	  (message (if some-automatic
-		       "(Some special files were saved without asking)"
+		       (concat
+			"(The following special buffers were saved without asking: "
+			(mapconcat 'identity some-automatic " ") ")")
 		     "(No files need saving)"))))))
 
 (defun not-modified (&optional arg)

Message #11 received at 8134 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: David Engster <deng <at> randomsample.de>
Cc: 8134 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#8134: (Some special files were saved without asking)
Date: Sat, 05 Mar 2011 12:50:54 +0100

David Engster <deng <at> randomsample.de> writes:

> --- lisp/files.el	2011-03-05 08:48:52 +0000
> +++ lisp/files.el	2011-03-05 11:03:02 +0000
> @@ -4616,7 +4616,7 @@
>  	;; That way the following code won't ask about them.
>  	(with-current-buffer buffer
>  	  (when (and buffer-save-without-query (buffer-modified-p))
> -	    (setq some-automatic t)
> +	    (setq some-automatic (append some-automatic (list (buffer-name))))

	    (setq some-automatic (cons (buffer-name) some-automatic))

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #14 received at 8134 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: schwab <at> linux-m68k.org
Cc: 8134 <at> debbugs.gnu.org, deng <at> randomsample.de
Subject: Re: bug#8134: (Some special files were saved without asking)
Date: Sat, 05 Mar 2011 20:20:22 +0800

Also I bet C-x C-x not asking if one wants to save gnus properly first, is related.

Message #17 received at 8134 <at> debbugs.gnu.org (full text, mbox):

From: David Engster <deng <at> randomsample.de>
To: jidanni <at> jidanni.org
Cc: 8134 <at> debbugs.gnu.org, schwab <at> linux-m68k.org
Subject: Re: bug#8134: (Some special files were saved without asking)
Date: Sat, 05 Mar 2011 14:03:18 +0100

'jidanni' writes:
> Also I bet C-x C-x not asking if one wants to save gnus properly first, is related.

You mean C-x C-c.

Yes, it's the same issue, but that was a kludge anyway. Gnus didn't say
"Hey, I'm still running, you sure you want to exit Emacs?". Instead it
just happened to have a changed file open and asked if you wanted to
save .newsrc-dribble.

-David

Message #20 received at 8134 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: David Engster <deng <at> randomsample.de>
Cc: 8134 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#8134: (Some special files were saved without asking)
Date: Sat, 05 Mar 2011 14:38:06 -0500

David Engster <deng <at> randomsample.de> writes:

>> Encountered new message "(Some special files were saved without asking)".
>> Well at least in C-h e mention what they were.
>
> I agree.
>
> That you're suddenly seeing this message is due to a change in Gnus,
> which now saves the .newsrc-dribble file without asking when you invoke
> stuff like 'compile' and other functions which call `save-some-buffers'.
>
> I'm proposing the following change (against trunk):

Committed, with some tweaks.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.