From unknown Fri Jun 20 07:19:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8111: after adding a(nother) subconfigure, rerunning make fails Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 24 Feb 2011 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8111 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 8111@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.129857637623409 (code B ref -1); Thu, 24 Feb 2011 19:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Feb 2011 19:39:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Psh2F-00065W-S3 for submit@debbugs.gnu.org; Thu, 24 Feb 2011 14:39:36 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Psh2C-00065I-Go for submit@debbugs.gnu.org; Thu, 24 Feb 2011 14:39:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Psh26-0008VZ-Cd for submit@debbugs.gnu.org; Thu, 24 Feb 2011 14:39:27 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:49016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Psh26-0008VQ-A3 for submit@debbugs.gnu.org; Thu, 24 Feb 2011 14:39:26 -0500 Received: from [140.186.70.92] (port=41206 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Psh24-0006z5-Vc for bug-automake@gnu.org; Thu, 24 Feb 2011 14:39:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsgzG-0007uR-Kj for bug-automake@gnu.org; Thu, 24 Feb 2011 14:36:31 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:43472) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1PsgzG-0007u7-7o for bug-automake@gnu.org; Thu, 24 Feb 2011 14:36:30 -0500 Received: (qmail invoked by alias); 24 Feb 2011 19:36:27 -0000 Received: from xdsl-78-35-55-244.netcologne.de (EHLO localhost.localdomain) [78.35.55.244] by mail.gmx.net (mp043) with SMTP; 24 Feb 2011 20:36:27 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX18PjIAfljQP0Jp8mnxP/M5Jgps1zca/Mp7IH3YJiG DAxcN3PeFgzfzC Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1Psgz8-0007RG-Qr for bug-automake@gnu.org; Thu, 24 Feb 2011 20:36:22 +0100 Date: Thu, 24 Feb 2011 20:36:22 +0100 From: Ralf Wildenhues Message-ID: <20110224193622.GB24584@gmx.de> Mail-Followup-To: bug-automake@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Say I have a project with an up to date build tree. Say I add a(nother) sub package, update toplevel configure.ac, then rerun make. Then the new sub/configure will not be rerun by the triggered './config.status --recheck' thus make will later fail due to nonexistent Makefile in the new subdirectory. Not even rerunning autoreconf -v in the toplevel source directory, then rerunning make, will fix this: you need to rerun configure in the (each) build tree. Can we fix this somehow in either Autoconf or Automake? We could, by not passing --no-recursion upon --recheck, but doing that all the time is probably not the best way to address this. I'm not quite sure if we can find out at 'config.status --recheck' time whether the updated configure will enable the new sub configure. Maybe a --maybe-recursion? Thanks, Ralf Expose failure to run 'make' when new subpackage has been added. * tests/new-subpkg.test: New test. * tests/Makefile.am (TESTS, XFAIL_TESTS): Update. diff --git a/tests/Makefile.am b/tests/Makefile.am index 2ffdb9b..d6e3664 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -24,6 +24,7 @@ all.test \ auxdir2.test \ cond17.test \ gcj6.test \ +new-subpkg.test \ override-conditional-2.test \ txinfo5.test @@ -633,6 +634,7 @@ mkinst3.test \ mmode.test \ mmodely.test \ multlib.test \ +new-subpkg.test \ no-outdir-option.test \ nobase.test \ nobase-libtool.test \ diff --git a/tests/new-subpkg.test b/tests/new-subpkg.test new file mode 100644 index 0000000..b49e16d --- /dev/null +++ b/tests/new-subpkg.test @@ -0,0 +1,66 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# make should work after adding a new subpackage. + +required='GNUmake' +. ./defs || Exit 1 + +cat >>configure.in <<'END' +dnl AC_CONFIG_SUBDIRS([lib]) +AC_OUTPUT +END + +: >Makefile.am + +$ACLOCAL +$AUTOMAKE --add-missing +$AUTOCONF +./configure +$MAKE + +sed 's/^dnl //' configure.in > configure.int +mv -f configure.int configure.in + +cat >Makefile.am <<'EOF' +SUBDIRS = lib +EOF + +mkdir lib + +cat >lib/configure.ac <<'EOF' +AC_INIT([lib], [1]) +AM_INIT_AUTOMAKE +AC_CONFIG_FILES([Makefile]) +EOF + +: >lib/Makefile.am + +# Ideally, this would work. +#$MAKE + +# But for a start, it would be good if even this would work. +$ACLOCAL +$AUTOMAKE +$AUTOCONF +cd lib +$ACLOCAL +$AUTOMAKE --add-missing +$AUTOCONF +cd .. +$MAKE + +: From unknown Fri Jun 20 07:19:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8111: after adding a(nother) subconfigure, rerunning make fails Resent-From: Jack Kelly Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 24 Feb 2011 22:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8111 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12985877967025 (code B ref -1); Thu, 24 Feb 2011 22:50:03 +0000 Received: (at submit) by debbugs.gnu.org; 24 Feb 2011 22:49:56 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Psk0R-0001pG-TH for submit@debbugs.gnu.org; Thu, 24 Feb 2011 17:49:56 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Psk0Q-0001p4-8o for submit@debbugs.gnu.org; Thu, 24 Feb 2011 17:49:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Psk0K-00065j-HL for submit@debbugs.gnu.org; Thu, 24 Feb 2011 17:49:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:45220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Psk0K-00065e-FN for submit@debbugs.gnu.org; Thu, 24 Feb 2011 17:49:48 -0500 Received: from [140.186.70.92] (port=53915 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Psk0J-0005tC-Fc for bug-automake@gnu.org; Thu, 24 Feb 2011 17:49:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Psk0I-00065F-64 for bug-automake@gnu.org; Thu, 24 Feb 2011 17:49:47 -0500 Received: from mail-iw0-f169.google.com ([209.85.214.169]:49962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Psk0I-000659-3B for bug-automake@gnu.org; Thu, 24 Feb 2011 17:49:46 -0500 Received: by iwl42 with SMTP id 42so734511iwl.0 for ; Thu, 24 Feb 2011 14:49:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=tnxWN8QJdm3ckIOXRNbWfcQdYhFBIUJZut8gpJciAgg=; b=b0EB0cGUxKu9Ei8wkeFcZQC8a2Ze+wrY7dLEZ8khtMn5B/IhNcs/6FBQmIiDjXHW2D DAdFHZgHlzCx845k80/W7XbyOZG+WmgPDntZRt/ngR0nFIDznqW9shHmst4QxtD+4qwL Wuy28QXvX7AVgW1vMcubeSCWEJOlXfzHNfkdk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; b=yF6BuIOv/aFZ7QVK8JmA7ZGejEAmM4LT0GWuVN+CdBoTTGukc7x5lqwy9guA7bheVs 3BY7MAQqW2YwfuTI7kJ9JSV/0d99yCO4m1U4ll7UGpaaxuH0/XF6ic9bjSl3lKZmPsFq h4ODCLzDGQB4rQbugoxhChhex4wPzbRYtCkLE= MIME-Version: 1.0 Received: by 10.231.199.81 with SMTP id er17mr2296817ibb.115.1298587785074; Thu, 24 Feb 2011 14:49:45 -0800 (PST) Received: by 10.231.19.69 with HTTP; Thu, 24 Feb 2011 14:49:44 -0800 (PST) In-Reply-To: <20110224193622.GB24584@gmx.de> References: <20110224193622.GB24584@gmx.de> Date: Fri, 25 Feb 2011 09:49:44 +1100 X-Google-Sender-Auth: WWB5Fk3SZQTdSx2B5RJ2EXv6LQA Message-ID: From: Jack Kelly Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.2 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) On Fri, Feb 25, 2011 at 6:36 AM, Ralf Wildenhues wrote: > Can we fix this somehow in either Autoconf or Automake? Could we save the results of tracing AC_CONFIG_SUBDIRS calls? If there's a change, invoke ./config.status --recheck. If not, config.status --recheck --no-recursion. -- Jack From unknown Fri Jun 20 07:19:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8111: after adding a(nother) subconfigure, rerunning make fails Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Fri, 25 Feb 2011 20:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8111 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Jack Kelly , autoconf-patches@gnu.org Cc: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.129866685312353 (code B ref -1); Fri, 25 Feb 2011 20:48:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Feb 2011 20:47:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pt4ZY-0003DC-O0 for submit@debbugs.gnu.org; Fri, 25 Feb 2011 15:47:33 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pt4ZW-0003Cz-N2 for submit@debbugs.gnu.org; Fri, 25 Feb 2011 15:47:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pt4ZM-0004PU-Sn for submit@debbugs.gnu.org; Fri, 25 Feb 2011 15:47:25 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:39705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pt4ZM-0004PQ-QT for submit@debbugs.gnu.org; Fri, 25 Feb 2011 15:47:20 -0500 Received: from [140.186.70.92] (port=38231 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pt4ZG-0002gR-HD for bug-automake@gnu.org; Fri, 25 Feb 2011 15:47:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pt4Z9-0004OI-5y for bug-automake@gnu.org; Fri, 25 Feb 2011 15:47:14 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]:44966) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1Pt4Z8-0004O2-Ph for bug-automake@gnu.org; Fri, 25 Feb 2011 15:47:07 -0500 Received: (qmail invoked by alias); 25 Feb 2011 20:47:04 -0000 Received: from xdsl-89-0-169-160.netcologne.de (EHLO localhost.localdomain) [89.0.169.160] by mail.gmx.net (mp011) with SMTP; 25 Feb 2011 21:47:04 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX19kqd8XxxNkNeazmolI/n4cqnVZ2Kzb9E12lv/xTM yHgbFyt5DlFzLr Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1Pt4Yz-0003wk-Dy; Fri, 25 Feb 2011 21:46:57 +0100 Date: Fri, 25 Feb 2011 21:46:57 +0100 From: Ralf Wildenhues Message-ID: <20110225204657.GD30034@gmx.de> Mail-Followup-To: Jack Kelly , autoconf-patches@gnu.org, bug-automake@gnu.org References: <20110224193622.GB24584@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -4.5 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.5 (----) [ adding autoconf-patches; this is ] * Jack Kelly wrote on Thu, Feb 24, 2011 at 11:49:44PM CET: > On Fri, Feb 25, 2011 at 6:36 AM, Ralf Wildenhues wrote: > > Can we fix this somehow in either Autoconf or Automake? > > Could we save the results of tracing AC_CONFIG_SUBDIRS calls? If > there's a change, invoke ./config.status --recheck. If not, > config.status --recheck --no-recursion. Well, the rule that invokes 'config.status --recheck', let's call it the config.status rule, does not invoke any autotools, thus no m4. Any rule that invokes m4 must be a developer rule, but the config.status rule is a user rule, which is even in place with maintainer-mode. So we cannot mix these two concepts. (Aside, config.status --recheck invokes configure with --no-create and --no-recursion added, among the other arguments. Sorry for the nitpicking.) But I think we can still have our cake and eat it too: if I remove the --no-recursion from the list of arguments passed to configure, then the test starts to pass (once the missing AC_OUTPUT in the lib/configure.ac is fixed). Of course, we don't want to do that outright: if there is already a makefile in the subdir, then we don't want to recurse: the subdir makefile might want to run other rebuilding rules first. But if there isn't, and there is a configure script we can run, then I think we should do that. Since 'makefile' might be spelt in various different ways, we can take presence of 'config.status' in the subdir build tree as indicator, that should be good enough. I'm still wondering whether we should rename the option --new-recursion-only however, that would be more precise. Other than that, the patch below seems to do what I want. Comments? (And of course the test will need to be rewritten for Autoconf's test suite and amended to ensure we don't recurse when we shouldn't, and documentation and all that ...) Thanks, Ralf diff --git a/lib/autoconf/general.m4 b/lib/autoconf/general.m4 index 337aba7..ce80dde 100644 --- a/lib/autoconf/general.m4 +++ b/lib/autoconf/general.m4 @@ -751,7 +751,7 @@ do -no-recursion | --no-recursion | --no-recursio | --no-recursi \ | --no-recurs | --no-recur | --no-recu | --no-rec | --no-re | --no-r) - no_recursion=yes ;; + no_recursion=new-only ;; -oldincludedir | --oldincludedir | --oldincludedi | --oldincluded \ | --oldinclude | --oldinclud | --oldinclu | --oldincl | --oldinc \ diff --git a/lib/autoconf/status.m4 b/lib/autoconf/status.m4 index a1a857b..00d5721 100644 --- a/lib/autoconf/status.m4 +++ b/lib/autoconf/status.m4 @@ -1181,6 +1181,11 @@ if test "$no_recursion" != yes; then # parts of a large source tree are present. test -d "$srcdir/$ac_dir" || continue + # If recursing to new subpackages only, skip those that have makefiles. + if test "$no_recursion" = new-only && test -x $ac_dir/config.status; then + continue + fi + ac_msg="=== configuring in $ac_dir (`pwd`/$ac_dir)" _AS_ECHO_LOG([$ac_msg]) _AS_ECHO([$ac_msg]) From unknown Fri Jun 20 07:19:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8111: after adding a(nother) subconfigure, rerunning make fails Resent-From: Jack Kelly Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Fri, 25 Feb 2011 21:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8111 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Jack Kelly , autoconf-patches@gnu.org, bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.129866994519778 (code B ref -1); Fri, 25 Feb 2011 21:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Feb 2011 21:39:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pt5NQ-00058x-4s for submit@debbugs.gnu.org; Fri, 25 Feb 2011 16:39:04 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pt5NN-00058T-NK for submit@debbugs.gnu.org; Fri, 25 Feb 2011 16:39:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pt5NE-0002rn-4K for submit@debbugs.gnu.org; Fri, 25 Feb 2011 16:38:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:58150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pt5NE-0002ri-1l for submit@debbugs.gnu.org; Fri, 25 Feb 2011 16:38:52 -0500 Received: from [140.186.70.92] (port=48698 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pt5N9-0006bB-2N for bug-automake@gnu.org; Fri, 25 Feb 2011 16:38:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pt5N3-0002pv-Uz for bug-automake@gnu.org; Fri, 25 Feb 2011 16:38:46 -0500 Received: from mail-vx0-f169.google.com ([209.85.220.169]:64173) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pt5N3-0002ph-Rq; Fri, 25 Feb 2011 16:38:41 -0500 Received: by vxc38 with SMTP id 38so2273510vxc.0 for ; Fri, 25 Feb 2011 13:38:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=0REYDCvudOzXkofaBOg9VaoA+TNYtJ22rXudTb9+m3U=; b=PJM+8Vni342LxsFN5iVCViorbWs3hYC6/2tkG3IymQumPtVjOspVU+CtXgdjLBRnU6 KWh9urQfs5lHNQ4pEKuIqjxD/srpAjIY7PAX8fnXPsoveWwKkVKJGLo2OWhpBgN5IkWQ RmqXtLgblCWvS9pY/n8onNMLCNMGVKHmWdp/g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=gjefRZJNymtDdk0cEy5rEJ0uSCmVF5u7jFB4RkULnl+Y2Vm3AE2+N1cI3scGIplxJH tbvGEuGtmsTr8SNCPT7ncT/tM2MFEGCC5hH6YVQhpI5rwKeJptZVmDK56XtbGNgTNqGd SFu675wEQKJNhDeySJJ+nR6qWT0G5CnaH5lfY= MIME-Version: 1.0 Received: by 10.220.184.75 with SMTP id cj11mr746948vcb.81.1298669920003; Fri, 25 Feb 2011 13:38:40 -0800 (PST) Received: by 10.220.4.148 with HTTP; Fri, 25 Feb 2011 13:38:39 -0800 (PST) In-Reply-To: <20110225204657.GD30034@gmx.de> References: <20110224193622.GB24584@gmx.de> <20110225204657.GD30034@gmx.de> Date: Sat, 26 Feb 2011 08:38:39 +1100 X-Google-Sender-Auth: 0LFx1Uiw5FJCHoIlYXtk9qXEaiQ Message-ID: From: Jack Kelly Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.2 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) On Sat, Feb 26, 2011 at 7:46 AM, Ralf Wildenhues w= rote: > [ adding autoconf-patches; this is ] > > * Jack Kelly wrote on Thu, Feb 24, 2011 at 11:49:44PM CET: >> On Fri, Feb 25, 2011 at 6:36 AM, Ralf Wildenhues wrote: >> > Can we fix this somehow in either Autoconf or Automake? >> >> Could we save the results of tracing AC_CONFIG_SUBDIRS calls? If >> there's a change, invoke ./config.status --recheck. If not, >> config.status --recheck --no-recursion. > > Well, the rule that invokes 'config.status --recheck', let's call it the > config.status rule, does not invoke any autotools, thus no m4. =A0Any > rule that invokes m4 must be a developer rule, but the config.status > rule is a user rule, which is even in place with maintainer-mode. > So we cannot mix these two concepts. If they are changing `configure.ac', they will be invoking developer rules. I don't mean trace in the ./config.status --recheck rule, but instead at `automake' time: If there are any AC_CONFIG_SUBDIRS calls, write them out to a trace file (such as build-aux/subdirs.trace). Save the previous trace as build-aux/subdirs.trace.old. Now the rule to call config.status --recheck needs to only run `diff'. Having clarified myself, I think your method makes more sense (and has no additional files to dist). Comments on that below. >=A0Since 'makefile' might be spelt in various different > ways, we can take presence of 'config.status' in the subdir build tree > as indicator, that should be good enough. You should add a comment to this effect in your status.m4 changes. Currently, it looks like you've tested for config.status by mistake. > I'm still wondering whether we should rename the option > --new-recursion-only however, that would be more precise. > Other than that, the patch below seems to do what I want. Yes. the name becomes very confusing. Maybe --recursion=3Dno (with --no-recursion as an alias), --recursion=3Dnew-only? -- Jack From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 26 03:00:53 2011 Received: (at control) by debbugs.gnu.org; 26 Feb 2011 08:00:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtF5B-0003Ih-GC for submit@debbugs.gnu.org; Sat, 26 Feb 2011 03:00:53 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PtF58-0003IQ-NU for control@debbugs.gnu.org; Sat, 26 Feb 2011 03:00:51 -0500 Received: (qmail invoked by alias); 26 Feb 2011 08:00:44 -0000 Received: from xdsl-78-35-50-51.netcologne.de (EHLO localhost.localdomain) [78.35.50.51] by mail.gmx.net (mp048) with SMTP; 26 Feb 2011 09:00:44 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX18bujVD+yUbwgb+NHQzHr2rv1NX+FloG0n94AAVvl BYoQXWlwV4QpXv Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1PtF4u-0001l8-MM; Sat, 26 Feb 2011 09:00:36 +0100 Date: Sat, 26 Feb 2011 09:00:36 +0100 From: Ralf Wildenhues To: Jack Kelly Subject: Re: bug#8111: after adding a(nother) subconfigure, rerunning make fails Message-ID: <20110226080036.GA15829@gmx.de> Mail-Followup-To: Jack Kelly , bug-automake@gnu.org References: <20110224193622.GB24584@gmx.de> <20110225204657.GD30034@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: control Cc: bug-automake@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) close 8111 thanks This is not an Automake bug after all. It can be solved completely within Autoconf, thus no new version skew danger. :-) Patch for Autoconf coming up. Thanks, Ralf From unknown Fri Jun 20 07:19:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8111: after adding a(nother) subconfigure, rerunning make fails Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 26 Feb 2011 08:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8111 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 8111@debbugs.gnu.org Cc: Ralf Wildenhues , Jack Kelly Received: via spool by 8111-submit@debbugs.gnu.org id=B8111.129870920018351 (code B ref 8111); Sat, 26 Feb 2011 08:34:01 +0000 Received: (at 8111) by debbugs.gnu.org; 26 Feb 2011 08:33:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtFaa-0004lw-F0 for submit@debbugs.gnu.org; Sat, 26 Feb 2011 03:33:20 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtFaZ-0004ll-0y for 8111@debbugs.gnu.org; Sat, 26 Feb 2011 03:33:19 -0500 Received: by wwc33 with SMTP id 33so3019683wwc.15 for <8111@debbugs.gnu.org>; Sat, 26 Feb 2011 00:33:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=HQjdT0mqMb/C/n/tyfp5Iyd8tc4A35moVIuZbBU8rm4=; b=ILfpkW4AgxGhNr2WrBa/kfc0zfDa5dALRfFsM+hii81WK9Ml1IphyQcTMvILhD0sxD maPRBjDkOQGW24rPQ9Yo1I0bPUI3W7rGSq0ww6aURaegg3apNuypbEnOsESA442Vd/Qc pztnP/rnVtrtz3csLIuZdJQ7xq62ovkfCBOTI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=slM2Mvhng/qETQce5TiDJ82EUN/cTEfFinFj53PVfrlcQxl8O5Z2JYfNXn/FbohKC3 tb5IhiwLD1Prc6iUUeUgQcjGW7Yr+eVtQznwEGboYUAXZOtc8pIrrLdVNBuSlatub5la chz+aRxvuZw+Zi5znfuIrLvGMeyb9JrFrfHtg= Received: by 10.227.154.74 with SMTP id n10mr2942080wbw.116.1298709193176; Sat, 26 Feb 2011 00:33:13 -0800 (PST) Received: from bigio.localnet (host166-97-dynamic.21-79-r.retail.telecomitalia.it [79.21.97.166]) by mx.google.com with ESMTPS id o6sm1307366wbo.21.2011.02.26.00.33.11 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 Feb 2011 00:33:12 -0800 (PST) From: Stefano Lattarini Date: Sat, 26 Feb 2011 09:32:57 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <20110224193622.GB24584@gmx.de> <20110226080036.GA15829@gmx.de> In-Reply-To: <20110226080036.GA15829@gmx.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201102260932.58511.stefano.lattarini@gmail.com> X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) Hello Ralf. On Saturday 26 February 2011, Ralf Wildenhues wrote: > close 8111 > thanks > > This is not an Automake bug after all. It can be solved completely > within Autoconf, thus no new version skew danger. :-) > What about checking in your automake testcase anyway (obviously to be skipped with autoconf <= 2.68)? From a blackbox perspective, the behaviour it tests is the desired and expected one, so IHMO it makes sense to check for it, against (say) possible future automake and/or autoconf regressions. Thanks, Stefano From unknown Fri Jun 20 07:19:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8111: after adding a(nother) subconfigure, rerunning make fails Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 26 Feb 2011 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8111 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Stefano Lattarini , automake-patches@gnu.org Cc: 8111@debbugs.gnu.org, Jack Kelly Received: via spool by 8111-submit@debbugs.gnu.org id=B8111.129871234922650 (code B ref 8111); Sat, 26 Feb 2011 09:26:02 +0000 Received: (at 8111) by debbugs.gnu.org; 26 Feb 2011 09:25:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtGPL-0005tH-Um for submit@debbugs.gnu.org; Sat, 26 Feb 2011 04:25:48 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PtGPJ-0005t3-1T for 8111@debbugs.gnu.org; Sat, 26 Feb 2011 04:25:46 -0500 Received: (qmail invoked by alias); 26 Feb 2011 09:25:38 -0000 Received: from xdsl-78-35-50-51.netcologne.de (EHLO localhost.localdomain) [78.35.50.51] by mail.gmx.net (mp060) with SMTP; 26 Feb 2011 10:25:38 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX18U6ANDmR8UiDjPDBh4d7bFq4cz+LxGHmEymb/yls AcOS4FJWuftPKW Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1PtGP4-0004Tr-2a; Sat, 26 Feb 2011 10:25:30 +0100 Date: Sat, 26 Feb 2011 10:25:30 +0100 From: Ralf Wildenhues Message-ID: <20110226092529.GC15829@gmx.de> Mail-Followup-To: Stefano Lattarini , automake-patches@gnu.org, 8111@debbugs.gnu.org, Jack Kelly References: <20110224193622.GB24584@gmx.de> <20110226080036.GA15829@gmx.de> <201102260932.58511.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102260932.58511.stefano.lattarini@gmail.com> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Hi Stefano, * Stefano Lattarini wrote on Sat, Feb 26, 2011 at 09:32:57AM CET: > On Saturday 26 February 2011, Ralf Wildenhues wrote: > > This is not an Automake bug after all. It can be solved completely > > within Autoconf, thus no new version skew danger. :-) > > > What about checking in your automake testcase anyway (obviously to > be skipped with autoconf <= 2.68)? From a blackbox perspective, the > behaviour it tests is the desired and expected one, so IHMO it makes > sense to check for it, against (say) possible future automake and/or > autoconf regressions. Yeah, that's what I figured too, but thanks for bringing it up. I intend to push something like the patch below to maint when the Autoconf API is cast in stone. Cheers, Ralf With new Autoconf, rebuilding works after adding a subpackage. * tests/new-subpkg.test: New test. * tests/Makefile.am (TESTS): Update. diff --git a/tests/Makefile.am b/tests/Makefile.am index 047bc7b..aecbfb3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -519,6 +519,7 @@ mkinst3.test \ mmode.test \ mmodely.test \ multlib.test \ +new-subpkg.test \ nobase.test \ nobase-libtool.test \ nobase-python.test \ diff --git a/tests/new-subpkg.test b/tests/new-subpkg.test new file mode 100755 index 0000000..0b82a9a --- /dev/null +++ b/tests/new-subpkg.test @@ -0,0 +1,71 @@ +#! /bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# `make' should work after adding a new subpackage to an existing tree. + +required='GNUmake' +. ./defs || Exit 1 + +cat >>configure.in <<'END' +dnl AC_CONFIG_SUBDIRS([lib]) +AC_OUTPUT +END + +: >Makefile.am + +$ACLOCAL +$AUTOMAKE --add-missing +$AUTOCONF + +# We need new-enough Autoconf that recurses new subpackages. +./configure --help | grep 'recursion=.*new-only' || Exit 77 + +./configure +$MAKE + +sed 's/^dnl //' configure.in > configure.int +mv -f configure.int configure.in + +cat >Makefile.am <<'EOF' +SUBDIRS = lib +EOF + +mkdir lib + +cat >lib/configure.ac <<'EOF' +AC_INIT([lib], [1]) +AM_INIT_AUTOMAKE +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT +EOF + +: >lib/Makefile.am + +# Ideally, this would work. +#$MAKE + +# But for a start, being able to run make after a manual bootstrap is good. +$ACLOCAL +$AUTOMAKE +$AUTOCONF +cd lib +$ACLOCAL +$AUTOMAKE --add-missing +$AUTOCONF +cd .. +$MAKE + +: