From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Resent-From: Jack Kelly Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 24 Feb 2011 02:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8104 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 8104@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12985128666687 (code B ref -1); Thu, 24 Feb 2011 02:02:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Feb 2011 02:01:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsQVu-0001jo-CN for submit@debbugs.gnu.org; Wed, 23 Feb 2011 21:01:06 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsQVs-0001jJ-F4 for submit@debbugs.gnu.org; Wed, 23 Feb 2011 21:01:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsQVm-0007DJ-GV for submit@debbugs.gnu.org; Wed, 23 Feb 2011 21:00:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:47885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsQVm-0007DF-EG for submit@debbugs.gnu.org; Wed, 23 Feb 2011 21:00:58 -0500 Received: from [140.186.70.92] (port=33330 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsQVl-0008F3-HJ for bug-automake@gnu.org; Wed, 23 Feb 2011 21:00:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsQVk-0007D5-9H for bug-automake@gnu.org; Wed, 23 Feb 2011 21:00:57 -0500 Received: from mail-vw0-f41.google.com ([209.85.212.41]:49163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsQVk-0007Cw-6t for bug-automake@gnu.org; Wed, 23 Feb 2011 21:00:56 -0500 Received: by vws13 with SMTP id 13so70464vws.0 for ; Wed, 23 Feb 2011 18:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:date:x-google-sender-auth :message-id:subject:from:to:content-type; bh=GnD94wJDjPKcajqe5IydZ2IZlxtzy/FBa69N04drxB4=; b=U62W7fkKfefcuhONEuabTYIVL6PpUoKu9GhSUwuClZZ5LDHDVwC8cZNDlZ/9+ghoUR yeYguwVUb6tgsHM1vLzmknI2RafBCXrqCTqEDJeMAFVb0v88UOU2rQsbKNj/XyJM39QF P0hcX3wy/jwT2SxCJl3ldcNMlGTOelRWjUPDg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; b=XyaLHXGoK6mUqCsn+Zr2nvynF37tKx7Vm+5Zq6ye9RhTf5GgJI4Qxg2NzHw0nQMw2M SaRQ4JPqwUUoC+g/wByIZegSKIEc6HQwt0rYEYa6CYEMEkOxVX9yEwZVjPaEPRZIJQCZ 7iNrLHsr4zWIHZupksTeKHUJABZ7Jei0zgXDo= MIME-Version: 1.0 Received: by 10.220.184.75 with SMTP id cj11mr65811vcb.81.1298512855050; Wed, 23 Feb 2011 18:00:55 -0800 (PST) Received: by 10.220.4.148 with HTTP; Wed, 23 Feb 2011 18:00:54 -0800 (PST) Date: Thu, 24 Feb 2011 13:00:54 +1100 X-Google-Sender-Auth: r8s0a5HJ6XyzUiprlLBaWiyJL_A Message-ID: From: Jack Kelly Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.1 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) Version: 1.11.1 (ubuntu 10.10). I have inspected the most recent master and it appears to also have this bug. configure.ac: AC_INIT([a], [b], [c]) AM_INIT_AUTOMAKE([foreign]) dnl no LT_INIT -- on purpose AC_PROG_CC AC_CONFIG_FILES([Makefile]) AC_OUTPUT Makefile.am: lib_LTLIBRARIES = libfoo.la Run autoreconf -i: $ autoreconf -i Makefile.am:1: Libtool library used but `LIBTOOL' is undefined Makefile.am:1: The usual way to define `LIBTOOL' is to add `AC_PROG_LIBTOOL' Makefile.am:1: to `configure.ac' and run `aclocal' and `autoconf' again. Makefile.am:1: If `AC_PROG_LIBTOOL' is in `configure.ac', make sure Makefile.am:1: its definition is in aclocal's search path. autoreconf: automake failed with exit status: 1 See the libtool manual ( http://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html ): AC_PROG_LIBTOOL and AM_PROG_LIBTOOL are deprecated names for older versions of this macro; autoupdate will upgrade your configure.ac files. It appears that automake's message is out of date. -- Jack From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Thu, 24 Feb 2011 09:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8104 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: automake-patches@gnu.org Cc: 8104@debbugs.gnu.org, Jack Kelly Received: via spool by 8104-submit@debbugs.gnu.org id=B8104.129854073828580 (code B ref 8104); Thu, 24 Feb 2011 09:46:01 +0000 Received: (at 8104) by debbugs.gnu.org; 24 Feb 2011 09:45:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsXlQ-0007Qv-QR for submit@debbugs.gnu.org; Thu, 24 Feb 2011 04:45:37 -0500 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsXlO-0007Qh-43 for 8104@debbugs.gnu.org; Thu, 24 Feb 2011 04:45:35 -0500 Received: by bwz13 with SMTP id 13so914956bwz.3 for <8104@debbugs.gnu.org>; Thu, 24 Feb 2011 01:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:message-id; bh=f3jHFA1vl9t0rTy2k5H3GV7N/ktx8+oAPk0fw0rUWU4=; b=x1Zb0B1phokAjBpc2/kqxpIhooS8uuF4pJ3DKTgfFt4y+h4AiXZ3oI/qoI+KOzYd3t w3nJzsAapCey4pd61oQpmPoWAa1wQUEzN0nzJzzR1e0/gEM6Uyz8K9Pa6QBUpx4Xseyh 2UZeNIO4WNPHF3mNT/C8ieyz/FHMAgEbTdQ00= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:message-id; b=tI8U84/ZtsSACdOGrnpTBJWuXwqGTUoXgtcQ4E3RiK/WCRiFKEKrub82zFC6wtrpwf qyPnQ0ad+lX4RTkcgL7SmwEm+rvBHcrqRNzZ1cu9I1AErKqfIG9eC/3YzfaVx64F/iMX fq8xp3LqcuwIR/U9o0qvVyK5Vvb+xX0fpFCuk= Received: by 10.204.61.10 with SMTP id r10mr490306bkh.195.1298540728156; Thu, 24 Feb 2011 01:45:28 -0800 (PST) Received: from bigio.localnet (host136-10-dynamic.13-87-r.retail.telecomitalia.it [87.13.10.136]) by mx.google.com with ESMTPS id a17sm564568bku.11.2011.02.24.01.45.26 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Feb 2011 01:45:26 -0800 (PST) From: Stefano Lattarini Date: Thu, 24 Feb 2011 10:45:11 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: In-Reply-To: MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_oiiZNTpoNhD+aNj" Message-Id: <201102241045.12178.stefano.lattarini@gmail.com> X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) --Boundary-00=_oiiZNTpoNhD+aNj Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thursday 24 February 2011, Jack Kelly wrote: > Version: 1.11.1 (ubuntu 10.10). I have inspected the most recent > master and it appears to also have this bug. > > configure.ac: > AC_INIT([a], [b], [c]) > AM_INIT_AUTOMAKE([foreign]) > dnl no LT_INIT -- on purpose > AC_PROG_CC > AC_CONFIG_FILES([Makefile]) > AC_OUTPUT > > Makefile.am: > lib_LTLIBRARIES = libfoo.la > > Run autoreconf -i: > $ autoreconf -i > Makefile.am:1: Libtool library used but `LIBTOOL' is undefined > Makefile.am:1: The usual way to define `LIBTOOL' is to add `AC_PROG_LIBTOOL' > Makefile.am:1: to `configure.ac' and run `aclocal' and `autoconf' again. > Makefile.am:1: If `AC_PROG_LIBTOOL' is in `configure.ac', make sure > Makefile.am:1: its definition is in aclocal's search path. > autoreconf: automake failed with exit status: 1 > > See the libtool manual ( > http://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html > ): > AC_PROG_LIBTOOL and AM_PROG_LIBTOOL are deprecated names for older > versions of this macro; autoupdate will upgrade your configure.ac > files. > > It appears that automake's message is out of date. > I agree with Jack that advertising the use of LT_INIT would be better, since, according to Libtool NEWS file, that has obsoleted AC_PROG_LIBTOOL since version 1.9b (2004-08-29). What about the attached patch (for maint)? Regards, Stefano --Boundary-00=_oiiZNTpoNhD+aNj Content-Type: text/x-patch; charset="us-ascii"; name="0001-libtool-suggest-LT_INIT-if-LTLIBRARIES-primary-is-us.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0001-libtool-suggest-LT_INIT-if-LTLIBRARIES-primary-is-us.patch" =46rom f61bfa70a40c5f29fa4fa9eb3ce7435f13aeb479 Mon Sep 17 00:00:00 2001 =46rom: Stefano Lattarini Date: Thu, 24 Feb 2011 10:21:19 +0100 Subject: [PATCH] libtool: suggest LT_INIT if LTLIBRARIES primary is used When the LTLIBRARIES primary was used, but $(LIBTOOL) wasn't defined, automake suggested to add a call to AC_PROG_LIBTOOL in configure.ac. But that macro is deprecated since Libtool version 1.9b (2004-08-29), in favor of the newer LT_INIT. So suggest the use of this latter macro instead. * lib/Automake/Variable.pm (%_am_macro_for_var): Pair 'LIBTOOL' with 'LT_INIT', not with 'AC_PROG_LIBTOOL'. * libtool4.test: Adjust and extend. Also, add a call to macro AC_PROG_CC in configure.in, to help ensuring that automake does not fail for the wrong reasons. * ltinit.test: New test, ensure that automake's libtool support works with LT_INIT-based interface. Thanks to Jack Kelly for the suggestion. =2D-- ChangeLog | 17 +++++++++++++ lib/Automake/Variable.pm | 2 +- tests/Makefile.am | 1 + tests/Makefile.in | 1 + tests/libtool4.test | 9 ++++++- tests/ltinit.test | 61 ++++++++++++++++++++++++++++++++++++++++++= ++++ 6 files changed, 89 insertions(+), 2 deletions(-) create mode 100755 tests/ltinit.test diff --git a/ChangeLog b/ChangeLog index 8d03512..acd71bb 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,20 @@ +2011-02-24 Stefano Lattarini + + libtool: suggest LT_INIT if LTLIBRARIES primary is used + When the LTLIBRARIES primary was used, but $(LIBTOOL) wasn't + defined, automake suggested to add a call to AC_PROG_LIBTOOL + in configure.ac. But that macro is deprecated since Libtool + version 1.9b (2004-08-29), in favor of the newer LT_INIT. So + suggest the use of this latter macro instead. + * lib/Automake/Variable.pm (%_am_macro_for_var): Pair 'LIBTOOL' + with 'LT_INIT', not with 'AC_PROG_LIBTOOL'. + * libtool4.test: Adjust and extend. Also, add a call to macro + AC_PROG_CC in configure.in, to help ensuring that automake does + not fail for the wrong reasons. + * ltinit.test: New test, ensure that automake's libtool support + works with LT_INIT-based interface. + Thanks to Jack Kelly for the suggestion. + 2011-02-20 Stefano Lattarini =20 tests: tempdirs with restrictive permissions are cleaned correctly diff --git a/lib/Automake/Variable.pm b/lib/Automake/Variable.pm index cb9d182..686847d 100644 =2D-- a/lib/Automake/Variable.pm +++ b/lib/Automake/Variable.pm @@ -162,7 +162,7 @@ my %_am_macro_for_var =3D EMACS =3D> 'AM_PATH_LISPDIR', GCJ =3D> 'AM_PROG_GCJ', LEX =3D> 'AM_PROG_LEX', =2D LIBTOOL =3D> 'AC_PROG_LIBTOOL', + LIBTOOL =3D> 'LT_INIT', lispdir =3D> 'AM_PATH_LISPDIR', pkgpyexecdir =3D> 'AM_PATH_PYTHON', pkgpythondir =3D> 'AM_PATH_PYTHON', diff --git a/tests/Makefile.am b/tests/Makefile.am index 047bc7b..cd564fa 100644 =2D-- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -481,6 +481,7 @@ ltcond.test \ ltcond2.test \ ltconv.test \ ltdeps.test \ +ltinit.test \ ltinstloc.test \ ltlibobjs.test \ ltlibsrc.test \ diff --git a/tests/Makefile.in b/tests/Makefile.in index fe6238b..f56ff21 100644 =2D-- a/tests/Makefile.in +++ b/tests/Makefile.in @@ -751,6 +751,7 @@ ltcond.test \ ltcond2.test \ ltconv.test \ ltdeps.test \ +ltinit.test \ ltinstloc.test \ ltlibobjs.test \ ltlibsrc.test \ diff --git a/tests/libtool4.test b/tests/libtool4.test index bcc9b0f..9f6a730 100755 =2D-- a/tests/libtool4.test +++ b/tests/libtool4.test @@ -20,10 +20,17 @@ =20 set -e =20 +cat >> configure.in <<'END' +AC_PROG_CC +END + cat > Makefile.am << 'END' EXTRA_LTLIBRARIES =3D liblib.la END =20 $ACLOCAL AUTOMAKE_fails =2Dgrep AC_PROG_LIBTOOL stderr +grep '[Ll]ibtool library .*LIBTOOL.* undefined' stderr +grep 'define .*LIBTOOL.* add .*LT_INIT' stderr + +: diff --git a/tests/ltinit.test b/tests/ltinit.test new file mode 100755 index 0000000..d646bc9 =2D-- /dev/null +++ b/tests/ltinit.test @@ -0,0 +1,61 @@ +#!/bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test that libtool support works correctly when "newer" libtool +# interface (with LT_INIT etc.) is used (this interface has been +# present since libtool 1.9b, circa 2004). + +required=3D'libtoolize' +. ./defs || Exit 1 + +set -e + +cat >>configure.in <<'END' +AC_PROG_CC +LT_PREREQ([2.0]) +LT_INIT([dlopen]) +AC_OUTPUT +END + +cat >Makefile.am <<'END' +lib_LTLIBRARIES =3D libfoo.la +END + +cat > libfoo.c <<'END' +int foo (void) +{ + return 1; +} +END + +libtoolize +$ACLOCAL + +$AUTOCONF || { if $? -eq 63; then Exit 77; else Exit 1; fi; } +$EGREP '^LT_(INIT|PREREQ)' configure && Exit 77 + +$AUTOMAKE -a + +cwd=3D`pwd` +./configure --prefix=3D"$cwd/inst" >stdout || { cat stdout; Exit 1; } +cat stdout +grep '^checking.*dlopen' stdout + +$MAKE +$MAKE install +$MAKE distcheck + +: =2D-=20 1.7.2.3 --Boundary-00=_oiiZNTpoNhD+aNj-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 24 04:48:33 2011 Received: (at control) by debbugs.gnu.org; 24 Feb 2011 09:48:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsXoG-0007VO-Ir for submit@debbugs.gnu.org; Thu, 24 Feb 2011 04:48:32 -0500 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsXoE-0007VC-NO for control@debbugs.gnu.org; Thu, 24 Feb 2011 04:48:31 -0500 Received: by bwz13 with SMTP id 13so916381bwz.3 for ; Thu, 24 Feb 2011 01:48:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:mime-version :content-type:content-transfer-encoding:message-id; bh=u5SwjJWncH1DfbB1fZ/7pVGRwp2aGCfT/DVsRMlVv+Q=; b=nn4B08TOHHv+oi1B+zWHq1hn2EDcx8afVT30FOxAKE/SLW6GUfr/7IaL4zapLd8MgK DJJ/qXn0JGTWZ8U2Y2wQOURrtsWLwYNRF84jwZvRjhj4QxUr1+0bU1Qcs6k4NOtRnLXC 5vQ2K4EV0Mwv56GTdntC5vW0Lo0NTn6hclros= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:mime-version:content-type :content-transfer-encoding:message-id; b=wKKzE3mdNAh0wZ42Co5uNj7Fr1RbbUo42seQm2EIJbt/ewpV66zqAlXMPkyneQhS+9 i/swKcBhpawNArkSgYDuBHjHlZqv+5aaMeWs9UO2wbLE/NxA2CVl8xfX6YtsMNnyAJ+f +g/CR70JN4qnL0oO7zz6WMTsImZmsE7ua7V3Y= Received: by 10.204.10.141 with SMTP id p13mr503514bkp.106.1298540905096; Thu, 24 Feb 2011 01:48:25 -0800 (PST) Received: from bigio.localnet (host136-10-dynamic.13-87-r.retail.telecomitalia.it [87.13.10.136]) by mx.google.com with ESMTPS id f20sm5978231bkf.4.2011.02.24.01.48.23 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 24 Feb 2011 01:48:24 -0800 (PST) From: Stefano Lattarini To: control@debbugs.gnu.org Subject: automake bug#8104 Date: Thu, 24 Feb 2011 10:48:14 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201102241048.15360.stefano.lattarini@gmail.com> X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) tags 8104 patch thanks From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 26 Feb 2011 11:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8104 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Stefano Lattarini Cc: 8104@debbugs.gnu.org, Jack Kelly , automake-patches@gnu.org Received: via spool by 8104-submit@debbugs.gnu.org id=B8104.1298719707351 (code B ref 8104); Sat, 26 Feb 2011 11:29:02 +0000 Received: (at 8104) by debbugs.gnu.org; 26 Feb 2011 11:28:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtIK3-00005c-1f for submit@debbugs.gnu.org; Sat, 26 Feb 2011 06:28:27 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PtIK0-00005Q-Cy for 8104@debbugs.gnu.org; Sat, 26 Feb 2011 06:28:25 -0500 Received: (qmail invoked by alias); 26 Feb 2011 11:28:18 -0000 Received: from xdsl-78-35-50-51.netcologne.de (EHLO localhost.localdomain) [78.35.50.51] by mail.gmx.net (mp065) with SMTP; 26 Feb 2011 12:28:18 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX18FR/8XWXMFpzBatpB6c9eod89KrwvhZDXPCnlOkZ FOjjj5HZ08OqmX Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1PtIJj-0004VW-1x; Sat, 26 Feb 2011 12:28:07 +0100 Date: Sat, 26 Feb 2011 12:28:07 +0100 From: Ralf Wildenhues Message-ID: <20110226112806.GD15829@gmx.de> Mail-Followup-To: Stefano Lattarini , automake-patches@gnu.org, 8104@debbugs.gnu.org, Jack Kelly References: <201102241045.12178.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102241045.12178.stefano.lattarini@gmail.com> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) * Stefano Lattarini wrote on Thu, Feb 24, 2011 at 10:45:11AM CET: > I agree with Jack that advertising the use of LT_INIT would be better, > since, according to Libtool NEWS file, that has obsoleted AC_PROG_LIBTOOL > since version 1.9b (2004-08-29). Yes. There are still 1.5.x users out there, but my patience with them is starting to go down. > What about the attached patch (for maint)? Yes, if it has been tested that it will skip when Libtool 1.5.x macros are in place. LT_PREREQ has been introduced in 1.9b only. Also, I think that if the LT_PREREQ check fails, it will fail already at aclocal run time, but I am not sure of that. Thanks, Ralf > Subject: [PATCH] libtool: suggest LT_INIT if LTLIBRARIES primary is used > > When the LTLIBRARIES primary was used, but $(LIBTOOL) wasn't > defined, automake suggested to add a call to AC_PROG_LIBTOOL > in configure.ac. But that macro is deprecated since Libtool > version 1.9b (2004-08-29), in favor of the newer LT_INIT. So > suggest the use of this latter macro instead. > > * lib/Automake/Variable.pm (%_am_macro_for_var): Pair 'LIBTOOL' > with 'LT_INIT', not with 'AC_PROG_LIBTOOL'. > * libtool4.test: Adjust and extend. Also, add a call to macro > AC_PROG_CC in configure.in, to help ensuring that automake does > not fail for the wrong reasons. > * ltinit.test: New test, ensure that automake's libtool support > works with LT_INIT-based interface. > > Thanks to Jack Kelly for the suggestion. From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 26 Feb 2011 13:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8104 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Ralf Wildenhues Cc: 8104@debbugs.gnu.org, Jack Kelly , automake-patches@gnu.org Received: via spool by 8104-submit@debbugs.gnu.org id=B8104.129872574711850 (code B ref 8104); Sat, 26 Feb 2011 13:10:03 +0000 Received: (at 8104) by debbugs.gnu.org; 26 Feb 2011 13:09:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtJtS-000355-GQ for submit@debbugs.gnu.org; Sat, 26 Feb 2011 08:09:07 -0500 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtJtQ-00034a-7A for 8104@debbugs.gnu.org; Sat, 26 Feb 2011 08:09:05 -0500 Received: by wyb42 with SMTP id 42so2240274wyb.3 for <8104@debbugs.gnu.org>; Sat, 26 Feb 2011 05:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=0caHCPX1nOR4KkdMoe0CrroTmwaHroi7/Yxc/RHNHKw=; b=u8dX7TDI45fplUOevFlKpDj3f+DNxnCE1ZF34QiMp+qvUHbJWFrpEPrQaofKIysqEp SAClElRAsvClta6VygLSyG3oLaRztAdbBCHuhr8niWYcinhqrRpncODE9NXslKL0Rn9/ S/Xd78vh6kuRyL3mR4w0s5KyzUNRCAA9WOP+M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=wPE+Gs+65Gl7zLkY6PuHjt8kH1Fac1NSSGGS08D53oBVIyp+iYgau3S7SOi5Iwity6 G7HRPjsVJIfQakn11F2gE9U0BOEFicAFGz2laxxdQwNsba+g5wEMesmLWnGE0cQC8xjD /4SYR2S8eUvavS+PWDgkbO7L+tF8oiKMftLsw= Received: by 10.216.52.143 with SMTP id e15mr458405wec.44.1298725738347; Sat, 26 Feb 2011 05:08:58 -0800 (PST) Received: from bigio.localnet (host24-48-dynamic.58-82-r.retail.telecomitalia.it [82.58.48.24]) by mx.google.com with ESMTPS id t11sm864256wes.17.2011.02.26.05.08.56 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 Feb 2011 05:08:57 -0800 (PST) From: Stefano Lattarini Date: Sat, 26 Feb 2011 14:08:39 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201102241045.12178.stefano.lattarini@gmail.com> <20110226112806.GD15829@gmx.de> In-Reply-To: <20110226112806.GD15829@gmx.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201102261408.40568.stefano.lattarini@gmail.com> X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Saturday 26 February 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Thu, Feb 24, 2011 at 10:45:11AM CET: > > I agree with Jack that advertising the use of LT_INIT would be better, > > since, according to Libtool NEWS file, that has obsoleted AC_PROG_LIBTOOL > > since version 1.9b (2004-08-29). > > Yes. There are still 1.5.x users out there, but my patience with them > is starting to go down. > > > What about the attached patch (for maint)? > > Yes, if it has been tested that it will skip when Libtool 1.5.x macros > are in place. > Done now, it works. BTW, such kind of checks would be much easier to perform with Paolo's pending patch for ACLOCAL_PATH support in place; pointer: > LT_PREREQ has been introduced in 1.9b only. Also, I > think that if the LT_PREREQ check fails, it will fail already > at aclocal run time, > Oops, I dind't think of that. > but I am not sure of that. > Better play safe anyway IMHO. What about the following squash-in? -*-*- diff --git a/tests/ltinit.test b/tests/ltinit.test index d646bc9..288a186 100755 --- a/tests/ltinit.test +++ b/tests/ltinit.test @@ -25,7 +25,6 @@ set -e cat >>configure.in <<'END' AC_PROG_CC -LT_PREREQ([2.0]) LT_INIT([dlopen]) AC_OUTPUT END @@ -43,9 +42,9 @@ END libtoolize $ACLOCAL - -$AUTOCONF || { if $? -eq 63; then Exit 77; else Exit 1; fi; } -$EGREP '^LT_(INIT|PREREQ)' configure && Exit 77 +$AUTOCONF +# Skip if older libtool (pre-2.0) is used. +$EGREP '^LT_INIT' configure && Exit 77 $AUTOMAKE -a -*-*- > Thanks, > Ralf > I'll push in 72 hours if there are no more objections. Regards, Stefano From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 26 Feb 2011 13:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8104 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Stefano Lattarini Cc: 8104@debbugs.gnu.org, Jack Kelly , automake-patches@gnu.org Received: via spool by 8104-submit@debbugs.gnu.org id=B8104.129872748814793 (code B ref 8104); Sat, 26 Feb 2011 13:39:02 +0000 Received: (at 8104) by debbugs.gnu.org; 26 Feb 2011 13:38:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtKLW-0003qY-C3 for submit@debbugs.gnu.org; Sat, 26 Feb 2011 08:38:06 -0500 Received: from mailout-de.gmx.net ([213.165.64.22]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PtKLT-0003q4-Hi for 8104@debbugs.gnu.org; Sat, 26 Feb 2011 08:38:04 -0500 Received: (qmail invoked by alias); 26 Feb 2011 13:37:57 -0000 Received: from xdsl-78-35-50-51.netcologne.de (EHLO localhost.localdomain) [78.35.50.51] by mail.gmx.net (mp050) with SMTP; 26 Feb 2011 14:37:57 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX1/CLwtmWKPCE2z9tAeaYaFjWZtCqEeTxCtJczfq7G 0QKLrzfKuU26IO Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1PtKLB-00051P-RC; Sat, 26 Feb 2011 14:37:45 +0100 Date: Sat, 26 Feb 2011 14:37:45 +0100 From: Ralf Wildenhues Message-ID: <20110226133745.GF15829@gmx.de> Mail-Followup-To: Stefano Lattarini , automake-patches@gnu.org, 8104@debbugs.gnu.org, Jack Kelly References: <201102241045.12178.stefano.lattarini@gmail.com> <20110226112806.GD15829@gmx.de> <201102261408.40568.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102261408.40568.stefano.lattarini@gmail.com> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) * Stefano Lattarini wrote on Sat, Feb 26, 2011 at 02:08:39PM CET: > BTW, such kind of checks would be much easier to perform with Paolo's > pending patch for ACLOCAL_PATH support in place; pointer: > Hmmyes, we have a lot of old pending stuff unfortunately ... > On Saturday 26 February 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Thu, Feb 24, 2011 at 10:45:11AM CET: > > LT_PREREQ has been introduced in 1.9b only. Also, I > > think that if the LT_PREREQ check fails, it will fail already > > at aclocal run time, > > > Oops, I dind't think of that. > > > but I am not sure of that. > > > Better play safe anyway IMHO. What about the following squash-in? Well, not using LT_PREREQ seems like another step back: situations like this is what LT_PREREQ was designed for. How about something like this? m4_ifdef([LT_PREREQ], [LT_PREREQ([2.0])], [m4_fatal([Libtool version too old], [63])]) (untested, sorry) Thanks, Ralf From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 26 Feb 2011 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8104 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Ralf Wildenhues Cc: 8104@debbugs.gnu.org, Jack Kelly , automake-patches@gnu.org Received: via spool by 8104-submit@debbugs.gnu.org id=B8104.129872848816172 (code B ref 8104); Sat, 26 Feb 2011 13:55:02 +0000 Received: (at 8104) by debbugs.gnu.org; 26 Feb 2011 13:54:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtKbf-0004Cn-LE for submit@debbugs.gnu.org; Sat, 26 Feb 2011 08:54:48 -0500 Received: from mail-ww0-f42.google.com ([74.125.82.42]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtKbd-0004CY-Bh for 8104@debbugs.gnu.org; Sat, 26 Feb 2011 08:54:46 -0500 Received: by wwe15 with SMTP id 15so1587041wwe.3 for <8104@debbugs.gnu.org>; Sat, 26 Feb 2011 05:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=r+3qV5mUOPUh0GDr21/M+fkDCbeQhDOwzNEogSia12I=; b=dOkuefsSGYFNs5LAXxhsXbjT/emiR5vfWOw54nyAuPIrfbB95tKlFclWq0WC+FsOt3 UXm1SbYkCMHcGVUpYkmTw8aJC20sPIa+0gGwMmVsKnsRTweia7gn9ZWLbY1UUWKXBUaL XXZqSZzsWdaTHgAdeUFORhHsFXhlCU+p5zFDk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=jlN1IKEK7ZRXVFPBZScZn6mccggH65dXqd/Ud3XObbkUNKnluLo/6OGmwkdv1HHsFg /dSFypCx8xJ5MhOkBTLPov1cajH0MQhR6VcGu+WBuGYjv5JbSUCz7Ciq3l8DRKgcLSC/ wOveZc8vtwPmzno46VfDyFPYFyA2kHnJ+75qU= Received: by 10.216.145.90 with SMTP id o68mr458219wej.77.1298728479511; Sat, 26 Feb 2011 05:54:39 -0800 (PST) Received: from bigio.localnet (host24-48-dynamic.58-82-r.retail.telecomitalia.it [82.58.48.24]) by mx.google.com with ESMTPS id r57sm891102wes.1.2011.02.26.05.54.37 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 Feb 2011 05:54:38 -0800 (PST) From: Stefano Lattarini Date: Sat, 26 Feb 2011 14:54:09 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201102261408.40568.stefano.lattarini@gmail.com> <20110226133745.GF15829@gmx.de> In-Reply-To: <20110226133745.GF15829@gmx.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201102261454.10416.stefano.lattarini@gmail.com> X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On Saturday 26 February 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Feb 26, 2011 at 02:08:39PM CET: > > BTW, such kind of checks would be much easier to perform with Paolo's > > pending patch for ACLOCAL_PATH support in place; pointer: > > > > Hmmyes, we have a lot of old pending stuff unfortunately ... > > > On Saturday 26 February 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Thu, Feb 24, 2011 at 10:45:11AM CET: > > > LT_PREREQ has been introduced in 1.9b only. Also, I > > > think that if the LT_PREREQ check fails, it will fail already > > > at aclocal run time, > > > > > Oops, I dind't think of that. > > > > > but I am not sure of that. > > > > > Better play safe anyway IMHO. What about the following squash-in? > > Well, not using LT_PREREQ seems like another step back: situations like > this is what LT_PREREQ was designed for. How about something like this? > > m4_ifdef([LT_PREREQ], > [LT_PREREQ([2.0])], > [m4_fatal([Libtool version too old], [63])]) > > (untested, sorry) > Fine with me. This is the additional squash-in -- on the top of the old one, since I had already commited that locally :-( -*-*- diff --git a/tests/ltinit.test b/tests/ltinit.test index 288a186..8517009 100755 --- a/tests/ltinit.test +++ b/tests/ltinit.test @@ -25,6 +25,10 @@ set -e cat >>configure.in <<'END' AC_PROG_CC +# Older libtool versions don't define LT_PREREQ :-( +m4_ifdef([LT_PREREQ], + [LT_PREREQ([2.0])], + [m4_fatal([Libtool version too old], [63])]) LT_INIT([dlopen]) AC_OUTPUT END @@ -42,10 +46,9 @@ END libtoolize $ACLOCAL -$AUTOCONF # Skip if older libtool (pre-2.0) is used. -$EGREP '^LT_INIT' configure && Exit 77 - +$AUTOCONF || { if $? -eq 63; then Exit 77; else Exit 1; fi; } +$EGREP 'LT_(INIT|PREREQ)' configure && Exit 1 # Sanity check. $AUTOMAKE -a cwd=`pwd` -*-*- I will push in 72 hours if there are no further objections. Thanks, Stefano From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Resent-From: Ralf Wildenhues Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 26 Feb 2011 14:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8104 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Stefano Lattarini Cc: 8104@debbugs.gnu.org, Jack Kelly , automake-patches@gnu.org Received: via spool by 8104-submit@debbugs.gnu.org id=B8104.129872950117615 (code B ref 8104); Sat, 26 Feb 2011 14:12:01 +0000 Received: (at 8104) by debbugs.gnu.org; 26 Feb 2011 14:11:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtKs0-0004a3-Vu for submit@debbugs.gnu.org; Sat, 26 Feb 2011 09:11:41 -0500 Received: from mailout-de.gmx.net ([213.165.64.23]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1PtKrx-0004Zo-QP for 8104@debbugs.gnu.org; Sat, 26 Feb 2011 09:11:38 -0500 Received: (qmail invoked by alias); 26 Feb 2011 14:11:31 -0000 Received: from xdsl-78-35-50-51.netcologne.de (EHLO localhost.localdomain) [78.35.50.51] by mail.gmx.net (mp061) with SMTP; 26 Feb 2011 15:11:31 +0100 X-Authenticated: #13673931 X-Provags-ID: V01U2FsdGVkX1/1GNhHTjv18KSQt+qR0rerTdJLf9SxAurEiklOAc NTZo1NVX+8xiZL Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1PtKrf-0000Mk-Sc; Sat, 26 Feb 2011 15:11:19 +0100 Date: Sat, 26 Feb 2011 15:11:19 +0100 From: Ralf Wildenhues Message-ID: <20110226141119.GH15829@gmx.de> Mail-Followup-To: Stefano Lattarini , automake-patches@gnu.org, 8104@debbugs.gnu.org, Jack Kelly References: <201102261408.40568.stefano.lattarini@gmail.com> <20110226133745.GF15829@gmx.de> <201102261454.10416.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102261454.10416.stefano.lattarini@gmail.com> Organization: Institute for Numerical Simulation, University of Bonn User-Agent: Mutt/1.5.20 (2010-08-04) X-Y-GMX-Trusted: 0 X-Spam-Score: -3.3 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) * Stefano Lattarini wrote on Sat, Feb 26, 2011 at 02:54:09PM CET: > Fine with me. This is the additional squash-in -- on the top of the old > one, since I had already commited that locally :-( Don't worry, I do such junk commits all the time. You could git diff HEAD@{2} or some similar command, based on 'git reflog' output. > I will push in 72 hours if there are no further objections. Feel free to go ahead. Thanks! Ralf From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Resent-From: Ralf Hemmecke Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 26 Feb 2011 23:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8104 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: automake-patches@gnu.org, 8104@debbugs.gnu.org, stefano.lattarini@gmail.com Received: via spool by 8104-submit@debbugs.gnu.org id=B8104.12987636849958 (code B ref 8104); Sat, 26 Feb 2011 23:42:01 +0000 Received: (at 8104) by debbugs.gnu.org; 26 Feb 2011 23:41:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtTlL-0002aY-LM for submit@debbugs.gnu.org; Sat, 26 Feb 2011 18:41:23 -0500 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PtTlI-0002aL-HO for 8104@debbugs.gnu.org; Sat, 26 Feb 2011 18:41:21 -0500 Received: by bwz13 with SMTP id 13so2881092bwz.3 for <8104@debbugs.gnu.org>; Sat, 26 Feb 2011 15:41:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=Ewq7S6QO2s56ZDyEsb5zLfX5r6Csxu1i99MGc7H/NhU=; b=iL6nIXJ5G1LSojPHl9K3s6kJgSqmTejMu5NttHG/XYDv67Q7TKBd+6FyhAnK3Ibd8J BmtJEcE71grmD8PdVuigbN9LgCc5cAoIqPcCOheI6NyziDJLm/+1+RW7cAjc7FcBO63y yUY1I9eg3DoPHue2ST1wDdR5RNBqU2j3jzTxk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=EipMKcaj1vh0JhRwHD3U4AX92nFkTHLxnXONWZaoc+ZeBhKvxCvfkRGNbMUeABQ3eC int3mHqHE/c09+4q+xD8zmKEwyp5AOPEUg82+3I+N4AlzM2zX0iPYQzC0HgSmbNKFUJ5 ZwSJ96nIFDfZGc9/EtJh8kbarswL+oXfMXFLQ= Received: by 10.204.59.129 with SMTP id l1mr3328590bkh.88.1298763674644; Sat, 26 Feb 2011 15:41:14 -0800 (PST) Received: from [192.168.2.100] (p57B3D038.dip.t-dialin.net [87.179.208.56]) by mx.google.com with ESMTPS id x38sm1438623bkj.13.2011.02.26.15.41.13 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 26 Feb 2011 15:41:13 -0800 (PST) Message-ID: <4D698F97.6090701@gmail.com> Date: Sun, 27 Feb 2011 00:41:11 +0100 From: Ralf Hemmecke User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101207 Thunderbird/3.1.7 MIME-Version: 1.0 References: <201102261408.40568.stefano.lattarini@gmail.com> <20110226133745.GF15829@gmx.de> <201102261454.10416.stefano.lattarini@gmail.com> <20110226141119.GH15829@gmx.de> In-Reply-To: <20110226141119.GH15829@gmx.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) On 02/26/2011 03:11 PM, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Feb 26, 2011 at 02:54:09PM CET: >> Fine with me. This is the additional squash-in -- on the top of the old >> one, since I had already commited that locally :-( > > Don't worry, I do such junk commits all the time. You could > git diff HEAD@{2} > > or some similar command, based on 'git reflog' output. You can use git add FILENAME git commit --amend -C HEAD to add additional stuff to the last commit. Ralf From unknown Mon Jun 23 06:01:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 28 Feb 2011 12:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8104 X-GNU-PR-Package: automake X-GNU-PR-Keywords: patch To: Ralf Wildenhues Cc: 8104@debbugs.gnu.org, Jack Kelly , automake-patches@gnu.org Received: via spool by 8104-submit@debbugs.gnu.org id=B8104.129889591932038 (code B ref 8104); Mon, 28 Feb 2011 12:26:01 +0000 Received: (at 8104) by debbugs.gnu.org; 28 Feb 2011 12:25:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pu2AA-0008Kh-6K for submit@debbugs.gnu.org; Mon, 28 Feb 2011 07:25:18 -0500 Received: from mail-ww0-f46.google.com ([74.125.82.46]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pu2A5-0008KR-Hs for 8104@debbugs.gnu.org; Mon, 28 Feb 2011 07:25:15 -0500 Received: by wwc33 with SMTP id 33so4639054wwc.15 for <8104@debbugs.gnu.org>; Mon, 28 Feb 2011 04:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:message-id; bh=oy09/HXpzkk1oH0BnlZ8bariagLllXznIg1U2gAcKd0=; b=n2fwDNPINsO/7V/WYPTbhNJ8WXqPN1WOG78xkc+GB+EyUyTipdf+8pDGlNI7jCQnGV FCfDMctbDWRX76bHeEW7xsnjGz/j7LAZAc5N37DwqE1XIqXsXwMQ+5eAjU3/Vwpv+3Et J0zSxh9UkT14v41+hsy3OnjqS1AHFa60ZzdvM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:message-id; b=lPIpaVxlHvvr1RgPT/RYKMBLJIf8ACLprs8VgvesgWZ0t6TpDRgawNeVlBOOzoX54n F/2y13RfG4jqClpGli1Bf/n6JIGukqzntU8EMPmTZZWjLp22Rp4urpjIgX6SLn1Dlc7R 2z9SIY9vnIhD7+qkyEDMTcDK0p7YLUSuWQEhw= Received: by 10.216.174.65 with SMTP id w43mr2104021wel.95.1298895907362; Mon, 28 Feb 2011 04:25:07 -0800 (PST) Received: from bigio.localnet (host102-103-dynamic.2-87-r.retail.telecomitalia.it [87.2.103.102]) by mx.google.com with ESMTPS id a50sm1841815wer.42.2011.02.28.04.25.04 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 28 Feb 2011 04:25:05 -0800 (PST) From: Stefano Lattarini Date: Mon, 28 Feb 2011 13:24:55 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <201102261454.10416.stefano.lattarini@gmail.com> <20110226141119.GH15829@gmx.de> In-Reply-To: <20110226141119.GH15829@gmx.de> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_XQ5aNgsG38NziCL" Message-Id: <201102281324.55817.stefano.lattarini@gmail.com> X-Spam-Score: -4.8 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.4 (----) --Boundary-00=_XQ5aNgsG38NziCL Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Saturday 26 February 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Feb 26, 2011 at 02:54:09PM CET: > > Fine with me. This is the additional squash-in -- on the top of the old > > one, since I had already commited that locally :-( > > Don't worry, I do such junk commits all the time. You could > git diff HEAD@{2} > > or some similar command, based on 'git reflog' output. > Thanks for the suggestion; I keep forgetting the usefulness of the `reflog' command (or its very existence) ... > > I will push in 72 hours if there are no further objections. > > Feel free to go ahead. > OK, attached is what I pushed. Note that it is slightly different from my last posted version, because also the call to aclocal can fail with older libtools. I should have tested better before submitting the previous diff; sorry for the noise. Thanks, Stefano --Boundary-00=_XQ5aNgsG38NziCL Content-Type: text/x-patch; charset="us-ascii"; name="0001-libtool-suggest-LT_INIT-if-LTLIBRARIES-primary-is-us.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="0001-libtool-suggest-LT_INIT-if-LTLIBRARIES-primary-is-us.patch" =46rom d51e7b79713f909c235c9880f7f62c4b0c0910d0 Mon Sep 17 00:00:00 2001 =46rom: Stefano Lattarini Date: Thu, 24 Feb 2011 10:21:19 +0100 Subject: [PATCH] libtool: suggest LT_INIT if LTLIBRARIES primary is used When the LTLIBRARIES primary was used, but $(LIBTOOL) wasn't defined, automake suggested to add a call to AC_PROG_LIBTOOL in configure.ac. But that macro is deprecated since Libtool version 1.9b (2004-08-29), in favor of the newer LT_INIT. So suggest the use of this latter macro instead. * lib/Automake/Variable.pm (%_am_macro_for_var): Pair 'LIBTOOL' with 'LT_INIT', not with 'AC_PROG_LIBTOOL'. * libtool4.test: Adjust and extend. Also, add a call to macro AC_PROG_CC in configure.in, to help ensuring that automake does not fail for the wrong reasons. * ltinit.test: New test, ensure that automake's libtool support works with LT_INIT-based interface. Thanks to Jack Kelly for the suggestion. =2D-- ChangeLog | 17 ++++++++++++ lib/Automake/Variable.pm | 2 +- tests/Makefile.am | 1 + tests/Makefile.in | 1 + tests/libtool4.test | 9 ++++++- tests/ltinit.test | 64 ++++++++++++++++++++++++++++++++++++++++++= ++++ 6 files changed, 92 insertions(+), 2 deletions(-) create mode 100755 tests/ltinit.test diff --git a/ChangeLog b/ChangeLog index 8d03512..47bc9fc 100644 =2D-- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,20 @@ +2011-02-26 Stefano Lattarini + + libtool: suggest LT_INIT if LTLIBRARIES primary is used + When the LTLIBRARIES primary was used, but $(LIBTOOL) wasn't + defined, automake suggested to add a call to AC_PROG_LIBTOOL + in configure.ac. But that macro is deprecated since Libtool + version 1.9b (2004-08-29), in favor of the newer LT_INIT. So + suggest the use of this latter macro instead. + * lib/Automake/Variable.pm (%_am_macro_for_var): Pair 'LIBTOOL' + with 'LT_INIT', not with 'AC_PROG_LIBTOOL'. + * libtool4.test: Adjust and extend. Also, add a call to macro + AC_PROG_CC in configure.in, to help ensuring that automake does + not fail for the wrong reasons. + * ltinit.test: New test, ensure that automake's libtool support + works with LT_INIT-based interface. + Thanks to Jack Kelly for the suggestion. + 2011-02-20 Stefano Lattarini =20 tests: tempdirs with restrictive permissions are cleaned correctly diff --git a/lib/Automake/Variable.pm b/lib/Automake/Variable.pm index cb9d182..686847d 100644 =2D-- a/lib/Automake/Variable.pm +++ b/lib/Automake/Variable.pm @@ -162,7 +162,7 @@ my %_am_macro_for_var =3D EMACS =3D> 'AM_PATH_LISPDIR', GCJ =3D> 'AM_PROG_GCJ', LEX =3D> 'AM_PROG_LEX', =2D LIBTOOL =3D> 'AC_PROG_LIBTOOL', + LIBTOOL =3D> 'LT_INIT', lispdir =3D> 'AM_PATH_LISPDIR', pkgpyexecdir =3D> 'AM_PATH_PYTHON', pkgpythondir =3D> 'AM_PATH_PYTHON', diff --git a/tests/Makefile.am b/tests/Makefile.am index 047bc7b..cd564fa 100644 =2D-- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -481,6 +481,7 @@ ltcond.test \ ltcond2.test \ ltconv.test \ ltdeps.test \ +ltinit.test \ ltinstloc.test \ ltlibobjs.test \ ltlibsrc.test \ diff --git a/tests/Makefile.in b/tests/Makefile.in index fe6238b..f56ff21 100644 =2D-- a/tests/Makefile.in +++ b/tests/Makefile.in @@ -751,6 +751,7 @@ ltcond.test \ ltcond2.test \ ltconv.test \ ltdeps.test \ +ltinit.test \ ltinstloc.test \ ltlibobjs.test \ ltlibsrc.test \ diff --git a/tests/libtool4.test b/tests/libtool4.test index bcc9b0f..9f6a730 100755 =2D-- a/tests/libtool4.test +++ b/tests/libtool4.test @@ -20,10 +20,17 @@ =20 set -e =20 +cat >> configure.in <<'END' +AC_PROG_CC +END + cat > Makefile.am << 'END' EXTRA_LTLIBRARIES =3D liblib.la END =20 $ACLOCAL AUTOMAKE_fails =2Dgrep AC_PROG_LIBTOOL stderr +grep '[Ll]ibtool library .*LIBTOOL.* undefined' stderr +grep 'define .*LIBTOOL.* add .*LT_INIT' stderr + +: diff --git a/tests/ltinit.test b/tests/ltinit.test new file mode 100755 index 0000000..b4eaad6 =2D-- /dev/null +++ b/tests/ltinit.test @@ -0,0 +1,64 @@ +#!/bin/sh +# Copyright (C) 2011 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Test that libtool support works correctly when "newer" libtool +# interface (with LT_INIT etc.) is used (this interface has been +# present since libtool 1.9b, circa 2004). + +required=3D'libtoolize' +. ./defs || Exit 1 + +set -e + +cat >>configure.in <<'END' +AC_PROG_CC +dnl Older libtool versions don't define LT_PREREQ :-( +m4_ifdef([LT_PREREQ], + [LT_PREREQ([2.0])], + [m4_fatal([Libtool version too old], [63])]) +LT_INIT([dlopen]) +AC_OUTPUT +END + +cat >Makefile.am <<'END' +lib_LTLIBRARIES =3D libfoo.la +END + +cat > libfoo.c <<'END' +int foo (void) +{ + return 1; +} +END + +libtoolize +# Skip if older libtool (pre-2.0) is used. +{ $ACLOCAL && $AUTOCONF; } || { + if test $? -eq 63; then Exit 77; else Exit 1; fi +} +$EGREP 'LT_(INIT|PREREQ)' configure && Exit 1 # Sanity check. +$AUTOMAKE -a + +cwd=3D`pwd` +./configure --prefix=3D"$cwd/inst" >stdout || { cat stdout; Exit 1; } +cat stdout +grep '^checking.*dlopen' stdout + +$MAKE +$MAKE install +$MAKE distcheck + +: =2D-=20 1.7.2.3 --Boundary-00=_XQ5aNgsG38NziCL-- From unknown Mon Jun 23 06:01:23 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jack Kelly Subject: bug#8104: closed (Re: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT) Message-ID: References: <201103071419.55495.stefano.lattarini@gmail.com> X-Gnu-PR-Message: they-closed 8104 X-Gnu-PR-Package: automake X-Gnu-PR-Keywords: patch Reply-To: 8104@debbugs.gnu.org Date: Mon, 07 Mar 2011 13:21:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1299504062-15246-1" This is a multi-part message in MIME format... ------------=_1299504062-15246-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by = LT_INIT which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8104@debbugs.gnu.org. --=20 8104: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8104 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1299504062-15246-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8104-done) by debbugs.gnu.org; 7 Mar 2011 13:20:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwaMD-0003ws-Jf for submit@debbugs.gnu.org; Mon, 07 Mar 2011 08:20:17 -0500 Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PwaMB-0003wb-Np for 8104-done@debbugs.gnu.org; Mon, 07 Mar 2011 08:20:16 -0500 Received: by bwz13 with SMTP id 13so3803158bwz.3 for <8104-done@debbugs.gnu.org>; Mon, 07 Mar 2011 05:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=nKDbU5IGt2iKWzLpbBgi3hJFbsph9dBL6R94RD92HQM=; b=etimOYrF5/DQv2ARJ11NvW/f5jh16lOVZFMa9l6MmEXtPLvQX4VfVIBywKOK6sso95 QlgXfrv7ULbSsvYoEcn3bFKNUsr+SYfVi6b1+I5VYOJG+x2IH3fexI1pWc8yx1TCMx4w i8WF16o721pyfMAg+gl46tGBwaYrfUq90McCo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding:message-id; b=fLdsBc9iorU3HUFgKVtSUcwXpm5rNpLROnmDTLVD50xY3bZtyMyL795O7ZIU+vJAjv 8Wbjk2mp4aMPKyqPj/y86k9obiQjCi1PkjbBO8DTqxPdK7JDIAfFveDYA/+rcQaHIdI5 xmHW4OvkLGppHybQV79cIekFKDgv6tS/Eedwk= Received: by 10.204.7.213 with SMTP id e21mr3183946bke.209.1299504009889; Mon, 07 Mar 2011 05:20:09 -0800 (PST) Received: from bigio.localnet (host94-100-dynamic.8-87-r.retail.telecomitalia.it [87.8.100.94]) by mx.google.com with ESMTPS id a17sm1664398bku.23.2011.03.07.05.20.05 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Mar 2011 05:20:06 -0800 (PST) From: Stefano Lattarini To: Ralf Wildenhues , 8104-done@debbugs.gnu.org Subject: Re: bug#8104: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT Date: Mon, 7 Mar 2011 14:19:54 +0100 User-Agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) References: <20110226112806.GD15829@gmx.de> <201102261408.40568.stefano.lattarini@gmail.com> In-Reply-To: <201102261408.40568.stefano.lattarini@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201103071419.55495.stefano.lattarini@gmail.com> X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 8104-done Cc: Jack Kelly X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) A patch fixing this bug has been applied in commit `v1.11-315-gd51e7b7' "libtool: suggest LT_INIT if LTLIBRARIES primary is used"; I'm thus closing the bug. Regards, Stefano ------------=_1299504062-15246-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Feb 2011 02:01:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsQVu-0001jo-CN for submit@debbugs.gnu.org; Wed, 23 Feb 2011 21:01:06 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsQVs-0001jJ-F4 for submit@debbugs.gnu.org; Wed, 23 Feb 2011 21:01:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsQVm-0007DJ-GV for submit@debbugs.gnu.org; Wed, 23 Feb 2011 21:00:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:47885) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsQVm-0007DF-EG for submit@debbugs.gnu.org; Wed, 23 Feb 2011 21:00:58 -0500 Received: from [140.186.70.92] (port=33330 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsQVl-0008F3-HJ for bug-automake@gnu.org; Wed, 23 Feb 2011 21:00:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsQVk-0007D5-9H for bug-automake@gnu.org; Wed, 23 Feb 2011 21:00:57 -0500 Received: from mail-vw0-f41.google.com ([209.85.212.41]:49163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsQVk-0007Cw-6t for bug-automake@gnu.org; Wed, 23 Feb 2011 21:00:56 -0500 Received: by vws13 with SMTP id 13so70464vws.0 for ; Wed, 23 Feb 2011 18:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:date:x-google-sender-auth :message-id:subject:from:to:content-type; bh=GnD94wJDjPKcajqe5IydZ2IZlxtzy/FBa69N04drxB4=; b=U62W7fkKfefcuhONEuabTYIVL6PpUoKu9GhSUwuClZZ5LDHDVwC8cZNDlZ/9+ghoUR yeYguwVUb6tgsHM1vLzmknI2RafBCXrqCTqEDJeMAFVb0v88UOU2rQsbKNj/XyJM39QF P0hcX3wy/jwT2SxCJl3ldcNMlGTOelRWjUPDg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type; b=XyaLHXGoK6mUqCsn+Zr2nvynF37tKx7Vm+5Zq6ye9RhTf5GgJI4Qxg2NzHw0nQMw2M SaRQ4JPqwUUoC+g/wByIZegSKIEc6HQwt0rYEYa6CYEMEkOxVX9yEwZVjPaEPRZIJQCZ 7iNrLHsr4zWIHZupksTeKHUJABZ7Jei0zgXDo= MIME-Version: 1.0 Received: by 10.220.184.75 with SMTP id cj11mr65811vcb.81.1298512855050; Wed, 23 Feb 2011 18:00:55 -0800 (PST) Received: by 10.220.4.148 with HTTP; Wed, 23 Feb 2011 18:00:54 -0800 (PST) Date: Thu, 24 Feb 2011 13:00:54 +1100 X-Google-Sender-Auth: r8s0a5HJ6XyzUiprlLBaWiyJL_A Message-ID: Subject: automake suggests use of AC_PROG_LIBTOOL, this has been replaced by LT_INIT From: Jack Kelly To: bug-automake@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) Version: 1.11.1 (ubuntu 10.10). I have inspected the most recent master and it appears to also have this bug. configure.ac: AC_INIT([a], [b], [c]) AM_INIT_AUTOMAKE([foreign]) dnl no LT_INIT -- on purpose AC_PROG_CC AC_CONFIG_FILES([Makefile]) AC_OUTPUT Makefile.am: lib_LTLIBRARIES = libfoo.la Run autoreconf -i: $ autoreconf -i Makefile.am:1: Libtool library used but `LIBTOOL' is undefined Makefile.am:1: The usual way to define `LIBTOOL' is to add `AC_PROG_LIBTOOL' Makefile.am:1: to `configure.ac' and run `aclocal' and `autoconf' again. Makefile.am:1: If `AC_PROG_LIBTOOL' is in `configure.ac', make sure Makefile.am:1: its definition is in aclocal's search path. autoreconf: automake failed with exit status: 1 See the libtool manual ( http://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html ): AC_PROG_LIBTOOL and AM_PROG_LIBTOOL are deprecated names for older versions of this macro; autoupdate will upgrade your configure.ac files. It appears that automake's message is out of date. -- Jack ------------=_1299504062-15246-1--