From unknown Tue Aug 19 02:52:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2011 06:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 8093@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12983551444083 (code B ref -1); Tue, 22 Feb 2011 06:13:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Feb 2011 06:12:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrlTz-00013n-Ud for submit@debbugs.gnu.org; Tue, 22 Feb 2011 01:12:24 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrlTx-00013a-Gi for submit@debbugs.gnu.org; Tue, 22 Feb 2011 01:12:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrlTr-0002Y0-Cg for submit@debbugs.gnu.org; Tue, 22 Feb 2011 01:12:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:53642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrlTr-0002Xw-Ac for submit@debbugs.gnu.org; Tue, 22 Feb 2011 01:12:15 -0500 Received: from [140.186.70.92] (port=58235 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrlTq-00019F-5e for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 01:12:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrlTo-0002Xk-VS for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 01:12:14 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:33050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrlTo-0002Xg-On for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 01:12:12 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D1D4339E80F2 for ; Mon, 21 Feb 2011 22:12:11 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XiNELsqAktun for ; Mon, 21 Feb 2011 22:12:11 -0800 (PST) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 2762B39E80DB for ; Mon, 21 Feb 2011 22:12:11 -0800 (PST) Message-ID: <4D6353B4.5010104@cs.ucla.edu> Date: Mon, 21 Feb 2011 22:12:04 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Emacs downcases drive letters when canonicalizing file names on Microsoft Windows, but etags upcases them. etags should be consistent with Emacs. I found this problem by code inspection, because there's a macro 'upcase' that normally isn't used in etags.c; its only use is in the section of code that upcases drive letters. Here's a proposed patch. 2011-02-21 Paul Eggert etags: Downcase drive letters, for consistency with Emacs proper. * etags.c (upcase): Remove; no longer used. (canonicalize_filename): Downcase drive letters. --- lib-src/etags.c 2011-02-21 16:47:08.883947000 -0800 +++ /u/cs/fac/eggert/junk/etags.c 2011-02-21 21:21:04.074974000 -0800 @@ -239,7 +239,6 @@ If you want regular expression support, #define ISLOWER(c) islower (CHAR(c)) #define lowcase(c) tolower (CHAR(c)) -#define upcase(c) toupper (CHAR(c)) /* @@ -6638,7 +6637,7 @@ filename_is_absolute (char *fn) ); } -/* Upcase DOS drive letter and collapse separators into single slashes. +/* Downcase DOS drive letter and collapse separators into single slashes. Works in place. */ static void canonicalize_filename (register char *fn) @@ -6648,8 +6647,8 @@ canonicalize_filename (register char *fn #ifdef DOS_NT /* Canonicalize drive letter case. */ - if (fn[0] != '\0' && fn[1] == ':' && ISLOWER (fn[0])) - fn[0] = upcase (fn[0]); + if (fn[0] != '\0' && fn[1] == ':' && ISUPPER (fn[0])) + fn[0] = downcase (fn[0]); sep = '\\'; #endif From unknown Tue Aug 19 02:52:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. Resent-From: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2011 13:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: bug-gnu-emacs@gnu.org, owner@debbugs.gnu.org, 8093@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12983799799919 (code B ref -1); Tue, 22 Feb 2011 13:07:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Feb 2011 13:06:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrrwY-0002Zv-9f for submit@debbugs.gnu.org; Tue, 22 Feb 2011 08:06:18 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrpEj-0006PL-A1 for submit@debbugs.gnu.org; Tue, 22 Feb 2011 05:12:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrpEc-0004j7-VS for submit@debbugs.gnu.org; Tue, 22 Feb 2011 05:12:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:43601) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrpEc-0004j3-TK for submit@debbugs.gnu.org; Tue, 22 Feb 2011 05:12:46 -0500 Received: from [140.186.70.92] (port=44077 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrpEb-00074w-Sv for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 05:12:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrpEa-0004im-Ff for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 05:12:45 -0500 Received: from blade3.isti.cnr.it ([194.119.192.19]:57590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrpEa-0004ib-9j for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 05:12:44 -0500 Received: from SCRIPT-SPFWL-DAEMON.mx.isti.cnr.it by mx.isti.cnr.it (PMDF V6.5-x5 #31825) id <01NY4IFFO8R4PHYFUK@mx.isti.cnr.it> for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 11:11:38 +0100 (MET) Received: from conversionlocal.isti.cnr.it by mx.isti.cnr.it (PMDF V6.5-x5 #31825) id <01NY4IFFDUU8PHXZ9M@mx.isti.cnr.it> for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 11:11:38 +0100 (MET) Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by mx.isti.cnr.it (PMDF V6.5-x5 #31826) with ESMTPSA id <01NY4IFE9J8YPSZSV6@mx.isti.cnr.it>; Tue, 22 Feb 2011 11:11:36 +0100 (MET) Received: from pot by tucano.isti.cnr.it with local (Exim 4.72) (envelope-from ) id 1PrpDU-0002HP-QK; Tue, 22 Feb 2011 11:11:37 +0100 Date: Tue, 22 Feb 2011 11:11:36 +0100 From: Francesco =?UTF-8?Q?Potort=C3=AC?= In-reply-to: <4D6353B4.5010104@cs.ucla.edu> Message-id: Organization: X-INSM-ip-source: 146.48.81.102 Auth Done X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 References: <4D6353B4.5010104@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.5 (-----) X-Mailman-Approved-At: Tue, 22 Feb 2011 08:06:16 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) >Emacs downcases drive letters when canonicalizing file names on >Microsoft Windows, but etags upcases them. etags should be consistent >with Emacs. I found this problem by code inspection, because there's >a macro 'upcase' that normally isn't used in etags.c; its only use is >in the section of code that upcases drive letters. Here's a proposed >patch. Looks reasonable and I see no compatibility issues. Please install it. >2011-02-21 Paul Eggert > > etags: Downcase drive letters, for consistency with Emacs proper. > * etags.c (upcase): Remove; no longer used. > (canonicalize_filename): Downcase drive letters. > >--- lib-src/etags.c 2011-02-21 16:47:08.883947000 -0800 >+++ /u/cs/fac/eggert/junk/etags.c 2011-02-21 21:21:04.074974000 -0800 >@@ -239,7 +239,6 @@ If you want regular expression support, > #define ISLOWER(c) islower (CHAR(c)) > > #define lowcase(c) tolower (CHAR(c)) >-#define upcase(c) toupper (CHAR(c)) > > > /* >@@ -6638,7 +6637,7 @@ filename_is_absolute (char *fn) > ); > } > >-/* Upcase DOS drive letter and collapse separators into single slashes. >+/* Downcase DOS drive letter and collapse separators into single slashes. > Works in place. */ > static void > canonicalize_filename (register char *fn) >@@ -6648,8 +6647,8 @@ canonicalize_filename (register char *fn > > #ifdef DOS_NT > /* Canonicalize drive letter case. */ >- if (fn[0] != '\0' && fn[1] == ':' && ISLOWER (fn[0])) >- fn[0] = upcase (fn[0]); >+ if (fn[0] != '\0' && fn[1] == ':' && ISUPPER (fn[0])) >+ fn[0] = downcase (fn[0]); > > sep = '\\'; > #endif > > > > > > From unknown Tue Aug 19 02:52:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2011 17:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Francesco =?UTF-8?Q?Potort=C3=AC?= Cc: eggert@cs.ucla.edu, 8093@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 8093-submit@debbugs.gnu.org id=B8093.129839603532690 (code B ref 8093); Tue, 22 Feb 2011 17:34:02 +0000 Received: (at 8093) by debbugs.gnu.org; 22 Feb 2011 17:33:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Prw7W-0008VD-9E for submit@debbugs.gnu.org; Tue, 22 Feb 2011 12:33:54 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Prw7U-0008Uz-6D for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 12:33:53 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LH100G004RJDP00@a-mtaout22.012.net.il> for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 19:33:46 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.14.198]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LH100DCY4S8Q0I0@a-mtaout22.012.net.il>; Tue, 22 Feb 2011 19:33:46 +0200 (IST) Date: Tue, 22 Feb 2011 19:33:47 +0200 From: Eli Zaretskii In-reply-to: Message-id: <83zkporn2c.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: QUOTED-PRINTABLE X-012-Sender: halo1@inter.net.il References: <4D6353B4.5010104@cs.ucla.edu> X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > Date: Tue, 22 Feb 2011 11:11:36 +0100 > From: Francesco Potort=C3=AC=3D > Cc: bug-gnu-emacs@gnu.org, owner@debbugs.gnu.org, 8093@debbugs.gnu.= org >=20 > >Emacs downcases drive letters when canonicalizing file names on > >Microsoft Windows, but etags upcases them. etags should be consis= tent > >with Emacs. I found this problem by code inspection, because ther= e's > >a macro 'upcase' that normally isn't used in etags.c; its only use= is > >in the section of code that upcases drive letters. Here's a propo= sed > >patch. >=20 > Looks reasonable and I see no compatibility issues. Please install= it. Agreed. Thanks, Paul. From unknown Tue Aug 19 02:52:15 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Paul Eggert Subject: bug#8093: closed (Re: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper.) Message-ID: References: <4D63F4C0.8060700@cs.ucla.edu> <4D6353B4.5010104@cs.ucla.edu> X-Gnu-PR-Message: they-closed 8093 X-Gnu-PR-Package: emacs Reply-To: 8093@debbugs.gnu.org Date: Tue, 22 Feb 2011 17:40:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1298396403-849-1" This is a multi-part message in MIME format... ------------=_1298396403-849-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #8093: etags: Downcase drive letters, for consistency with Emacs proper. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 8093@debbugs.gnu.org. --=20 8093: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D8093 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1298396403-849-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 8093-done) by debbugs.gnu.org; 22 Feb 2011 17:39:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrwCt-0000Cq-D6 for submit@debbugs.gnu.org; Tue, 22 Feb 2011 12:39:27 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrwCr-0000Cc-0k for 8093-done@debbugs.gnu.org; Tue, 22 Feb 2011 12:39:25 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 7A2E139E80DB; Tue, 22 Feb 2011 09:39:19 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K+SkE87jnUyZ; Tue, 22 Feb 2011 09:39:19 -0800 (PST) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 145AB39E80F2; Tue, 22 Feb 2011 09:39:19 -0800 (PST) Message-ID: <4D63F4C0.8060700@cs.ucla.edu> Date: Tue, 22 Feb 2011 09:39:12 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. References: <4D6353B4.5010104@cs.ucla.edu> <83zkporn2c.fsf@gnu.org> In-Reply-To: <83zkporn2c.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 8093-done Cc: =?UTF-8?B?RnJhbmNlc2NvIFBvdG9ydMOs?= , 8093-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On 02/22/2011 09:33 AM, Eli Zaretskii wrote: > Thanks, Paul. You're welcome, and I installed it as revno 103385 on the trunk. ------------=_1298396403-849-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Feb 2011 06:12:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrlTz-00013n-Ud for submit@debbugs.gnu.org; Tue, 22 Feb 2011 01:12:24 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrlTx-00013a-Gi for submit@debbugs.gnu.org; Tue, 22 Feb 2011 01:12:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrlTr-0002Y0-Cg for submit@debbugs.gnu.org; Tue, 22 Feb 2011 01:12:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:53642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrlTr-0002Xw-Ac for submit@debbugs.gnu.org; Tue, 22 Feb 2011 01:12:15 -0500 Received: from [140.186.70.92] (port=58235 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrlTq-00019F-5e for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 01:12:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrlTo-0002Xk-VS for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 01:12:14 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:33050) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrlTo-0002Xg-On for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2011 01:12:12 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D1D4339E80F2 for ; Mon, 21 Feb 2011 22:12:11 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XiNELsqAktun for ; Mon, 21 Feb 2011 22:12:11 -0800 (PST) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 2762B39E80DB for ; Mon, 21 Feb 2011 22:12:11 -0800 (PST) Message-ID: <4D6353B4.5010104@cs.ucla.edu> Date: Mon, 21 Feb 2011 22:12:04 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Thunderbird/3.1.7 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: etags: Downcase drive letters, for consistency with Emacs proper. Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) Emacs downcases drive letters when canonicalizing file names on Microsoft Windows, but etags upcases them. etags should be consistent with Emacs. I found this problem by code inspection, because there's a macro 'upcase' that normally isn't used in etags.c; its only use is in the section of code that upcases drive letters. Here's a proposed patch. 2011-02-21 Paul Eggert etags: Downcase drive letters, for consistency with Emacs proper. * etags.c (upcase): Remove; no longer used. (canonicalize_filename): Downcase drive letters. --- lib-src/etags.c 2011-02-21 16:47:08.883947000 -0800 +++ /u/cs/fac/eggert/junk/etags.c 2011-02-21 21:21:04.074974000 -0800 @@ -239,7 +239,6 @@ If you want regular expression support, #define ISLOWER(c) islower (CHAR(c)) #define lowcase(c) tolower (CHAR(c)) -#define upcase(c) toupper (CHAR(c)) /* @@ -6638,7 +6637,7 @@ filename_is_absolute (char *fn) ); } -/* Upcase DOS drive letter and collapse separators into single slashes. +/* Downcase DOS drive letter and collapse separators into single slashes. Works in place. */ static void canonicalize_filename (register char *fn) @@ -6648,8 +6647,8 @@ canonicalize_filename (register char *fn #ifdef DOS_NT /* Canonicalize drive letter case. */ - if (fn[0] != '\0' && fn[1] == ':' && ISLOWER (fn[0])) - fn[0] = upcase (fn[0]); + if (fn[0] != '\0' && fn[1] == ':' && ISUPPER (fn[0])) + fn[0] = downcase (fn[0]); sep = '\\'; #endif ------------=_1298396403-849-1-- From unknown Tue Aug 19 02:52:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2011 17:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Francesco =?UTF-8?Q?Potort=C3=AC?= Cc: 8093@debbugs.gnu.org Received: via spool by 8093-submit@debbugs.gnu.org id=B8093.12983969001575 (code B ref 8093); Tue, 22 Feb 2011 17:49:01 +0000 Received: (at 8093) by debbugs.gnu.org; 22 Feb 2011 17:48:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrwLT-0000PM-KO for submit@debbugs.gnu.org; Tue, 22 Feb 2011 12:48:19 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrwLR-0000P9-Dg for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 12:48:17 -0500 Received: from localhost ([127.0.0.1]:32928) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrwLM-000559-30; Tue, 22 Feb 2011 12:48:12 -0500 From: Glenn Morris References: <4D6353B4.5010104@cs.ucla.edu> X-Spook: counter intelligence Bruxelles Afghanistan Leuken-Baden X-Ran: "ZI{V{G<{x,:j;H:Zp1GO"'.\[LAo$=di1gd/gBXexk&zaB25;nM$3+F X-Hue: magenta X-Attribution: GM Date: Tue, 22 Feb 2011 12:48:11 -0500 In-Reply-To: ("Francesco =?UTF-8?Q?Potort=C3=AC?="'s message of "Tue, 22 Feb 2011 11:11:36 +0100") Message-ID: <2pd3mkvu3o.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) From: Francesco Potorti Subject: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. To: Paul Eggert Cc: bug-gnu-emacs@gnu.org, owner@debbugs.gnu.org, 8093@debbugs.gnu.org FYI, your mail client seems to be including Resent-To and Resent-Cc in replies. Per RFC 2822, it should not do this. Eg http://lists.gnu.org/archive/html/emacs-devel/2009-01/msg00765.html From unknown Tue Aug 19 02:52:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. Resent-From: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2011 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 8093@debbugs.gnu.org Received: via spool by 8093-submit@debbugs.gnu.org id=B8093.12984023639340 (code B ref 8093); Tue, 22 Feb 2011 19:20:02 +0000 Received: (at 8093) by debbugs.gnu.org; 22 Feb 2011 19:19:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Prxlb-0002Qb-5i for submit@debbugs.gnu.org; Tue, 22 Feb 2011 14:19:23 -0500 Received: from mx2.isti.cnr.it ([194.119.192.4]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PrxlZ-0002QQ-1q for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 14:19:21 -0500 Received: from SCRIPT-SPFWL-DAEMON.mx.isti.cnr.it by mx.isti.cnr.it (PMDF V6.5-x5 #31825) id <01NY51I2X99SPHYQX3@mx.isti.cnr.it> for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 20:18:13 +0100 (MET) Received: from conversionlocal.isti.cnr.it by mx.isti.cnr.it (PMDF V6.5-x5 #31825) id <01NY51I2B71CPHYSHY@mx.isti.cnr.it> for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 20:18:10 +0100 (MET) Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by mx.isti.cnr.it (PMDF V6.5-x5 #31826) with ESMTPSA id <01NY51I1P8LCPT02XT@mx.isti.cnr.it>; Tue, 22 Feb 2011 20:18:10 +0100 (MET) Received: from pot by tucano.isti.cnr.it with local (Exim 4.72) (envelope-from ) id 1PrxkP-00085w-St; Tue, 22 Feb 2011 20:18:09 +0100 Date: Tue, 22 Feb 2011 20:18:09 +0100 From: Francesco =?UTF-8?Q?Potort=C3=AC?= In-reply-to: <2pd3mkvu3o.fsf@fencepost.gnu.org> Message-id: Organization: X-INSM-ip-source: 146.48.81.102 Auth Done X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 References: <4D6353B4.5010104@cs.ucla.edu> <2pd3mkvu3o.fsf@fencepost.gnu.org> X-Spam-Score: -3.1 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) > From: Francesco Potorti > Subject: bug#8093: etags: Downcase drive letters, > for consistency with Emacs proper. > To: Paul Eggert > Cc: bug-gnu-emacs@gnu.org, owner@debbugs.gnu.org, 8093@debbugs.gnu.org > >FYI, your mail client seems to be including Resent-To and Resent-Cc in >replies. Per RFC 2822, it should not do this. Eg > >http://lists.gnu.org/archive/html/emacs-devel/2009-01/msg00765.html I use Emacs 22.3 rmail. Unfortunately, I have a set of custom additions to rmail which do not work with Emacs 23 and I have not yet found the time to convert them and switch to Emacs 23 :( From unknown Tue Aug 19 02:52:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. In-Reply-To: <4D6353B4.5010104@cs.ucla.edu> Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2011 22:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Francesco =?UTF-8?Q?Potort=C3=AC?= Cc: 8093@debbugs.gnu.org Received: via spool by 8093-submit@debbugs.gnu.org id=B8093.1298414210724 (code B ref 8093); Tue, 22 Feb 2011 22:37:02 +0000 Received: (at 8093) by debbugs.gnu.org; 22 Feb 2011 22:36:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ps0qg-0000Bd-4T for submit@debbugs.gnu.org; Tue, 22 Feb 2011 17:36:50 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ps0qe-0000BR-By for 8093@debbugs.gnu.org; Tue, 22 Feb 2011 17:36:48 -0500 Received: from localhost ([127.0.0.1]:41546) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ps0qZ-0007eT-5l; Tue, 22 Feb 2011 17:36:43 -0500 From: Glenn Morris References: <4D6353B4.5010104@cs.ucla.edu> <2pd3mkvu3o.fsf@fencepost.gnu.org> X-Spook: Bin Laden IMF Ft. Meade strategic Telex illuminati MIT-LL X-Ran: )@O)+SNn&CSrU/V*v=jd`4k@(z>7e4\{gy^IwN`URC@c!C70XRiWYFt$M8!ts]W+xIYE'M X-Hue: black X-Attribution: GM Date: Tue, 22 Feb 2011 17:36:42 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Francesco Potort=C3=AC wrote: > I use Emacs 22.3 rmail. rmail-dont-reply-to-names should work as a stopgap. From unknown Tue Aug 19 02:52:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8093: etags: Downcase drive letters, for consistency with Emacs proper. Resent-From: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Feb 2011 08:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8093 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 8093@debbugs.gnu.org Received: via spool by 8093-submit@debbugs.gnu.org id=B8093.129845040524063 (code B ref 8093); Wed, 23 Feb 2011 08:41:02 +0000 Received: (at 8093) by debbugs.gnu.org; 23 Feb 2011 08:40:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsAGT-0006G4-NA for submit@debbugs.gnu.org; Wed, 23 Feb 2011 03:40:05 -0500 Received: from mx2.isti.cnr.it ([194.119.192.4]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PsAGR-0006FV-9f for 8093@debbugs.gnu.org; Wed, 23 Feb 2011 03:40:04 -0500 Received: from SCRIPT-SPFWL-DAEMON.mx.isti.cnr.it by mx.isti.cnr.it (PMDF V6.5-x5 #31825) id <01NY5TGPEMKWPHYJRW@mx.isti.cnr.it> for 8093@debbugs.gnu.org; Wed, 23 Feb 2011 09:38:50 +0100 (MET) Received: from conversionlocal.isti.cnr.it by mx.isti.cnr.it (PMDF V6.5-x5 #31825) id <01NY5TGOZL28PHYWF5@mx.isti.cnr.it> for 8093@debbugs.gnu.org; Wed, 23 Feb 2011 09:38:48 +0100 (MET) Received: from tucano.isti.cnr.it (tucano.isti.cnr.it [146.48.81.102]) by mx.isti.cnr.it (PMDF V6.5-x5 #31826) with ESMTPSA id <01NY5TGOLF1APU8CB0@mx.isti.cnr.it>; Wed, 23 Feb 2011 09:38:47 +0100 (MET) Received: from pot by tucano.isti.cnr.it with local (Exim 4.72) (envelope-from ) id 1PsAFD-0006Yv-MA; Wed, 23 Feb 2011 09:38:47 +0100 Date: Wed, 23 Feb 2011 09:38:47 +0100 From: Francesco =?UTF-8?Q?Potort=C3=AC?= In-reply-to: Message-id: Organization: X-INSM-ip-source: 146.48.81.102 Auth Done X-fingerprint: 4B02 6187 5C03 D6B1 2E31 7666 09DF 2DC9 BE21 6115 References: <4D6353B4.5010104@cs.ucla.edu> <2pd3mkvu3o.fsf@fencepost.gnu.org> X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) >> I use Emacs 22.3 rmail. > >rmail-dont-reply-to-names should work as a stopgap. I do not see how: rmail-dont-reply-to-names is a list of addresses, while I want to prevent answering to spcific headers. Anyway, I see the importance of this and I will modify my rmail.el, thank you for noticing.