GNU bug report logs - #8093
etags: Downcase drive letters, for consistency with Emacs proper.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8093 in the body.
You can then email your comments to 8093 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: etags: Downcase drive letters, for consistency with Emacs proper.
Date: Mon, 21 Feb 2011 22:12:04 -0800

Emacs downcases drive letters when canonicalizing file names on
Microsoft Windows, but etags upcases them.  etags should be consistent
with Emacs.  I found this problem by code inspection, because there's
a macro 'upcase' that normally isn't used in etags.c; its only use is
in the section of code that upcases drive letters.  Here's a proposed
patch.

2011-02-21  Paul Eggert  <eggert <at> cs.ucla.edu>

	etags: Downcase drive letters, for consistency with Emacs proper.
	* etags.c (upcase): Remove; no longer used.
	(canonicalize_filename): Downcase drive letters.

--- lib-src/etags.c	2011-02-21 16:47:08.883947000 -0800
+++ /u/cs/fac/eggert/junk/etags.c	2011-02-21 21:21:04.074974000 -0800
@@ -239,7 +239,6 @@ If you want regular expression support,
 #define ISLOWER(c)	islower (CHAR(c))
 
 #define lowcase(c)	tolower (CHAR(c))
-#define upcase(c)	toupper (CHAR(c))
 
 
 /*
@@ -6638,7 +6637,7 @@ filename_is_absolute (char *fn)
 	  );
 }
 
-/* Upcase DOS drive letter and collapse separators into single slashes.
+/* Downcase DOS drive letter and collapse separators into single slashes.
    Works in place. */
 static void
 canonicalize_filename (register char *fn)
@@ -6648,8 +6647,8 @@ canonicalize_filename (register char *fn
 
 #ifdef DOS_NT
   /* Canonicalize drive letter case.  */
-  if (fn[0] != '\0' && fn[1] == ':' && ISLOWER (fn[0]))
-    fn[0] = upcase (fn[0]);
+  if (fn[0] != '\0' && fn[1] == ':' && ISUPPER (fn[0]))
+    fn[0] = downcase (fn[0]);
 
   sep = '\\';
 #endif

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Francesco Potortì <pot <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: bug-gnu-emacs <at> gnu.org, owner <at> debbugs.gnu.org, 8093 <at> debbugs.gnu.org
Subject: Re: bug#8093: etags: Downcase drive letters,
	for consistency with Emacs proper.
Date: Tue, 22 Feb 2011 11:11:36 +0100

>Emacs downcases drive letters when canonicalizing file names on
>Microsoft Windows, but etags upcases them.  etags should be consistent
>with Emacs.  I found this problem by code inspection, because there's
>a macro 'upcase' that normally isn't used in etags.c; its only use is
>in the section of code that upcases drive letters.  Here's a proposed
>patch.

Looks reasonable and I see no compatibility issues.  Please install it.

>2011-02-21  Paul Eggert  <eggert <at> cs.ucla.edu>
>
>	etags: Downcase drive letters, for consistency with Emacs proper.
>	* etags.c (upcase): Remove; no longer used.
>	(canonicalize_filename): Downcase drive letters.
>
>--- lib-src/etags.c	2011-02-21 16:47:08.883947000 -0800
>+++ /u/cs/fac/eggert/junk/etags.c	2011-02-21 21:21:04.074974000 -0800
>@@ -239,7 +239,6 @@ If you want regular expression support,
>  #define ISLOWER(c)	islower (CHAR(c))
>  
>  #define lowcase(c)	tolower (CHAR(c))
>-#define upcase(c)	toupper (CHAR(c))
>  
>  
>  /*
>@@ -6638,7 +6637,7 @@ filename_is_absolute (char *fn)
>  	  );
>  }
>  
>-/* Upcase DOS drive letter and collapse separators into single slashes.
>+/* Downcase DOS drive letter and collapse separators into single slashes.
>     Works in place. */
>  static void
>  canonicalize_filename (register char *fn)
>@@ -6648,8 +6647,8 @@ canonicalize_filename (register char *fn
>  
>  #ifdef DOS_NT
>    /* Canonicalize drive letter case.  */
>-  if (fn[0] != '\0' && fn[1] == ':' && ISLOWER (fn[0]))
>-    fn[0] = upcase (fn[0]);
>+  if (fn[0] != '\0' && fn[1] == ':' && ISUPPER (fn[0]))
>+    fn[0] = downcase (fn[0]);
>  
>    sep = '\\';
>  #endif
>
>
>
>
>
>

Message #14 received at 8093 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Francesco Potortì <pot <at> gnu.org>
Cc: eggert <at> cs.ucla.edu, 8093 <at> debbugs.gnu.org
Subject: Re: bug#8093: etags: Downcase drive letters,
	for consistency with Emacs proper.
Date: Tue, 22 Feb 2011 19:33:47 +0200

> Date: Tue, 22 Feb 2011 11:11:36 +0100
> From: Francesco Potortì= <pot <at> gnu.org>
> Cc: bug-gnu-emacs <at> gnu.org, owner <at> debbugs.gnu.org, 8093 <at> debbugs.gnu.org
> 
> >Emacs downcases drive letters when canonicalizing file names on
> >Microsoft Windows, but etags upcases them.  etags should be consistent
> >with Emacs.  I found this problem by code inspection, because there's
> >a macro 'upcase' that normally isn't used in etags.c; its only use is
> >in the section of code that upcases drive letters.  Here's a proposed
> >patch.
> 
> Looks reasonable and I see no compatibility issues.  Please install it.

Agreed.

Thanks, Paul.

Message #19 received at 8093-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Francesco Potortì <pot <at> gnu.org>,
	8093-done <at> debbugs.gnu.org
Subject: Re: bug#8093: etags: Downcase drive letters,	for consistency with
	Emacs proper.
Date: Tue, 22 Feb 2011 09:39:12 -0800

On 02/22/2011 09:33 AM, Eli Zaretskii wrote:
> Thanks, Paul.

You're welcome, and I installed it as revno 103385
on the trunk.

Message #22 received at 8093 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Francesco Potortì <pot <at> gnu.org>
Cc: 8093 <at> debbugs.gnu.org
Subject: Re: bug#8093: etags: Downcase drive letters,
	for consistency with Emacs proper.
Date: Tue, 22 Feb 2011 12:48:11 -0500

    From: Francesco Potorti <pot <at> gnu.org>
    Subject: bug#8093: etags: Downcase drive letters, 
        for consistency with Emacs proper.
    To: Paul Eggert <eggert <at> cs.ucla.edu>
    Cc: bug-gnu-emacs <at> gnu.org, owner <at> debbugs.gnu.org, 8093 <at> debbugs.gnu.org


FYI, your mail client seems to be including Resent-To and Resent-Cc in
replies. Per RFC 2822, it should not do this. Eg

http://lists.gnu.org/archive/html/emacs-devel/2009-01/msg00765.html

Message #25 received at 8093 <at> debbugs.gnu.org (full text, mbox):

From: Francesco Potortì <pot <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 8093 <at> debbugs.gnu.org
Subject: Re: bug#8093: etags: Downcase drive letters,
	for consistency with Emacs proper.
Date: Tue, 22 Feb 2011 20:18:09 +0100

>    From: Francesco Potorti <pot <at> gnu.org>
>    Subject: bug#8093: etags: Downcase drive letters, 
>        for consistency with Emacs proper.
>    To: Paul Eggert <eggert <at> cs.ucla.edu>
>    Cc: bug-gnu-emacs <at> gnu.org, owner <at> debbugs.gnu.org, 8093 <at> debbugs.gnu.org
>
>FYI, your mail client seems to be including Resent-To and Resent-Cc in
>replies. Per RFC 2822, it should not do this. Eg
>
>http://lists.gnu.org/archive/html/emacs-devel/2009-01/msg00765.html

I use Emacs 22.3 rmail.  Unfortunately, I have a set of custom additions
to rmail which do not work with Emacs 23 and I have not yet found the
time to convert them and switch to Emacs 23 :(

Message #28 received at 8093 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Francesco Potortì <pot <at> gnu.org>
Cc: 8093 <at> debbugs.gnu.org
Subject: Re: bug#8093: etags: Downcase drive letters,
	for consistency with Emacs proper.
Date: Tue, 22 Feb 2011 17:36:42 -0500

Francesco Potortì wrote:

> I use Emacs 22.3 rmail.

rmail-dont-reply-to-names should work as a stopgap.

Message #31 received at 8093 <at> debbugs.gnu.org (full text, mbox):

From: Francesco Potortì <pot <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 8093 <at> debbugs.gnu.org
Subject: Re: bug#8093: etags: Downcase drive letters,
	for consistency with Emacs proper.
Date: Wed, 23 Feb 2011 09:38:47 +0100

>> I use Emacs 22.3 rmail.
>
>rmail-dont-reply-to-names should work as a stopgap.

I do not see how: rmail-dont-reply-to-names is a list of addresses,
while I want to prevent answering to spcific headers.

Anyway, I see the importance of this and I will modify my rmail.el,
thank you for noticing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.