GNU bug report logs - #8084
24.0.50; grep still relies on font-lock somewhat

Previous Next

Package: emacs;

Reported by: Lars Magne Ingebrigtsen <lmi <at> gnus.org>

Date: Sun, 20 Feb 2011 01:45:02 UTC

Severity: normal

Found in version 24.0.50

Done: Juri Linkov <juri <at> jurta.org>

Bug is archived. No further changes may be made.

Full log


Message #30 received at 8084-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 8084-done <at> debbugs.gnu.org
Subject: Re: bug#8084: 24.0.50; grep still relies on font-lock somewhat
Date: Mon, 05 Sep 2011 12:49:43 +0300
> Do I understand correctly that after revno:104159 (2011-05-08) that
> fixes bug#7952 by handling escape sequences in the process filter
> rather than in font-lock, now the line `(null font-lock-mode)' should be
> removed from `grep-process-setup'

I now think that `grep-process-setup' should still check for
`(null font-lock-mode)' to not output color escapes
that can't be highlighted with `font-lock-face' by `grep-filter'.
There is no harm to output color escapes because `grep-filter'
still removes them, but this is useless because text properties
`font-lock-face' can't be displayed when `font-lock-mode' is nil.

> and this bug#8084 should be closed?

I fixed comments and closed this bug.




This bug report was last modified 13 years and 322 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.