From unknown Tue Jul 08 09:42:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8046: [PATCH] Incorrect font selection in fontconfig driver Resent-From: Kostya Stopani Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Feb 2011 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 8046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 8046@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12977946896729 (code B ref -1); Tue, 15 Feb 2011 18:32:01 +0000 Received: (at submit) by debbugs.gnu.org; 15 Feb 2011 18:31:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PpPgP-0001kU-H5 for submit@debbugs.gnu.org; Tue, 15 Feb 2011 13:31:29 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PpPgN-0001kJ-Nd for submit@debbugs.gnu.org; Tue, 15 Feb 2011 13:31:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PpPp2-0003Ds-MX for submit@debbugs.gnu.org; Tue, 15 Feb 2011 13:40:28 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:56131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PpPp2-0003Do-Gj for submit@debbugs.gnu.org; Tue, 15 Feb 2011 13:40:24 -0500 Received: from [140.186.70.92] (port=43082 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PpPp0-0001E4-HT for bug-gnu-emacs@gnu.org; Tue, 15 Feb 2011 13:40:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PpPoz-0003D8-1j for bug-gnu-emacs@gnu.org; Tue, 15 Feb 2011 13:40:22 -0500 Received: from depni.sinp.msu.ru ([213.131.7.21]:58048) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PpPoy-0003C8-LZ for bug-gnu-emacs@gnu.org; Tue, 15 Feb 2011 13:40:20 -0500 Received: by depni.sinp.msu.ru (Postfix, from userid 65534) id 4A3EBD6C76; Tue, 15 Feb 2011 21:40:17 +0300 (MSK) Received: from thinkpad (depni.sinp.msu.ru [213.131.7.21]) by depni.sinp.msu.ru (Postfix) with ESMTP id C2F8ED6C28; Tue, 15 Feb 2011 21:40:10 +0300 (MSK) Date: Tue, 15 Feb 2011 21:40:10 +0300 From: Kostya Stopani Message-ID: <20110215184010.GA10051@thinkpad> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FkmkrVfFsRoUs1wW" Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-Received-From: 213.131.7.21 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) --FkmkrVfFsRoUs1wW Content-Type: multipart/mixed; boundary="PEIAKu/WMn1b1Hv9" Content-Disposition: inline --PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Attached file in koi8-r encoding displays incorrectly on Linux with default DejaVu (from fontset-startup) and some other fonts (on emacs-24.0.50.12). Cyrillic characters are rendered in oblique style instead of normal. Here's a part of M-x font-show-log showing this: default fontset: font for: 1057 ftfont-list: -unknown-DejaVu Sans Mono-*-k-koi8-r -unknown-DejaVu Sans Mono-bold-oblique-normal-*-m-0-isoso6060646-1 -unknown-DejaVu Sans Mono-normal-oblique-normal-*-m-0-iso10646-1 -unknown-DejaVu Sans Mono-bold-normal-normal-*-0soso101064646-1 xfont-list: -unknown-DejaVu Sans Mono-*-*-*-*-*-*-*-*-*-*-koi8-r list: -unknown-DejaVu Sans Mono-*-k-koi8-r -unknown-DejaVu Sans Mono-bold-oblique-normal-*-m-0-isoso6060646-1 -unknown-DejaVu Sans Mono-normal-oblique-normal-*-m-0-iso10646-1 -unknown-DejaVu Sans Mono-bold-normal-normal-*-0soso101064646-1 sort-by: -*-normal-normal-normal-*-13-* xft:-unknown-DejaVu Sans Mono-normal-oblique-normal-*-m-0-iso10646-1 open: -unknown-DejaVu Sans Mono-normal-oblique-normal-*-m-0-iso10646-1 xft:-unknown-DejaVu Sans Mono-normal-oblique-normal-*-13-*-m-0-iso10646-1 The reason is that ftfont_list function filters out fonts when its langname parameter doesn't match font's adstyle property. But adstyle really most of the time has neutral values like "Book" or "Semicondensed". As far as I know it can contain language codes only for PCF japanese and korean fonts (respectively "ja" and "ko"). A patch to fix this behaviour is below. * src/ftfont.c (ftfont_list): reject fonts using langname only if adstyle is "ja" or "ko". =3D=3D=3D modified file 'src/ftfont.c' *** src/ftfont.c 2011-02-05 22:30:14 +0000 --- src/ftfont.c 2011-02-15 18:13:28 +0000 *************** ftfont_list (Lisp_Object frame, Lisp_Obj *** 1026,1031 **** --- 1026,1032 ---- SSDATA (SYMBOL_NAME (this_adstyle))) !=3D 0)) continue; if (langname + && (xstrcasecmp (langname, "ja") =3D=3D 0 || xstrcasecmp (langname= , "ko") =3D=3D 0) && ! NILP (this_adstyle) && xstrcasecmp (langname, SSDATA (SYMBOL_NAME (this_adstyle)))) continue; =20 --PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="1.txt" Content-Transfer-Encoding: quoted-printable -*- coding: koi8-r -*- abc =C1=C2=D7 --PEIAKu/WMn1b1Hv9-- --FkmkrVfFsRoUs1wW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJNWsiJAAoJED9ghtPvprnDY1oQALrE86svyghw8tK+pljvSEst jJEPRO5kGlB9KEmtNPQUxDiG5ANLG+t1FPZ6SA6I7inPadlBS59yViihcug31geq Mn9Yh23koIJnb0Rfbg9prkdsVXdXR7oTBXSNwPlIyuDRBcUmQVyklvloYivHs8l6 3NMmk7cNwXUI1HnXz3rf3K52MYNT8LYZ5BJZS+4GRoOfQOTchSvzQMKaqIi29lTs h21Seq5n3sSJbYYYjddkm8OzTHaVrGhX9Ve6PwXEvVkUiDMRAbs9Hr6mRUhdJeC9 r2OQfwzUQ7Sb2cYyRBXscAqUKcMzmHFpLefgIWu2BZfc1RVuQ1JJhO4qjeqzyEaE PcjXnqUHMPgrl/J5ZFHbAqFiyPtTRqmgOEMrsUl8lxUb3yZBLuKkOb943Ea7XUwA zhBfoHPqEa0b+FGjPH3OwuuP5Oxhr3V2XD2NkAsVDdQ6l4G7B5gVA/eOOW6OFdZO f8y/8M8Mpbg44V97X8ptt1n4EOFhfVdfyzFc5/C4a6+TIYYViGEcNNvdTvTIsF4s NTGBHmukhGeMX+PPY02l/dvVHZN+eGN6ZdC6DJmmlFQTl7MU7SX8ocrKIpTaRC7l 8dOeH9vL9pQx7j08Dgrs8G4LvAKjfirLqfIR89JeH8tMb93dYxRxyUCH7l6BlAPP VUm+1iwz9w9bk2bo07IL =J78C -----END PGP SIGNATURE----- --FkmkrVfFsRoUs1wW-- From unknown Tue Jul 08 09:42:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#8046: [PATCH] Incorrect font selection in fontconfig driver Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Aug 2011 20:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8046 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kenichi Handa Cc: 8046@debbugs.gnu.org, Kostya Stopani Received: via spool by 8046-submit@debbugs.gnu.org id=B8046.131275016314248 (code B ref 8046); Sun, 07 Aug 2011 20:50:02 +0000 Received: (at 8046) by debbugs.gnu.org; 7 Aug 2011 20:49:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QqAHi-0003hk-DM for submit@debbugs.gnu.org; Sun, 07 Aug 2011 16:49:22 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QqAHg-0003hd-0u for 8046@debbugs.gnu.org; Sun, 07 Aug 2011 16:49:20 -0400 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p77KmJVq013119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 7 Aug 2011 16:48:20 -0400 From: Chong Yidong References: <20110215184010.GA10051@thinkpad> Date: Sun, 07 Aug 2011 16:48:18 -0400 In-Reply-To: <20110215184010.GA10051@thinkpad> (Kostya Stopani's message of "Tue, 15 Feb 2011 21:40:10 +0300") Message-ID: <87hb5t2bjh.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Handa-san, could you evaluate this proposed change? Thanks. Kostya Stopani writes: > Attached file in koi8-r encoding displays incorrectly on Linux with > default DejaVu (from fontset-startup) and some other fonts (on > emacs-24.0.50.12). Cyrillic characters are rendered in oblique style > instead of normal. > > The reason is that ftfont_list function filters out fonts when its > langname parameter doesn't match font's adstyle property. But adstyle > really most of the time has neutral values like "Book" or > "Semicondensed". As far as I know it can contain language codes only > for PCF japanese and korean fonts (respectively "ja" and "ko"). A > patch to fix this behaviour is below. > > * src/ftfont.c (ftfont_list): reject fonts using langname only if > adstyle is "ja" or "ko". > > > === modified file 'src/ftfont.c' > *** src/ftfont.c 2011-02-05 22:30:14 +0000 > --- src/ftfont.c 2011-02-15 18:13:28 +0000 > *************** ftfont_list (Lisp_Object frame, Lisp_Obj > *** 1026,1031 **** > --- 1026,1032 ---- > SSDATA (SYMBOL_NAME (this_adstyle))) != 0)) > continue; > if (langname > + && (xstrcasecmp (langname, "ja") == 0 || xstrcasecmp (langname, "ko") == 0) > && ! NILP (this_adstyle) > && xstrcasecmp (langname, SSDATA (SYMBOL_NAME (this_adstyle)))) > continue; From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 12:34:20 2011 Received: (at control) by debbugs.gnu.org; 2 Dec 2011 17:34:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWX07-00033x-0V for submit@debbugs.gnu.org; Fri, 02 Dec 2011 12:34:20 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RWX02-00033n-2i for control@debbugs.gnu.org; Fri, 02 Dec 2011 12:34:15 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RWWzl-00078T-QJ for control@debbugs.gnu.org; Fri, 02 Dec 2011 12:33:57 -0500 Date: Fri, 02 Dec 2011 12:33:57 -0500 Message-Id: Subject: control message for bug 10193 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) merge 8046 10193 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 06 03:36:23 2011 Received: (at control) by debbugs.gnu.org; 6 Dec 2011 08:36:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXqVj-0004mZ-EB for submit@debbugs.gnu.org; Tue, 06 Dec 2011 03:36:23 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXqVi-0004mT-3R for control@debbugs.gnu.org; Tue, 06 Dec 2011 03:36:22 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RXqV7-0000QS-Bd for control@debbugs.gnu.org; Tue, 06 Dec 2011 03:35:45 -0500 Date: Tue, 06 Dec 2011 03:35:45 -0500 Message-Id: Subject: control message for bug 10193 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) close 10193 24.0.93