GNU bug report logs - #8020
23.2.93; assertion failure on fast frame resize

Previous Next

Package: emacs;

Reported by: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>

Date: Sat, 12 Feb 2011 02:22:02 UTC

Severity: important

Found in version 23.2.93

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 8020 in the body.
You can then email your comments to 8020 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8020; Package emacs. (Sat, 12 Feb 2011 02:22:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 12 Feb 2011 02:22:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2.93; assertion failure on fast frame resize
Date: Sat, 12 Feb 2011 11:30:28 +0900
This is forked from Bug#7348, and some analysis can be found there.
(http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7348)

Steps to reproduce:

  1. Build emacs with --enable-checking
  2. emacs -Q
  3. C-x 2
  4. Move your mouse to the corner of the frame, grab it, drag up,
     rescaling the vertically to minimum size

Result:

 ../src/xdisp.c:11515: Emacs fatal error: assertion failed: BUFFERP(w->buffer)

The value of w->buffer was nil when the assertion failure occurred.

				     YAMAMOTO Mitsuharu
				mituharu <at> math.s.chiba-u.ac.jp

In GNU Emacs 23.2.93.1 (x86_64-apple-darwin10.6.0, GTK+ Version 2.22.1)
 of 2011-02-09 on yamamoto-mitsuharu-no-iMac.local
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--enable-checking' 'LDFLAGS=-L/opt/local/lib' 'CPPFLAGS=-I/opt/local/include' 'CFLAGS=-g''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ja_JP.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t




Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8020; Package emacs. (Sat, 12 Feb 2011 08:43:01 GMT) Full text and rfc822 format available.

Message #8 received at 8020 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
Cc: 8020 <at> debbugs.gnu.org
Subject: Re: bug#8020: 23.2.93; assertion failure on fast frame resize
Date: Sat, 12 Feb 2011 10:50:49 +0200
> Date: Sat, 12 Feb 2011 11:30:28 +0900
> From: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
> Cc: 
> 
> This is forked from Bug#7348, and some analysis can be found there.
> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7348)
> 
> Steps to reproduce:
> 
>   1. Build emacs with --enable-checking
>   2. emacs -Q
>   3. C-x 2
>   4. Move your mouse to the corner of the frame, grab it, drag up,
>      rescaling the vertically to minimum size
> 
> Result:
> 
>  ../src/xdisp.c:11515: Emacs fatal error: assertion failed: BUFFERP(w->buffer)
> 
> The value of w->buffer was nil when the assertion failure occurred.

Please try the patch below, which is based on the discussions in bug
#7348.  The patch seems to solve the bug on MS-Windows.  If it works
for you on another platform, and doesn't cause problems elsewhere, I
will install it on the emacs-23 branch.

Thanks.


--- src/xdisp.c.orig	2011-01-26 20:15:42.000000000 +0200
+++ src/xdisp.c	2011-02-12 10:48:56.296875000 +0200
@@ -11261,6 +11261,7 @@
      int preserve_echo_area;
 {
   struct window *w = XWINDOW (selected_window);
+  struct window *sw;
   struct frame *f;
   int pause;
   int must_finish = 0;
@@ -11331,6 +11332,9 @@
   }
 
  retry:
+  /* Remember the currently selected window.  */
+  sw = w;
+
   if (!EQ (old_frame, selected_frame)
       && FRAME_LIVE_P (XFRAME (old_frame)))
     /* When running redisplay, we play a bit fast-and-loose and allow e.g.
@@ -11396,6 +11400,14 @@
   /* Notice any pending interrupt request to change frame size.  */
   do_pending_window_change (1);
 
+  /* do_pending_window_change could change the selected_window due to
+     frame resizing which makes the selected window too small.  */
+  if (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw)
+    {
+      sw = w;
+      reconsider_clip_changes (w, current_buffer);
+    }
+
   /* Clear frames marked as garbaged.  */
   if (frame_garbaged)
     clear_garbaged_frames ();
@@ -11665,6 +11677,10 @@
 	  if (!must_finish)
 	    {
 	      do_pending_window_change (1);
+	      /* If selected_window changed, redisplay again.  */
+	      if (WINDOWP (selected_window)
+		  && (w = XWINDOW (selected_window)) != sw)
+		goto retry;
 
 	      /* We used to always goto end_of_redisplay here, but this
 		 isn't enough if we have a blinking cursor.  */
@@ -11959,8 +11975,9 @@
   do_pending_window_change (1);
 
   /* If we just did a pending size change, or have additional
-     visible frames, redisplay again.  */
-  if (windows_or_buffers_changed && !pause)
+     visible frames, or selected_window changed, redisplay again.  */
+  if ((windows_or_buffers_changed && !pause)
+      || (WINDOWP (selected_window) && (w = XWINDOW (selected_window)) != sw))
     goto retry;
 
   /* Clear the face cache eventually.  */




Severity set to 'important' from 'normal' Request was from Chong Yidong <cyd <at> stupidchicken.com> to control <at> debbugs.gnu.org. (Sat, 12 Feb 2011 21:06:02 GMT) Full text and rfc822 format available.

Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#8020; Package emacs. (Sun, 13 Feb 2011 04:34:02 GMT) Full text and rfc822 format available.

Message #13 received at 8020 <at> debbugs.gnu.org (full text, mbox):

From: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 8020 <at> debbugs.gnu.org
Subject: Re: bug#8020: 23.2.93; assertion failure on fast frame resize
Date: Sun, 13 Feb 2011 13:41:36 +0900
>>>>> On Sat, 12 Feb 2011 10:50:49 +0200, Eli Zaretskii <eliz <at> gnu.org> said:

> Please try the patch below, which is based on the discussions in bug
> #7348.  The patch seems to solve the bug on MS-Windows.  If it works
> for you on another platform, and doesn't cause problems elsewhere, I
> will install it on the emacs-23 branch.

Yes, it also works for me with the GTK+ build on Mac OS X 10.6.
Thanks.

				     YAMAMOTO Mitsuharu
				mituharu <at> math.s.chiba-u.ac.jp




Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Sun, 13 Feb 2011 18:48:01 GMT) Full text and rfc822 format available.

Notification sent to YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>:
bug acknowledged by developer. (Sun, 13 Feb 2011 18:48:02 GMT) Full text and rfc822 format available.

Message #18 received at 8020-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
Cc: 8020-done <at> debbugs.gnu.org
Subject: Re: bug#8020: 23.2.93; assertion failure on fast frame resize
Date: Sun, 13 Feb 2011 20:56:26 +0200
> Date: Sun, 13 Feb 2011 13:41:36 +0900
> From: YAMAMOTO Mitsuharu <mituharu <at> math.s.chiba-u.ac.jp>
> Cc: 8020 <at> debbugs.gnu.org
> 
> >>>>> On Sat, 12 Feb 2011 10:50:49 +0200, Eli Zaretskii <eliz <at> gnu.org> said:
> 
> > Please try the patch below, which is based on the discussions in bug
> > #7348.  The patch seems to solve the bug on MS-Windows.  If it works
> > for you on another platform, and doesn't cause problems elsewhere, I
> > will install it on the emacs-23 branch.
> 
> Yes, it also works for me with the GTK+ build on Mac OS X 10.6.
> Thanks.

Thanks, installed on the emacs-23 branch.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 14 Mar 2011 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 14 years and 156 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.