GNU bug report logs - #801
grep et al should use font-lock

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#2134: closed ([PATCH] progmodes/compile.el: check
 global-font-lock-mode)
Date: Fri, 28 Jan 2011 22:13:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 28 Jan 2011 17:19:56 -0500
with message-id <jwv39ochdxi.fsf-monnier+emacs <at> gnu.org>
and subject line compile.el and font-lock
has caused the GNU bug report #801,
regarding [PATCH] progmodes/compile.el: check global-font-lock-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
801: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=801
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jari Aalto <jari.aalto <at> cante.net>
To: submit <at> debbugs.gnu.org
Subject: [PATCH] progmodes/compile.el: check global-font-lock-mode
Date: Sat, 31 Jan 2009 14:34:46 +0200

Tags: patch

Here is patch to not to turn on font-lock unconditionally. Patch is
against Emacs version control tree check out 2009-01-31.

2009-01-31  Jari Aalto  <jari.aalto <at> cante.net>

	* progmodes/compile.el (compilation-start): Run
	`font-lock-fontify-buffer' only if `global-font-lock-mode'
	is non-nil.

From 473ca5257db6da8da4d31e4b9a2682f0972cc8c1 Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Sat, 31 Jan 2009 14:27:23 +0200
Subject: [PATCH] lisp/progmodes/compile.el: (compilation-start): check global-font-lock-mode

Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/progmodes/compile.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 2554730..1259403 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1326,7 +1326,8 @@ Returns the compilation buffer created."
 	  ;; Without async subprocesses, the buffer is not yet
 	  ;; fontified, so fontify it now.
 	  (let ((font-lock-verbose nil)) ; shut up font-lock messages
-	    (font-lock-fontify-buffer))
+	    (if global-font-lock-mode
+		(font-lock-fontify-buffer)))
 	  (set-buffer-modified-p nil)
 	  (message "Executing `%s'...done" command)))
       ;; Now finally cd to where the shell started make/grep/...
-- 
1.5.6.5

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: 801-done <at> debbugs.gnu.org, 7771-done <at> debbugs.gnu.org
Subject: compile.el and font-lock
Date: Fri, 28 Jan 2011 17:19:56 -0500

I've just pushed a change which makes M-x compile and M-x grep work
without forcing font-lock to be enabled.  They also make the
error-parsing lazier, so it may be faster in some cases (tho probably
slower in others as well: speed was not the main focus of my coding).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.