From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 01 15:30:20 2011 Received: (at submit) by debbugs.gnu.org; 1 Feb 2011 20:30:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkMrj-00076r-VJ for submit@debbugs.gnu.org; Tue, 01 Feb 2011 15:30:20 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkMri-00076f-0d for submit@debbugs.gnu.org; Tue, 01 Feb 2011 15:30:18 -0500 Received: from localhost ([127.0.0.1]:45131) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkMzl-00068y-Pp; Tue, 01 Feb 2011 15:38:37 -0500 To: submit@debbugs.gnu.org Subject: configure does not thoroughly test for ImageMagick includes From: Glenn Morris X-Spook: Afghanistan Serbian 64 Vauxhall Cross chameleon man X-Ran: <'^]i}-|M0;HlQ_'zf]T@BgV@FpcI:<'Np1Sx~6t=1*l+\H]O$t3LNh9^4><(o\G}m"a41 X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 01 Feb 2011 15:38:37 -0500 Message-ID: <2evd137anm.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Package: emacs Version: 24.0.50 Severity: minor I tried to build the current trunk on a RHEL 4.8 system. This has ImageMagick 6.0.7 installed. configure decided that ImageMagick was usable: checking for Wand... yes checking IMAGEMAGICK_CFLAGS... checking IMAGEMAGICK_LIBS... -lWand -lMagick checking for MagickExportImagePixels... no [...] Does Emacs use imagemagick? yes However, the build failed because of this: image.c:7455:29: warning: wand/MagickWand.h: No such file or directory The system has /usr/include/wand/magick_wand.h, but it does not have /usr/include/wand/MagickWand.h. Looks like the former is now deprecated. The latter does exist on RHEL 5.5, with ImageMagick 6.2.8. Obviously I can just re-configure using --without-imagemagick, but Emacs should do this for me. Either configure should test for some required minimum version of ImageMagick (I was not able to find out in what version wand/MagickWand.h was added); or image.c should fall back to wand/magick_wand.h if it can. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 01 21:40:13 2011 Received: (at 7955) by debbugs.gnu.org; 2 Feb 2011 02:40:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkSdg-0006gu-TY for submit@debbugs.gnu.org; Tue, 01 Feb 2011 21:40:13 -0500 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkSdf-0006gj-CE for 7955@debbugs.gnu.org; Tue, 01 Feb 2011 21:40:11 -0500 Received: from furball (dhcp128036014044.central.yale.edu [128.36.14.44]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p122mZoh016153 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 1 Feb 2011 21:48:35 -0500 Received: by furball (Postfix, from userid 1000) id 37AAC16058F; Tue, 1 Feb 2011 21:48:35 -0500 (EST) From: Chong Yidong To: Joakim Verona Subject: Re: bug#7955: configure does not thoroughly test for ImageMagick includes References: <2evd137anm.fsf@fencepost.gnu.org> Date: Tue, 01 Feb 2011 21:48:35 -0500 In-Reply-To: <2evd137anm.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 01 Feb 2011 15:38:37 -0500") Message-ID: <87bp2vb18c.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org, Glenn Morris X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Joakim, mind taking a look at this? Thanks. Glenn Morris writes: > Package: emacs > Version: 24.0.50 > Severity: minor > > I tried to build the current trunk on a RHEL 4.8 system. > This has ImageMagick 6.0.7 installed. > configure decided that ImageMagick was usable: > > checking for Wand... yes > checking IMAGEMAGICK_CFLAGS... > checking IMAGEMAGICK_LIBS... -lWand -lMagick > checking for MagickExportImagePixels... no > [...] > Does Emacs use imagemagick? yes > > However, the build failed because of this: > > image.c:7455:29: warning: wand/MagickWand.h: No such file or directory > > The system has /usr/include/wand/magick_wand.h, but it does not > have /usr/include/wand/MagickWand.h. Looks like the former is now > deprecated. The latter does exist on RHEL 5.5, with ImageMagick 6.2.8. > > Obviously I can just re-configure using --without-imagemagick, but > Emacs should do this for me. Either configure should test for some > required minimum version of ImageMagick (I was not able to find out in > what version wand/MagickWand.h was added); or image.c should fall back > to wand/magick_wand.h if it can. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 02 04:22:24 2011 Received: (at 7955) by debbugs.gnu.org; 2 Feb 2011 09:22:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkYuu-0006x4-CC for submit@debbugs.gnu.org; Wed, 02 Feb 2011 04:22:24 -0500 Received: from iwfs.imcode.com ([82.115.149.64] helo=gate.verona.se) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkYus-0006wr-Kq for 7955@debbugs.gnu.org; Wed, 02 Feb 2011 04:22:23 -0500 Received: from chopper (IDENT:1005@localhost [127.0.0.1]) by gate.verona.se (8.13.4/8.11.4) with ESMTP id p129Ui2D002869; Wed, 2 Feb 2011 10:30:45 +0100 From: joakim@verona.se To: Chong Yidong Subject: Re: bug#7955: configure does not thoroughly test for ImageMagick includes References: <2evd137anm.fsf@fencepost.gnu.org> <87bp2vb18c.fsf@stupidchicken.com> Date: Wed, 02 Feb 2011 10:30:44 +0100 In-Reply-To: <87bp2vb18c.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 01 Feb 2011 21:48:35 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org, Glenn Morris X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) Chong Yidong writes: > Joakim, mind taking a look at this? Thanks. I'll ask the ImageMagick maintainers. If that fails, I can try to add a specific configure check for the include file we need. If I could get a pointer to a virtualization image for rhel 4.8 that would be splendid too. > > Glenn Morris writes: > >> Package: emacs >> Version: 24.0.50 >> Severity: minor >> >> I tried to build the current trunk on a RHEL 4.8 system. >> This has ImageMagick 6.0.7 installed. >> configure decided that ImageMagick was usable: >> >> checking for Wand... yes >> checking IMAGEMAGICK_CFLAGS... >> checking IMAGEMAGICK_LIBS... -lWand -lMagick >> checking for MagickExportImagePixels... no >> [...] >> Does Emacs use imagemagick? yes >> >> However, the build failed because of this: >> >> image.c:7455:29: warning: wand/MagickWand.h: No such file or directory >> >> The system has /usr/include/wand/magick_wand.h, but it does not >> have /usr/include/wand/MagickWand.h. Looks like the former is now >> deprecated. The latter does exist on RHEL 5.5, with ImageMagick 6.2.8. >> >> Obviously I can just re-configure using --without-imagemagick, but >> Emacs should do this for me. Either configure should test for some >> required minimum version of ImageMagick (I was not able to find out in >> what version wand/MagickWand.h was added); or image.c should fall back >> to wand/magick_wand.h if it can. -- Joakim Verona From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 02 14:23:48 2011 Received: (at 7955) by debbugs.gnu.org; 2 Feb 2011 19:23:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkiIt-0005k0-MZ for submit@debbugs.gnu.org; Wed, 02 Feb 2011 14:23:48 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkiIr-0005jm-Rq for 7955@debbugs.gnu.org; Wed, 02 Feb 2011 14:23:46 -0500 Received: from localhost ([127.0.0.1]:52551) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkiR1-0001oI-P4; Wed, 02 Feb 2011 14:32:11 -0500 From: Glenn Morris To: joakim@verona.se Subject: Re: bug#7955: configure does not thoroughly test for ImageMagick includes References: <2evd137anm.fsf@fencepost.gnu.org> <87bp2vb18c.fsf@stupidchicken.com> X-Spook: Ceridian KGB Ortega blackjack Echelon Israel INSCOM Tony X-Ran: (MK[n9Gi;:gST[+|of>HV (joakim@verona.se's message of "Wed, 02 Feb 2011 10:30:44 +0100") Message-ID: <2hfws6fd1g.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) joakim@verona.se wrote: > If I could get a pointer to a virtualization image for rhel 4.8 that > would be splendid too. I don't think you can get one without paying Red Hat cash money; but Scientific Linux: http://www.scientificlinux.org/ http://www.scientificlinux.org/distributions/4x/48/ or CentOS http://www.centos.org/ http://mirror.centos.org/centos/4/isos/ ought to be functionally equivalent in every way. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 03 03:08:31 2011 Received: (at 7955) by debbugs.gnu.org; 3 Feb 2011 08:08:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkuEw-0007Dp-Jg for submit@debbugs.gnu.org; Thu, 03 Feb 2011 03:08:30 -0500 Received: from iwfs.imcode.com ([82.115.149.64] helo=gate.verona.se) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkuEv-0007De-4B for 7955@debbugs.gnu.org; Thu, 03 Feb 2011 03:08:30 -0500 Received: from chopper (IDENT:1005@localhost [127.0.0.1]) by gate.verona.se (8.13.4/8.11.4) with ESMTP id p138Guak030599 for <7955@debbugs.gnu.org>; Thu, 3 Feb 2011 09:16:56 +0100 From: joakim@verona.se To: 7955@debbugs.gnu.org Subject: reply from the IM team Date: Thu, 03 Feb 2011 09:16:56 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 7955 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) http://www.imagemagick.org/discourse-server/viewtopic.php?f=2&t=17985 basically: ,---- | The magick_wand.h header file was deprecated after ImageMagick version 6. Its still included in the distribution but probably should not be used since it will be removed in version 7 of ImageMagick (due in 3-4 years). It should not be a problem. Change your configure.ac file to check for MagickWand.h then use a conditional compile, something like: | | #if defined (HAVE_MAGICKWAND_H) | #include | #else | #include | #endif /* HAVE_MAGICKWAND_H */ `---- -- Joakim Verona From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 08 14:11:03 2011 Received: (at 7955) by debbugs.gnu.org; 8 Feb 2011 19:11:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pmsxr-0006iC-CJ for submit@debbugs.gnu.org; Tue, 08 Feb 2011 14:11:03 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pmsxq-0006hk-2M for 7955@debbugs.gnu.org; Tue, 08 Feb 2011 14:11:02 -0500 Received: from localhost ([127.0.0.1]:45344) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pmt6G-0004t4-1H; Tue, 08 Feb 2011 14:19:44 -0500 From: Glenn Morris To: joakim@verona.se Subject: Re: bug#7955: reply from the IM team References: <2evd137anm.fsf@fencepost.gnu.org> X-Spook: Blowfish Craig Livingstone enforcers White Water Aladdin X-Ran: >lzy!Ybnmi:glIl7Vh6]v-;VDy*V7;)y,t.tf875\1X.gry X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 08 Feb 2011 14:19:43 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) OK, so can you implement that then? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 11 18:29:45 2011 Received: (at 7955) by debbugs.gnu.org; 11 Feb 2011 23:29:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Po2Qq-0004QU-Q0 for submit@debbugs.gnu.org; Fri, 11 Feb 2011 18:29:45 -0500 Received: from iwfs.imcode.com ([82.115.149.64] helo=gate.verona.se) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Po2Qn-0004QH-M4 for 7955@debbugs.gnu.org; Fri, 11 Feb 2011 18:29:42 -0500 Received: from chopper (IDENT:1005@localhost [127.0.0.1]) by gate.verona.se (8.13.4/8.11.4) with ESMTP id p1BNcUsN001513; Sat, 12 Feb 2011 00:38:30 +0100 From: joakim@verona.se To: 7955@debbugs.gnu.org, rgm@gnu.org Subject: patch for imagemagick header rename User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Date: Sat, 12 Feb 2011 00:38:30 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 7955 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) I have a patch attempt now. I was going to test it and push it to the imagemagick branch but experienced some infuriating setbacks. If you could help me test and commit that would be spectacular. === modified file 'src/image.c' --- src/image.c 2011-02-01 19:46:21 +0000 +++ src/image.c 2011-02-11 23:23:42 +0000 @@ -7452,7 +7452,12 @@ /* The GIF library also defines DrawRectangle, but its never used in Emacs. Therefore rename the function so it doesnt collide with ImageMagick. */ #define DrawRectangle DrawRectangleGif +#if defined (HAVE_WAND_MAGICKWAND_H) #include +#else +#include +#endif /* HAVE_MAGICKWAND_H */ + /* imagemagick_load_image is a helper function for imagemagick_load, which does the actual loading given contents and size, apart from === modified file 'configure.in' --- configure.in 2011-01-31 23:54:50 +0000 +++ configure.in 2011-02-11 23:20:24 +0000 @@ -1832,6 +1832,7 @@ CFLAGS="$CFLAGS $IMAGEMAGICK_CFLAGS" LIBS="$IMAGEMAGICK_LIBS $LIBS" AC_CHECK_FUNCS(MagickExportImagePixels) + AC_CHECK_HEADERS(wand/MagickWand.h) fi fi fi -- Joakim Verona From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 11 20:02:58 2011 Received: (at 7955) by debbugs.gnu.org; 12 Feb 2011 01:02:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Po3t3-0006Rp-P2 for submit@debbugs.gnu.org; Fri, 11 Feb 2011 20:02:57 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Po3t1-0006Re-Ui for 7955@debbugs.gnu.org; Fri, 11 Feb 2011 20:02:56 -0500 Received: from localhost ([127.0.0.1]:41242) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Po41a-0006bL-Dh; Fri, 11 Feb 2011 20:11:46 -0500 From: Glenn Morris To: joakim@verona.se Subject: Re: patch for imagemagick header rename References: X-Spook: embassy domestic disruption monarchist Ft. Knox blackjack X-Ran: SprnT>\Z+uZ/5b8KF9:L53&Fl?-_Y1C[w$|":%#Pe8>4 User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Seems fine on RHEL5. On RHEL4, build still fails. configure says: checking IMAGEMAGICK_CFLAGS... checking IMAGEMAGICK_LIBS... -lWand -lMagick checking for MagickExportImagePixels... no checking wand/MagickWand.h usability... no checking wand/MagickWand.h presence... no checking for wand/MagickWand.h... no Does Emacs use imagemagick? yes make says: image.c: In function `imagemagick_load_image': image.c:7521: warning: implicit declaration of function `MagickWandGenesis' image.c:7525: warning: implicit declaration of function `MagickSetResolution' image.c:7532: warning: implicit declaration of function `MagickPingImageBlob' image.c:7560: warning: implicit declaration of function `AcquireExceptionInfo' image.c:7560: warning: assignment makes pointer from integer without a cast image.c:7725: warning: implicit declaration of function `PixelGetMagickColor' image.c:7809: warning: implicit declaration of function `MagickWandTerminus' image.c: In function `Fimagemagick_types': image.c:7899: error: too many arguments to function `GetMagickList' make[1]: *** [image.o] Error 1 /usr/include/magick/magick.h says: **GetMagickList(const char *,unsigned long *), Looks like it may be best for configure to check for a minimum imagemagick version. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 12 17:30:28 2011 Received: (at 7955) by debbugs.gnu.org; 12 Feb 2011 22:30:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PoNz2-0006ds-3S for submit@debbugs.gnu.org; Sat, 12 Feb 2011 17:30:28 -0500 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PoNz0-0006TB-3q for 7955@debbugs.gnu.org; Sat, 12 Feb 2011 17:30:26 -0500 Received: from furball (c-71-192-165-84.hsd1.ct.comcast.net [71.192.165.84]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1CMdIB7001444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 12 Feb 2011 17:39:18 -0500 Received: by furball (Postfix, from userid 1000) id D38AF1605B7; Sat, 12 Feb 2011 17:39:15 -0500 (EST) From: Chong Yidong To: Glenn Morris Subject: Re: bug#7955: patch for imagemagick header rename References: Date: Sat, 12 Feb 2011 17:39:15 -0500 In-Reply-To: (Glenn Morris's message of "Fri, 11 Feb 2011 20:11:46 -0500") Message-ID: <87mxm0x4h8.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org, joakim@verona.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Glenn Morris writes: > Seems fine on RHEL5. On RHEL4, build still fails. > > configure says: > > checking IMAGEMAGICK_CFLAGS... > checking IMAGEMAGICK_LIBS... -lWand -lMagick > checking for MagickExportImagePixels... no > checking wand/MagickWand.h usability... no > checking wand/MagickWand.h presence... no > checking for wand/MagickWand.h... no > Does Emacs use imagemagick? yes ImageMagick-6.0 is almost 7 years old. Let's just set HAVE_IMAGEMAGICK back to "no" if AC_CHECK_HEADER doesn't find MagickWand.h, and not try to handle the magick_wand.h case. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 12 18:28:23 2011 Received: (at 7955) by debbugs.gnu.org; 12 Feb 2011 23:28:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PoOt4-00083q-L8 for submit@debbugs.gnu.org; Sat, 12 Feb 2011 18:28:23 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PoOt1-00083N-Kn for 7955@debbugs.gnu.org; Sat, 12 Feb 2011 18:28:20 -0500 Received: from localhost ([127.0.0.1]:52744) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PoP1c-00083i-R9; Sat, 12 Feb 2011 18:37:12 -0500 From: Glenn Morris To: Chong Yidong Subject: Re: bug#7955: patch for imagemagick header rename References: <87mxm0x4h8.fsf@stupidchicken.com> X-Spook: Capricorn infowar Peking bullion EuroFed Tony Blair X-Ran: @[(Xk8MjqxG|-.pk2uYa.31th"s User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org, joakim@verona.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Chong Yidong wrote: > ImageMagick-6.0 is almost 7 years old. Let's just set HAVE_IMAGEMAGICK > back to "no" if AC_CHECK_HEADER doesn't find MagickWand.h, and not try > to handle the magick_wand.h case. I'm fine with not supporting old versions, but AFAIK we have no idea if an ImageMagick with MagickWand.h also satisfies all the other assumptions Emacs has made about the API. So, again, I think it is better if configure tests for the minimum version of ImageMagick that is known to work. As a data point, 6.2.8, which is over 4 years old, seems fine. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 12 19:19:44 2011 Received: (at 7955) by debbugs.gnu.org; 13 Feb 2011 00:19:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PoPgm-0000kO-8N for submit@debbugs.gnu.org; Sat, 12 Feb 2011 19:19:44 -0500 Received: from iwfs.imcode.com ([82.115.149.64] helo=gate.verona.se) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PoPgk-0000kB-NX for 7955@debbugs.gnu.org; Sat, 12 Feb 2011 19:19:43 -0500 Received: from chopper (IDENT:1005@localhost [127.0.0.1]) by gate.verona.se (8.13.4/8.11.4) with ESMTP id p1D0SYkc003735; Sun, 13 Feb 2011 01:28:34 +0100 From: joakim@verona.se To: Chong Yidong Subject: Re: bug#7955: patch for imagemagick header rename In-Reply-To: <87mxm0x4h8.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 12 Feb 2011 17:39:15 -0500") References: <87mxm0x4h8.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Date: Sun, 13 Feb 2011 01:28:34 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) Chong Yidong writes: > Glenn Morris writes: > >> Seems fine on RHEL5. On RHEL4, build still fails. >> >> configure says: >> >> checking IMAGEMAGICK_CFLAGS... >> checking IMAGEMAGICK_LIBS... -lWand -lMagick >> checking for MagickExportImagePixels... no >> checking wand/MagickWand.h usability... no >> checking wand/MagickWand.h presence... no >> checking for wand/MagickWand.h... no >> Does Emacs use imagemagick? yes > > ImageMagick-6.0 is almost 7 years old. Let's just set HAVE_IMAGEMAGICK > back to "no" if AC_CHECK_HEADER doesn't find MagickWand.h, and not try > to handle the magick_wand.h case. I managed to push to the imagemagick branch. it checks for IM version now. Im still not sure which version to require yet though so I just picked one. -- Joakim Verona From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 15:04:19 2011 Received: (at 7955) by debbugs.gnu.org; 14 Feb 2011 20:04:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp4eh-0006j7-Jf for submit@debbugs.gnu.org; Mon, 14 Feb 2011 15:04:19 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp4eg-0006iw-OB for 7955@debbugs.gnu.org; Mon, 14 Feb 2011 15:04:19 -0500 Received: from localhost ([127.0.0.1]:47095) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pp4nM-0005EF-5d; Mon, 14 Feb 2011 15:13:16 -0500 From: Glenn Morris To: joakim@verona.se Subject: Re: bug#7955: patch for imagemagick header rename References: <87mxm0x4h8.fsf@stupidchicken.com> X-Spook: MIT-LL class struggle cypherpunk Axis of Evil CIDA World X-Ran: -&%hq_g>MW.mT{fgNmZ75_pS6]U%Pn<+D?OLM`,^@cg!jPFqRhffBS\mMq;Na-Yr0/q,=a X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 14 Feb 2011 15:13:15 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) joakim@verona.se wrote: > I managed to push to the imagemagick branch. Why are you still using that branch? From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 15:28:16 2011 Received: (at 7955) by debbugs.gnu.org; 14 Feb 2011 20:28:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp51s-0007Ft-Cv for submit@debbugs.gnu.org; Mon, 14 Feb 2011 15:28:16 -0500 Received: from iwfs.imcode.com ([82.115.149.64] helo=gate.verona.se) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pp51q-0007Fg-M9 for 7955@debbugs.gnu.org; Mon, 14 Feb 2011 15:28:15 -0500 Received: from chopper (IDENT:1005@localhost [127.0.0.1]) by gate.verona.se (8.13.4/8.11.4) with ESMTP id p1EKbBdS014084; Mon, 14 Feb 2011 21:37:11 +0100 From: joakim@verona.se To: Glenn Morris Subject: Re: bug#7955: patch for imagemagick header rename References: <87mxm0x4h8.fsf@stupidchicken.com> Date: Mon, 14 Feb 2011 21:37:11 +0100 In-Reply-To: (Glenn Morris's message of "Mon, 14 Feb 2011 15:13:15 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) Glenn Morris writes: > joakim@verona.se wrote: > >> I managed to push to the imagemagick branch. > > Why are you still using that branch? I thought it was suitable to work on a branch since I find the autoconf machinery to be brittle and I'm not even able to test the patch properly atm. The branch has been updated from trunk so I thought it was ok. Why is it a concern? -- Joakim Verona From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 14 21:42:49 2011 Received: (at 7955) by debbugs.gnu.org; 15 Feb 2011 02:42:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PpAsL-0003iq-O7 for submit@debbugs.gnu.org; Mon, 14 Feb 2011 21:42:49 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PpAsJ-0003iW-Dl for 7955@debbugs.gnu.org; Mon, 14 Feb 2011 21:42:47 -0500 Received: from localhost ([127.0.0.1]:40976) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PpB0z-0003yY-KF; Mon, 14 Feb 2011 21:51:45 -0500 From: Glenn Morris To: joakim@verona.se Subject: Re: bug#7955: patch for imagemagick header rename References: <87mxm0x4h8.fsf@stupidchicken.com> X-Spook: SAFE Bruxelles Craig Livingstone RSA AK-47 BLU-97 A/B X-Ran: #>mz3bk0,1K:8A{8Ta{kEn7m[4)*SNkN=bmH|D7W3y8[M;oYyFk{&|T0@#-EgsJek.yAJ= X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 14 Feb 2011 21:51:45 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) joakim@verona.se wrote: > I thought it was suitable to work on a branch since I find the autoconf > machinery to be brittle and I'm not even able to test the patch properly > atm. The branch has been updated from trunk so I thought it was ok. > > Why is it a concern? I'm not concerned, just seems like it makes more work to continue using a branch after the feature in question has been merged to the trunk. There are several uses of a ">=" test with PKG_CHECK_MODULES in configure already, so I think you can feel pretty confident about adding another. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 07 17:00:10 2011 Received: (at 7955) by debbugs.gnu.org; 7 Apr 2011 21:00:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7wJG-00014l-AY for submit@debbugs.gnu.org; Thu, 07 Apr 2011 17:00:10 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q7wJE-00014J-82 for 7955@debbugs.gnu.org; Thu, 07 Apr 2011 17:00:08 -0400 Received: from localhost ([127.0.0.1]:33028) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7wJ7-000140-1C; Thu, 07 Apr 2011 17:00:01 -0400 From: Glenn Morris To: joakim@verona.se Subject: Re: bug#7955: patch for imagemagick header rename References: <87mxm0x4h8.fsf@stupidchicken.com> X-Spook: Treasury clandestine fissionable Gazprom corporate X-Ran: ,45|vI/KSqYyY>2~+J-$q[jSiu]O3NRaa{SsLEXU?e=5"s12ab.Z'qw"s5{a-R,2q$KZ]2 X-Hue: yellow X-Attribution: GM Date: Thu, 07 Apr 2011 17:00:00 -0400 In-Reply-To: (Glenn Morris's message of "Mon, 14 Feb 2011 21:51:45 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 7955 Cc: 7955@debbugs.gnu.org, Chong Yidong X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Please can we have this fix installed in the trunk and close this report. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 11 23:56:27 2011 Received: (at 7955-done) by debbugs.gnu.org; 12 Apr 2011 03:56:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q9UiJ-0001G1-LY for submit@debbugs.gnu.org; Mon, 11 Apr 2011 23:56:27 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q9UiG-0001Fn-S8 for 7955-done@debbugs.gnu.org; Mon, 11 Apr 2011 23:56:25 -0400 Received: from localhost ([127.0.0.1]:36368) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9UiA-0003oN-MG; Mon, 11 Apr 2011 23:56:18 -0400 From: Glenn Morris To: 7955-done@debbugs.gnu.org Subject: Re: bug#7955: patch for imagemagick header rename References: <87mxm0x4h8.fsf@stupidchicken.com> X-Spook: illuminati propaganda industrial espionage csim JUWTF X-Ran: &a)I`N5N"D?[s5ROa\9Qx(uU[(GG;l~DNK(a{0Aj^vWAz_J['`%0-s%JSi`}9Vb\;v`AG< X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 11 Apr 2011 23:56:18 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: 7955-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) Version: 24.1 Done. From unknown Sat Aug 16 18:32:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 10 May 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator