From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 01 07:33:03 2011 Received: (at submit) by debbugs.gnu.org; 1 Feb 2011 12:33:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkFPr-0004nl-95 for submit@debbugs.gnu.org; Tue, 01 Feb 2011 07:33:03 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PkFPp-0004nF-4I for submit@debbugs.gnu.org; Tue, 01 Feb 2011 07:33:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkFXv-0004Xh-7j for submit@debbugs.gnu.org; Tue, 01 Feb 2011 07:41:24 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:37884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkFXu-0004Xd-V9 for submit@debbugs.gnu.org; Tue, 01 Feb 2011 07:41:23 -0500 Received: from [140.186.70.92] (port=44733 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PkFXt-0002d4-KN for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2011 07:41:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PkFXp-0004WI-VE for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2011 07:41:21 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]:34242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PkFXp-0004Un-8b for bug-gnu-emacs@gnu.org; Tue, 01 Feb 2011 07:41:17 -0500 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id 143AB82283 for ; Tue, 1 Feb 2011 13:41:09 +0100 (CET) Received: by silenus.orebokech.com (Postfix, from userid 1000) id DDBAB2E0198; Tue, 1 Feb 2011 13:41:08 +0100 (CET) From: Romain Francoise To: bug-gnu-emacs@gnu.org Subject: 24.0.50; crash in find_interval Organization: orebokech dot com X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 212.27.42.6 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 199.232.76.165 X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.7 (----) Emacs from Git as of revision 4817a832f49, which corresponds to the bzr trunk as of revision 103065, crashes in find_interval() when I move around grep buffers: | Core was generated by `./src/emacs -nw'. | Program terminated with signal 6, Aborted. | #0 0x00007fc45c00c447 in kill () at ../sysdeps/unix/syscall-template.S:82 | 82 ../sysdeps/unix/syscall-template.S: No such file or directory. | in ../sysdeps/unix/syscall-template.S | (gdb) bt | #0 0x00007fc45c00c447 in kill () at ../sysdeps/unix/syscall-template.S:82 | #1 0x000000000055b203 in fatal_error_signal (sig=6) at emacs.c:343 | #2 | #3 0x00007fc45c00c447 in kill () at ../sysdeps/unix/syscall-template.S:82 | #4 0x000000000055b222 in abort () at emacs.c:372 | #5 0x0000000000669960 in find_interval (tree=0x0, position=1559343) | at intervals.c:635 | #6 0x000000000066c116 in set_point_both (charpos=1559343, bytepos=1559964) | at intervals.c:2008 | #7 0x000000000048da2d in window_scroll_line_based (window=43271749, n=-49, | whole=1, noerror=0) at window.c:5125 | #8 0x000000000048c726 in window_scroll (window=43271749, n=-1, whole=1, | noerror=0) at window.c:4715 | #9 0x000000000048dde8 in scroll_command (n=12601730, direction=-1) | at window.c:5248 | #10 0x000000000048deb6 in Fscroll_down (arg=12601730) at window.c:5282 | #11 0x00000000005ffb32 in Ffuncall (nargs=2, args=0x7fff5c4c84b0) | at eval.c:2842 | #12 0x000000000064bac7 in Fbyte_code (bytestr=10424209, vector=10424245, | maxdepth=12) at bytecode.c:676 | #13 0x0000000000600430 in funcall_lambda (fun=10424149, nargs=1, | arg_vector=0x7fff5c4c8958) at eval.c:3028 | #14 0x00000000005ffd3f in Ffuncall (nargs=2, args=0x7fff5c4c8950) | at eval.c:2891 | #15 0x00000000005fa4ad in Fcall_interactively (function=12963906, | record_flag=12601730, keys=12649141) at callint.c:842 | #16 0x00000000005ffb88 in Ffuncall (nargs=4, args=0x7fff5c4c8cd0) | at eval.c:2849 | #17 0x00000000005ff539 in call3 (fn=12788898, arg1=12963906, arg2=12601730, | arg3=12601730) at eval.c:2674 | #18 0x000000000057250c in Fcommand_execute (cmd=12963906, | record_flag=12601730, keys=12601730, special=12601730) at keyboard.c:10180 | #19 0x000000000055ff27 in command_loop_1 () at keyboard.c:1528 | #20 0x00000000005fccad in internal_condition_case ( | bfun=0x55f711 , handlers=12653922, | hfun=0x55f019 ) at eval.c:1408 | #21 0x000000000055f412 in command_loop_2 (ignore=12601730) at keyboard.c:1129 | #22 0x00000000005fc64a in internal_catch (tag=12649938, | func=0x55f3ec , arg=12601730) at eval.c:1152 | #23 0x000000000055f3c5 in command_loop () at keyboard.c:1108 | #24 0x000000000055eb50 in recursive_edit_1 () at keyboard.c:731 | #25 0x000000000055ed03 in Frecursive_edit () at keyboard.c:793 | #26 0x000000000055d04d in main (argc=2, argv=0x7fff5c4c96d8) at emacs.c:1682 | (gdb) Steps to reproduce: 1) Start ./src/emacs -nw in the top-level of the source tree 2) Do M-x grep-find RET emacs RET 3) Do C-x 0 to maximize the window with *grep* buffer 4) Move around with C-v/M-v until it crashes This may be related bug #7920, but I'm not sure. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 07:25:20 2011 Received: (at 7952) by debbugs.gnu.org; 9 Mar 2011 12:25:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxIS8-0001wW-Ie for submit@debbugs.gnu.org; Wed, 09 Mar 2011 07:25:20 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxIS5-0001wE-Cr for 7952@debbugs.gnu.org; Wed, 09 Mar 2011 07:25:18 -0500 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id 2B91B824BE for <7952@debbugs.gnu.org>; Wed, 9 Mar 2011 13:25:06 +0100 (CET) Received: by silenus.orebokech.com (Postfix, from userid 1000) id EF4A32E00FE; Wed, 9 Mar 2011 13:25:05 +0100 (CET) From: Romain Francoise To: 7952@debbugs.gnu.org Subject: Re: bug#7952: 24.0.50; crash in find_interval Organization: orebokech dot com References: X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM (Romain Francoise's message of "Tue, 01 Feb 2011 13:41:08 +0100") Message-ID: <87r5ag7a72.fsf@silenus.orebokech.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 7952 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) I tried to update Emacs again, and this bug is still there. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 08:47:13 2011 Received: (at 7952) by debbugs.gnu.org; 9 Mar 2011 13:47:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxJjN-0004lS-17 for submit@debbugs.gnu.org; Wed, 09 Mar 2011 08:47:13 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxJjK-0004lC-Mn for 7952@debbugs.gnu.org; Wed, 09 Mar 2011 08:47:11 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LHS00E00M7HXB00@a-mtaout21.012.net.il> for 7952@debbugs.gnu.org; Wed, 09 Mar 2011 15:46:46 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.58.59]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LHS00EX6M9T6QB0@a-mtaout21.012.net.il>; Wed, 09 Mar 2011 15:46:43 +0200 (IST) Date: Wed, 09 Mar 2011 15:46:42 +0200 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: <87r5ag7a72.fsf@silenus.orebokech.com> X-012-Sender: halo1@inter.net.il To: Romain Francoise Message-id: <83ipvspfst.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 7952 Cc: 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Romain Francoise > Date: Wed, 09 Mar 2011 13:25:05 +0100 > Cc: > > I tried to update Emacs again, and this bug is still there. This crash happens here: if (INTERVAL_HAS_OBJECT (tree)) { Lisp_Object parent; GET_INTERVAL_OBJECT (parent, tree); if (BUFFERP (parent)) relative_position -= BUF_BEG (XBUFFER (parent)); } if (relative_position > TOTAL_LENGTH (tree)) abort (); <<<<<<<<<<<<<<<<<<<<<<<<<< Can you show the value of relative_position and of TOTAL_LENGTH (tree)? FWIW, I couldn't crash today's build on MS-Windows using your recipe. Perhaps I didn't move around enough -- does it take you a lot? From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 09 10:16:49 2011 Received: (at 7952) by debbugs.gnu.org; 9 Mar 2011 15:16:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxL85-00079G-0P for submit@debbugs.gnu.org; Wed, 09 Mar 2011 10:16:49 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PxL80-00078y-Rx for 7952@debbugs.gnu.org; Wed, 09 Mar 2011 10:16:47 -0500 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id A8DC0825EB; Wed, 9 Mar 2011 16:16:34 +0100 (CET) Received: by silenus.orebokech.com (Postfix, from userid 1000) id 788FE2E00FC; Wed, 9 Mar 2011 16:16:33 +0100 (CET) From: Romain Francoise To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Organization: orebokech dot com References: <87r5ag7a72.fsf@silenus.orebokech.com> <83ipvspfst.fsf@gnu.org> X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM (Eli Zaretskii's message of "Wed, 09 Mar 2011 15:46:42 +0200") Message-ID: <87k4g8729a.fsf@silenus.orebokech.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 7952 Cc: 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Hi Eli, Thanks for your help. Eli Zaretskii writes: > Can you show the value of relative_position and of TOTAL_LENGTH > (tree)? As you can see from the backtrace in my original report, tree is NULL when `find_interval' is called, so TOTAL_LENGTH(tree) is 0. (gdb) f 5 #5 0x00000000006612b8 in find_interval (tree=0x0, position=1626800) at intervals.c:635 635 abort (); /* Paranoia */ (gdb) p relative_position $1 = 1626799 (gdb) p tree $2 = (INTERVAL) 0x0 (gdb) p position $3 = 1626800 (gdb) > Perhaps I didn't move around enough -- does it take you a lot? It's usually enough to do M-> and M-v, but sometimes it takes a little more moving around to get it to crash (but it never takes more than a few seconds). From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 18 15:20:09 2011 Received: (at 7952) by debbugs.gnu.org; 18 Mar 2011 19:20:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fDV-0007qx-9O for submit@debbugs.gnu.org; Fri, 18 Mar 2011 15:20:09 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fDT-0007qM-1D for 7952@debbugs.gnu.org; Fri, 18 Mar 2011 15:20:08 -0400 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id C97DA82342; Fri, 18 Mar 2011 20:19:56 +0100 (CET) Received: by silenus.orebokech.com (Postfix, from userid 1000) id 961C62E0307; Fri, 18 Mar 2011 20:19:55 +0100 (CET) From: Romain Francoise To: 7952@debbugs.gnu.org Subject: Re: bug#7952: 24.0.50; crash in find_interval Organization: orebokech dot com References: <87r5ag7a72.fsf@silenus.orebokech.com> X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM (Romain Francoise's message of "Wed, 09 Mar 2011 13:25:05 +0100") Message-ID: <87lj0c1bj8.fsf@silenus.orebokech.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 7952 Cc: Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Still crashes as of revision 103683, but now it hits the abort at marker.c:130 rather than the one at intervals.c:635. I tried bisecting it, without success so far. Program terminated with signal 6, Aborted. #0 0x00007f5b748c0447 in kill () at ../sysdeps/unix/syscall-template.S:82 82 ../sysdeps/unix/syscall-template.S: No such file or directory. in ../sysdeps/unix/syscall-template.S (gdb) bt #0 0x00007f5b748c0447 in kill () at ../sysdeps/unix/syscall-template.S:82 #1 0x0000000000558617 in fatal_error_signal (sig=6) at emacs.c:342 #2 #3 0x00007f5b748c0447 in kill () at ../sysdeps/unix/syscall-template.S:82 #4 0x0000000000558636 in abort () at emacs.c:371 #5 0x00000000005956cd in buf_charpos_to_bytepos (b=0x11511c0, charpos=1332719) at marker.c:130 #6 0x00000000005b7a51 in fast_looking_at (regexp=13575105, pos=1331082, pos_byte=1331194, limit=1332719, limit_byte=-1, string=12593666) at search.c:566 #7 0x000000000066fc57 in autocmp_chars (rule=16637925, charpos=1331082, bytepos=1331194, limit=1332719, win=0x117e910, face=0x114e3d0, string=12593666) at composite.c:916 #8 0x0000000000671e46 in composition_reseat_it (cmp_it=0x7fff61245610, charpos=1331082, bytepos=1331194, endpos=1332719, w=0x117e910, face=0x114e3d0, string=12593666) at composite.c:1266 #9 0x000000000044114e in next_element_from_buffer (it=0x7fff61244de0) at xdisp.c:6693 #10 0x0000000000440f5e in next_element_from_buffer (it=0x7fff61244de0) at xdisp.c:6660 #11 0x000000000043dd2c in get_next_display_element (it=0x7fff61244de0) at xdisp.c:5630 #12 0x0000000000441a43 in move_it_in_display_line_to (it=0x7fff61244de0, to_charpos=1332455, to_x=-1, op=MOVE_TO_POS) at xdisp.c:6956 #13 0x0000000000443274 in move_it_to (it=0x7fff61244de0, to_charpos=1332455, to_x=-1, to_y=25, to_vpos=-1, op=10) at xdisp.c:7406 #14 0x0000000000443e5f in move_it_vertically (it=0x7fff61244de0, dy=8) at xdisp.c:7691 #15 0x0000000000443d94 in move_it_vertically_backward (it=0x7fff61244de0, dy=25) at xdisp.c:7665 #16 0x0000000000453c5e in redisplay_window (window=18344213, just_this_one_p=0) at xdisp.c:14205 #17 0x000000000044e4ed in redisplay_window_0 (window=18344213) at xdisp.c:12362 #18 0x00000000005f72c8 in internal_condition_case_1 ( bfun=0x44e4ae , arg=18344213, handlers=12564150, hfun=0x44e47f ) at eval.c:1455 #19 0x000000000044e460 in redisplay_windows (window=18344213) at xdisp.c:12342 #20 0x000000000044d47d in redisplay_internal (preserve_echo_area=1) at xdisp.c:11919 #21 0x000000000044dc97 in redisplay_preserve_echo_area (from_where=12) at xdisp.c:12170 #22 0x0000000000651789 in wait_reading_process_output (time_limit=120, microsecs=0, read_kbd=-1, do_display=1, wait_for_cell=12593666, wait_proc=0x0, just_wait_proc=0) at process.c:4974 #23 0x0000000000421e9f in sit_for (timeout=480, reading=1, do_display=1) at dispnew.c:6017 ... From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 18 15:38:29 2011 Received: (at 7952) by debbugs.gnu.org; 18 Mar 2011 19:38:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fVF-0008Fm-Aq for submit@debbugs.gnu.org; Fri, 18 Mar 2011 15:38:29 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0fVD-0008Fa-Aq for 7952@debbugs.gnu.org; Fri, 18 Mar 2011 15:38:28 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LI900C00QBWVF00@a-mtaout22.012.net.il> for 7952@debbugs.gnu.org; Fri, 18 Mar 2011 21:37:28 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.131.120]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LI900CUPQIE2Q80@a-mtaout22.012.net.il>; Fri, 18 Mar 2011 21:37:28 +0200 (IST) Date: Fri, 18 Mar 2011 21:37:31 +0200 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: <87lj0c1bj8.fsf@silenus.orebokech.com> X-012-Sender: halo1@inter.net.il To: Romain Francoise Message-id: <8339mkrzic.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 7952 Cc: 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Romain Francoise > Cc: Eli Zaretskii > Date: Fri, 18 Mar 2011 20:19:55 +0100 > > Still crashes as of revision 103683, but now it hits the abort at > marker.c:130 rather than the one at intervals.c:635. Is this repeatable enough to present a recipe starting from "emacs -Q"? This backtrace doesn't look similar to the previous one at all, FWIW. It happens in a totally different and unrelated place of the display engine. So why do you think it's the same problem? From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 18 16:45:45 2011 Received: (at 7952) by debbugs.gnu.org; 18 Mar 2011 20:45:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0gYK-0001G7-Rn for submit@debbugs.gnu.org; Fri, 18 Mar 2011 16:45:45 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0gYH-0001Ft-HY for 7952@debbugs.gnu.org; Fri, 18 Mar 2011 16:45:42 -0400 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id 64F2F82293; Fri, 18 Mar 2011 21:45:31 +0100 (CET) Received: by silenus.orebokech.com (Postfix, from userid 1000) id 2432B2E0413; Fri, 18 Mar 2011 21:45:30 +0100 (CET) From: Romain Francoise To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Organization: orebokech dot com References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM (Eli Zaretskii's message of "Fri, 18 Mar 2011 21:37:31 +0200") Message-ID: <87ei6417kl.fsf@silenus.orebokech.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7952 Cc: 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Hi Eli, Eli Zaretskii writes: > Is this repeatable enough to present a recipe starting from > "emacs -Q"? Sure, the recipe is the same as in my opening message: 1) Start ./src/emacs -Q -nw in the top-level of the source tree 2) Do M-x grep-find RET emacs RET 3) Do C-x 0 to maximize the window with the *grep* buffer 4) Move around with C-v, M-v, M-< or M-> until it crashes (e.g. M-> M-v) Also, this is not specific to my machine because I can reproduce it on fencepost. I generated a core file for you (~rfrancoise/emacs/core) if you want to have a closer look. > This backtrace doesn't look similar to the previous one at all, FWIW. > It happens in a totally different and unrelated place of the display > engine. So why do you think it's the same problem? Because it happens in the same circumstances. But actually, I've now tried it a few more times and hit the other abort again, once (the one at intervals.c:635)... so it could be two bugs, or a bug that results in two different aborts. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 19 06:38:20 2011 Received: (at 7952) by debbugs.gnu.org; 19 Mar 2011 10:38:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0tY3-0002Th-7K for submit@debbugs.gnu.org; Sat, 19 Mar 2011 06:38:20 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0tY0-0002TS-1g for 7952@debbugs.gnu.org; Sat, 19 Mar 2011 06:38:17 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LIA00600VUBD300@a-mtaout23.012.net.il> for 7952@debbugs.gnu.org; Sat, 19 Mar 2011 12:37:53 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.131.120]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LIA006MVW7007C0@a-mtaout23.012.net.il>; Sat, 19 Mar 2011 12:37:53 +0200 (IST) Date: Sat, 19 Mar 2011 12:37:51 +0200 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: <87ei6417kl.fsf@silenus.orebokech.com> X-012-Sender: halo1@inter.net.il To: Romain Francoise Message-id: <83r5a3qtts.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 7952 Cc: 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.7 (-) > From: Romain Francoise > Cc: 7952@debbugs.gnu.org > Date: Fri, 18 Mar 2011 21:45:30 +0100 > > Also, this is not specific to my machine because I can > reproduce it on fencepost. I generated a core file for you > (~rfrancoise/emacs/core) if you want to have a closer look. Now, that's one weird crash. Observe: (gdb) bt 10 #0 0x00007fd2af56dd57 in kill () from /lib/libc.so.6 #1 0x000000000053bb1d in fatal_error_signal (sig=6) at emacs.c:342 #2 #3 0x00007fd2af56dd57 in kill () from /lib/libc.so.6 #4 0x000000000053bb3c in abort () at emacs.c:371 #5 0x0000000000648688 in find_interval (tree=0x0, position=255426) at intervals.c:635 #6 0x000000000064af6f in set_point_both (charpos=255426, bytepos=255426) at intervals.c:2007 #7 0x000000000048a9b2 in window_scroll_line_based (window=18497157, n=-49, whole=1, noerror=0) at window.c:5123 #8 0x00000000004896cf in window_scroll (window=18497157, n=-1, whole=1, noerror=0) at window.c:4713 #9 0x000000000048ad6d in scroll_command (n=12466818, direction=-1) at window.c:5246 (More stack frames follow...) (gdb) frame 6 #6 0x000000000064af6f in set_point_both (charpos=255426, bytepos=255426) at intervals.c:2007 (gdb) l 2007 to = find_interval (BUF_INTERVALS (current_buffer), charpos); 2008 if (charpos == BEGV) 2009 toprev = 0; 2010 else if (to && to->position == charpos) 2011 toprev = previous_interval (to); 2012 else 2013 toprev = to; 2014 2015 buffer_point = (PT == ZV ? ZV - 1 : PT); 2016 (gdb) p current_buffer->text->intervals $24 = (INTERVAL) 0x314b4c0 (gdb) down #5 0x0000000000648688 in find_interval (tree=0x0, position=255426) at intervals.c:635 (gdb) info address tree Symbol "tree" is a variable in $rax. (gdb) current_buffer->text->intervals is the expansion of "BUF_INTERVALS (current_buffer)" (btw, please use -g3 when you compile an unoptimized version, because then the macro information is present in the debug info in a form that GDB can use, rather than me having to look up the macro in the sources and manually expand it). So BUF_INTERVALS (current_buffer) is 0x314b4c0 in set_point_both, but when find_interval is called with that value as the first argument, the value winds up as zero inside find_interval! The code in find_interval leading to the abort is this: INTERVAL find_interval (register INTERVAL tree, register EMACS_INT position) { /* The distance from the left edge of the subtree at TREE to POSITION. */ register EMACS_INT relative_position; if (NULL_INTERVAL_P (tree)) return NULL_INTERVAL; relative_position = position; if (INTERVAL_HAS_OBJECT (tree)) { Lisp_Object parent; GET_INTERVAL_OBJECT (parent, tree); if (BUFFERP (parent)) relative_position -= BUF_BEG (XBUFFER (parent)); } if (relative_position > TOTAL_LENGTH (tree)) abort (); /* Paranoia */ There's nothing in this code that modifies `tree' in any way. (I even disassembled the code to make sure.) So how come a non-NULL value becomes NULL here? Since this value is passed in a register by the caller and kept in a register from the very beginning of the function, not even some missing GCPRO somewhere could explain this. What am I missing? Ideas are welcome. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 19 08:15:01 2011 Received: (at 7952) by debbugs.gnu.org; 19 Mar 2011 12:15:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0v3c-0005JN-P6 for submit@debbugs.gnu.org; Sat, 19 Mar 2011 08:15:01 -0400 Received: from mail-out.m-online.net ([212.18.0.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0v3a-0005JB-95 for 7952@debbugs.gnu.org; Sat, 19 Mar 2011 08:14:59 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id A0E691C1DA0F; Sat, 19 Mar 2011 13:14:52 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id 950A81C00117; Sat, 19 Mar 2011 13:14:52 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id EwuTXTxpbeuj; Sat, 19 Mar 2011 13:14:52 +0100 (CET) Received: from igel.home (ppp-93-104-145-233.dynamic.mnet-online.de [93.104.145.233]) by mail.mnet-online.de (Postfix) with ESMTP; Sat, 19 Mar 2011 13:14:51 +0100 (CET) Received: by igel.home (Postfix, from userid 501) id 6CC8DCA2A0; Sat, 19 Mar 2011 13:14:48 +0100 (CET) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <83r5a3qtts.fsf@gnu.org> X-Yow: I am having FUN... I wonder if it's NET FUN or GROSS FUN? Date: Sat, 19 Mar 2011 13:14:48 +0100 In-Reply-To: <83r5a3qtts.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Mar 2011 12:37:51 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7952 Cc: Romain Francoise , 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Eli Zaretskii writes: > There's nothing in this code that modifies `tree' in any way. (I even > disassembled the code to make sure.) So how come a non-NULL value > becomes NULL here? It isn't, otherwise you would get a crash. > Since this value is passed in a register by the caller and kept in a > register from the very beginning of the function, not even some > missing GCPRO somewhere could explain this. What am I missing? Probably your toolchain is too old to be able to produce complete unwind information. Try setting a breakpoint at the abort line to get a better picture. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 19 08:52:10 2011 Received: (at 7952) by debbugs.gnu.org; 19 Mar 2011 12:52:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0vdZ-000687-Oo for submit@debbugs.gnu.org; Sat, 19 Mar 2011 08:52:09 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0vdW-00067b-3n for 7952@debbugs.gnu.org; Sat, 19 Mar 2011 08:52:07 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LIB000002763W00@a-mtaout20.012.net.il> for 7952@debbugs.gnu.org; Sat, 19 Mar 2011 14:51:23 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.131.120]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LIB00MEH2DKDRD0@a-mtaout20.012.net.il>; Sat, 19 Mar 2011 14:51:23 +0200 (IST) Date: Sat, 19 Mar 2011 14:51:25 +0200 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: X-012-Sender: halo1@inter.net.il To: Andreas Schwab Message-id: <83zkor9stu.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <83r5a3qtts.fsf@gnu.org> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 7952 Cc: romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > From: Andreas Schwab > Cc: Romain Francoise , 7952@debbugs.gnu.org > Date: Sat, 19 Mar 2011 13:14:48 +0100 > > Eli Zaretskii writes: > > > There's nothing in this code that modifies `tree' in any way. (I even > > disassembled the code to make sure.) So how come a non-NULL value > > becomes NULL here? > > It isn't, otherwise you would get a crash. Unless it happens after the place where `tree' is dereferenced. > > Since this value is passed in a register by the caller and kept in a > > register from the very beginning of the function, not even some > > missing GCPRO somewhere could explain this. What am I missing? > > Probably your toolchain is too old to be able to produce complete unwind > information. I doubt that, since it's GDB 7.2. Maybe it's a GCC problem. > Try setting a breakpoint at the abort line to get a better picture. It's a core file. Romain, could you try that, perhaps? In any case, we could look at TOTAL_LENGTH of the pointer in the frame where it has a non-NULL value. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 19 09:19:01 2011 Received: (at 7952) by debbugs.gnu.org; 19 Mar 2011 13:19:02 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0w3Z-0006gc-5G for submit@debbugs.gnu.org; Sat, 19 Mar 2011 09:19:01 -0400 Received: from mail-out.m-online.net ([212.18.0.9]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0w3W-0006gR-Jf for 7952@debbugs.gnu.org; Sat, 19 Mar 2011 09:18:59 -0400 Received: from frontend1.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 169FD1C1D9E4; Sat, 19 Mar 2011 14:18:52 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.8.164]) by mail.m-online.net (Postfix) with ESMTP id DDBA71C00112; Sat, 19 Mar 2011 14:18:52 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.8.164]) (amavisd-new, port 10024) with ESMTP id JqaRhoWdu95t; Sat, 19 Mar 2011 14:18:52 +0100 (CET) Received: from igel.home (ppp-93-104-145-233.dynamic.mnet-online.de [93.104.145.233]) by mail.mnet-online.de (Postfix) with ESMTP; Sat, 19 Mar 2011 14:18:52 +0100 (CET) Received: by igel.home (Postfix, from userid 501) id B6D17CA2A0; Sat, 19 Mar 2011 14:18:51 +0100 (CET) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <83r5a3qtts.fsf@gnu.org> <83zkor9stu.fsf@gnu.org> X-Yow: The Korean War must have been fun. Date: Sat, 19 Mar 2011 14:18:51 +0100 In-Reply-To: <83zkor9stu.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 19 Mar 2011 14:51:25 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7952 Cc: romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Eli Zaretskii writes: > I doubt that, since it's GDB 7.2. Maybe it's a GCC problem. Of course, the unwind information is generated by the compiler. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 19 09:56:37 2011 Received: (at 7952) by debbugs.gnu.org; 19 Mar 2011 13:56:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0wdw-0007WF-Hf for submit@debbugs.gnu.org; Sat, 19 Mar 2011 09:56:36 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0wds-0007W0-Vc for 7952@debbugs.gnu.org; Sat, 19 Mar 2011 09:56:34 -0400 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id 7987382294; Sat, 19 Mar 2011 14:56:22 +0100 (CET) Received: by silenus.orebokech.com (Postfix, from userid 1000) id 4BE942E00FC; Sat, 19 Mar 2011 14:56:21 +0100 (CET) From: Romain Francoise To: Andreas Schwab Subject: Re: bug#7952: 24.0.50; crash in find_interval Organization: orebokech dot com References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <83r5a3qtts.fsf@gnu.org> X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM (Andreas Schwab's message of "Sat, 19 Mar 2011 13:14:48 +0100") Message-ID: <8739mj1aey.fsf@silenus.orebokech.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7952 Cc: Eli Zaretskii , 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Andreas Schwab writes: > Try setting a breakpoint at the abort line to get a better > picture. Thanks, that helped. (gdb) p tree $1 = (INTERVAL) 0x102cdc8 (gdb) p *tree $2 = { total_length = 222096, position = 129685, left = 0x11f4d58, right = 0x1059098, up = { interval = 0xeee915, obj = 15657237 }, up_obj = 1, gcmarkbit = 0, write_protect = 0, visible = 0, front_sticky = 0, rear_sticky = 0, plist = 20446582 } (gdb) p relative_position $3 = 222657 (gdb) p TOTAL_LENGTH (tree) $4 = 222096 (gdb) l 630 if (BUFFERP (parent)) 631 relative_position -= BUF_BEG (XBUFFER (parent)); 632 } 633 634 if (relative_position > TOTAL_LENGTH (tree)) 635 abort (); /* Paranoia */ 636 637 if (!handling_signal) 638 tree = balance_possible_root_interval (tree); 639 (gdb) > Probably your toolchain is too old to be able to produce complete > unwind information. It happens with GCC 4.4.3 (fencepost) and 4.5.2 (my machine), both are x86_64. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 13 17:06:42 2011 Received: (at 7952) by debbugs.gnu.org; 13 Apr 2011 21:06:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QA7Gs-0000xn-3b for submit@debbugs.gnu.org; Wed, 13 Apr 2011 17:06:42 -0400 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QA7Gq-0000xa-14 for 7952@debbugs.gnu.org; Wed, 13 Apr 2011 17:06:40 -0400 Received: from furball (dhcp128036014032.central.yale.edu [128.36.14.32]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p3DL6YI6010306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 13 Apr 2011 17:06:34 -0400 Received: by furball (Postfix, from userid 1000) id DB6D816065B; Wed, 13 Apr 2011 17:06:32 -0400 (EDT) From: Chong Yidong To: Romain Francoise Subject: Re: bug#7952: 24.0.50; crash in find_interval References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> Date: Wed, 13 Apr 2011 17:06:32 -0400 In-Reply-To: <87ei6417kl.fsf@silenus.orebokech.com> (Romain Francoise's message of "Fri, 18 Mar 2011 21:45:30 +0100") Message-ID: <87tye1x3mv.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7952 Cc: Eli Zaretskii , 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Romain Francoise writes: > 1) Start ./src/emacs -Q -nw in the top-level of the source tree > 2) Do M-x grep-find RET emacs RET > 3) Do C-x 0 to maximize the window with the *grep* buffer > 4) Move around with C-v, M-v, M-< or M-> until it crashes (e.g. M-> M-v) I can reproduce it too, and have bisected the crash down to 103013: Stefan Monnier 2011-01-28 [merge] * progmodes/compile.el: Don't use font-lock any more. revno: 103013 [merge] committer: Stefan Monnier branch nick: trunk timestamp: Fri 2011-01-28 17:12:05 -0500 message: * progmodes/compile.el: Don't use font-lock any more. Unfortunately, this is a change in only compile.el, which means the problem somewhere in the C code did not originate in this commit, and is only triggered by it. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 00:36:40 2011 Received: (at 7952) by debbugs.gnu.org; 14 Apr 2011 04:36:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QAEIJ-0004RZ-S0 for submit@debbugs.gnu.org; Thu, 14 Apr 2011 00:36:40 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QAEIH-0004RN-Fp for 7952@debbugs.gnu.org; Thu, 14 Apr 2011 00:36:38 -0400 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QAEIB-0000nS-Q7; Thu, 14 Apr 2011 00:36:31 -0400 Date: Thu, 14 Apr 2011 00:36:31 -0400 Message-Id: From: Eli Zaretskii To: Chong Yidong In-reply-to: <87tye1x3mv.fsf@stupidchicken.com> (message from Chong Yidong on Wed, 13 Apr 2011 17:06:32 -0400) Subject: Re: bug#7952: 24.0.50; crash in find_interval References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 7952 Cc: romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > From: Chong Yidong > Cc: Eli Zaretskii , 7952@debbugs.gnu.org > Date: Wed, 13 Apr 2011 17:06:32 -0400 > > Unfortunately, this is a change in only compile.el, which means the > problem somewhere in the C code did not originate in this commit, and is > only triggered by it. Do you succeed in understanding how the problem in intervals.c came into existence? E.g., did something change BUF_BEG behind the back of intervals.c? How about adding some tracing code to intervals.c and see what comes up there? Btw, does this problem happen only while grep-find runs, or also after it exits? From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 14 09:18:58 2011 Received: (at 7952) by debbugs.gnu.org; 14 Apr 2011 13:18:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QAMRm-0008Gl-GZ for submit@debbugs.gnu.org; Thu, 14 Apr 2011 09:18:58 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QAMRk-0008GX-4u for 7952@debbugs.gnu.org; Thu, 14 Apr 2011 09:18:57 -0400 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id 8F297822B2; Thu, 14 Apr 2011 15:18:45 +0200 (CEST) Received: by silenus.orebokech.com (Postfix, from userid 1000) id 27A992E00F0; Thu, 14 Apr 2011 15:18:44 +0200 (CEST) From: Romain Francoise To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Organization: orebokech dot com References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM (Eli Zaretskii's message of "Thu, 14 Apr 2011 00:36:31 -0400") Message-ID: <87sjtl6kej.fsf@silenus.orebokech.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7952 Cc: Chong Yidong , 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Eli Zaretskii writes: > Btw, does this problem happen only while grep-find runs, or also > after it exits? It also happens when the subprocess is dead. In fact, I just tried saving the *grep* buffer to a file, opening it in a fresh Emacs and it crashed when I did M-> M-v, the first time. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 04:39:26 2011 Received: (at 7952) by debbugs.gnu.org; 26 Apr 2011 08:39:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEdnp-0008CN-Td for submit@debbugs.gnu.org; Tue, 26 Apr 2011 04:39:26 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEdnm-0008C8-K8 for 7952@debbugs.gnu.org; Tue, 26 Apr 2011 04:39:23 -0400 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id 26F35824B5; Tue, 26 Apr 2011 10:39:11 +0200 (CEST) Received: by silenus.orebokech.com (Postfix, from userid 1000) id E64A32E003D; Tue, 26 Apr 2011 10:39:10 +0200 (CEST) From: Romain Francoise To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Organization: orebokech dot com References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM (Eli Zaretskii's message of "Thu, 14 Apr 2011 00:36:31 -0400") Message-ID: <87y62xh0ep.fsf@silenus.orebokech.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7952 Cc: Chong Yidong , 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Any chance some intervals expert could look at this bug? I'm still using an old Emacs copy from January because of it and I would like to update. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 26 13:52:39 2011 Received: (at 7952) by debbugs.gnu.org; 26 Apr 2011 17:52:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEmRD-0004mV-BJ for submit@debbugs.gnu.org; Tue, 26 Apr 2011 13:52:39 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QEmRB-0004mJ-Hq for 7952@debbugs.gnu.org; Tue, 26 Apr 2011 13:52:38 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LK900200TMZ6R00@a-mtaout22.012.net.il> for 7952@debbugs.gnu.org; Tue, 26 Apr 2011 20:52:31 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.59.73]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LK900I7STNH4WN1@a-mtaout22.012.net.il>; Tue, 26 Apr 2011 20:52:31 +0300 (IDT) Date: Tue, 26 Apr 2011 20:52:35 +0300 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: <87y62xh0ep.fsf@silenus.orebokech.com> X-012-Sender: halo1@inter.net.il To: Romain Francoise Message-id: <83pqo899y4.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Romain Francoise > Cc: Chong Yidong , 7952@debbugs.gnu.org > Date: Tue, 26 Apr 2011 10:39:10 +0200 > > Any chance some intervals expert could look at this bug? I'm no expert on this, but I will try this weekend, if no one beats me to it. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 29 14:17:35 2011 Received: (at 7952-done) by debbugs.gnu.org; 29 Apr 2011 18:17:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QFsFz-0007mY-ER for submit@debbugs.gnu.org; Fri, 29 Apr 2011 14:17:35 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QFsFx-0007mM-7T for 7952-done@debbugs.gnu.org; Fri, 29 Apr 2011 14:17:34 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LKF00900EQ2P100@a-mtaout20.012.net.il> for 7952-done@debbugs.gnu.org; Fri, 29 Apr 2011 21:17:20 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.124.150.132]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKF009K7ESU0UD0@a-mtaout20.012.net.il>; Fri, 29 Apr 2011 21:17:20 +0300 (IDT) Date: Fri, 29 Apr 2011 21:17:20 +0300 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: <83pqo899y4.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: romain@orebokech.com, cyd@stupidchicken.com Message-id: <834o5g7wi7.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7952-done Cc: 7952-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > Date: Tue, 26 Apr 2011 20:52:35 +0300 > From: Eli Zaretskii > Cc: cyd@stupidchicken.com, 7952@debbugs.gnu.org > > > From: Romain Francoise > > Cc: Chong Yidong , 7952@debbugs.gnu.org > > Date: Tue, 26 Apr 2011 10:39:10 +0200 > > > > Any chance some intervals expert could look at this bug? > > I'm no expert on this, but I will try this weekend, if no one beats me > to it. I found the reason. It had nothing to do with intervals: in an Emacs compiled with -DENABLE_CHECKING the crash happens earlier, inside set_point_both, because the value of point passed to it is greater than the buffer size. The problem is that the new fontification in Grep buffers can modify buffer text, e.g. when it finds an escape sequence emitted by Grep. The other part of the puzzle is that vertical-motion, called from window_scroll_line_based as part of handling M-v or C-v, enters redisplay, which triggers JIT Lock fontification. Here's the Lisp-level backtrace from GDB; note the call to replace-match: "replace-match" (0x82d760) "progn" (0x82d940) "eval" (0x82da14) "font-lock-fontify-keywords-region" (0x82dc54) "font-lock-default-fontify-region" (0x82de94) "font-lock-fontify-region" (0x82e1f8) "run-hook-with-args" (0x82e1f4) "byte-code" (0x82e3a0) "jit-lock-fontify-now" (0x82e774) "jit-lock-function" (0x82eae4) "scroll-down" (0x82f674) "scroll-down-command" (0x82f8f4) "call-interactively" (0x82fb84) So the value of point saved by window_scroll_line_based becomes invalid after vertical-motion returns, and the rest is history. I fixed this on the trunk (revision 104055). Emacs-23 branch has the same problem, but I'd like to hear Stefan's and Chong's opinion whether to install this change there as well (since Grep buffer fontifications that trigger this problem were only introduced on the trunk, and since the code in question survived without changes since the 1990s). From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 29 16:42:35 2011 Received: (at 7952) by debbugs.gnu.org; 29 Apr 2011 20:42:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QFuWJ-0002g7-9r for submit@debbugs.gnu.org; Fri, 29 Apr 2011 16:42:35 -0400 Received: from smtp6-g21.free.fr ([212.27.42.6]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QFuWH-0002ft-2d for 7952@debbugs.gnu.org; Fri, 29 Apr 2011 16:42:34 -0400 Received: from silenus.orebokech.com (unknown [82.67.41.165]) by smtp6-g21.free.fr (Postfix) with ESMTP id 8BA1282358; Fri, 29 Apr 2011 22:42:22 +0200 (CEST) Received: by silenus.orebokech.com (Postfix, from userid 1000) id 434752E00EB; Fri, 29 Apr 2011 22:42:21 +0200 (CEST) From: Romain Francoise To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Organization: orebokech dot com References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> X-Face: }9mYu,e_@+e!`Z-P5kVXa3\_b:hdJ"B)ww[&=b<2=awG:GOIM (Eli Zaretskii's message of "Fri, 29 Apr 2011 21:17:20 +0300") Message-ID: <87wric23iq.fsf@silenus.orebokech.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Eli Zaretskii writes: > I fixed this on the trunk (revision 104055). I'm happy to confirm that rev 104055 doesn't crash anymore, thank you very much! Not sure if it's related, but using grep results in lots of those in the Messages buffer: | Error during redisplay: (args-out-of-range 26100 26140) | Error during redisplay: (args-out-of-range 55792 55803) | Error during redisplay: (args-out-of-range 89118 89155) | Error during redisplay: (args-out-of-range 107767 107804) | Error during redisplay: (args-out-of-range 119160 119176) | Error during redisplay: (args-out-of-range 152422 152434) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 04:58:27 2011 Received: (at 7952) by debbugs.gnu.org; 30 Apr 2011 08:58:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QG60R-0003px-2T for submit@debbugs.gnu.org; Sat, 30 Apr 2011 04:58:27 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QG60N-0003pj-LB for 7952@debbugs.gnu.org; Sat, 30 Apr 2011 04:58:25 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LKG00H00JG2IZ00@a-mtaout23.012.net.il> for 7952@debbugs.gnu.org; Sat, 30 Apr 2011 11:58:16 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.185.101]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKG00HINJL2IO10@a-mtaout23.012.net.il>; Sat, 30 Apr 2011 11:58:16 +0300 (IDT) Date: Sat, 30 Apr 2011 11:58:17 +0300 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: <87wric23iq.fsf@silenus.orebokech.com> X-012-Sender: halo1@inter.net.il To: Romain Francoise Message-id: <83sjt05d5i.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) > From: Romain Francoise > Cc: cyd@stupidchicken.com, 7952@debbugs.gnu.org > Date: Fri, 29 Apr 2011 22:42:21 +0200 > > Not sure if it's related, but using grep results in lots of those in > the Messages buffer: > > | Error during redisplay: (args-out-of-range 26100 26140) > | Error during redisplay: (args-out-of-range 55792 55803) > | Error during redisplay: (args-out-of-range 89118 89155) > | Error during redisplay: (args-out-of-range 107767 107804) > | Error during redisplay: (args-out-of-range 119160 119176) > | Error during redisplay: (args-out-of-range 152422 152434) It's unrelated to the crash, but it's caused by the same reason: jit-lock's function jit-lock-fontify-now also assumes that buffer positions don't change as result of fontification. The patch below, which uses markers for those positions that can change, seems to fix that. Before I commit this, I'd appreciate a review by Stefan (and anyone else who cares to comment), especially wrt to semi-kludgey updating of jit-lock-context-unfontify-pos (I wasn't sure making it a marker would be TRT). === modified file 'lisp/jit-lock.el' --- lisp/jit-lock.el 2011-01-25 04:08:28 +0000 +++ lisp/jit-lock.el 2011-04-30 08:45:26 +0000 @@ -315,7 +315,8 @@ Defaults to the whole buffer. END can b (with-buffer-prepared-for-jit-lock (save-excursion (unless start (setq start (point-min))) - (setq end (if end (min end (point-max)) (point-max))) + (setq end (copy-marker + (if end (min end (point-max)) (point-max)))) ;; This did bind `font-lock-beginning-of-syntax-function' to ;; nil at some point, for an unknown reason. Don't do this; it ;; can make highlighting slow due to expensive calls to @@ -324,15 +325,16 @@ Defaults to the whole buffer. END can b ;; from the end of a buffer to its start, can do repeated ;; `parse-partial-sexp' starting from `point-min', which can ;; take a long time in a large buffer. - (let ((orig-start start) next) + (let ((orig-start start) + (next (make-marker))) (save-match-data ;; Fontify chunks beginning at START. The end of a ;; chunk is either `end', or the start of a region ;; before `end' that has already been fontified. (while (and start (< start end)) ;; Determine the end of this chunk. - (setq next (or (text-property-any start end 'fontified t) - end)) + (move-marker next (or (text-property-any start end 'fontified t) + end)) ;; Decide which range of text should be fontified. ;; The problem is that START and NEXT may be in the @@ -340,7 +342,7 @@ Defaults to the whole buffer. END can b ;; Until someone has a better idea, let's start ;; at the start of the line containing START and ;; stop at the start of the line following NEXT. - (goto-char next) (setq next (line-beginning-position 2)) + (goto-char next) (move-marker next (line-beginning-position 2)) (goto-char start) (setq start (line-beginning-position)) ;; Make sure the contextual refontification doesn't re-refontify @@ -353,7 +355,7 @@ Defaults to the whole buffer. END can b ;; it past the end of the multiline property and thus ;; forget about this multiline region altogether. (not (get-text-property start 'jit-lock-defer-multiline))) - (setq jit-lock-context-unfontify-pos next)) + (setq jit-lock-context-unfontify-pos (marker-position next))) ;; Fontify the chunk, and mark it as fontified. ;; We mark it first, to make sure that we don't indefinitely @@ -366,6 +368,13 @@ Defaults to the whole buffer. END can b ;; before displaying the block again. (quit (put-text-property start next 'fontified nil) (funcall 'signal (car err) (cdr err)))) + ;; If NEXT moved as result of fontifying this chunk, update + ;; jit-lock-context-unfontify-pos. + (when (and jit-lock-context-unfontify-pos + (>= jit-lock-context-unfontify-pos start) + (> jit-lock-context-unfontify-pos next) + (not (get-text-property start 'jit-lock-defer-multiline))) + (setq jit-lock-context-unfontify-pos (marker-position next))) ;; The redisplay engine has already rendered the buffer up-to ;; `orig-start' and won't notice if the above jit-lock-functions From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 09:16:56 2011 Received: (at 7952) by debbugs.gnu.org; 30 Apr 2011 13:16:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGA2Z-0001mf-Ko for submit@debbugs.gnu.org; Sat, 30 Apr 2011 09:16:56 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGA2X-0001mS-BI for 7952@debbugs.gnu.org; Sat, 30 Apr 2011 09:16:54 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:37275 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QGA2R-0007uT-84; Sat, 30 Apr 2011 09:16:47 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 951DB660D4; Sat, 30 Apr 2011 10:16:44 -0300 (ART) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Message-ID: References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> Date: Sat, 30 Apr 2011 10:16:44 -0300 In-Reply-To: <83sjt05d5i.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Apr 2011 11:58:17 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, Romain Francoise , 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> Not sure if it's related, but using grep results in lots of those in >> the Messages buffer: >> >> | Error during redisplay: (args-out-of-range 26100 26140) >> | Error during redisplay: (args-out-of-range 55792 55803) >> | Error during redisplay: (args-out-of-range 89118 89155) >> | Error during redisplay: (args-out-of-range 107767 107804) >> | Error during redisplay: (args-out-of-range 119160 119176) >> | Error during redisplay: (args-out-of-range 152422 152434) > It's unrelated to the crash, but it's caused by the same reason: > jit-lock's function jit-lock-fontify-now also assumes that buffer > positions don't change as result of fontification. The patch below, > which uses markers for those positions that can change, seems to fix > that. > Before I commit this, I'd appreciate a review by Stefan (and anyone > else who cares to comment), especially wrt to semi-kludgey updating of > jit-lock-context-unfontify-pos (I wasn't sure making it a marker would > be TRT). As can be seen by a comment in grep.el, I consider grep's updating of the buffer as a problem. Also, we've seen other reasons why grep's handling of escape sequences should be performed in the process filter rather than in font-lock. So I'd rather say that grep's use of font-lock is wrong, rather than change jit-lock to accommodate it. Your earlier fix that eliminates the crash is not affected by this decision, because even bad Lisp code should not be able to crash Emacs so easily, so even if it's triggered by grep.el's bad code, it still needs to be fixed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 30 09:25:05 2011 Received: (at 7952) by debbugs.gnu.org; 30 Apr 2011 13:25:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGAAT-0001xj-2m for submit@debbugs.gnu.org; Sat, 30 Apr 2011 09:25:05 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGAAQ-0001xL-Du for 7952@debbugs.gnu.org; Sat, 30 Apr 2011 09:25:03 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LKG00J00VGPDY00@a-mtaout20.012.net.il> for 7952@debbugs.gnu.org; Sat, 30 Apr 2011 16:24:34 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.185.101]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKG00J8AVWXCW20@a-mtaout20.012.net.il>; Sat, 30 Apr 2011 16:24:34 +0300 (IDT) Date: Sat, 30 Apr 2011 16:24:36 +0300 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83oc3n6fe3.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Stefan Monnier > Cc: Romain Francoise , cyd@stupidchicken.com, 7952@debbugs.gnu.org > Date: Sat, 30 Apr 2011 10:16:44 -0300 > > As can be seen by a comment in grep.el, I consider grep's updating of > the buffer as a problem. Also, we've seen other reasons why grep's > handling of escape sequences should be performed in the process filter > rather than in font-lock. So I'd rather say that grep's use of > font-lock is wrong, rather than change jit-lock to accommodate it. So you are saying that, as a matter of policy, font-lock should never modify the text of its buffer, is that right? From debbugs-submit-bounces@debbugs.gnu.org Mon May 02 10:51:42 2011 Received: (at 7952) by debbugs.gnu.org; 2 May 2011 14:51:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGuTO-0002R0-EM for submit@debbugs.gnu.org; Mon, 02 May 2011 10:51:42 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QGuTM-0002Qo-DJ for 7952@debbugs.gnu.org; Mon, 02 May 2011 10:51:41 -0400 Received: from 121-249-126-200.fibertel.com.ar ([200.126.249.121]:51770 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QGuTF-0003ir-Gs; Mon, 02 May 2011 10:51:33 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 8A13966119; Mon, 2 May 2011 11:51:31 -0300 (ART) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Message-ID: References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83oc3n6fe3.fsf@gnu.org> Date: Mon, 02 May 2011 11:51:31 -0300 In-Reply-To: <83oc3n6fe3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 30 Apr 2011 16:24:36 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> As can be seen by a comment in grep.el, I consider grep's updating of >> the buffer as a problem. Also, we've seen other reasons why grep's >> handling of escape sequences should be performed in the process filter >> rather than in font-lock. So I'd rather say that grep's use of >> font-lock is wrong, rather than change jit-lock to accommodate it. > So you are saying that, as a matter of policy, font-lock should never > modify the text of its buffer, is that right? [ Actually, we're talking about jit-lock, really. ] Yes. We should not crash if it does, but any non-crashing behavior (including minor redisplay glitches) is fair game, I think. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun May 08 01:18:14 2011 Received: (at 7952) by debbugs.gnu.org; 8 May 2011 05:18:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QIwNi-0000OO-D4 for submit@debbugs.gnu.org; Sun, 08 May 2011 01:18:14 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QIwNf-0000OA-6I for 7952@debbugs.gnu.org; Sun, 08 May 2011 01:18:12 -0400 Received: from cyd by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QIwNY-0007AA-Ha; Sun, 08 May 2011 01:18:04 -0400 From: Chong Yidong To: Stefan Monnier Subject: Re: bug#7952: 24.0.50; crash in find_interval References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> Date: Sun, 08 May 2011 01:18:04 -0400 In-Reply-To: (Stefan Monnier's message of "Sat, 30 Apr 2011 10:16:44 -0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 7952 Cc: Eli Zaretskii , Romain Francoise , 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Stefan Monnier writes: > As can be seen by a comment in grep.el, I consider grep's updating of > the buffer as a problem. Also, we've seen other reasons why grep's > handling of escape sequences should be performed in the process filter > rather than in font-lock. So I'd rather say that grep's use of > font-lock is wrong, rather than change jit-lock to accommodate it. I've committed a fix for grep.el. From debbugs-submit-bounces@debbugs.gnu.org Sun May 08 11:29:23 2011 Received: (at 7952) by debbugs.gnu.org; 8 May 2011 15:29:23 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ5v9-0006KR-JZ for submit@debbugs.gnu.org; Sun, 08 May 2011 11:29:23 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJ5v7-0006KD-Fa for 7952@debbugs.gnu.org; Sun, 08 May 2011 11:29:22 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LKV00800UIOZ400@a-mtaout22.012.net.il> for 7952@debbugs.gnu.org; Sun, 08 May 2011 18:28:55 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.234.175]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKV007OPV055QN0@a-mtaout22.012.net.il>; Sun, 08 May 2011 18:28:55 +0300 (IDT) Date: Sun, 08 May 2011 18:28:58 +0300 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: X-012-Sender: halo1@inter.net.il To: Chong Yidong Message-id: <83liyhjjnp.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7952 Cc: romain@orebokech.com, monnier@iro.umontreal.ca, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Chong Yidong > Cc: Eli Zaretskii , Romain Francoise , 7952@debbugs.gnu.org > Date: Sun, 08 May 2011 01:18:04 -0400 > > Stefan Monnier writes: > > > As can be seen by a comment in grep.el, I consider grep's updating of > > the buffer as a problem. Also, we've seen other reasons why grep's > > handling of escape sequences should be performed in the process filter > > rather than in font-lock. So I'd rather say that grep's use of > > font-lock is wrong, rather than change jit-lock to accommodate it. > > I've committed a fix for grep.el. Thanks, but will that solution work when start-process is not available (MS-DOS)? I'm not sure (I think compilation-filter is not run in that case). From debbugs-submit-bounces@debbugs.gnu.org Sun May 08 16:27:24 2011 Received: (at 7952) by debbugs.gnu.org; 8 May 2011 20:27:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJAZX-00072K-VC for submit@debbugs.gnu.org; Sun, 08 May 2011 16:27:24 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJAZW-000728-Jz for 7952@debbugs.gnu.org; Sun, 08 May 2011 16:27:23 -0400 Received: from furball (dhcp128036225146.central.yale.edu [128.36.225.146]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p48KRGE6019933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 8 May 2011 16:27:16 -0400 Received: by furball (Postfix, from userid 1000) id D3328160603; Sun, 8 May 2011 16:27:15 -0400 (EDT) From: Chong Yidong To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83liyhjjnp.fsf@gnu.org> Date: Sun, 08 May 2011 16:27:15 -0400 In-Reply-To: <83liyhjjnp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 08 May 2011 18:28:58 +0300") Message-ID: <87iptl7xb0.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7952 Cc: romain@orebokech.com, monnier@iro.umontreal.ca, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Eli Zaretskii writes: > Thanks, but will that solution work when start-process is not > available (MS-DOS)? I'm not sure (I think compilation-filter is not > run in that case). Good point. This problem isn't limited to grep. For the synchronous case, compilation-start should probably run compilation-filter-hook after call-process returns. WDYT? *** lisp/progmodes/compile.el 2011-05-08 05:17:17 +0000 --- lisp/progmodes/compile.el 2011-05-08 20:25:38 +0000 *************** *** 1623,1630 **** --- 1623,1632 ---- ;; regardless of where the user sees point. (goto-char (point-max)) (let* ((inhibit-read-only t) ; call-process needs to modify outbuf + (compilation-filter-start (point)) (status (call-process shell-file-name nil outbuf nil "-c" command))) + (run-hooks 'compilation-filter-hook) (cond ((numberp status) (compilation-handle-exit 'exit status From debbugs-submit-bounces@debbugs.gnu.org Mon May 09 02:24:39 2011 Received: (at 7952) by debbugs.gnu.org; 9 May 2011 06:24:39 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJJtW-0004B0-RJ for submit@debbugs.gnu.org; Mon, 09 May 2011 02:24:39 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJJtT-0004Am-LM for 7952@debbugs.gnu.org; Mon, 09 May 2011 02:24:36 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0LKX009000DVIW00@a-mtaout23.012.net.il> for 7952@debbugs.gnu.org; Mon, 09 May 2011 09:23:59 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.234.175]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKX009DY0FXET50@a-mtaout23.012.net.il>; Mon, 09 May 2011 09:23:59 +0300 (IDT) Date: Mon, 09 May 2011 09:24:03 +0300 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: <87iptl7xb0.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il To: Chong Yidong Message-id: <83fwoojssc.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83liyhjjnp.fsf@gnu.org> <87iptl7xb0.fsf@stupidchicken.com> X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 7952 Cc: romain@orebokech.com, monnier@iro.umontreal.ca, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.8 (-) > From: Chong Yidong > Cc: monnier@iro.umontreal.ca, romain@orebokech.com, 7952@debbugs.gnu.org > Date: Sun, 08 May 2011 16:27:15 -0400 > > Eli Zaretskii writes: > > > Thanks, but will that solution work when start-process is not > > available (MS-DOS)? I'm not sure (I think compilation-filter is not > > run in that case). > > Good point. This problem isn't limited to grep. For the synchronous > case, compilation-start should probably run compilation-filter-hook > after call-process returns. WDYT? Looks good, thanks. Go ahead and commit, I will test it when I have time. From debbugs-submit-bounces@debbugs.gnu.org Mon May 09 10:07:03 2011 Received: (at 7952) by debbugs.gnu.org; 9 May 2011 14:07:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJR71-0000Pg-Dn for submit@debbugs.gnu.org; Mon, 09 May 2011 10:07:03 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJR6z-0000PG-NS for 7952@debbugs.gnu.org; Mon, 09 May 2011 10:07:02 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:60235 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QJR6t-0004IO-9G; Mon, 09 May 2011 10:06:55 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 816D2664BA; Mon, 9 May 2011 11:06:52 -0300 (ART) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Message-ID: References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83liyhjjnp.fsf@gnu.org> <87iptl7xb0.fsf@stupidchicken.com> <83fwoojssc.fsf@gnu.org> Date: Mon, 09 May 2011 11:06:52 -0300 In-Reply-To: <83fwoojssc.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 May 2011 09:24:03 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 7952 Cc: Chong Yidong , romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> > Thanks, but will that solution work when start-process is not >> > available (MS-DOS)? I'm not sure (I think compilation-filter is not >> > run in that case). >> Good point. This problem isn't limited to grep. For the synchronous >> case, compilation-start should probably run compilation-filter-hook >> after call-process returns. WDYT? > Looks good, thanks. Go ahead and commit, I will test it when I have > time. BTW, wouldn't it be preferable to pass the `start' position as an argument rather passing it implicitly via a dynamic variable? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon May 09 10:47:34 2011 Received: (at 7952) by debbugs.gnu.org; 9 May 2011 14:47:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJRkE-0001LW-DL for submit@debbugs.gnu.org; Mon, 09 May 2011 10:47:34 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJRkB-0001LE-0W for 7952@debbugs.gnu.org; Mon, 09 May 2011 10:47:32 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LKX00200NMSYW00@a-mtaout22.012.net.il> for 7952@debbugs.gnu.org; Mon, 09 May 2011 17:47:00 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.234.175]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKX002QHNQ53AE0@a-mtaout22.012.net.il>; Mon, 09 May 2011 17:46:58 +0300 (IDT) Date: Mon, 09 May 2011 17:46:59 +0300 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83wri0hqxo.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83liyhjjnp.fsf@gnu.org> <87iptl7xb0.fsf@stupidchicken.com> <83fwoojssc.fsf@gnu.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Stefan Monnier > Cc: Chong Yidong , romain@orebokech.com, 7952@debbugs.gnu.org > Date: Mon, 09 May 2011 11:06:52 -0300 > > BTW, wouldn't it be preferable to pass the `start' position as an > argument rather passing it implicitly via a dynamic variable? ??? It's a hook we are going to call, right? It's not just any function. From debbugs-submit-bounces@debbugs.gnu.org Mon May 09 11:32:41 2011 Received: (at 7952) by debbugs.gnu.org; 9 May 2011 15:32:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJSRt-0002NO-Kf for submit@debbugs.gnu.org; Mon, 09 May 2011 11:32:41 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJSRr-0002N9-O1 for 7952@debbugs.gnu.org; Mon, 09 May 2011 11:32:40 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:58260 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QJSRl-0000w5-Cn; Mon, 09 May 2011 11:32:33 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 08AF066152; Mon, 9 May 2011 12:32:30 -0300 (ART) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Message-ID: References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83liyhjjnp.fsf@gnu.org> <87iptl7xb0.fsf@stupidchicken.com> <83fwoojssc.fsf@gnu.org> <83wri0hqxo.fsf@gnu.org> Date: Mon, 09 May 2011 12:32:29 -0300 In-Reply-To: <83wri0hqxo.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 May 2011 17:46:59 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> BTW, wouldn't it be preferable to pass the `start' position as an >> argument rather passing it implicitly via a dynamic variable? > ??? It's a hook we are going to call, right? It's not just any > function. run-hook-with-args (...-hook would need to be renamed to ...-functions, of course). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon May 09 11:42:49 2011 Received: (at 7952) by debbugs.gnu.org; 9 May 2011 15:42:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJSbg-0002be-S7 for submit@debbugs.gnu.org; Mon, 09 May 2011 11:42:49 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJSbe-0002bP-RY for 7952@debbugs.gnu.org; Mon, 09 May 2011 11:42:48 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LKX00300QB2HW00@a-mtaout22.012.net.il> for 7952@debbugs.gnu.org; Mon, 09 May 2011 18:42:40 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.234.175]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKX0029EQB2MRD0@a-mtaout22.012.net.il>; Mon, 09 May 2011 18:42:40 +0300 (IDT) Date: Mon, 09 May 2011 18:42:44 +0300 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83mxivj2x7.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83liyhjjnp.fsf@gnu.org> <87iptl7xb0.fsf@stupidchicken.com> <83fwoojssc.fsf@gnu.org> <83wri0hqxo.fsf@gnu.org> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Stefan Monnier > Cc: cyd@stupidchicken.com, romain@orebokech.com, 7952@debbugs.gnu.org > Date: Mon, 09 May 2011 12:32:29 -0300 > > >> BTW, wouldn't it be preferable to pass the `start' position as an > >> argument rather passing it implicitly via a dynamic variable? > > > ??? It's a hook we are going to call, right? It's not just any > > function. > > run-hook-with-args (...-hook would need to be renamed to ...-functions, > of course). Which breaks back-compatibility. Unless we introduce compilation-filter-start-functions _in_addition_to_ the existing hook. But that sounds gross, just to avoid a single let-bound dynamic variable, doesn't it? From debbugs-submit-bounces@debbugs.gnu.org Mon May 09 13:09:17 2011 Received: (at 7952) by debbugs.gnu.org; 9 May 2011 17:09:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJTxM-0004bY-Lj for submit@debbugs.gnu.org; Mon, 09 May 2011 13:09:16 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJTxJ-0004bL-He for 7952@debbugs.gnu.org; Mon, 09 May 2011 13:09:14 -0400 Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:38447 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QJTxD-00017w-17; Mon, 09 May 2011 13:09:07 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 524F066152; Mon, 9 May 2011 14:09:04 -0300 (ART) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval Message-ID: References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83liyhjjnp.fsf@gnu.org> <87iptl7xb0.fsf@stupidchicken.com> <83fwoojssc.fsf@gnu.org> <83wri0hqxo.fsf@gnu.org> <83mxivj2x7.fsf@gnu.org> Date: Mon, 09 May 2011 14:09:04 -0300 In-Reply-To: <83mxivj2x7.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 May 2011 18:42:44 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: 7952 Cc: cyd@stupidchicken.com, romain@orebokech.com, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.0 (------) >> >> BTW, wouldn't it be preferable to pass the `start' position as an >> >> argument rather passing it implicitly via a dynamic variable? >> >> > ??? It's a hook we are going to call, right? It's not just any >> > function. >> >> run-hook-with-args (...-hook would need to be renamed to ...-functions, >> of course). > Which breaks back-compatibility. Ah, I didn't realize that compilation-filter-hook already existed in Emacs-23, so that's the reason why "it wouldn't be preferable ...". Thanks for the explanation. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon May 09 15:46:49 2011 Received: (at 7952) by debbugs.gnu.org; 9 May 2011 19:46:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJWPp-0008CO-Eo for submit@debbugs.gnu.org; Mon, 09 May 2011 15:46:49 -0400 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJWPn-0008CA-Sx for 7952@debbugs.gnu.org; Mon, 09 May 2011 15:46:48 -0400 Received: from furball (dhcp128036014040.central.yale.edu [128.36.14.40]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p49Jkdxx026410 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 9 May 2011 15:46:40 -0400 Received: by furball (Postfix, from userid 1000) id 8EC1B160401; Mon, 9 May 2011 15:46:39 -0400 (EDT) From: Chong Yidong To: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83liyhjjnp.fsf@gnu.org> <87iptl7xb0.fsf@stupidchicken.com> <83fwoojssc.fsf@gnu.org> Date: Mon, 09 May 2011 15:46:39 -0400 In-Reply-To: <83fwoojssc.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 May 2011 09:24:03 +0300") Message-ID: <871v07mzc0.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 7952 Cc: romain@orebokech.com, monnier@iro.umontreal.ca, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Eli Zaretskii writes: > Looks good, thanks. Go ahead and commit, I will test it when I have > time. Committed. Tested OK by replacing (fboundp 'start-process) with nil to force the async code path. The only difference was that when called through call-process, grep doesn't emit the highlighting escape sequences by default; I had to pass "--color=always". This may have something to do with the way grep's --color=auto detection works. From debbugs-submit-bounces@debbugs.gnu.org Mon May 09 16:31:30 2011 Received: (at 7952) by debbugs.gnu.org; 9 May 2011 20:31:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJX74-0000og-4G for submit@debbugs.gnu.org; Mon, 09 May 2011 16:31:30 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QJX71-0000oO-EP for 7952@debbugs.gnu.org; Mon, 09 May 2011 16:31:28 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0LKY006003NC3400@a-mtaout22.012.net.il> for 7952@debbugs.gnu.org; Mon, 09 May 2011 23:31:17 +0300 (IDT) Received: from HOME-C4E4A596F7 ([84.228.234.175]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LKY004TQ3O4Q4K0@a-mtaout22.012.net.il>; Mon, 09 May 2011 23:31:17 +0300 (IDT) Date: Mon, 09 May 2011 23:31:22 +0300 From: Eli Zaretskii Subject: Re: bug#7952: 24.0.50; crash in find_interval In-reply-to: <871v07mzc0.fsf@stupidchicken.com> X-012-Sender: halo1@inter.net.il To: Chong Yidong Message-id: <8362pjipk5.fsf@gnu.org> References: <87r5ag7a72.fsf@silenus.orebokech.com> <87lj0c1bj8.fsf@silenus.orebokech.com> <8339mkrzic.fsf@gnu.org> <87ei6417kl.fsf@silenus.orebokech.com> <87tye1x3mv.fsf@stupidchicken.com> <87y62xh0ep.fsf@silenus.orebokech.com> <83pqo899y4.fsf@gnu.org> <834o5g7wi7.fsf@gnu.org> <87wric23iq.fsf@silenus.orebokech.com> <83sjt05d5i.fsf@gnu.org> <83liyhjjnp.fsf@gnu.org> <87iptl7xb0.fsf@stupidchicken.com> <83fwoojssc.fsf@gnu.org> <871v07mzc0.fsf@stupidchicken.com> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 7952 Cc: romain@orebokech.com, monnier@iro.umontreal.ca, 7952@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Chong Yidong > Cc: romain@orebokech.com, monnier@iro.umontreal.ca, 7952@debbugs.gnu.org > Date: Mon, 09 May 2011 15:46:39 -0400 > > Eli Zaretskii writes: > > > Looks good, thanks. Go ahead and commit, I will test it when I have > > time. > > Committed. Tested OK by replacing (fboundp 'start-process) with nil to > force the async code path. Thanks. > The only difference was that when called > through call-process, grep doesn't emit the highlighting escape > sequences by default; I had to pass "--color=always". This may have > something to do with the way grep's --color=auto detection works. On MS-DOS, we already pass --color=always, see grep-compute-defaults. From unknown Sat Jun 21 03:20:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 07 Jun 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator