GNU bug report logs - #79412
30.2; `define-globalized-minor-mode' does not respect `:variable'

Previous Next

Full log

Message #32 received at 79412 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: inet0 <at> qq.com, 79412 <at> debbugs.gnu.org
Subject: Re: bug#79412: 30.2; `define-globalized-minor-mode' does not
 respect `:variable'
Date: Sat, 13 Sep 2025 13:50:25 -0400

>> > So you mean this:
>> >
>> > diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el
>> > index ca92130..de77eb3 100644
>> > --- a/lisp/emacs-lisp/easy-mmode.el
>> > +++ b/lisp/emacs-lisp/easy-mmode.el
>> > @@ -570,7 +570,7 @@ define-globalized-minor-mode
>> >  	 (dolist (buf (buffer-list))
>> >  	   (with-current-buffer buf
>> >               (if ,global-mode (funcall ,turn-on-function)
>> > -               (when ,mode (,mode -1)))))
>> > +               (when ,mode (,MODE-variable -1)))))
>> >           ,@body)
>> >  
>> >         ,(when predicate
>> 
>> No, like
>> 
>>     (when ,MODE-variable (,mode -1))
>
> And what about this one:
>
> 	 ;; Go through existing buffers.
> 	 (dolist (buf (buffer-list))
> 	   (with-current-buffer buf
>              (if ,global-mode (funcall ,turn-on-function)
>                (when ,mode (,MODE-variable -1)))))
>          ,@body)

Hmm... actually this is the same as the one further above.
AFAICT there's only one such piece of code in `easy-mmode.el`.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.