GNU bug report logs - #79406
[PATCH] 31.0.50; csharp-ts-mode does not fontify variable-use consistently

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 79406 <at> debbugs.gnu.org, casouri <at> gmail.com
Subject: bug#79406: [PATCH] 31.0.50; csharp-ts-mode does not fontify variable-use consistently
Date: Mon, 08 Sep 2025 15:59:12 +0300

> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> Date: Mon, 8 Sep 2025 14:50:23 +0200
> Cc: 79406 <at> debbugs.gnu.org,
>  Yuan Fu <casouri <at> gmail.com>
> 
>  On 8 Sep 2025, at 13:14, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>  Are all of these appropriate for the default value of
>  treesit-font-lock-level?  
> 
> I'll have to be honest and admit I haven't tested any major-mode in "default" fontification level in probably a
> decade. My settings is maximum detail, and I've based my findings on that.
> 
> It may previously have been difficult to compartementalize some of these fontifications into different features
> and levels (due to extensive use of override:t and rules being heavily order-dependent).
> 
> With the changes in this patch however, I can probably move some rules about if that's wanted. Anything in
> particular you are thinking about?

Can you correlate the syntactic elements with the guidelines in the
doc string of treesit-font-lock-level?

>  I see that
>  csharp-ts-mode--font-lock-settings doesn't use the level at all -- is
>  that on purpose?
> 
> I'm not sure I'm following. We have the following LISP to configure tree-sitter for the different feature-levels?
> 
>   (setq-local treesit-font-lock-feature-list
>               '(( comment definition)
>                 ( keyword string type directives)
>                 ( constant escape-sequence expression literal attribute)
>                 ( function bracket delimiter error)))
> 
> Can you provide a more concrete example of what you think is missing or inappropriate and I can try to
> address that.

Hmm... maybe nothing.  Yuan, could you please see if anything is
missing here?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.