GNU bug report logs - #79390
31.0.50; oauth2.el; error in byte-compiling

Previous Next

Full log

View this message in rfc822 format

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: Xiyue Deng <manphiz <at> gmail.com>
Cc: 79390 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: bug#79390: 31.0.50; oauth2.el; error in byte-compiling
Date: Sat, 06 Sep 2025 15:37:45 +0900

[Message part 1 (text/plain, inline)]

> >> When I byte-compile oauth2.el (0.18), below errors and warnings are
> >> displayed and fail to byte-compiling.
(snip)

> Thanks for the report!  I have now pushed a few fixes which should
> handle those warnings/errors plus a few other fixes.  I have also added
> build checks in Gitlab CI.  Now tagged v0.18.1.  Please help check
> whether those fixes work for you.

I've tested on 0.18.2 and confirmed errors and warnings were fixed,
thank you.
But I have one question.  

In oauth2--update-request-cache, 

> (when host-name
>   (let ((host-name (intern host-name)))
>     (org-plist-delete request-cache host-name)
>     (setq request-cache
>         (plist-put request-cache host-name
>                    `( :access-token ,access-token
>                       :request-timestamp ,request-timestamp)))))
> request-cache)

org-plist-delete returns newly created plist and doesn't modify
arguement PLIST, so it does nothing in the above code.  Moreover,
because next plist-put set new property value, it is no need to delete
old property value explicitly.

Please see attached patch.

-- 
Kazuhiro Ito

[0001-oauth2.el-oauth2-update-request-cache-Remove-unneede.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.