From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 05 11:31:11 2025 Received: (at submit) by debbugs.gnu.org; 5 Sep 2025 15:31:11 +0000 Received: from localhost ([127.0.0.1]:55880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uuYP8-00055G-Qb for submit@debbugs.gnu.org; Fri, 05 Sep 2025 11:31:11 -0400 Received: from lists.gnu.org ([2001:470:142::17]:46518) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uuYP2-00054G-VH for submit@debbugs.gnu.org; Fri, 05 Sep 2025 11:31:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuYOq-0006x0-FC for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2025 11:30:52 -0400 Received: from mta-snd-e09.auone-net.jp ([111.86.247.9]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuYOZ-0004ol-15 for bug-gnu-emacs@gnu.org; Fri, 05 Sep 2025 11:30:51 -0400 Received: from kzhr.d1.dion.ne.jp by mta-snd-e09.auone-net.jp with ESMTP id <20250905153022355.SVLZ.117557.kzhr.d1.dion.ne.jp@mta-snd-e09.auone-net.jp>; Sat, 6 Sep 2025 00:30:22 +0900 Date: Sat, 06 Sep 2025 00:30:03 +0900 Message-ID: <85frd07w90.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito To: bug-gnu-emacs@gnu.org Subject: 31.0.50; oauth2.el; error in byte-compiling User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/31.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-7 Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d1.dion.ne.jp; s=default-1; t=1757086222; bh=UyCa+huaYUW4zLIrS4+ZHfzh1o3tzkueIXk0p4yfHsg=; h=Date:From:To:Subject; b=CbMo//BdAH6WIfdGcOxRbIvK24U63rxIKRlRAaW9q6oleztWNEicHvFF0/8LAlOurev0+Nne 4qc8uSSHz7802rsfKPygghOxLoQpp3ZETHwDvdM/osG0DLm2NPqH9UO/sfyF5j9rE6BDAsjlm+ oZJSJzMEnmrT6O8Y5Hl7OlThewG6VkzevgZzbskG9GMJv1SCccvkBxOEBSqQOd9qbK1lWdrNOn 4ZpxhzvJlBKkVpdLI5mLp4RHooAzKBWFSBmVQfpHbeh9MTt9E6nvVQryUBDpv7jg88nXgF3T1q mbRuvNoGhM9YddvQA4Oe6iviczUV4MRybNpzjri3kl6ChXSg== Received-SPF: pass client-ip=111.86.247.9; envelope-from=kzhr@d1.dion.ne.jp; helo=mta-snd-e09.auone-net.jp X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) When I byte-compile oauth2.el (0.18), below errors and warnings are displayed and fail to byte-compiling. In oauth2--build-url-param-str: oauth2.el:164:12: Error: =A1add-to-list=A2 can=A2t use lexical var =A1data-= list=A2; use =A1push=A2 or =A1cl-pushnew=A2 In oauth2--generate-code-verifier: oauth2.el:187:11: Warning: Unused lexical variable =A1func-name=A2 In oauth2-request-authorization: oauth2.el:223:16: Error: =A1add-to-list=A2 can=A2t use lexical var =A1param= =A2; use =A1push=A2 or =A1cl-pushnew=A2 In end of data: oauth2.el:124:8: Warning: the function =A1org-plist-delete=A2 is not known = to be defined. --=20 Kazuhiro Ito From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 05 13:30:51 2025 Received: (at 79390) by debbugs.gnu.org; 5 Sep 2025 17:30:51 +0000 Received: from localhost ([127.0.0.1]:56819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uuaGw-0005nA-R9 for submit@debbugs.gnu.org; Fri, 05 Sep 2025 13:30:51 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:43874) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uuaGp-0005lj-He for 79390@debbugs.gnu.org; Fri, 05 Sep 2025 13:30:46 -0400 DKIM-Signature: a=rsa-sha256; b=RPRkgzaTAU710We/ghRRrGHTLKhzsZ6o3UdBt4juquaZ1v16rEx/1sIC++ieFw6d4Bi+Y6OknPslrT+Jj/FF1UglydYXdA7Ag3ZLOspRNkVRtAelFfUOyqgXCc8QYhJxN/KZI7lqLej6bEOzrem+VWpACJCTDAtgQ9kHoSaDvgD9WqHGKzU+U8EohtKkARfmcbm1wfZLFdV9QJR8rsW/emMpBso56wIkPTx32mQrIGnTjiO1X+Doaz0NfF2ioT+BmFqzpcpDdqfRZBU985Dz0ioNcsN96hyTLG1Y14DjSAQ+emte9HIYHb9UzqEtR9LUnZb5WQWdn0YAvmSXtVmSWQ==; s=purelymail2; d=spwhitton.name; v=1; bh=f1aj+YxFb30BGS/p/mymXAUJghkeGArZ+aM2jGxDeZU=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=cUpIWhS696ZpF36DIuqUgV+GOG0r8HtVaFkHLwFk8Jk+zZeL2hVphVuBgcqp0P1ryITy5gpnltPbwzrBN+FQDUeCoJxqlX9QQpVjXRh67XQtxBsHcn/XR/rdnFy0SvRo6MfQKA3cgR2firVBDzx0NUgZcHmY3ZJHyIJ9jNCRbDivQvHgO9NRX9r09paBY9VnspNKFe84jM2KC+iiNGiu7JbMNA4HryATyleILfJfV0J5WwoSYeIbRXtXWnQXstoAFz/SjnF+q9yUz1qfWOb+goV/Zd5w/3Y9Irt9G5hmsllhZFTq9/Rp6HzLri64XNXttKapsB7NcGDcgQNXqTCr4w==; s=purelymail2; d=purelymail.com; v=1; bh=f1aj+YxFb30BGS/p/mymXAUJghkeGArZ+aM2jGxDeZU=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79390@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1868885096; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Fri, 05 Sep 2025 17:30:33 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id A6B7B940456; Fri, 05 Sep 2025 18:30:32 +0100 (BST) From: Sean Whitton To: Kazuhiro Ito Subject: Re: bug#79390: 31.0.50; oauth2.el; error in byte-compiling In-Reply-To: <85frd07w90.wl--xmue@d1.dion.ne.jp> References: <85frd07w90.wl--xmue@d1.dion.ne.jp> Date: Fri, 05 Sep 2025 18:30:32 +0100 Message-ID: <87ldmsq01z.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79390 Cc: 79390@debbugs.gnu.org, Xiyue Deng X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Thanks. Adding Xiyue. On Sat 06 Sep 2025 at 12:30am +09, Kazuhiro Ito wrote: > When I byte-compile oauth2.el (0.18), below errors and warnings are > displayed and fail to byte-compiling. > > > In oauth2--build-url-param-str: > oauth2.el:164:12: Error: =E2=80=98add-to-list=E2=80=99 can=E2=80=99t use = lexical var =E2=80=98data-list=E2=80=99; > use =E2=80=98push=E2=80=99 or =E2=80=98cl-pushnew=E2=80=99 > > In oauth2--generate-code-verifier: > oauth2.el:187:11: Warning: Unused lexical variable =E2=80=98func-name=E2= =80=99 > > In oauth2-request-authorization: > oauth2.el:223:16: Error: =E2=80=98add-to-list=E2=80=99 can=E2=80=99t use = lexical var =E2=80=98param=E2=80=99; use > =E2=80=98push=E2=80=99 or =E2=80=98cl-pushnew=E2=80=99 > > In end of data: > oauth2.el:124:8: Warning: the function =E2=80=98org-plist-delete=E2=80=99= is not known to be > defined. --=20 Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 05 20:01:58 2025 Received: (at 79390) by debbugs.gnu.org; 6 Sep 2025 00:01:59 +0000 Received: from localhost ([127.0.0.1]:58771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uugNR-00043S-35 for submit@debbugs.gnu.org; Fri, 05 Sep 2025 20:01:57 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:54778) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uugNA-00042R-NC for 79390@debbugs.gnu.org; Fri, 05 Sep 2025 20:01:50 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-24c863e852aso24143985ad.1 for <79390@debbugs.gnu.org>; Fri, 05 Sep 2025 17:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757116893; x=1757721693; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=BcGThwVEcOHvC9cd8IMfqWD8XVyvri3zEn/KFmTDsvw=; b=GeOsioDxb/ZQi+8DV0mT466g4+LxVvN+LwG47COW3XE+vzEZ4m6dxsciSHSLEEJrhu n32Nw4dwDFCn9+Fz1uR/f0l6kAIae0kTWQHaGaF2r4A4GEVEJGT36/0aHNHLepLupAEm F50qW2uECN35z1Qxla8ZPR6irgeT52wym+JGTz9uLzKUI/KrP+FIA2GCF7np2Ni7mg+Y FPrByq2S5/pzOUbbAxxVZ6T7WMlgpJMJmAY/fsPP7XLMTf1mbfrRetQ2FX/2wJ1kKEry GaANU5+sFrqWIEOYFEfVDhF8kR4kF+0cpbjoHkHBp0N+hAmb/FO1HZ6p7sEUXyDHejot p+CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757116893; x=1757721693; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BcGThwVEcOHvC9cd8IMfqWD8XVyvri3zEn/KFmTDsvw=; b=p+japzLzBZSkODJI0HMwMvKvYpZKGVVCdr0XyoUTC21XrvEFKacko974AqS7tdquAa xMDjsAc1vQPNRGZXFwTApM6vtBEwIEC5VjKAoq/0JDMINFXXDedBRKcTa6ZTF2xoZE2Q JWfj02iqGGzZncNsrdBJaLvf6dBBj/ocEcLdCX6IyCdsxLZmH5US1EmqJ9dktLK83+1h HGdGvWmaATwoVTbFcUvSjEFBZICWFziMJN22hVnnr0knGuq+5I/selOJY47+DZiZJdSG H0FgJiHeBXcjqVlXNx8Y0XAdhP3j1NslAXhcmgv1B3pFd4Q9xgItDMJosfYcPQP8dmRt 5wpQ== X-Gm-Message-State: AOJu0YzeSDe4Xc/D3rAEBkmB3b59V3p0CPmx3sDXdo+70JKvU8UDHmKw 5JpWgmLUU+O0xhxTrR3cXsRDGhTPuZT/YXUN7yk8mrzASL8nPRBSSx/b0+pfyg== X-Gm-Gg: ASbGncssdETFf6rsiyUN9qzEJUv2TmlX3XOrvpPFTTG5+33EUEZBLTuB28pN/zQb5NZ 9xfywBQnKxHWMNf6/aSr9e5nP+0nUD9SrF7DbTlfarodjenUXUckXhT4eo3YJ2LPOepuCv4RKXr 6L3Iewj6cx42+uj/l/lBIf1H4zcifIhpDjQCRQGVKp4RB0YLuq/m4JxrERUqP3e+gHg+Xr8FHPu nkqYxM+4+myy9a/mfrI0V8wWP39yymzv1OM+Qw36MwiXe4ocWWXv9Mr56D4/GkXAdrgwKWAbnZW jjnCeMuWftOMHcTmng2TQOsJJwgIw2Txx4SAcWu4L6vx48UODH4CxRDfptgfhc0TbP6jTOVxE2i 2PFmbGzjxMy/h0E+EHlEYhOxGSRP+13NpDTxSG+letA+mXvTK3rwlqP7L X-Google-Smtp-Source: AGHT+IH3re+ATtshrMU0TozKEJPMjf9MGkfH5O177U+WBFAAqkY79EPhxywON1y0nc5eGjOLzsxBAA== X-Received: by 2002:a17:902:cf03:b0:235:ec11:f0ee with SMTP id d9443c01a7336-2516e4aeef1mr5410125ad.14.1757116892707; Fri, 05 Sep 2025 17:01:32 -0700 (PDT) Received: from debian-hx90 (syn-076-094-249-045.res.spectrum.com. [76.94.249.45]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24c860066d3sm85199585ad.71.2025.09.05.17.01.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Sep 2025 17:01:31 -0700 (PDT) From: Xiyue Deng To: Sean Whitton , Kazuhiro Ito Subject: Re: bug#79390: 31.0.50; oauth2.el; error in byte-compiling In-Reply-To: <87ldmsq01z.fsf@zephyr.silentflame.com> References: <85frd07w90.wl--xmue@d1.dion.ne.jp> <87ldmsq01z.fsf@zephyr.silentflame.com> User-Agent: Notmuch/0.39 (https://notmuchmail.org) Emacs/30.1 (x86_64-pc-linux-gnu) Date: Fri, 05 Sep 2025 17:01:28 -0700 Message-ID: <87a538xxd3.fsf@debian-hx90.lan> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79390 Cc: 79390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ito-san, Sean, Sean Whitton writes: > Hello, > > Thanks. Adding Xiyue. > > On Sat 06 Sep 2025 at 12:30am +09, Kazuhiro Ito wrote: > >> When I byte-compile oauth2.el (0.18), below errors and warnings are >> displayed and fail to byte-compiling. >> >> >> In oauth2--build-url-param-str: >> oauth2.el:164:12: Error: =E2=80=98add-to-list=E2=80=99 can=E2=80=99t use= lexical var =E2=80=98data-list=E2=80=99; >> use =E2=80=98push=E2=80=99 or =E2=80=98cl-pushnew=E2=80=99 >> >> In oauth2--generate-code-verifier: >> oauth2.el:187:11: Warning: Unused lexical variable =E2=80=98func-name=E2= =80=99 >> >> In oauth2-request-authorization: >> oauth2.el:223:16: Error: =E2=80=98add-to-list=E2=80=99 can=E2=80=99t use= lexical var =E2=80=98param=E2=80=99; use >> =E2=80=98push=E2=80=99 or =E2=80=98cl-pushnew=E2=80=99 >> >> In end of data: >> oauth2.el:124:8: Warning: the function =E2=80=98org-plist-delete=E2=80= =99 is not known to be >> defined. > > --=20 > Sean Whitton Thanks for the report! I have now pushed a few fixes which should handle those warnings/errors plus a few other fixes. I have also added build checks in Gitlab CI. Now tagged v0.18.1. Please help check whether those fixes work for you. =2D-=20 Regards, Xiyue Deng --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJGBAEBCgAwFiEEiKQfd6o81mjI+LWALell7WOCXJMFAmi7edkSHG1hbnBoaXpA Z21haWwuY29tAAoJEC3pZe1jglyT08kP/i1JBQ61yoo8Emuju3AttoQ72fWsDG84 CJEOTr2n6dcf6V9SB2jLecGGwMm0ICReNjthG01njFnNU/4/fV3ZvC8o1XNIxQvJ K7oM/oEmOMu12TP/EJbOQM1xRXjDKmUI/IbTJxEO+QLaZkmEDOlsAuArzCct35XB c9lFBaSgG0mtyGbGLMsszH374Fu/Q7QV2q7I+B14fw4pYtdC/tjT62w/kS8HGoBq MuGZB9Q9Et+xQ7t5ly0Jz3X/bhIQB5MAMCyEJE3xX4/20QgGsLuNQ1F31XlyrIFm 95eknJ6Mm6O6T1kUysjnXIcGPRSmuw3uBtG1VSpq8G+uU3zjVUq9ayaWbZq4WuWg zARywNWgxuWgENgS7YHkOMTxuUSmRo0xZcJVCqzzFSIPNMkdJAd5mamyvdyGSukK YWNkusWf6dyzMyiGekEB5M1faz5TCwLb6UfCOxqADm+/0VSi/cg/vKcX8/FERPS6 0BeZ44pYQfXRPEfTADdDxlnDKyEQePlFA5CTKjhJQkKGVi7Gjuiq+BuB318OkqYH vimZ8xry1TC1VCkZUQAEKBSJpout7WmlBtqSFMwqcZEQhyFzzIxtiFwMMF7Tspfu mMSolazV1tsxHblNDIqNANm5fEmcXiZMWufmCfe0T11yfzUWMcXKvmkvv9gPU38U vHb+hrhhbsR0 =CzgI -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 06 02:38:01 2025 Received: (at 79390) by debbugs.gnu.org; 6 Sep 2025 06:38:01 +0000 Received: from localhost ([127.0.0.1]:32866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uumYi-0004oZ-K7 for submit@debbugs.gnu.org; Sat, 06 Sep 2025 02:38:01 -0400 Received: from mta-snd-e02.auone-net.jp ([111.86.247.2]:14816) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uumYZ-0004nm-EV for 79390@debbugs.gnu.org; Sat, 06 Sep 2025 02:37:56 -0400 Received: from kzhr.d1.dion.ne.jp by mta-snd-e02.auone-net.jp with ESMTP id <20250906063746959.TYSV.44998.kzhr.d1.dion.ne.jp@mta-snd-e02.auone-net.jp>; Sat, 6 Sep 2025 15:37:46 +0900 Date: Sat, 06 Sep 2025 15:37:45 +0900 Message-ID: <85ecsk6q86.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito To: Xiyue Deng Subject: Re: bug#79390: 31.0.50; oauth2.el; error in byte-compiling In-Reply-To: <87a538xxd3.fsf@debian-hx90.lan> References: <85frd07w90.wl--xmue@d1.dion.ne.jp> <87ldmsq01z.fsf@zephyr.silentflame.com> <87a538xxd3.fsf@debian-hx90.lan> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/31.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: multipart/mixed; boundary="Multipart_Sat_Sep__6_15:37:45_2025-1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=d1.dion.ne.jp; s=default-1; t=1757140667; bh=HADyj9pT68/6CNFuxbTDxHSi5o+eUPhrYxE9Zmi7rE4=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=aGGRz7JHtV8yTKHI6Km6mbCijHTytAVRXRL5XD3d6DtoQ3InbsolihouMLsP0TGfreCBXJsv 35eFQK0haljJ6Pso9NrLW/WalvUkKq3uZLwRsxhA6m9+YQnawNQIkkAV9ocVVJwAYZswsWf5Cd k3sZEgE+8tkkVwnoK6R6Y9vMqPemf7nyqCVgGoGuglep+NN6+e8y8+ESqSm8Lfi5RdQgo4GTOk gebZgYPfZTaLeLzMvwoG2Ic2kNxAB7F2Y8NjDzIX/bd1ZPCa6APm3qB7/H24H6GJwE8GihIdpt Jz+Rh7scl0GDbCtmvgdBCNEsCrlM/RYvORoc4YbFhmHKfP5g== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79390 Cc: 79390@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Multipart_Sat_Sep__6_15:37:45_2025-1 Content-Type: text/plain; charset=US-ASCII > >> When I byte-compile oauth2.el (0.18), below errors and warnings are > >> displayed and fail to byte-compiling. (snip) > Thanks for the report! I have now pushed a few fixes which should > handle those warnings/errors plus a few other fixes. I have also added > build checks in Gitlab CI. Now tagged v0.18.1. Please help check > whether those fixes work for you. I've tested on 0.18.2 and confirmed errors and warnings were fixed, thank you. But I have one question. In oauth2--update-request-cache, > (when host-name > (let ((host-name (intern host-name))) > (org-plist-delete request-cache host-name) > (setq request-cache > (plist-put request-cache host-name > `( :access-token ,access-token > :request-timestamp ,request-timestamp))))) > request-cache) org-plist-delete returns newly created plist and doesn't modify arguement PLIST, so it does nothing in the above code. Moreover, because next plist-put set new property value, it is no need to delete old property value explicitly. Please see attached patch. -- Kazuhiro Ito --Multipart_Sat_Sep__6_15:37:45_2025-1 Content-Type: text/plain; type=patch; name="0001-oauth2.el-oauth2-update-request-cache-Remove-unneede.patch"; charset=US-ASCII Content-Disposition: attachment; filename="0001-oauth2.el-oauth2-update-request-cache-Remove-unneede.patch" Content-Transfer-Encoding: 7bit >From 4661b972491084d35c23351bd05438cec05e8440 Mon Sep 17 00:00:00 2001 From: Kazuhiro Ito Date: Sat, 6 Sep 2025 15:22:01 +0900 Subject: [PATCH] * oauth2.el (oauth2--update-request-cache): Remove unneeded code. --- oauth2.el | 2 -- 1 file changed, 2 deletions(-) diff --git a/oauth2.el b/oauth2.el index c0aca41c66..612881a615 100644 --- a/oauth2.el +++ b/oauth2.el @@ -39,7 +39,6 @@ ;;; Code: (eval-when-compile (require 'cl-lib)) -(require 'org-macs) (require 'plstore) (require 'json) (require 'url-http) @@ -122,7 +121,6 @@ HOST-NAME is nil, do nothing. Returns the newly updated request-cache." (when host-name (let ((host-name (intern host-name))) - (org-plist-delete request-cache host-name) (setq request-cache (plist-put request-cache host-name `( :access-token ,access-token -- 2.45.1 --Multipart_Sat_Sep__6_15:37:45_2025-1-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 06 05:23:09 2025 Received: (at 79390) by debbugs.gnu.org; 6 Sep 2025 09:23:09 +0000 Received: from localhost ([127.0.0.1]:34422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uup8W-0000Kh-HE for submit@debbugs.gnu.org; Sat, 06 Sep 2025 05:23:09 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]:56807) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uup8P-0000Jp-EY for 79390@debbugs.gnu.org; Sat, 06 Sep 2025 05:23:06 -0400 Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-b4c1fc383eeso1741686a12.1 for <79390@debbugs.gnu.org>; Sat, 06 Sep 2025 02:23:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757150574; x=1757755374; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZP4oeh1w4cuPspky7qsK5L6TfKjuyC1XP6v2AsbTq1c=; b=W3PBV4c/Im7xn8t/NZB+W60JLDxuKKSPH98369uJ0FT8FobWLNf7M3Jarni0yqJahJ 4BlefPXvDY1WIxkcrG09iCRtAuhYeRti4NNumjPREiTFA0MX7lHr1vagFyWvoTqm2Sf0 BXQt5uRiRZHs6WRQMOjTjPKmw0q2dreQqga/e8w6SRIPUeM3Q2da/I+CarZksBcp0E3E 17fTqoMz06XOxltWqnOvIW2rGmCpwuTdaWsewVqG6JhQxOfYsK+OjVSA4U97a7DUcrt/ Qx/n+wwKcZuHCkCDRy90vxI3u3Iz/B6gKci3iT0EK/M4ucwsnTaBdu6yNRoSnq1eNDFw mS9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757150574; x=1757755374; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZP4oeh1w4cuPspky7qsK5L6TfKjuyC1XP6v2AsbTq1c=; b=f/89JJ7TWQPajs7mf7SB2PP1HfyTdPOLMlGUtCYeXkkAYIVKsM4DLpBQfh2wBUEM/l hPohyyIIenh13bqFH9IMBlPq7Cxh65r0pndKjtvpGn/ToUTSEc3TbUsoijMlIH2SvlaH JLCYruU/Y3A5nymm7o8ctk7WLfN77YczfSnhk93MBlJKSGmJOccUwBo4yeNPRl1szsqZ TdTZh3gSF0NdvsafJayezEdhWw7KmjB+gNU6mHMosJJHAIGo3FHnEO3QDkygd+KmFb6c 2cmOt95US3yl5args2wpyK/PToqqDkT0wwT6L/3LJYaSZ9OPabIJs9vNBxeHxhTLH2/n 44Xw== X-Forwarded-Encrypted: i=1; AJvYcCXdg+GCbC3CXK2ltcfYa0prMZJMNR6txqCyw1U3hKKlAD4O80Ce1ekYvOUrK6O9ItgQzYegzA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx5hqsHqb9FQ3w3HGEYIvVGof3YJ6WXQ83RieQRpBkLwR+ysZdA D/c22LPWYxQ9LkTINEQwMUjtUAgNFc+0G/uLbOqNuQRZcbpYtTjh1EKmzAAorQ== X-Gm-Gg: ASbGncvr4bdN9ewggBZO1vPaSU6IzyX6dWIVtqfi0VAcYAhGerhhcDq+1EyFpesTWf9 BxHjS8wnaDfopXrO0UxohVuoA8GT3IzBNGaNX9Ru+4UFnq5j5lnvZXbBkCUqN8uH2JtVbFrWJan uY/SWsnateJDoi5axqW7GtdZNbK4uQ1oAcMYGIsn/ff+ZWgcXo7IeJUKof5c6V/KyOVg31wkhsT QpWfIN+oWkFe1NOMtZJgS/nEMVgrlYDBEOOyPOLtPTp2wn398e0h+4UF4Xs8fNP7VejbwfG/dss MGcoJgsZ2GXwLYrr/mmfvRqZJB7ivl7Egmqk3gauO8HufGuYdmRHc/HlawUFq6zMii1R/zQ9xDV TRWJ/yFvoMe3MdT9EU533kr3waUvqQhenSqkBeEbHxNzCr8uxbSlLsSUDNA3M+tdEi6w= X-Google-Smtp-Source: AGHT+IGOlMfHfeFXR9s5wS8ILQbCeSQgSCvCpkQ6KfRLYX2fDsWnILf96IPvZCSSSEsYimTwzgJ9vQ== X-Received: by 2002:a17:902:f78f:b0:24f:8286:9e54 with SMTP id d9443c01a7336-2516f5209c2mr22631535ad.15.1757150574036; Sat, 06 Sep 2025 02:22:54 -0700 (PDT) Received: from debian-hx90 (syn-076-094-249-045.res.spectrum.com. [76.94.249.45]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24b2daec2dbsm111410315ad.124.2025.09.06.02.22.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Sep 2025 02:22:53 -0700 (PDT) From: Xiyue Deng To: Kazuhiro Ito Subject: Re: bug#79390: 31.0.50; oauth2.el; error in byte-compiling In-Reply-To: <85ecsk6q86.wl--xmue@d1.dion.ne.jp> References: <85frd07w90.wl--xmue@d1.dion.ne.jp> <87ldmsq01z.fsf@zephyr.silentflame.com> <87a538xxd3.fsf@debian-hx90.lan> <85ecsk6q86.wl--xmue@d1.dion.ne.jp> User-Agent: Notmuch/0.39 (https://notmuchmail.org) Emacs/30.1 (x86_64-pc-linux-gnu) Date: Sat, 06 Sep 2025 02:22:50 -0700 Message-ID: <87plc4vst1.fsf@debian-hx90.lan> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79390 Cc: 79390@debbugs.gnu.org, Sean Whitton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Ito-san, Kazuhiro Ito writes: >> >> When I byte-compile oauth2.el (0.18), below errors and warnings are >> >> displayed and fail to byte-compiling. > (snip) > >> Thanks for the report! I have now pushed a few fixes which should >> handle those warnings/errors plus a few other fixes. I have also added >> build checks in Gitlab CI. Now tagged v0.18.1. Please help check >> whether those fixes work for you. > > I've tested on 0.18.2 and confirmed errors and warnings were fixed, > thank you. > But I have one question.=20=20 > > In oauth2--update-request-cache,=20 > >> (when host-name >> (let ((host-name (intern host-name))) >> (org-plist-delete request-cache host-name) >> (setq request-cache >> (plist-put request-cache host-name >> `( :access-token ,access-token >> :request-timestamp ,request-timestamp))))) >> request-cache) > > org-plist-delete returns newly created plist and doesn't modify > arguement PLIST, so it does nothing in the above code. Hmm, when I look at the `org-plist-delete' doc in my 30.1 it seems to suggest it does remove in-place: ,---- | (org-plist-delete PLIST PROPERTY) |=20 | Delete PROPERTY from PLIST. | This is in contrast to merely setting it to 0. `---- And on my test in a previous version of code it did seem to work (for my kinda wrong usage. See below.) > Moreover, > because next plist-put set new property value, it is no need to delete > old property value explicitly. I think you are correct here. [ Well the full story is a bit long: previously I used a string as the key for plist, which partially works because you can use `plist-get' with `string=3D' so that you can get the value back, but when doing `plist-put' I forgot to add a predicate which ended up with many entries with the same string key. Well I could have fixed it by adding the predicate, but it was probably quite late in the night and somehow I ended up trying to remove all previous entries before adding a new one using `org-plist-delete', which also worked. ] Anyway, now I use interned account string as keys (which I think should be faster than using strings with `string=3D') so `plist-put' should just DTRT, and `org-plist-delete' is indeed not needed. I have applied your patch and initial testing shows it is working fine. I'll see if there are any other issues, and tag another release soon. Thanks again! > > Please see attached patch. > > --=20 > Kazuhiro Ito > From 4661b972491084d35c23351bd05438cec05e8440 Mon Sep 17 00:00:00 2001 > From: Kazuhiro Ito > Date: Sat, 6 Sep 2025 15:22:01 +0900 > Subject: [PATCH] * oauth2.el (oauth2--update-request-cache): Remove unnee= ded > code. > > --- > oauth2.el | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/oauth2.el b/oauth2.el > index c0aca41c66..612881a615 100644 > --- a/oauth2.el > +++ b/oauth2.el > @@ -39,7 +39,6 @@ > ;;; Code: >=20=20 > (eval-when-compile (require 'cl-lib)) > -(require 'org-macs) > (require 'plstore) > (require 'json) > (require 'url-http) > @@ -122,7 +121,6 @@ HOST-NAME is nil, do nothing. > Returns the newly updated request-cache." > (when host-name > (let ((host-name (intern host-name))) > - (org-plist-delete request-cache host-name) > (setq request-cache > (plist-put request-cache host-name > `( :access-token ,access-token > --=20 > 2.45.1 > =2D-=20 Regards, Xiyue Deng --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJGBAEBCgAwFiEEiKQfd6o81mjI+LWALell7WOCXJMFAmi7/WoSHG1hbnBoaXpA Z21haWwuY29tAAoJEC3pZe1jglyTZl4P/2NJMuXrzjwmLtMXQsfmn1boQUsaAA0H jrBpRCKzQPYi52ZwtfiZPklSn+2SR8n51xwcQ/vXsDSSfdvpObZkyezmWvnL0VVj id73y+owgDHlSIvPQrJmih+SsO2a7TJP7IcQSxX7GcKBaEFi1zSo6jnWqtpcf4w3 hzFlAA4Qp/yDwMACfBnuK7dv8foo1BOya+DmN8vdwQOEU3NWCkm836oR+ITT7R0n 7UF0oXySp5zy60IeVO9In5FWXZmHDE47TVZgLWftVE6B27kJ9eR6yAaREYZjt6Fh hGPPnJSLMwkWuwqGomUjl5uPQJb+lZzRCcR91NN82fYR3wSApHZffRJbEEcNkmqE B3869L6mgBYNu+kfiA2IkmVtll+CrJSa/WLK0IZfGh+DpPiFYgVVS6THbVcIsCZA XL0L/oRS6w6ZGOKIjEK9detCBZ6wToc1T3bF1zEXgGJy0PUybZ4PlEODpsENZ2mt JaX5r7LTCYY/vr7VbKsMVPO6Lnuk9wdxSTXxcCOH4sNxLt/OKteqoftxQgBqL1Jh MWp170DZIKzEWlX6BzV8lvHu/qFfrjQ8EpZBH8jckgryF9n9rAlR6sTYuj6VsscQ +MsO2z6YQMbSNOjfZlpDsty7cau01tmVfYBH0xudPNtoNHfd5ZBksE4Iyg+C8ib4 yQnRKgaHt9lT =OIRn -----END PGP SIGNATURE----- --=-=-=--