GNU bug report logs - #79385
build: don't force specific warning options on gnulib code

Previous Next

Full log

View this message in rfc822 format

From: Collin Funk <collin.funk1 <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Bruno Haible <bruno <at> clisp.org>, 79385 <at> debbugs.gnu.org
Subject: bug#79385: build: don't force specific warning options on gnulib code
Date: Wed, 03 Sep 2025 18:44:17 -0700

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> On 2025-09-03 16:25, Bruno Haible via Bug reports for GNU grep wrote:
>> Still, in some circumstances, the current state of grep's
>> gnulib-tests/Makefile.am forces errors for warnings
>
> What circumstances are these? For grep we don't recommend
> --enable-gcc-warnings unless you know what you're doing.
>
> In the past I've preferred stricter warnings even for Gnulib, to help
> maintain the Gnulib stuff that I maintain.

If grep is the same as coreutils, then it is --enable-gcc-warnings is
enabled by default when there is a .git subdirectory.

Also, this patch makes things look similar to coreutils:

    $ head -n 3 coreutils/gnulib-tests/Makefile.am 
    AM_CFLAGS = $(GNULIB_TEST_WARN_CFLAGS) $(WERROR_CFLAGS)
    
    include gnulib.mk

Collin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.