From unknown Fri Sep 12 13:30:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79385 <79385@debbugs.gnu.org> To: bug#79385 <79385@debbugs.gnu.org> Subject: Status: build: don't force specific warning options on gnulib code Reply-To: bug#79385 <79385@debbugs.gnu.org> Date: Fri, 12 Sep 2025 20:30:23 +0000 retitle 79385 build: don't force specific warning options on gnulib code reassign 79385 grep submitter 79385 Bruno Haible severity 79385 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 03 19:25:31 2025 Received: (at submit) by debbugs.gnu.org; 3 Sep 2025 23:25:31 +0000 Received: from localhost ([127.0.0.1]:43430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1utwr5-0007nV-5K for submit@debbugs.gnu.org; Wed, 03 Sep 2025 19:25:31 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33616) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1utwr2-0007n4-FK for submit@debbugs.gnu.org; Wed, 03 Sep 2025 19:25:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utwqr-0004uL-Jg for bug-grep@gnu.org; Wed, 03 Sep 2025 19:25:17 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.52]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1utwqp-00036n-Go for bug-grep@gnu.org; Wed, 03 Sep 2025 19:25:17 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1756941911; cv=none; d=strato.com; s=strato-dkim-0002; b=eAqs4rseAFLkASvWKrgD1CMOFPQ1hkEfUlNyFuXbGX9Ztui2mTzNgj/Lu28xb6qJaO nJsks3qpUgeKvqXg6TJ52zGMVtZfbAJPLKmrLLwo+d8iRiCttNXVGVAD+dAwM1aOap/p BhGWoutcidxhwZCYkSt49U016ouAz2fl1pPQ4cnKGgPyDAJe80t/qHcWxGS8wYq/WiFu EVyEdPbgJ+WHbgg3tGapa5hi1kLMf9vr1fKvdLmLep4GIUTeiH3q3lDwBNf9CfPvAO1k vP7l8FGwgXbzSCZHnr7vcpjQZeSXJYFewo8DqxJtrD9R2n36W0kXP41yWvaQs1ahT5GB rbzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1756941911; s=strato-dkim-0002; d=strato.com; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=rIx+jLiTf7CU+L3OuimtQWAAOaBKl6eJvUE2kLWTRDc=; b=Fz2Pll/QlzSlEHkIDRrSdWAUUOtRiZUQu/GZamwFasJfBVj5Tja8JjwLk5XYPAMp4U ZlmF1w0veAdw7PGrBWSE++mh72T8ckj/oUV3o/bz/0gvVi9A+FZD7CF0wrrK5BTu8ifz mr1hsQg2Ws25s48IqJdK/xJJDcdeNLmvrcZImyXDS5fwkOsGWvHJoeTzNMY8IBR4bDoo QkVWWf+kFURX7BMbTTAziANPBGbdLimiPKN66iuLoPQekD0uN1RrOUZ4OO9lVxBusymM XK0uSdQbgEyg6zkgfGNTtHKqjKxffNFEth+zV8+YcjN9jNEL2x7/cx8W4fH9A7thuBDS MjYw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1756941911; s=strato-dkim-0002; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=rIx+jLiTf7CU+L3OuimtQWAAOaBKl6eJvUE2kLWTRDc=; b=qwOXS4iD97AcDM9FSiHqGgLRbBzB4n3VeVFkSOd5V6mXPZwEb+64Z4psyIqxX/asJ6 1qwL1+MrJ4DFd+AVuOj+qRyrPORjWJbxpAaxelxA2Ovp1/cRSLh5jrxA5iViGoUsWSXF VfRsS2VJGwohkDNsp4YqWIYQFIjEuScKNVwLES2kJyncy5Zy4msWap9Ypu71bC04hT9Y xEtNeAgALCoQ9hqjUbVKs8eb2M/7PfMx/U6D61SRliGCEMG9tue7a3ogEp8LAn9LRnzp MDjKKCJKoKih224lu8EHe/8lW/ZFH4WayNF6dWutvBtxVaRGBK/L/3lSAM+xA+goWOsj F6GA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1756941911; s=strato-dkim-0003; d=clisp.org; h=Message-ID:Date:Subject:To:From:Cc:Date:From:Subject:Sender; bh=rIx+jLiTf7CU+L3OuimtQWAAOaBKl6eJvUE2kLWTRDc=; b=a58wVdaA8lqQxgJf3LeZXeVraNAEHOr4ACRuECfBEvVg+Z5pmKMEAwSyhA0lAVNGye 3V0aC+VaUHCDMqgvcACw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlLnY4jECd2hdUURIbZgL8PX2QiTuZ3cdB8X/nqmqeF235XbG12RLCPP5dgnTWurU6" Received: from nimes.localnet by smtp.strato.de (RZmta 52.1.2 AUTH) with ESMTPSA id N9ae63183NPB4f0 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 4 Sep 2025 01:25:11 +0200 (CEST) From: Bruno Haible To: bug-grep@gnu.org Subject: build: don't force specific warning options on gnulib code Date: Thu, 04 Sep 2025 01:25:11 +0200 Message-ID: <4536278.lkGlKoMeLH@nimes> Organization: GNU MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart25492874.oGa5eShVsT" Content-Transfer-Encoding: 7Bit Received-SPF: none client-ip=85.215.255.52; envelope-from=bruno@clisp.org; helo=mo4-p01-ob.smtp.rzone.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --nextPart25492874.oGa5eShVsT Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi, On 2020-11-26, gnulib-tests/Makefile.am was modified, so as to append '-Werror' to the AM_CFLAGS, thus forcing the warning options chosen by the GNU grep maintainer(s) on the GNU gnulib test code. Meanwhile, it was mentioned several times on the Gnulib mailing list that this is unsupported. E.g. https://lists.gnu.org/archive/html/bug-gnulib/2023-08/msg00145.html Still, in some circumstances, the current state of grep's gnulib-tests/Makefile.am forces errors for warnings that the GNU grep maintainer(s) are picky about and the GNU gnulib maintainers allow. Please apply this patch, to respect the code ownership of Gnulib. Thanks. --nextPart25492874.oGa5eShVsT Content-Disposition: attachment; filename="0001-build-Respect-gnulib-code-ownership.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="x-UTF_8J"; name="0001-build-Respect-gnulib-code-ownership.patch" >From 0b4d199504b9b47ccb3105221b1bb843592c920e Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Thu, 4 Sep 2025 01:09:49 +0200 Subject: [PATCH] build: Respect gnulib code ownership. * gnulib-tests/Makefile.am (AM_CFLAGS): Don't augment after including gnulib.mk. --- gnulib-tests/Makefile.am | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gnulib-tests/Makefile.am b/gnulib-tests/Makefile.am index 3085f63..ae4e035 100644 --- a/gnulib-tests/Makefile.am +++ b/gnulib-tests/Makefile.am @@ -1,4 +1,3 @@ -AM_CFLAGS = -include gnulib.mk +AM_CFLAGS = $(GNULIB_TEST_WARN_CFLAGS) $(WERROR_CFLAGS) -AM_CFLAGS += $(GNULIB_TEST_WARN_CFLAGS) $(WERROR_CFLAGS) +include gnulib.mk -- 2.50.1 --nextPart25492874.oGa5eShVsT-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 03 21:01:50 2025 Received: (at 79385) by debbugs.gnu.org; 4 Sep 2025 01:01:50 +0000 Received: from localhost ([127.0.0.1]:43932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1utyMH-0004A6-Sj for submit@debbugs.gnu.org; Wed, 03 Sep 2025 21:01:50 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:37990) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1utyMD-00049m-2Z for 79385@debbugs.gnu.org; Wed, 03 Sep 2025 21:01:47 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 9F5E43C3068C7; Wed, 3 Sep 2025 18:01:38 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id yROqf84fL9y4; Wed, 3 Sep 2025 18:01:38 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 76F3B3C3068CA; Wed, 3 Sep 2025 18:01:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 76F3B3C3068CA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1756947698; bh=yu0DL2uM4VOJ67ix6D2AC23Dwzlq6TI8WdiW2LhnLNk=; h=Message-ID:Date:MIME-Version:To:From; b=rop7qvwzK5dEORn5mJ/cIaJA+4dDQaaVD4HCHvqOpTEh5wxFjvt2zrImVZKa2GPa5 qAhcrGvaO4NNJ48bKqLdYoAp9M8dn2XAdfg7WPb6nT5M4j8MWDGCV86g065sA94M4I 8l9qXcBlnUICSAhE0EWBIkB+XJn9emZ5X0H5W1TF7zRwr86I7GpRsHCp5n7LZ4bUHw c0cLcMF6g1x914leCWVX0qM9Y2WMYXk4U7WvvSzFiO5A7Cc63kEF7pA33i0mDncY9I 87OpPQTrn/2GUJJMY7uUND+y3Migj3V8zjHTd1a0BY2mfHAUNYKTISkqLW2g3dSKSK UAcZupwJlMUOg== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id l65q_SMzPzoq; Wed, 3 Sep 2025 18:01:38 -0700 (PDT) Received: from penguin.cs.ucla.edu (47-154-18-19.fdr01.snmn.ca.ip.frontiernet.net [47.154.18.19]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 5DAD33C3068C7; Wed, 3 Sep 2025 18:01:38 -0700 (PDT) Message-ID: <86ca4f38-01da-4639-b60a-a70ac1ec1387@cs.ucla.edu> Date: Wed, 3 Sep 2025 18:01:38 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#79385: build: don't force specific warning options on gnulib code To: Bruno Haible , 79385@debbugs.gnu.org References: <4536278.lkGlKoMeLH@nimes> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <4536278.lkGlKoMeLH@nimes> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79385 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-09-03 16:25, Bruno Haible via Bug reports for GNU grep wrote: > Still, in some circumstances, the current state of grep's > gnulib-tests/Makefile.am forces errors for warnings What circumstances are these? For grep we don't recommend --enable-gcc-warnings unless you know what you're doing. In the past I've preferred stricter warnings even for Gnulib, to help maintain the Gnulib stuff that I maintain. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 03 21:38:30 2025 Received: (at 79385) by debbugs.gnu.org; 4 Sep 2025 01:38:30 +0000 Received: from localhost ([127.0.0.1]:44043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1utyvl-0005nL-Pr for submit@debbugs.gnu.org; Wed, 03 Sep 2025 21:38:30 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.162]:44989) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1utyva-0005mx-QF for 79385@debbugs.gnu.org; Wed, 03 Sep 2025 21:38:25 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1756949886; cv=none; d=strato.com; s=strato-dkim-0002; b=XvExTnMjZgng/sxzd8stIaS2uC1Q5fT0B8rELy6vAsi8bmxIO+3Ji62b1n0T8jCtYo lhGe7DZML1MF2nlHk+pIvEp2CylbIl6WbWdrVFbNQnNk7r8ylgyhQLbx4+PaeNSo2Vak 3iZXDV/A8cYR0BbQexMeb2YBngCGdF1i884mMLOjGuksThHjDBpC+6nb8NwPtOAJq5wj kl576uBPgHhNkcoPjiNSiOjyUbzEmVQCD/7uM5fF2U6T49WYhNS7zxySVY0lrlRPvXbN IS6q0tHiZWbN/GYtjWVBeQW2pUgImPOQ6ZYKh8lO16OH6jLoB1rNRu/Hj2LO7E0aXR4c 3Pow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1756949886; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=xYyZCfFpernQ+EMnkXJ9kSfCwmTWtKoAcMA3U/Z9cwE=; b=XV+LiIHaLAA3XammZSAOrn0Rq93X07JY5QFKjVLqELJfBcLmTFk5XjdrP4IjzLxH1Q 8+7s+v5/tomg6HWNf+ViVgx+joemTXWOrYKW37JhHNM0OFB0s4799Y1vd5cfcWrLaLpt xCeTFw++HCYMjQOlpeTcus6JlqaTRubNRB5nR/tAPtHtUX6OYHTQtiabCjXVr5lxuiuJ tCPIXkH3zFkYGYVzzdM+grBLirTS5Dczxc0nS6mXjVjr9ZMr2d+ILUsZI6V693O9jeOJ ctJA9b0RoXZ/lKj+1faH0rNc7QhdN6oAXy9Bs2dvTcmFfeT1aQnNg6bwMvYDF7M8wbbt qq+Q== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1756949886; s=strato-dkim-0002; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=xYyZCfFpernQ+EMnkXJ9kSfCwmTWtKoAcMA3U/Z9cwE=; b=UOIQzilx4jxYV9xxVa7LCo1o16nGhBHD47ckR91oFdhcqYrzAu7o5Orq1nNiRlvdqW xwMuqtJwiPtJVb/CQF5FBlDAfmmzmTVdiOavasjMYbVfO8PtjMfRUUl3YFerB1dLcEt9 8Hb5VrERy4YyXtMGVGXz0719p5duUn3OQqplwhB87dFI4xqAgoDmFhgclejj2wj3wj01 2GnpKt+T4FRresY7Oqq28QwkguwQeauviyhJihPVsNh5534yOZya+1aCvG4cCwafFF/b lX3vO/QsgOx/WlkcPFjXOrk7ib4Gnxgy7z7S+cuxC9Af9JM7rrRCuqr2jkw2s/eRY7Jh BNHw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1756949886; s=strato-dkim-0003; d=clisp.org; h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From: Subject:Sender; bh=xYyZCfFpernQ+EMnkXJ9kSfCwmTWtKoAcMA3U/Z9cwE=; b=9Yr4FyB/Hyh1vlbmXdmB3eIxF5pRQV899MdTH2gBOBNMu9+ZA9/PYU6ixWGjhkJDOF FDXbW1teS1k4AG3a2GDw== X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlLnY4jECd2hdUURIbZgL8PX2QiTuZ3cdB8X/nqmqeF235XbG12RLCPP5dgnTWurU6" Received: from nimes.localnet by smtp.strato.de (RZmta 52.1.2 AUTH) with ESMTPSA id N9ae631841c64jl (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Thu, 4 Sep 2025 03:38:06 +0200 (CEST) From: Bruno Haible To: 79385@debbugs.gnu.org, Paul Eggert Subject: Re: bug#79385: build: don't force specific warning options on gnulib code Date: Thu, 04 Sep 2025 03:38:05 +0200 Message-ID: <5037263.Jt7WUSI9oG@nimes> Organization: GNU In-Reply-To: <86ca4f38-01da-4639-b60a-a70ac1ec1387@cs.ucla.edu> References: <4536278.lkGlKoMeLH@nimes> <86ca4f38-01da-4639-b60a-a70ac1ec1387@cs.ucla.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79385 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Paul Eggert wrote: > > Still, in some circumstances, the current state of grep's > > gnulib-tests/Makefile.am forces errors for warnings > > What circumstances are these? As detailed in : $ ./configure --enable-gcc-warnings $ make CFLAGS='-g -O2' V=1 > For grep we don't recommend > --enable-gcc-warnings unless you know what you're doing. Still, --enable-gcc-warnings is enabled by default, in certain situations, through grep/configure.ac lines 107..111. I won't argue about that; that's entirely your choice which GCC warnings to apply to your package. I won't argue about "make CFLAGS='-g -O2'" either; that's part of the freedom that a user has when building a package; see also https://www.gnu.org/software/automake/manual/html_node/User-Variables.html What I'm opposed to is that these users then get a failing build, with an "error" claimed by gcc or clang, and report it as a gnulib "bug", just like it happened two days ago and numerous times before. > In the past I've preferred stricter warnings even for Gnulib, to help > maintain the Gnulib stuff that I maintain. That's OK because this happens on the bug-gnulib mailing list, and because you are listening when I happen to say "this warning option is silly, I don't want to hear about this type of warning in code that I maintain. Whereas the grep/gnulib-tests/Makefile.am is doing a different thing: here the grep maintainer chooses warning options for code in gnulib/tests/ (including code that they don't maintain) and adds '-Werror', thereby triggering "bug" reports to bug-gnulib. My proposed patch has the purpose to stop this. I respect the warning options the grep maintainer chooses for code that they maintain; and I want the grep maintainer to respect the warning options that I choose for code that I maintain. Bruno From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 03 21:44:30 2025 Received: (at 79385) by debbugs.gnu.org; 4 Sep 2025 01:44:30 +0000 Received: from localhost ([127.0.0.1]:44077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1utz1a-00065V-8Z for submit@debbugs.gnu.org; Wed, 03 Sep 2025 21:44:30 -0400 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:59762) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1utz1V-00064z-NC for 79385@debbugs.gnu.org; Wed, 03 Sep 2025 21:44:26 -0400 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-772301f8a4cso761132b3a.3 for <79385@debbugs.gnu.org>; Wed, 03 Sep 2025 18:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756950259; x=1757555059; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=dt9mPkdrVntWATABl9ZIxGNWAwdlfQ8o6bxfNvskr8w=; b=JPChrl7vTF89itpOdDVwjg2Ti0Kh6JpBlXVmb/xX6mMYGBLkZaIOGYNfivcKFgThYZ F0eOrMLwtZg53Bkce27ubSOcO2JaORnx8AwyOoEDZUex8AQt0ZPBrDEu5Usworx8k+CC HJT3Z976KZqKO0fQ+uT9VTP4ziMOZca7UPGzrHpgPaIMrtfE0m249FTBWbUtsE+OwjpU qXcs0WDUoMWwxh+JFOJ4mh/HAyfTFzI4pQM25gmkIADs0+qI5zMOWgI3hOQr3qTGW8zY bCHXfnW4mpDxduGXrAHI4rB7xYVSV73TiaQQQ87yRX+9e9Q9KH3C14HUY4J5NT+NDDK8 YfpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756950259; x=1757555059; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dt9mPkdrVntWATABl9ZIxGNWAwdlfQ8o6bxfNvskr8w=; b=cANAdjeMOivtk5j+rfAIYNYS53LZBCdZWq8qJFKJZhmOQ1QCtkFA/5tR87GPo+NkY8 NYTdcDUTa/QAJ6wQGLRCW48HJKHCyHbI35n2oPn99pKwSyDBokw0qkZtt6J29xNxkkj/ vW9zYXvBcC3iFrjyphWXJUrYY4a7gxlHloM1ps5RnCt+oohmuAp816ulkDIe++6eChYp 13SELMcLIRmnOnbSLF4w9zHBGKjyUyvOwmIuL1QnH+03cM1cs9NZ3oL8PqbsP+BHgAZD /t8FRsQ+EWFLo7cdjpETh43Tr9fukJLy90Uvxx1K98tWPyQMPkBineYDSIZtBgzQPIjY pM6w== X-Forwarded-Encrypted: i=1; AJvYcCWqT4Fy2yV/73wo62ykYYlnsvSMomkPNOGa24vWalpOWbaC7hSFg2MqDLpC77IAnHaw7KZlQQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzUbyt1NAcFEOOH6jLmG65V+Fss58ehN+u1YFBWObFDf/weLPSz wNffsZ9elevuH//buNHF2LEDc5BbluZRsI6rzaE/95XVNQx2xC7DScoYwwUNlfnLLcQ= X-Gm-Gg: ASbGnctfK31eksPMk7NkrBlNreC9XhP9MlMUQH+oE2AirWwfTPIu7kjMNlyLni/o7ee NZ5kB25E3fLS70JvaHyhXoRLnU7RFx9CJWpFxXEywXUlEG3R5zJMZaPMgFn/W7S/xvZ0JnBKyW4 /RlI+a0k86UBz1qywc8zORyfjWnTfkv454rzg3noVkzdCVjnUVKeJbZXn9yLr2zHAZXmAkaFYDN e4wMrSv2WjrTMAnrmlIgLYXLVepyqor4Aw4THEYG0ji5s4dxIvt7rsPKZbutoKlIuvMLWjlwEa1 xeYc/86u3iSOvEhXexU9o3VfayDT/1AyM3qZfTAaKppyJWvZzNIb8169SoNjlzTifSeIk62ctTF M9cAa X-Google-Smtp-Source: AGHT+IH35AqhlPaG8T9LaKlBoJmIwWrGafEtJ79bjmpd/D4AegNjNyYH6mEZkHsHbV3GuYT/bhlIlQ== X-Received: by 2002:a05:6a20:6ca8:b0:243:f625:8d5c with SMTP id adf61e73a8af0-243f6258ef0mr12627142637.46.1756950258919; Wed, 03 Sep 2025 18:44:18 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::cccc]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7723f095d3esm14589152b3a.97.2025.09.03.18.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Sep 2025 18:44:18 -0700 (PDT) From: Collin Funk To: Paul Eggert Subject: Re: bug#79385: build: don't force specific warning options on gnulib code In-Reply-To: <86ca4f38-01da-4639-b60a-a70ac1ec1387@cs.ucla.edu> References: <4536278.lkGlKoMeLH@nimes> <86ca4f38-01da-4639-b60a-a70ac1ec1387@cs.ucla.edu> Date: Wed, 03 Sep 2025 18:44:17 -0700 Message-ID: <87qzwngff2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 79385 Cc: Bruno Haible , 79385@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Paul Eggert writes: > On 2025-09-03 16:25, Bruno Haible via Bug reports for GNU grep wrote: >> Still, in some circumstances, the current state of grep's >> gnulib-tests/Makefile.am forces errors for warnings > > What circumstances are these? For grep we don't recommend > --enable-gcc-warnings unless you know what you're doing. > > In the past I've preferred stricter warnings even for Gnulib, to help > maintain the Gnulib stuff that I maintain. If grep is the same as coreutils, then it is --enable-gcc-warnings is enabled by default when there is a .git subdirectory. Also, this patch makes things look similar to coreutils: $ head -n 3 coreutils/gnulib-tests/Makefile.am AM_CFLAGS = $(GNULIB_TEST_WARN_CFLAGS) $(WERROR_CFLAGS) include gnulib.mk Collin From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 03 23:27:10 2025 Received: (at 79385) by debbugs.gnu.org; 4 Sep 2025 03:27:10 +0000 Received: from localhost ([127.0.0.1]:44264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uu0cw-0005JA-ED for submit@debbugs.gnu.org; Wed, 03 Sep 2025 23:27:10 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:49458) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uu0cq-0005Ia-Fu for 79385@debbugs.gnu.org; Wed, 03 Sep 2025 23:27:08 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 16DED3C2BE579; Wed, 3 Sep 2025 20:26:58 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id zXi74eHKOpxL; Wed, 3 Sep 2025 20:26:58 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id DF3573C3068D3; Wed, 3 Sep 2025 20:26:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu DF3573C3068D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1756956417; bh=2lmKLxQ6S4Cy9aHukq4icEPltC6EO3PhJjY0UN6V87w=; h=Message-ID:Date:MIME-Version:To:From; b=mnehioRA2CEDpgRNXgYRIfSjkDb5r8lC7SON5FU4PQxpAtVYddFSqowkDVZd0blzW LFfg+r5hIkO9VvcLWfnlkeaqo7fpSRI+GOhaIrpAHsQJWHOqzn7sNFw5QqFDW097Hj z2Flvtf17h+Pu9WZmJxqhyyOv6NHNDD6Xtz8Wn2SP2A/2DevMRKrMMZWXbxLXN+PN2 qZ3rmd7wslCQSbLpEyhq9CvQCuOqqeFAmZoBNWGy2sQi3X9O7sjHwiWAnJdiK9LHwp EVmcEDezshYdi6acy5g3T2u49McxNmb6CXVrj9DHDEBowBEVLt6ZewN8mo3Nw8oX9+ TOECZCLWNH67g== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id vEH0wCBRSJ7k; Wed, 3 Sep 2025 20:26:57 -0700 (PDT) Received: from penguin.cs.ucla.edu (47-154-18-19.fdr01.snmn.ca.ip.frontiernet.net [47.154.18.19]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id BFAA23C2BE579; Wed, 3 Sep 2025 20:26:57 -0700 (PDT) Message-ID: <3579b624-87ef-458c-a894-8c55368722a8@cs.ucla.edu> Date: Wed, 3 Sep 2025 20:26:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#79385: build: don't force specific warning options on gnulib code To: Bruno Haible References: <4536278.lkGlKoMeLH@nimes> <86ca4f38-01da-4639-b60a-a70ac1ec1387@cs.ucla.edu> <5037263.Jt7WUSI9oG@nimes> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <5037263.Jt7WUSI9oG@nimes> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79385 Cc: 79385@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2025-09-03 18:38, Bruno Haible wrote: >> What circumstances are these? > As detailed in > : > > $ ./configure --enable-gcc-warnings > $ make CFLAGS='-g -O2' V=1 But that bug report is about vma-iter, which grep doesn't use.