Subject: Re: bug#79367: 31.0.50; magit-commit sometimes doesn't work if diff-hl-update-async is t

From: Spencer Baugh <[email-masked]>
Date: Tue, 02 Sep 2025 09:56:47 -0400

Zhengyi Fu <[email-masked]> writes:
> Spencer Baugh <[email-masked]> writes:
>>>> Further debugging through gdb revealed more details: the `thread'
>>>> member of the fd_callback_info entry for the server connection
>>>> references the diff-hl-async thread, which is already exited.
>>
>> This aspect sounds similar to bug#79201.
>>
>> Zhengyi, I assume you're testing with an Emacs built from source.  Can
>> you check whether the Emacs you're building includes commit
>> 37325ed5a9c7f62c35b368d9530496ed31404940, which was pushed just a couple
>> weeks ago?  If not, can you pull and test again?
>
> Yes, it includes that commit.
>
>> If that doesn't fix it (or you already had that commit), can you try
>> reverting commits 034d755f2f21088b97fdb0a34d846c39fcdbf46d then
>> c93be71e45d4cebeb017c813426228e579e9381d and test again?
>
> After reverting those two commits, it worked fine.

Thanks for testing.

I believe the right fix is to revert those commits, since they are
already breaking existing code using threads.