Subject: bug#79367: 31.0.50; magit-commit sometimes doesn't work if diff-hl-update-async is t

From: Zhengyi Fu <[email-masked]>
Date: Tue, 02 Sep 2025 21:46:56 +0800

Spencer Baugh <[email-masked]> writes:

>>
>> Spencer and Dmitry, do you agree?
>
> No.  At worst, the locking of the new connection should match that of
> the existing process.  The new connection should not randomly be locked
> to the thread which happened to run wait_reading_process_output.
>
>>> Further debugging through gdb revealed more details: the `thread'
>>> member of the fd_callback_info entry for the server connection
>>> references the diff-hl-async thread, which is already exited.
>
> This aspect sounds similar to bug#79201.
>
> Zhengyi, I assume you're testing with an Emacs built from source.  Can
> you check whether the Emacs you're building includes commit
> 37325ed5a9c7f62c35b368d9530496ed31404940, which was pushed just a couple
> weeks ago?  If not, can you pull and test again?

Yes, it includes that commit.

> If that doesn't fix it (or you already had that commit), can you try
> reverting commits 034d755f2f21088b97fdb0a34d846c39fcdbf46d then
> c93be71e45d4cebeb017c813426228e579e9381d and test again?

After reverting those two commits, it worked fine.