From unknown Tue Sep 09 00:44:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79356 <79356@debbugs.gnu.org> To: bug#79356 <79356@debbugs.gnu.org> Subject: Status: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt Reply-To: bug#79356 <79356@debbugs.gnu.org> Date: Tue, 09 Sep 2025 07:44:36 +0000 retitle 79356 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't = decrypt reassign 79356 emacs submitter 79356 Sean Whitton severity 79356 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 31 12:25:47 2025 Received: (at submit) by debbugs.gnu.org; 31 Aug 2025 16:25:47 +0000 Received: from localhost ([127.0.0.1]:54961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usksF-0004Dx-Al for submit@debbugs.gnu.org; Sun, 31 Aug 2025 12:25:47 -0400 Received: from lists.gnu.org ([2001:470:142::17]:44052) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1usksC-0004Di-2Z for submit@debbugs.gnu.org; Sun, 31 Aug 2025 12:25:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1usks4-0005qk-Jb for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2025 12:25:37 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uskrz-0006Yo-Fg for bug-gnu-emacs@gnu.org; Sun, 31 Aug 2025 12:25:33 -0400 DKIM-Signature: a=rsa-sha256; b=lWaiZlFUXhYrx2gHto7qlhsSk3wbmfAuLRKODHhHBrYijG9SmbrMZkLr5XocoC+FkH3nNrcENoMg31qTO+vuOsp05zIEwZ06BRS8PZSwR5DGvPotlJswSl9wNrTDCe9drRsAxuUwWof6ERzbkHRBvh5LcvCH7gvXMLgnoA7o1n60vXDL7SJeI9uwMQL6wlEAOTMJcNEYmgytMnalVGxxwATR7SJ9xpQDp7/eK4rnnOuhGygx8R23I6raO58qD7lsMFDF5yBntjcGYsyTvb5HQC05mcagRyGwaaOiVjHwYF4otOZwA/kMN16qGxx56KajUof3E++x1HzItfKlU72Pcg==; s=purelymail1; d=spwhitton.name; v=1; bh=YC2m2y66Jjbjm+mH/fJcqsPTLEwe+d7OYmtlRonzQp0=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=iqU4fwPXizVlhSt3AkcdtoCYNSEnjB9j3ImQQ6GXApANcrGlv0CU1cW+qR5poFUUI7sffDeksbxCzF4gML8YVl9Vml82QG8D6TJtdGSWTaIGNGFEuSGyVw7C77YyeHalH6ruLXpOI60wJF3oyeFjNunSVDET/+kZ9gv4zMUiltgPzulVnarIefI0LJjF81NBWJSLlRWkfMyMwpi1zc2tGlpkMtFPtW1MaN0ehIponkrPOUwdL4FoQvXoeeFXT4X71UmiHRh/Vs7ofVpohdsoCWUnLqS+OMMUW6eLxHOwDvyq0qHUM9CmB5/ZPLHMwz9sSZ5I4L9ahIzwrBJkfvA0qQ==; s=purelymail1; d=purelymail.com; v=1; bh=YC2m2y66Jjbjm+mH/fJcqsPTLEwe+d7OYmtlRonzQp0=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: bug-gnu-emacs@gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1655884702 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 31 Aug 2025 16:25:28 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id D216A94014B; Sun, 31 Aug 2025 17:25:27 +0100 (BST) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt Date: Sun, 31 Aug 2025 17:25:27 +0100 Message-ID: <87bjnvlaq0.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GAPPY_SUBJECT=0.1, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: X-debbugs-cc: monnier@iro.umontreal.ca If you try to use 'C-x p r' in emacs.git it exits partway through because insert-file-contents for etc/package-keyring.gpg cannot succeed. EPA tries to decrypt the file but can't because it's a keyrin [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.1 GAPPY_SUBJECT Subject: contains G.a.p.p.y-T.e.x.t X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) X-debbugs-cc: monnier@iro.umontreal.ca If you try to use 'C-x p r' in emacs.git it exits partway through because insert-file-contents for etc/package-keyring.gpg cannot succeed. EPA tries to decrypt the file but can't because it's a keyring. It even suggests what the problem is: --8<---------------cut here---------------start------------->8--- Error while decrypting with "/usr/bin/gpg2": gpg: decrypt_message failed: Unexpected error (File possibly not an encrypted file, but is perhaps a key ring file?) --8<---------------cut here---------------end--------------->8--- The problem is a bit more general than just keyrings. In other repositories I work with there are encrypted files used as test suite data. I don't have the keys in my personal keyring; the keys too are dummy test suite data, loaded up by the test suite. In either case the presence of these files shouldn't make it impossible to use 'C-x p r'. So how about doing something like this: --8<---------------cut here---------------start------------->8--- diff --git a/lisp/fileloop.el b/lisp/fileloop.el index d7d2aa7e0d5..fd749353753 100644 --- a/lisp/fileloop.el +++ b/lisp/fileloop.el @@ -121,10 +121,17 @@ fileloop-next-file (kill-all-local-variables) (erase-buffer) (setq new next) - (condition-case nil + (condition-case err (insert-file-contents new nil) (file-missing - (fileloop-next-file novisit)))) + (fileloop-next-file novisit)) + (file-error + (unless + (and (equal (caddr err) "Can't decrypt") + (y-or-n-p (substitute-quotes + (format "Couldn't decrypt `%s'; skip it?" + (abbreviate-file-name new))))) + (signal (car err) (cdr err)))))) new))) (defun fileloop-continue () --8<---------------cut here---------------end--------------->8--- -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 01 00:00:12 2025 Received: (at 79356) by debbugs.gnu.org; 1 Sep 2025 04:00:12 +0000 Received: from localhost ([127.0.0.1]:55998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usviF-0006W9-Oa for submit@debbugs.gnu.org; Mon, 01 Sep 2025 00:00:12 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47659) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1usviD-0006Uj-Uf for 79356@debbugs.gnu.org; Mon, 01 Sep 2025 00:00:10 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7083D100383; Mon, 1 Sep 2025 00:00:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1756699202; bh=yoe7cs8wvX9uZAZ4zK7FS+JoPG8M0QSD4iCmiR5OdhY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IJMzjHMLadPKG2UJ90HIIXu9uwmf88h74LeRSvMnYabvdOOcGmalMaPvyBzALuZEO Eh9Rz3Ct9lcPAQEG3gdcpdiz3D1UfT8WY6Y3m50xp3dDcQYFeOcBLPLbBglpis4Txg ldfKf8H+Mo62CAp0odX+DaHSwF13Tpb1c0omQkB8uTix3AQ+6plwvt8Uzf0K3G+x1U qJz+/NvAwcuvrjZdzfZ2cphEcQzB0jrCC4X/c1s06qYZH6Ug693C0eG9HD/qng/Hy7 MuVy/XtVApNHrCaTEZiSea6kJeEY+gCu0Gg08d5lsRfyaASHDI9ofN2/FyUyHUBBPn +cXsqlrJKqKWw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 54728100034; Mon, 1 Sep 2025 00:00:02 -0400 (EDT) Received: from alfajor (69-165-161-194.dsl.teksavvy.com [69.165.161.194]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 28466120568; Mon, 1 Sep 2025 00:00:02 -0400 (EDT) From: Stefan Monnier To: Sean Whitton Subject: Re: bug#79356: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt In-Reply-To: <87bjnvlaq0.fsf@zephyr.silentflame.com> Message-ID: References: <87bjnvlaq0.fsf@zephyr.silentflame.com> Date: Mon, 01 Sep 2025 00:00:01 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.178 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain GAPPY_SUBJECT 0.1 Subject: contains G.a.p.p.y-T.e.x.t X-SPAM-LEVEL: X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 79356 Cc: 79356@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) > --8<---------------cut here---------------start------------->8--- > diff --git a/lisp/fileloop.el b/lisp/fileloop.el > index d7d2aa7e0d5..fd749353753 100644 > --- a/lisp/fileloop.el > +++ b/lisp/fileloop.el > @@ -121,10 +121,17 @@ fileloop-next-file > (kill-all-local-variables) > (erase-buffer) > (setq new next) > - (condition-case nil > + (condition-case err > (insert-file-contents new nil) > (file-missing > - (fileloop-next-file novisit)))) > + (fileloop-next-file novisit)) > + (file-error > + (unless > + (and (equal (caddr err) "Can't decrypt") > + (y-or-n-p (substitute-quotes > + (format "Couldn't decrypt `%s'; skip it?" > + (abbreviate-file-name new))))) > + (signal (car err) (cdr err)))))) > new))) The (equal (caddr err) "Can't decrypt") is rather hideous and brittle, especially given that `fileloop` is a generic operation that shouldn't know about EPA. How 'bout we just prompt for all `file-error`s? After all, the same kind of reasoning applies to invalid .gz files, or files for which we don't have read access, ... Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 01 04:45:09 2025 Received: (at 79356) by debbugs.gnu.org; 1 Sep 2025 08:45:09 +0000 Received: from localhost ([127.0.0.1]:56648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ut0A1-000424-27 for submit@debbugs.gnu.org; Mon, 01 Sep 2025 04:45:09 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:37282) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ut09y-0003ws-05 for 79356@debbugs.gnu.org; Mon, 01 Sep 2025 04:45:06 -0400 DKIM-Signature: a=rsa-sha256; b=qKiVzh6wD1G3+Ixi1UKKImoVKNueZIWuZ1zD+QFCenXPuvf9kQ26gdULsTaIInaNJdJv2XtpEIVLUzccFXlmdEvX41q0iqeAKkSbzJQXOzI6N7bcmPyRhD8PpHl3ao2Lmf6O1NM6Qy7dRSUx/MgunmqZaHjXGis8YIF8R5X9s5jS/7auuOe7diyP+OEwfZATnWA1msE0GiJSZ7vny7d20zonu5IbyG84JHtwTJvEs/CghlD1UIk1U6wRspnhp7czWTYRmIpZL2WWv4Xc2c/93TxBlbyXWQfxuKGfWQ1mHsycACni7mbOC80Zy8aifZTld/N8CJnHCfStRaChkBBQgg==; s=purelymail1; d=spwhitton.name; v=1; bh=Es9WyKAb8V2qAERqXuAj+DJiCAVQxM11CfBl8rJ416M=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=j2DSgP4evaPzWgAehN1av5hiur4coseMba2jBdN0qFu5odNdyuuzIddIeplcGC00VXWUQ9lLq9cY9+d2h6+D+azTKsHHLnnNI6V80fz6FgHAqzTRRt50o1Jsne9EqgjqaX6j5DKEgK83z1ikvxZcuANtrpsVMlIsW4NoX3ohq2oBb/f2+XwNy0RyPMI9htqw5+JuGqBpbu6/mvJsdjkPeIVC3X5J+GEYIGzmrdEL20Z9+gPwcuN9TS3UJvvdFvFunFJAyXcMajGm8OL2sEabcx4v7n/jFtwJ3UhszSw++UpEazMtcL/jiAOGSUhvZuf+QIzjHBkyP8Y27DhQQS1NEg==; s=purelymail1; d=purelymail.com; v=1; bh=Es9WyKAb8V2qAERqXuAj+DJiCAVQxM11CfBl8rJ416M=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79356@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 2132378282; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Mon, 01 Sep 2025 08:44:59 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id ED6E29405FB; Mon, 01 Sep 2025 09:44:58 +0100 (BST) From: Sean Whitton To: Stefan Monnier Subject: Re: bug#79356: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt In-Reply-To: References: <87bjnvlaq0.fsf@zephyr.silentflame.com> Date: Mon, 01 Sep 2025 09:44:58 +0100 Message-ID: <87v7m2imt1.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 79356 Cc: 79356@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) Hello, On Mon 01 Sep 2025 at 12:00am -04, Stefan Monnier wrote: > The (equal (caddr err) "Can't decrypt") is rather hideous and brittle, > especially given that `fileloop` is a generic operation that shouldn't > know about EPA. Yes. > How 'bout we just prompt for all `file-error`s? After all, the same > kind of reasoning applies to invalid .gz files, or files for which we > don't have read access, ... I realised after trying out my patch a bit that the prompting is a bit annoying. It's common to interrupt and then restart 'C-x p r' operations but that means you get prompted over and over again for the same files. How about converting `file-error's into warnings? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 01 11:45:58 2025 Received: (at 79356) by debbugs.gnu.org; 1 Sep 2025 15:45:58 +0000 Received: from localhost ([127.0.0.1]:58256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ut6jF-0006N9-Tw for submit@debbugs.gnu.org; Mon, 01 Sep 2025 11:45:58 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43315) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ut6jE-0006BR-P5 for 79356@debbugs.gnu.org; Mon, 01 Sep 2025 11:45:57 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 56723440F71; Mon, 1 Sep 2025 11:45:51 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1756741550; bh=wmCvMQblMWKfTIsFPiLLnXO/fCSJtq0YqXnVAygx5M0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=O2KYfh+qDWNHDteXU2BprdMjWE+thbgUxa8M42b55LcE1j0DG6Oh9VnsyQZK9Etcq 5k8WsY9V6rTz+4SHK+F/hi93cDRUGfkBI6asAOQqkYj9OA19mz2xLNIjELjAfQR0EM 65aammAGQXWBGXP9u4BSMWa/yytAb81DoYeji5qr0gSVVzHD0nlFRZl81+O3Z4cXQ8 a8X4sIX9fv3BRabJ6N5qfpLLkkQBC3Qa0s0qGMpwmEOQzI0NGvm2CFZU8+D8DeT1sw +TmHOgtSrvpw52+d6+Ca/RJyen9M3Pz7DSWQNKGoRd6eTE+ZD5ClCF7tl2ymBxzqTv SE74FhkullH9Q== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5FF30440F61; Mon, 1 Sep 2025 11:45:50 -0400 (EDT) Received: from alfajor (69-165-161-194.dsl.teksavvy.com [69.165.161.194]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2CFC81203B6; Mon, 1 Sep 2025 11:45:50 -0400 (EDT) From: Stefan Monnier To: Sean Whitton Subject: Re: bug#79356: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt In-Reply-To: <87v7m2imt1.fsf@zephyr.silentflame.com> Message-ID: References: <87bjnvlaq0.fsf@zephyr.silentflame.com> <87v7m2imt1.fsf@zephyr.silentflame.com> Date: Mon, 01 Sep 2025 11:45:49 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.105 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain GAPPY_SUBJECT 0.1 Subject: contains G.a.p.p.y-T.e.x.t X-SPAM-LEVEL: X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 79356 Cc: 79356@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) >> How 'bout we just prompt for all `file-error`s? After all, the same >> kind of reasoning applies to invalid .gz files, or files for which we >> don't have read access, ... > I realised after trying out my patch a bit that the prompting is a bit > annoying. It's common to interrupt and then restart 'C-x p r' > operations but that means you get prompted over and over again for the > same files. > How about converting `file-error's into warnings? Fine by me (probably better if they're batched). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 02 08:43:06 2025 Received: (at 79356) by debbugs.gnu.org; 2 Sep 2025 12:43:07 +0000 Received: from localhost ([127.0.0.1]:33096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1utQLp-0008Ed-DC for submit@debbugs.gnu.org; Tue, 02 Sep 2025 08:43:06 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:45904) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1utQLj-0008DJ-Os for 79356@debbugs.gnu.org; Tue, 02 Sep 2025 08:43:02 -0400 DKIM-Signature: a=rsa-sha256; b=krmGKlMN7caH/pNBxxQQkpY1zJ315iqqbScCdCPnemOhxCPtLGVFOEGSuGIzN+/DhVE+IUgKDrWqFgXJR4vkNCzokM9s3F3nBY556DfnyrIL+1lp+Z1MtJ0Q2b5nGLlAfuakgXnp5qpb6TPlkkcNH0MxI81nRcxVIByQ6MeZqt+OkUpdCnJys2YsNbYPsmFD3d85qI4UL9w3vRrFS6AW5pEHhXa45EhoebeFV1eH0tMw01Z53A11kjxI5+Fgzc/lQFV5UxNcYGol8AhiC1KVV6wvdMbtQanXsBJGMOAOtnDoFF2xALAy6YmFNrsx/31hArSFpREJWwq3ZDVsWyEZDQ==; s=purelymail1; d=spwhitton.name; v=1; bh=t2tUcZUlaZgYQlX4c7vEV/pEy8sDBhJJsdDYzwyJFRA=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=Mu/JrskM2fjXKJRczMoa7QUoH9nVdIwF3Fd643DvCRm/MTyOa3X8Wxzqj5tZVw/8XksqkT0k4MZAcWZ89FJe0zq4JSEomVMCbiajWo4WovoJPERPfXeB/XWNGsHU/tpv6uFadXH45UGo4WDp+sKP9GV00XeTqsOGd34URxXzlcY2l1ELbHCO9Q80YWWOkHF3SHgmNSdCodAftvq1/mV9XFEk3oV0PtZfx0giTCJMn1i0xG7d86jmo5Nxy/UGDvyvi8cnhbAiF5lSkYzYDIAPpJ7i6TpFnLkLsXuhsqx+L90dVNgERQejzPq3aIaA95g2b+9vpK9CpiKq28HWfyey+g==; s=purelymail1; d=purelymail.com; v=1; bh=t2tUcZUlaZgYQlX4c7vEV/pEy8sDBhJJsdDYzwyJFRA=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79356@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 2039308599; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 02 Sep 2025 12:42:50 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 29B649405FC; Tue, 02 Sep 2025 13:42:50 +0100 (BST) From: Sean Whitton To: Stefan Monnier Subject: Re: bug#79356: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt In-Reply-To: References: <87bjnvlaq0.fsf@zephyr.silentflame.com> <87v7m2imt1.fsf@zephyr.silentflame.com> Date: Tue, 02 Sep 2025 13:42:50 +0100 Message-ID: <875xe1f2k5.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 79356 Cc: 79356@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --=-=-= Content-Type: text/plain Hello, On Mon 01 Sep 2025 at 11:45am -04, Stefan Monnier wrote: >>> How 'bout we just prompt for all `file-error`s? After all, the same >>> kind of reasoning applies to invalid .gz files, or files for which we >>> don't have read access, ... >> I realised after trying out my patch a bit that the prompting is a bit >> annoying. It's common to interrupt and then restart 'C-x p r' >> operations but that means you get prompted over and over again for the >> same files. >> How about converting `file-error's into warnings? > > Fine by me (probably better if they're batched). delay-warning seems to be sufficient to batch them up. Let me know what you think of this. -- Sean Whitton --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-fileloop-next-file-Convert-file-error-to-warnings.patch >From 056938803a5502f8427c6e97a74fa5b29a1d60c9 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Tue, 2 Sep 2025 13:42:26 +0100 Subject: [PATCH] fileloop-next-file: Convert file-error to warnings * lisp/fileloop.el (fileloop-next-file): Catch file-error and convert to a delayed warning (bug#79356). --- lisp/fileloop.el | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lisp/fileloop.el b/lisp/fileloop.el index d7d2aa7e0d5..903c5cca0a7 100644 --- a/lisp/fileloop.el +++ b/lisp/fileloop.el @@ -121,10 +121,16 @@ fileloop-next-file (kill-all-local-variables) (erase-buffer) (setq new next) - (condition-case nil + (condition-case err (insert-file-contents new nil) (file-missing - (fileloop-next-file novisit)))) + (fileloop-next-file novisit)) + (file-error + ;; See bug#79356 for discussion. + (let ((msg (error-message-string err))) + (unless (string-search new msg) + (setq msg (format "%s, %s" msg new))) + (delay-warning 'file-error msg :error))))) new))) (defun fileloop-continue () -- 2.47.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 02 10:00:44 2025 Received: (at 79356) by debbugs.gnu.org; 2 Sep 2025 14:00:44 +0000 Received: from localhost ([127.0.0.1]:34920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1utRYx-00062C-SV for submit@debbugs.gnu.org; Tue, 02 Sep 2025 10:00:44 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:58686) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1utRYu-00061M-11 for 79356@debbugs.gnu.org; Tue, 02 Sep 2025 10:00:40 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7ACC980BF9; Tue, 2 Sep 2025 10:00:33 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1756821632; bh=EHRDScHzkCkTTsd8FJBbm+3Fjuwf5c60OJPJ7J+ca78=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=DR0o0NZ11hy6nn1ccuqdevxdpzUorETOaJIN8kNN8rnaQ74sKFsx7mJlARQQyHYkp 6GUcv8dn6F1aUSAglb+kQ5tRQMTlDwTZ2vOzprmgIg3XpjASEjWsY8vGoTaGSgAFfV fysAIsgjwR0/80z/8340+CBR7VjQTbNz0v9Yhaa6WtP8pGfeZPdUGvZ8KCf37Bd5LG bOo9LSf7gguXbmJgG43pa1jj0uk2aXwmLp2l9YpWCBlSw3NqMXMO0C+Kw2q8hCICpN 1UOARblF6hbXoRi+F+rOPaJHyMG1HfNP44rTth+7pP5vk4iRj1A3XnQBX7iBbuexke ZMkyiY6ow2uEw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 981148034A; Tue, 2 Sep 2025 10:00:32 -0400 (EDT) Received: from pastel (69-165-161-194.dsl.teksavvy.com [69.165.161.194]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 548271203B6; Tue, 2 Sep 2025 10:00:32 -0400 (EDT) From: Stefan Monnier To: Sean Whitton Subject: Re: bug#79356: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt In-Reply-To: <875xe1f2k5.fsf@zephyr.silentflame.com> Message-ID: References: <87bjnvlaq0.fsf@zephyr.silentflame.com> <87v7m2imt1.fsf@zephyr.silentflame.com> <875xe1f2k5.fsf@zephyr.silentflame.com> Date: Tue, 02 Sep 2025 10:00:31 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.301 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain GAPPY_SUBJECT 0.1 Subject: contains G.a.p.p.y-T.e.x.t X-SPAM-LEVEL: X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 79356 Cc: 79356@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) > From 056938803a5502f8427c6e97a74fa5b29a1d60c9 Mon Sep 17 00:00:00 2001 > From: Sean Whitton > Date: Tue, 2 Sep 2025 13:42:26 +0100 > Subject: [PATCH] fileloop-next-file: Convert file-error to warnings > > * lisp/fileloop.el (fileloop-next-file): Catch file-error and > convert to a delayed warning (bug#79356). > --- > lisp/fileloop.el | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/lisp/fileloop.el b/lisp/fileloop.el > index d7d2aa7e0d5..903c5cca0a7 100644 > --- a/lisp/fileloop.el > +++ b/lisp/fileloop.el > @@ -121,10 +121,16 @@ fileloop-next-file > (kill-all-local-variables) > (erase-buffer) > (setq new next) > - (condition-case nil > + (condition-case err > (insert-file-contents new nil) > (file-missing > - (fileloop-next-file novisit)))) > + (fileloop-next-file novisit)) > + (file-error > + ;; See bug#79356 for discussion. > + (let ((msg (error-message-string err))) > + (unless (string-search new msg) > + (setq msg (format "%s, %s" msg new))) > + (delay-warning 'file-error msg :error))))) > new))) Not sure ", " is the best syntax (I'd have used ": ", instead), but that looks good enough to me, thanks. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 02 10:44:02 2025 Received: (at 79356-done) by debbugs.gnu.org; 2 Sep 2025 14:44:02 +0000 Received: from localhost ([127.0.0.1]:35433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1utSEs-0002JG-Cf for submit@debbugs.gnu.org; Tue, 02 Sep 2025 10:44:02 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:54752) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1utSEm-0002IP-Nk for 79356-done@debbugs.gnu.org; Tue, 02 Sep 2025 10:43:58 -0400 DKIM-Signature: a=rsa-sha256; b=JGV34QflykEGkGchX7vsPTVrrs79By0+qJ3B+ZmtQJvt1zM2fb30KFPE02KTgCIbxCulCMudWADU986x36TfGy9tCJUaBo9XCPGXsGUSB/HXEgYofSH/Jl0GBbHgd+rirkZD/tyJRSFM+BpexonPbCC9ov8OHRNQ7/VXw3ied1C+4wSIU0KprgKlF1dxA24EvI6C+yY3n6sDQ7g9DaI5/M02YDYk6n2rs+0M2JA4rBMCjuXWMf13s2NCUl2PxabJmoLp6eJLWb97EvbGkcM1G3U3UWWvNJwoqcj4GXZZ8UwRZP2s0QwKMoCgAbsSTWqa1biKF7QJ6qvQafGM96hJzQ==; s=purelymail1; d=spwhitton.name; v=1; bh=zw+yQnomNpjlMRWxObUZPOa9YfOC7+9BxlZpcI+xMbU=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=KqY8wRaNyu7DNPTkDnGE0MqCE9bgR9nE8BcVdoIakw0TV8PGORBMRJ43kPAYXnhUe2B6VSKCIko3dtLVnF6yIo0VBxu2+A4QsywVDYLXRki8yr+svT64DsOaR75ZgNPMH+BskNEjVz1RDG/NRPOUeau7Ngao10VSzt9IT91EZq2vNoldve0+AJni/DGsLUklXufgsgyVAoD3CgOwcbb3Zq3RW7jkUeiqlB+bkuUNppI/wECoGsoyTBTAmCnidt6vwHdqgLFM55Q5SnRdilvgJLI0ZKPo/dOWgpfj3kiC8Ubb3mY+e41bPfhyLs6sZ4zrRurpzwJY1p6qSyAkRe33dA==; s=purelymail1; d=purelymail.com; v=1; bh=zw+yQnomNpjlMRWxObUZPOa9YfOC7+9BxlZpcI+xMbU=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79356-done@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1379825532; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 02 Sep 2025 14:43:47 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 1DBB39405FC; Tue, 02 Sep 2025 15:43:46 +0100 (BST) From: Sean Whitton To: Stefan Monnier Subject: Re: bug#79356: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt In-Reply-To: References: <87bjnvlaq0.fsf@zephyr.silentflame.com> <87v7m2imt1.fsf@zephyr.silentflame.com> <875xe1f2k5.fsf@zephyr.silentflame.com> Date: Tue, 02 Sep 2025 15:43:46 +0100 Message-ID: <87v7m0ewyl.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 79356-done Cc: 79356-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Version: 31.1 Hello, On Tue 02 Sep 2025 at 10:00am -04, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > Not sure ", " is the best syntax (I'd have used ": > ", instead), but that looks good enough to me, thanks. I did the colon-separated format first but then I noticed that other file-errors which were firing were putting it at the end. I've switched it back to the colon-separated format for now, anyway, and installed. Thanks! -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 02 13:05:31 2025 Received: (at 79356-done) by debbugs.gnu.org; 2 Sep 2025 17:05:32 +0000 Received: from localhost ([127.0.0.1]:36399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1utURn-0002LB-Ji for submit@debbugs.gnu.org; Tue, 02 Sep 2025 13:05:31 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47525) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1utURk-0002Kw-Uy for 79356-done@debbugs.gnu.org; Tue, 02 Sep 2025 13:05:30 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 137C7442244; Tue, 2 Sep 2025 13:05:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1756832722; bh=No14x2AWh6riAPydrIwYR/C3FvFh4JdtYrTxM6QGH7E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=H4l0ij3jxC3hDOTZomq1KaKwI0KmyWrfssfO6HubEvW5IikbEYco8bOUzsv2ZfWhW w3DwDcy5vO/JqfDmf/igNNAqMAVhenPfXbZ5c7IX9bjpyIO5omofx5b9IYx0eLa+Wo PetaVlAC3CavvS2WGXzwktiLM4RX/noYmcjfpXYV5GaWlSzST5BDK3KDbt2LNipIYP tZvOyxQex0mZHNFuZd3rBtddASpfpUr9gHAh+p6ryG3hXsmWVMoJdGPRhaGfbpy5Eq QOTcUOWHFq/veb68lfL+59p6uQgku5GWUvse3Kq7wfxiDDy4HgK6b85P6YZrURCBPh +7jkw2KmUT2KQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3167C44223F; Tue, 2 Sep 2025 13:05:22 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 23DB41202F2; Tue, 2 Sep 2025 13:05:22 -0400 (EDT) From: Stefan Monnier To: Sean Whitton Subject: Re: bug#79356: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt In-Reply-To: <87v7m0ewyl.fsf@zephyr.silentflame.com> Message-ID: References: <87bjnvlaq0.fsf@zephyr.silentflame.com> <87v7m2imt1.fsf@zephyr.silentflame.com> <875xe1f2k5.fsf@zephyr.silentflame.com> <87v7m0ewyl.fsf@zephyr.silentflame.com> Date: Tue, 02 Sep 2025 13:05:17 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.110 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain GAPPY_SUBJECT 0.1 Subject: contains G.a.p.p.y-T.e.x.t X-SPAM-LEVEL: X-Spam-Score: -2.2 (--) X-Debbugs-Envelope-To: 79356-done Cc: 79356-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) >> Not sure ", " is the best syntax (I'd have used ": >> ", instead), but that looks good enough to me, thanks. > I did the colon-separated format first but then I noticed that other > file-errors which were firing were putting it at the end. Hmm... I guess `error-message-string` uses ", " when it's part of the error object, indeed. Maybe ", " is a better choice after all? As I said, I'm "not sure" which is the best syntax. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 04 10:50:51 2025 Received: (at 79356-done) by debbugs.gnu.org; 4 Sep 2025 14:50:51 +0000 Received: from localhost ([127.0.0.1]:48264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uuBIY-0002jZ-EF for submit@debbugs.gnu.org; Thu, 04 Sep 2025 10:50:50 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:53290) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uuBIR-0002j0-S3 for 79356-done@debbugs.gnu.org; Thu, 04 Sep 2025 10:50:45 -0400 DKIM-Signature: a=rsa-sha256; b=qYoPTI8vO8d9By3NQ880+JhMkQNnqGiLzz5YhIzNQITuJHEptwze/D39zUWQ0qaTGaS4iOikl/E6bczeYn8pg59D0/AsA++yCiz0c8fQrTlzTvM8RhDqv0U9iuYuvJ3OXJHlSnsf9lR/qMbC1uLW1o+IdCGRdO/cVVlvqBmz0JyDSenD16WH2nRRRa+Qg5+/NM4jWJiMM77N3ZSsdk/ceAYo7dEKVGjjMdD+BAclS68KZJOHUu5Gzpq5hC3dp08BSB7Xir3nOiG7joNrVg8xfRKdDAVgR2jFh+szBzaJJzHUO8fKJ//59TMl8Wn1acmBl8SFee9X/DrSDzPfMKHczg==; s=purelymail2; d=spwhitton.name; v=1; bh=QCjR7WI9Zu/j7GE9MS+LzFA1l6Zzlj9LePHbsm2az1Q=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=UhKbPbgKa8smgZ0VgOUxmvR8DazYjKea99Wregkx9VvkBPY+ycXf7zS9is5UwhsDZeLGd1ihPJFJJOVArIM23f4LLI4gpOBo1PdX4tDwlR1PhHBsfsor7ZEbQ9dgINtmHmZ9mxPdKwU6Vj7RzElRmq6z0QfIgCCG4FloLPXLwwVJiU6ZIkA72HraCpr+1ZQHDBoRL2hh9UWKR0Qrh36LqW0NGgrty9daCFT5hyHrc9SpWnNHyFVoZ3bxEBhGxOd14xhDeVLtojfB4Gucq/fNsnD6mrKIdoNqwj7KdQ6NkMrOhB9os6dbgnHkwpO4vlgOOGc/rJBowrmlp3fghXIYig==; s=purelymail2; d=purelymail.com; v=1; bh=QCjR7WI9Zu/j7GE9MS+LzFA1l6Zzlj9LePHbsm2az1Q=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79356-done@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 2048944149; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 04 Sep 2025 14:50:37 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 7DBC2940343; Thu, 04 Sep 2025 15:50:36 +0100 (BST) From: Sean Whitton To: Stefan Monnier Subject: Re: bug#79356: 31.0.50; 'C-x p r' fails when there are .gpg files EPA can't decrypt In-Reply-To: References: <87bjnvlaq0.fsf@zephyr.silentflame.com> <87v7m2imt1.fsf@zephyr.silentflame.com> <875xe1f2k5.fsf@zephyr.silentflame.com> <87v7m0ewyl.fsf@zephyr.silentflame.com> Date: Thu, 04 Sep 2025 15:50:36 +0100 Message-ID: <87a53aclvn.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 79356-done Cc: 79356-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) Hello, On Tue 02 Sep 2025 at 01:05pm -04, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: >>> Not sure ", " is the best syntax (I'd have used ": >>> ", instead), but that looks good enough to me, thanks. >> I did the colon-separated format first but then I noticed that other >> file-errors which were firing were putting it at the end. > > Hmm... I guess `error-message-string` uses ", " when it's part of > the error object, indeed. Maybe ", " is a better choice after all? > As I said, I'm "not sure" which is the best syntax. Me neither. If either of us decides one is better than the other at some point, we can change it over. -- Sean Whitton