Subject: bug#79353: 31.0.50; Eager macro expansion errors when building master

From: Gerd Möllmann <[email-masked]>
Date: Sun, 31 Aug 2025 19:55:07 +0200

"J.D. Smith" <[email-masked]> writes:

> Gerd Möllmann <[email-masked]> writes:
>
>> "J.D. Smith" <[email-masked]> writes:
>>
>>> *Question*:
>>>
>>> In the lisp/net/tramp-loaddefs.el file which was generated during this
>>> build, what do you see under:
>>>
>>>   ;;; Generated autoloads from tramp-adb.el
>>
>> This is the tramp-loaddefs.el after building from git clean -xdf
>>
>>
>>
>>> Can you try a build again with `make bootstrap' and see whether the
>>> warning disappears and if that section of lisp/net/tramp-loaddefs.el
>>> changes?  My guess is this is a harmless warning.
>>
>> The errors are the same, and here's tramp-loaddefs.el after bootstrap
>
> Thanks for checking.  These files are identical, and the error is
> preventing tramp--with-startup from getting defined during autoload
> generation, so autoloaded calls to it just get inlined as-is in
> tramp-loaddefs.el.  If it were working as intended, most of those would
> be replaced by `add-hook'.
>
> Gerd, do you mind reverting e9800cabffa and seeing what if anything
> changes (from a clean start)?  Probably nothing.

Sure. Reverting

  e9800cabffa73018a83108de2bb4e1686f1e8385
  Author:     Po Lu <[email-masked]>
  AuthorDate: Thu Aug 14 19:33:09 2025 +0800
  Commit:     Po Lu <[email-masked]>
  CommitDate: Thu Aug 14 19:34:28 2025 +0800

  Parent:     02f5a075dc2 vc-hg-checkin-patch: Fix several issues
  Merged:     consult-problem
  Contained:  cl-packages emacs-mac-master feature/igc master
  Follows:    emacs-30.1 (178644)

  Fix generation of defvars defined by easy-mmode and company in loaddefs.el

changes nothing.