From unknown Sat Sep 06 00:52:54 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79350 <79350@debbugs.gnu.org> To: bug#79350 <79350@debbugs.gnu.org> Subject: Status: [PATCH] Update shortdoc hash-table and sequence Reply-To: bug#79350 <79350@debbugs.gnu.org> Date: Sat, 06 Sep 2025 07:52:54 +0000 retitle 79350 [PATCH] Update shortdoc hash-table and sequence reassign 79350 emacs submitter 79350 Gabriel do Nascimento Ribeiro severity 79350 normal tag 79350 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 30 15:26:25 2025 Received: (at submit) by debbugs.gnu.org; 30 Aug 2025 19:26:25 +0000 Received: from localhost ([127.0.0.1]:49876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usRDV-0003KG-1S for submit@debbugs.gnu.org; Sat, 30 Aug 2025 15:26:25 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33574) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1usRDS-0003K1-Vn for submit@debbugs.gnu.org; Sat, 30 Aug 2025 15:26:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1usRDN-0003oE-0D for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2025 15:26:17 -0400 Received: from mail-bn7nam10olkn20818.outbound.protection.outlook.com ([2a01:111:f403:2804::818] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1usRDK-0002ep-R0 for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2025 15:26:16 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NMf/NUmCDqnxHARzc5mjzITw3oD4/rgKKIqRzDeWi3UyOeLaqJRUHYKh0tC+3PRyeH3NH2tsZklA69HY53JkiNg7OFiloJf9W6hSr5spRyQ34t8OdGCOlL35T3wouZ7xe6kebsTkgzxmJOpq510TuD3K60q2vSDqk/h9/cKsKO+Ci5+/yhxe8aHaNc12EkuHRopdE8ommoa3C3+zI5mBqUNRZUEqvPIxT2acbER61s0FN/Uk1accwhb4e4aH8M/Ir/7nO32AnIuahzr/Fi7sR0RZQeze6mQVHspkdesKUmQV3y91j+25lmnA4SY4ZdyBlkFrO5l3HIY2Nje9hDinLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EpBnjN1XEgDxj/Y6VdZnGo0AcUeODyxzkAvXThJUwyo=; b=Ye2oVfHkSxqVjBgDY07oZdEN8kX36F5Cj0HCVq30qcq7A00dhpZmThIx87MahKj6upCzH5TIkD4E2+sxPIMaXO7E9bvl426VI/iHwl+oEh4ExjWbk2dg4PLeNH/nnGeBbeU+X+aQhSc1Qx3ad8pW1BTntQxgdOUUKbMH2EDXjSJ9wtzTPVnwzdAqGXM+m/VjgRiLyVj551Jm41HNzSopM8poIbqpR+qJ5tEkXhj1LofCxX5bNAhBze5mj3V0tXdcJw007/Cd5LKNfnZD+rtvOrk+p10vazS5vsA6tJQ9wvxbDWlSDOdycAPT0mrsFYllLR1lPjvKD9P0oRI2n9rU+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EpBnjN1XEgDxj/Y6VdZnGo0AcUeODyxzkAvXThJUwyo=; b=XRvjyuh1F2IbZpGuwfhMfRHyHF37j049D0i9fVNhJ84/uWlxG25TzyZ4mR0p1NutwLF8iX6njWdSpC3r30sGn/YIyG2xlUQPT0RghlwHFs82ldmGPoTtuMFMgAWWeZzvuMcgzCPy50NWy/T/qLCVRHt5RvqDKQlS/mdOcztqJHI1WL2naYdvR5wT/I1rxFPZOAZlQAtsgbPmt4+/ZhfUCgtWFsRQK0Y7vK7a9GFUHgYDqJnxRXet4ldg478/Mcx4EfinQffsb0bRqVU65keKkTWPa4OF8d4PZ+Yv3X60N+M0Zk5g8D6MbzWj+kqGrzRX18KpKZ2jyib8haGhmtz3Zg== Received: from SN6PR06MB3935.namprd06.prod.outlook.com (2603:10b6:805:21::11) by SJ2PR06MB9476.namprd06.prod.outlook.com (2603:10b6:a03:556::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.21; Sat, 30 Aug 2025 19:26:10 +0000 Received: from SN6PR06MB3935.namprd06.prod.outlook.com ([fe80::9f7:a06a:fd92:9751]) by SN6PR06MB3935.namprd06.prod.outlook.com ([fe80::9f7:a06a:fd92:9751%3]) with mapi id 15.20.9052.019; Sat, 30 Aug 2025 19:26:10 +0000 From: Gabriel do Nascimento Ribeiro To: "bug-gnu-emacs@gnu.org" Subject: [PATCH] Update shortdoc hash-table and sequence Thread-Topic: [PATCH] Update shortdoc hash-table and sequence Thread-Index: AQHcGePl698WQ3wSq0iZD2nVbnghJg== Date: Sat, 30 Aug 2025 19:26:09 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SN6PR06MB3935:EE_|SJ2PR06MB9476:EE_ x-ms-office365-filtering-correlation-id: 41a059f8-63c2-4697-344e-08dde7fb1308 x-microsoft-antispam: BCL:0; ARA:14566002|21061999006|31061999003|461199028|15030799006|15080799012|8062599012|8060799015|19110799012|39105399003|40105399003|440099028|51005399003|3412199025|102099032; x-microsoft-antispam-message-info: =?iso-8859-1?Q?Gm+CfkmiihwuglK/cMvdgp0yzZOPQ7y6DICdR6zN4Bl2k1297L5TThrjnK?= =?iso-8859-1?Q?ah/eUHFF7UPVjtlAoDkpONB99LKxjwkaG4Whp91SNB8Kk5Nj3iGkfXScF9?= =?iso-8859-1?Q?wYQnBy2N76cPPrii2iRAspnBtDz/XbYBYKPbKDz8oDBHzjPe4Z9y2jH/dq?= =?iso-8859-1?Q?mdB5cJrlKrYa8cVTuxooSKj0ZPH34s1azgV5f4p3yGdrW5NCHj+++y/v+l?= =?iso-8859-1?Q?gBstmYThAyjhyaLIUHjICiFlqkvOsJLs24FKih5k1aQTZQkSxczoFSwgzH?= =?iso-8859-1?Q?u/c+NJ6Qe3hOVxpGHZTgaAfVhCtyWKvaV0b/foHk2TCN0H90zc0LXP1+Db?= =?iso-8859-1?Q?qXuidy3ubgScTzWhEnQsm/HSPfxgm82JSxNQ6qyf0Zk2C6VJRzvJR4VDj+?= =?iso-8859-1?Q?ewi3o77NUhHvnrAk/rZiVZYZFAt9AOKOwj8hCH5pcMpidlo/ny4jfPFxqc?= =?iso-8859-1?Q?U1CHnL+ctWPCfT2PXcwONZbI6/Kkoa3nTwfy5t0nrFPx7fBWJ1BQrhZuni?= =?iso-8859-1?Q?bUqrpZn9SjNIZp5KtgYtx4ykfLvHJDnikRydy4aN60yH465eigQiLN8brP?= =?iso-8859-1?Q?+xBtZNzFIrhb5H637JTQpShaGPly4rDVvdc7K6DkipnmBo+mYhCFITelJl?= =?iso-8859-1?Q?50ULGZNcB4OOW7Mx86nabrr9rr1kznjjbz6gbfYFKiom8QxLN0X6Q0bnXu?= =?iso-8859-1?Q?4sCP58Shk7YLC0fK8BN9isDhjiJRtYVVd1txMPVxx7tQYO2zPeRU+OqElq?= =?iso-8859-1?Q?4KPD1qiIkpV509Z2VD3J2RwGNBcPzd2zasQab61uNQOkUHx8uYI8Kygf73?= =?iso-8859-1?Q?L3y8fofymmtNFINhALiwBOjYaVIjACHYJsiKmF2y6uu/PkOpqDOW2cg+xG?= =?iso-8859-1?Q?lTnIpRuxpKASKN5sAhbv/dnwRBlo/TsB0ccgKKY7yCW5kAad3AgxxnCkyh?= =?iso-8859-1?Q?+2c6B9BuATANITzhQahXX0An18kcUmUiJW8bG32JTvVKhWyhiafskc5SUX?= =?iso-8859-1?Q?sytMf2Qx3tGCDO73PVdE21hOM1EHush8S8G9Q5/aRUBqe3iZUT5v7xbYnb?= =?iso-8859-1?Q?O4yzzSsf6GVCws8Y1Da/u3LK1ysGChBiChuJbb2/FrZiRLVsiHgz75KKU3?= =?iso-8859-1?Q?OMkUnDix8/+G72TTmA2RKEV19Tyslnsf2i9Bjgks8y1UTfBPv3+mIDU+au?= =?iso-8859-1?Q?fCNZQpD+YNWKnVFD7rOEuTM2IcGrdA06bxhB+uAWEnO6531R2c3Yfttn0G?= =?iso-8859-1?Q?PwTtZ4sFlc1bgtOW5vGycCio2qklXdTmV6qugeWBD9KT8EdCsp6xP3P3Jo?= =?iso-8859-1?Q?EUcsFrff3cCEBuMWPYvehJHuWw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rfg7nRClje7yj9DjaQxxG5/F4HphgMQFyXqhJo985a4xISxsrO6uu0Gum/?= =?iso-8859-1?Q?uEKKS+5WiOXlnCX8KzdRBn6pryC5Zo/3THXWiYdh+x5xJJhBSiN6P0flsJ?= =?iso-8859-1?Q?Q0OOk5wdZ0IX+5p+RUkFcug7MxtkuIczca3WIStZJFdAVK9747JgqRrdy3?= =?iso-8859-1?Q?HvdQrP8pVgioGF/KdsDXpu9r0UYph5haJgnZfXbErrOAYhU83c5nlhCrNm?= =?iso-8859-1?Q?GJqDD8UbfSb2sJobpgEszrkmB/ArKvPMDYFS7adcXMKMeK0dVDVfhq8RVM?= =?iso-8859-1?Q?ohETuzbCrjymjK37gsIf4IJBiAKin6CDV2lcBSGJzkXLzhqXzcet09zQca?= =?iso-8859-1?Q?jEIiDfNHJurcqltwTtWz6wZYJ5l2qLAasOqwbuOP6KdRfRlbYmt35Q2jbJ?= =?iso-8859-1?Q?Z0ZQaMOSE0tokf2YIMnw9DkIPMbAGQ7rgDgc2mrjitzvePEz4rmX8qUSt/?= =?iso-8859-1?Q?/9lf10fzFwX1AfOrb7WMfTNjXrPwvj9vBwpU2kVXWQpTrTIDVZ6RDUA2Qk?= =?iso-8859-1?Q?yTXXhESdZB1gHS375G7OEJjugQjZaOY+Ktt6tNmNR8WEPDZX2wIRYt+Bcw?= =?iso-8859-1?Q?G2gK0dQFxMNyemnC3LGDQv6vBT3uxL2kD+stdt2qhOa/mf0QDA6fvRfHsJ?= =?iso-8859-1?Q?hjy5TGLp5Y/mbLAW6RXSaWgz6PPkwvlfTlDP0AcJ7B1KeQn79JST5Y4WZT?= =?iso-8859-1?Q?h20kIk8sDd3jG6sMKVfrCSvF+DkrNB4F+xal6sm2hEyj/NdKRszPmM8ZDe?= =?iso-8859-1?Q?iRvvOXi6kPeu3HaeJSaW5nTEZIvdGH5FuoMbt3GU2YjeEJ8AHOGoQsOnUT?= =?iso-8859-1?Q?ujK6WV9BzLI/GQINEu/0BwqHPhotGQjVzLaDfOi93SZ/syDc2GHocdIXWJ?= =?iso-8859-1?Q?uJp4rJfIOVofc0ONE6XXqEcpPyBsV8owhm9vygskXRjJbKKwq92IyHGKjZ?= =?iso-8859-1?Q?FY1cFotx+6xPQLLs7RHPHkImIpYKsO8t7veihD9fagl3JfWvVlUkmZkdjm?= =?iso-8859-1?Q?0lgYZZ7MxGwI7yNXxvgA9q9ta/7k3MEorpt8JP2tyF7NQ1oG4PbK8RcmkQ?= =?iso-8859-1?Q?ACmyHwv/zWrAxflyyYk7eogTRQylSI5tWX6stHF4cxh26RGsnN1PumxECg?= =?iso-8859-1?Q?HiaDadi6mvKyaKR/UxXsKZfyJEKPkc0myb+85JW5mUJsMYLcoDSzbxajC1?= =?iso-8859-1?Q?B22uhzkoUnfsVZmFAsxppcyLG/FUQhaNFqXj3d7EdhZi5ex3SLUUuKAAGB?= =?iso-8859-1?Q?Il/NYQLeVNI2YqPE2PToSEQUinYJC0zBqVkuGiYUQnqmXR33CBZx9RdoNf?= =?iso-8859-1?Q?CCKp2v7FuM8BKsTIbG4p91wj1H62S4RY2Qdoql3IvSK5Aqk=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-a1430.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR06MB3935.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 41a059f8-63c2-4697-344e-08dde7fb1308 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2025 19:26:09.8236 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR06MB9476 Received-SPF: pass client-ip=2a01:111:f403:2804::818; envelope-from=gabriel376@hotmail.com; helo=NAM10-BN7-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: The patch below adds more functions to shortdoc and info: - info hash-table: - hash-table-keys - hash-table-values - hash-table-empty-p - shortdoc hash-table: - hash-table-empty-p - hash-table-keys - hash-table-values - hash-table-test - hash-table-weakness Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (gabriel376[at]hotmail.com) 0.9 SPF_FAIL SPF: sender does not match SPF record (fail) [SPF failed: Please see http://www.openspf.org/Why?s=mfrom; id=gabriel376%40hotmail.com; ip=2001%3A470%3A142%3A%3A17; r=debbugs.gnu.org] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (gabriel376[at]hotmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) The patch below adds more functions to shortdoc and info:=0A= =0A= - info hash-table:=0A= - hash-table-keys=0A= - hash-table-values=0A= - hash-table-empty-p=0A= =0A= - shortdoc hash-table:=0A= - hash-table-empty-p=0A= - hash-table-keys=0A= - hash-table-values=0A= - hash-table-test=0A= - hash-table-weakness=0A= =0A= - shortdoc sequence=0A= - seq-let=0A= =0A= It also makes the info buffer display in the same window when pushing short= doc=0A= buttons, which I think is a better behavior than the one that currently dis= plays=0A= the info buffer in another widow and does not make it selected.=0A= =0A= =0A= >From 803583c20cfa726488ce40e7365eca4311a1d4ef Mon Sep 17 00:00:00 2001=0A= From: Gabriel Ribeiro =0A= Date: Sat, 30 Aug 2025 16:13:33 -0300=0A= Subject: [PATCH] Add more functions to shortdoc hash-table and sequence=0A= =0A= * doc/lispref/hash.texi: Add 'hash-table-keys', 'hash-table-values'=0A= and 'hash-table-empty-p'.=0A= * lisp/emacs-lisp/shortdoc.el=0A= (define-short-documentation-group hash-table): Add=0A= 'hash-table-empty-p', 'hash-table-keys', 'hash-table-values',=0A= 'hash-table-test', 'hash-table-weakness'.=0A= (define-short-documentation-group sequence): Add 'seq-let'.=0A= (hash-table-weakness): Display info buffer in same window.=0A= ---=0A= doc/lispref/hash.texi | 12 ++++++++++++=0A= lisp/emacs-lisp/shortdoc.el | 21 +++++++++++++++++++--=0A= 2 files changed, 31 insertions(+), 2 deletions(-)=0A= =0A= diff --git a/doc/lispref/hash.texi b/doc/lispref/hash.texi=0A= index 56862a9d934..1660c209435 100644=0A= --- a/doc/lispref/hash.texi=0A= +++ b/doc/lispref/hash.texi=0A= @@ -343,6 +343,18 @@ Other Hash=0A= itself is copied---the keys and values are shared.=0A= @end defun=0A= =0A= +@defun hash-table-keys table=0A= +This function returns the list of keys in @var{table}.=0A= +@end defun=0A= +=0A= +@defun hash-table-values table=0A= +This function returns the list of values in @var{table}.=0A= +@end defun=0A= +=0A= +@defun hash-table-empty-p table=0A= +This function non-@code{nil} if @var{table} contains any entries..=0A= +@end defun=0A= +=0A= @defun hash-table-count table=0A= This function returns the actual number of entries in @var{table}.=0A= @end defun=0A= diff --git a/lisp/emacs-lisp/shortdoc.el b/lisp/emacs-lisp/shortdoc.el=0A= index 754b2016d9e..697e2a51642 100644=0A= --- a/lisp/emacs-lisp/shortdoc.el=0A= +++ b/lisp/emacs-lisp/shortdoc.el=0A= @@ -717,7 +717,22 @@ hash-table=0A= :result-string "#s(hash-table ...)")=0A= (hash-table-count=0A= :no-eval (hash-table-count table)=0A= - :eg-result 15))=0A= + :eg-result 15)=0A= + (hash-table-empty-p=0A= + :no-eval (hash-table-empty-p table)=0A= + :eg-result t)=0A= + (hash-table-keys=0A= + :no-eval (hash-table-keys table)=0A= + :eg-result-string "(key1 key2 ...)")=0A= + (hash-table-values=0A= + :no-eval (hash-table-values table)=0A= + :eg-result-string "(value1 value2 ...)")=0A= + (hash-table-test=0A= + :no-eval (hash-table-test table)=0A= + :eg-result eql)=0A= + (hash-table-weakness=0A= + :no-eval (hash-table-weakness table)=0A= + :eg-result key-and-value))=0A= =0A= (define-short-documentation-group list=0A= "Making Lists"=0A= @@ -1124,6 +1139,8 @@ sequence=0A= :eval (seq-sort #'> '(1 2 3)))=0A= (seq-sort-by=0A= :eval (seq-sort-by (lambda (a) (/ 1.0 a)) #'< '(1 2 3)))=0A= + (seq-let=0A= + :eval (seq-let (a b c) '(1 2 3) (+ a b c)))=0A= "Mapping Over Sequences"=0A= (seq-map=0A= :eval (seq-map #'1+ '(1 2 3)))=0A= @@ -1689,7 +1706,7 @@ shortdoc--display-function=0A= (symbol-name function)=0A= 'face 'button=0A= 'action (lambda (_)=0A= - (info-lookup-symbol function 'emacs-lisp-mode))=0A= + (info-lookup-symbol function 'emacs-lisp-mode t))=0A= 'follow-link t=0A= 'help-echo "mouse-1, RET: show \=0A= function's documentation in the Info manual"))=0A= -- =0A= 2.34.1=0A= =0A= =0A= ---=0A= Gabriel= From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 31 01:04:56 2025 Received: (at 79350) by debbugs.gnu.org; 31 Aug 2025 05:04:56 +0000 Received: from localhost ([127.0.0.1]:51401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usaFM-00018g-3M for submit@debbugs.gnu.org; Sun, 31 Aug 2025 01:04:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51174) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1usaFJ-00018S-Go for 79350@debbugs.gnu.org; Sun, 31 Aug 2025 01:04:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1usaFC-0005sV-QY; Sun, 31 Aug 2025 01:04:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tvI7gsc+/A6WyE8RYaUcG67t89QX2yBxsJw+2TUXP+Y=; b=bSsfNxyD6Dwv D3LHdIVHU+LwqPi/UUoaTJU4K0G+/O3ZIGnB4+HcSzX6XVkND6KfG4iS29kkilO0ZPq9scbtSQsZc fYslcF7bCMknT7vgfMEfKcKapm2b3vpUuvg/LuSESjM0cLJY0ypFZ2hh9Ob/IDda/ZYjGNUUqMRSR sNJp2SvE3SjHa9+kPpfo50kG5++0likD56Fkg0/TSpQlIwBFAzIsrZa+iGdOgEZGXuQbbnw+H3WZD IJgvOj1D0sDxEmrNmyjlS2uLXQUqVWcmeqiTOtfA8waaJDaKU2WkkJyilB6Di5QpZhfA4nwPQZOg7 JPZ3jAVIUBqQoZ5qsMnYEQ==; Date: Sun, 31 Aug 2025 08:04:42 +0300 Message-Id: <864itoozdh.fsf@gnu.org> From: Eli Zaretskii To: Gabriel do Nascimento Ribeiro In-Reply-To: (message from Gabriel do Nascimento Ribeiro on Sat, 30 Aug 2025 19:26:09 +0000) Subject: Re: bug#79350: [PATCH] Update shortdoc hash-table and sequence References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79350 Cc: 79350@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Gabriel do Nascimento Ribeiro > Date: Sat, 30 Aug 2025 19:26:09 +0000 > msip_labels: > > The patch below adds more functions to shortdoc and info: > > - info hash-table: > - hash-table-keys > - hash-table-values > - hash-table-empty-p > > - shortdoc hash-table: > - hash-table-empty-p > - hash-table-keys > - hash-table-values > - hash-table-test > - hash-table-weakness > > - shortdoc sequence > - seq-let Thanks, but what is the rationale for adding these functions to the ELisp manual? I could maybe understand why we should add hash-table-empty-p, but why the other two? They are in subr-x.el for a reason. Are they important enough to be in the manual? In any case, these are defsubst's, not defun's, so the manual should not call them "functions". > It also makes the info buffer display in the same window when pushing shortdoc > buttons, which I think is a better behavior than the one that currently displays > the info buffer in another widow and does not make it selected. This is a change in behavior, and I personally would not like it. It is customary in Emacs to show help in another window by default, because that leaves the buffer where you invoked the help command displayed, in case the user wants to continue working on that buffer or reading its text. So if we want to allow such a behavior, it should be opt-in, not the default. (In general, independent changes are better submitted as separate bug reports. This report should have been split into 2 or 3 separate ones. Please keep this in mind in the future.) > * doc/lispref/hash.texi: Add 'hash-table-keys', 'hash-table-values' > and 'hash-table-empty-p'. > * lisp/emacs-lisp/shortdoc.el > (define-short-documentation-group hash-table): Add > 'hash-table-empty-p', 'hash-table-keys', 'hash-table-values', > 'hash-table-test', 'hash-table-weakness'. > (define-short-documentation-group sequence): Add 'seq-let'. > (hash-table-weakness): Display info buffer in same window. A minor nit: the second and following lines of a log entry should be flushed all the way to the left, like this: * doc/lispref/hash.texi: Add 'hash-table-keys', 'hash-table-values' and 'hash-table-empty-p'. * lisp/emacs-lisp/shortdoc.el (define-short-documentation-group hash-table): Add 'hash-table-empty-p', 'hash-table-keys', 'hash-table-values', 'hash-table-test', 'hash-table-weakness'. (define-short-documentation-group sequence): Add 'seq-let'. (hash-table-weakness): Display info buffer in same window.