From unknown Thu Sep 11 02:37:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79336: [PATCH] df: fix potential null pointer dereference Resent-From: yubiao hu Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 29 Aug 2025 01:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 79336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 79336@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.175643197630296 (code B ref -1); Fri, 29 Aug 2025 01:47:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Aug 2025 01:46:16 +0000 Received: from localhost ([127.0.0.1]:40884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uroBz-0007sM-8x for submit@debbugs.gnu.org; Thu, 28 Aug 2025 21:46:16 -0400 Received: from lists.gnu.org ([2001:470:142::17]:39304) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uroBu-0007qX-1h for submit@debbugs.gnu.org; Thu, 28 Aug 2025 21:46:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uroBn-0004M5-RG for bug-coreutils@gnu.org; Thu, 28 Aug 2025 21:46:03 -0400 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uroBl-0005DG-0b for bug-coreutils@gnu.org; Thu, 28 Aug 2025 21:46:03 -0400 Received: by mail-pj1-x1041.google.com with SMTP id 98e67ed59e1d1-32783de3e87so1625483a91.0 for ; Thu, 28 Aug 2025 18:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756431958; x=1757036758; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=MZBolQzK5vqT10JvgYwzwA8XTyRibApJSabcfwx12e8=; b=c6rRoJx27kd1xUxdhuxcjmvkBTpKitszR6jocW1/yxOoXuIISIKxfw9CdW8WCpkmt2 zo0ekbZ5IK9nCyyuLckWqKmjFAc6Cfe2goGekG0q5dPRDe64apkSOgwAuW35KGWxfk3i +HnRdMmUlXFWn+2LwFnW4vQ/qeh0wQuMOTChNeoHcwgsKvGmNZHI0waqoQV9hVDejUWv o1bEcoTV8IMlOGOhojzXvI2SmzLXJLUiH+8jNwaq5W1kNtHRxRG06XeI8EJ5ldxjqy3x EMivuwQLaaUaRtdngPwirVO6SsMXUFb14+fE35eIjE/jcVQa/Ph0soKzvBjsvphGazMr 7QbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756431958; x=1757036758; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MZBolQzK5vqT10JvgYwzwA8XTyRibApJSabcfwx12e8=; b=JoRmGs31y3PKHBRmn3Yq/AIWscZXL4/gxG2ejVaAWHvAt/kXIlnCE785E9I+Hhz54e PSgxwsuaEJu1E1R4Ni7/92aq7DKqQ/iOCXP+MgiFZ7+bydpAlRfVH78LhaiYmvEQ+Ne8 NJL0PSVx6fq5MHe9MxRxjZpSzInVvwQeXgWPZq23os7jMtJGH0ENubh1iSilqtgITQEq PJ8CZvUJKXnOjW2ebGAHVQavj1cqwILqtPpk+VeEEDUWt/4JqAXN7JVQUEZZFtYXFBJy NVSIzJTr70iihPkpjBQgIh/urweAPry9kraCi+iIKgPRhERaC8sns0NZ0+9VrkDIHj/Q CY7Q== X-Gm-Message-State: AOJu0Yw9tvtb8RIQaMAbipFXwv+bKYywf4eGM02o7xtyH2jrInApopTv xG/HCc+sK0BoFjZhgYV3gEaBi/YYVEO8A5eyae3ZBwLbJx/5sI5KYtHBTqPswnJxeQ5hVY/obtU BiL7od/3jeirB9tM9zOS5xks/RTTs1HD79lrMD2IVvA== X-Gm-Gg: ASbGncu4NhljcUhXPRunfkZryTj91LCoddAS1KrDQChwssHalLWoSTaqqJCAn5MhNLX sVMIsIPHD5dpO8nX+T1JGL4La9pOG6i6uUfRYY1rRQmC+HChYNbne3ofu2Evy+7CPqN9qrO6hD8 3CG3Rf3V7U8R3BYCnDelvhgv7lXetX4BbAYVP/YcnaUqrAzB/p0VWQKEtqvd7UP+HpelMeJS0No /7GXriWyg== X-Google-Smtp-Source: AGHT+IHFmOtE5suJ00qg01lqkQfN3B3Ynzcb6wKG3oAcz2b5o/7Gb5WSUEXp9puFMkJAtiPYwqDhwW+CIdgxiNV0K6A= X-Received: by 2002:a17:90b:50c6:b0:325:2a77:bf5d with SMTP id 98e67ed59e1d1-3275085d3e8mr14781539a91.0.1756431957997; Thu, 28 Aug 2025 18:45:57 -0700 (PDT) MIME-Version: 1.0 From: yubiao hu Date: Fri, 29 Aug 2025 09:45:46 +0800 X-Gm-Features: Ac12FXwbqCHiN-p4EY7SZxUcZjKvzwIccS63BrKcbAl-_b60q0Ed8rVo0gy8INY Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=huyubiaox@gmail.com; helo=mail-pj1-x1041.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * src/df.c (get_dev): Fix potential null pointer dereference - Avoid dereferencing stat_file when both device and mount_point are NULL - Handle allocation failure for cell when mount_point is NULL --- src/df.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/df.c b/src/df.c index fe2e0e3..f60319c 100644 --- a/src/df.c +++ b/src/df.c @@ -1050,7 +1050,7 @@ get_dev (char const *device, char const *mount_point, char const *file, } else { - error (0, errno, "%s", quotef (stat_file)); + error (0, errno, "%s", quotef (stat_file ? stat_file : "-")); exit_status = EXIT_FAILURE; return; } @@ -1215,17 +1215,23 @@ get_dev (char const *device, char const *mount_point, char const *file, break; case TARGET_FIELD: + { + if (! mount_point) { + cell = xstrdup ("-"); + break; + } #ifdef HIDE_AUTOMOUNT_PREFIX - /* Don't print the first directory name in MOUNT_POINT if it's an - artifact of an automounter. This is a bit too aggressive to be - the default. */ - if (STRNCMP_LIT (mount_point, "/auto/") == 0) - mount_point += 5; - else if (STRNCMP_LIT (mount_point, "/tmp_mnt/") == 0) - mount_point += 8; + /* Don't print the first directory name in MOUNT_POINT if it's an + artifact of an automounter. This is a bit too aggressive to be + the default. */ + if (STRNCMP_LIT (mount_point, "/auto/") == 0) + mount_point += 5; + else if (STRNCMP_LIT (mount_point, "/tmp_mnt/") == 0) + mount_point += 8; #endif - cell = xstrdup (mount_point); - break; + cell = xstrdup (mount_point); + break; + } case INVALID_FIELD: default: -- 2.33.0 From unknown Thu Sep 11 02:37:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79336: [PATCH] df: fix potential null pointer dereference Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 30 Aug 2025 17:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: yubiao hu Cc: 79336@debbugs.gnu.org Received: via spool by 79336-submit@debbugs.gnu.org id=B79336.175657570125734 (code B ref 79336); Sat, 30 Aug 2025 17:42:02 +0000 Received: (at 79336) by debbugs.gnu.org; 30 Aug 2025 17:41:41 +0000 Received: from localhost ([127.0.0.1]:49699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usPa4-0006gv-64 for submit@debbugs.gnu.org; Sat, 30 Aug 2025 13:41:41 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:49950) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1usPZz-0006gV-4t for 79336@debbugs.gnu.org; Sat, 30 Aug 2025 13:41:33 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 893B63C32B0F2; Sat, 30 Aug 2025 10:41:24 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id IHAjOiwImOhg; Sat, 30 Aug 2025 10:41:24 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 616183C32B0F4; Sat, 30 Aug 2025 10:41:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 616183C32B0F4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1756575684; bh=GTb4qNHEtAyse1qyiLbqWv85xlBC4zltplr2wzH90AY=; h=Message-ID:Date:MIME-Version:To:From; b=eGWJe1pGxcdo9HA6WnABmDct022EtRZmMxSjazNrXN4DB4C78p6Dlw/wPfUj89DBQ gTvfz+OUfFo3WTCXahj02Z9E0WpJLyA4paCQttZAnUiVkAGggEsUyjgvNx1lBqz7sc 4RFzBRWA5NybGVHexj+si8RJDvqeObSlSkLh9rFJ1QR0LSzQgseqZSgI0LqBk6h/cZ ujM7xy6/hs4t0/UTCdLFPmGPj90hjXgr6EgxCmjoiM0J4dvKu4u09CrXivw04EfZXx z+aFkuHKpETTIl2477fgyfs0aHIsx5bdhyPR65LQBtS0fnxL2xvSGMds4MCX5Ya4ub S0SWrW4uWjKew== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id L-LjFa08Ud8h; Sat, 30 Aug 2025 10:41:24 -0700 (PDT) Received: from penguin.cs.ucla.edu (47-154-18-19.fdr01.snmn.ca.ip.frontiernet.net [47.154.18.19]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 43ECD3C306724; Sat, 30 Aug 2025 10:41:24 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------f6Ju6jJIVZW4G6rmMgKtTElT" Message-ID: <28259158-445c-4769-9d11-b43594ced9e2@cs.ucla.edu> Date: Sat, 30 Aug 2025 10:41:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------f6Ju6jJIVZW4G6rmMgKtTElT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-08-28 18:45, yubiao hu wrote: > * src/df.c (get_dev): Fix potential null pointer dereference > - Avoid dereferencing stat_file when both device and > mount_point are NULL > - Handle allocation failure for cell when mount_point > is NULL Why is this patch needed? Can you give an example df invocation in which mount_point is null there? As far as I can see, that cannot happen. Did your bug report come from static analysis? If so, which static analyzer did you use and how did you use it? Does the attached patch pacify your static analyzer? --------------f6Ju6jJIVZW4G6rmMgKtTElT Content-Type: text/x-patch; charset=UTF-8; name="0001-df-pacify-static-analysis.patch" Content-Disposition: attachment; filename="0001-df-pacify-static-analysis.patch" Content-Transfer-Encoding: base64 RnJvbSA4ZDlhY2NmYjQ3MWJkNmUxYWE0NTY4ZWE0MDczNDEzY2UzNDEyODNiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDMwIEF1ZyAyMDI1IDEwOjM5OjQ5IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gZGY6IHBhY2lmeSBzdGF0aWMgYW5hbHlzaXMKClByb2JsZW0gcmVwb3J0ZWQgYnkgWXVi aWFvIEh1IDxodHRwczovL2J1Z3MuZ251Lm9yZy83OTMzNj4uCiogc3JjL2RmLmMgKGdldF9k ZXYpOiBBc3N1bWUgTU9VTlRfUE9JTlQgaXMgbm9uLW51bGwuCi0tLQogc3JjL2RmLmMgfCAx MiArKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDYgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2RmLmMgYi9zcmMvZGYuYwppbmRleCBmZTJl MGUzOGYuLjM1ZjQzOTQ2ZiAxMDA2NDQKLS0tIGEvc3JjL2RmLmMKKysrIGIvc3JjL2RmLmMK QEAgLTk4OCwxNSArOTg4LDE1IEBAIGFkZF90b19ncmFuZF90b3RhbCAoc3RydWN0IGZpZWxk X3ZhbHVlc190ICpidiwgc3RydWN0IGZpZWxkX3ZhbHVlc190ICppdikKIH0KIAogLyogT2J0 YWluIGEgc3BhY2UgbGlzdGluZyBmb3IgdGhlIGRldmljZSB3aXRoIGFic29sdXRlIGZpbGUg bmFtZSBERVZJQ0UuCi0gICBJZiBNT1VOVF9QT0lOVCBpcyBub24tbnVsbCwgaXQgaXMgdGhl IG5hbWUgb2YgdGhlIHJvb3Qgb2YgdGhlCi0gICBmaWxlIHN5c3RlbSBvbiBERVZJQ0UuCisg ICBNT1VOVF9QT0lOVCBuYW1lcyB0aGUgcm9vdCBvZiB0aGUgZmlsZSBzeXN0ZW0gb24gREVW SUNFLgorICAgRklMRSBpcyB0aGUgbmFtZSB0byBsaXN0OyBpZiBudWxsLCBpdCBkZWZhdWx0 cyB0byAiLSIuCiAgICBJZiBTVEFUX0ZJTEUgaXMgbm9uLW51bGwsIGl0IGlzIHRoZSBuYW1l IG9mIGEgZmlsZSB3aXRoaW4gdGhlIGZpbGUKICAgIHN5c3RlbSB0aGF0IHRoZSB1c2VyIG9y aWdpbmFsbHkgYXNrZWQgZm9yOyB0aGlzIHByb3ZpZGVzIGJldHRlcgogICAgZGlhZ25vc3Rp Y3MsIGFuZCBzb21ldGltZXMgaXQgcHJvdmlkZXMgYmV0dGVyIHJlc3VsdHMgb24gbmV0d29y a2VkCiAgICBmaWxlIHN5c3RlbXMgdGhhdCBnaXZlIGRpZmZlcmVudCBmcmVlLXNwYWNlIHJl c3VsdHMgZGVwZW5kaW5nIG9uCiAgICB3aGVyZSBpbiB0aGUgZmlsZSBzeXN0ZW0geW91IHBy b2JlLgogICAgSWYgRlNUWVBFIGlzIG5vbi1udWxsLCBpdCBpcyB0aGUgdHlwZSBvZiB0aGUg ZmlsZSBzeXN0ZW0gb24gREVWSUNFLgotICAgSWYgTU9VTlRfUE9JTlQgaXMgbm9uLW51bGws IHRoZW4gREVWSUNFIG1heSBiZSBudWxsIC0tIGNlcnRhaW4gc3lzdGVtcyBtYXkKKyAgIERF VklDRSBtYXkgYmUgbnVsbCAtLSBjZXJ0YWluIHN5c3RlbXMgbWF5CiAgICBub3QgYmUgYWJs ZSB0byBwcm9kdWNlIHN0YXRpc3RpY3MgaW4gdGhpcyBjYXNlLgogICAgTUVfRFVNTVkgYW5k IE1FX1JFTU9URSBhcmUgdGhlIG1vdW50IGVudHJ5IGZsYWdzLgogICAgQ2FsbGVyIG11c3Qg c2V0IFBST0NFU1NfQUxMIHRvIHRydWUgd2hlbiBpdGVyYXRpbmcgb3ZlciBhbGwgZW50cmll cywgYXMKQEAgLTEwMjAsMTUgKzEwMjAsMTUgQEAgZ2V0X2RldiAoY2hhciBjb25zdCAqZGV2 aWNlLCBjaGFyIGNvbnN0ICptb3VudF9wb2ludCwgY2hhciBjb25zdCAqZmlsZSwKIAogICAv KiBJZ25vcmUgcmVsYXRpdmUgTU9VTlRfUE9JTlRzLCB3aGljaCBhcmUgcHJlc2VudCBmb3Ig ZXhhbXBsZQogICAgICBpbiAvcHJvYy9tb3VudHMgb24gTGludXggd2l0aCBuZXR3b3JrIG5h bWVzcGFjZXMuICAqLwotICBpZiAoIWZvcmNlX2ZzdSAmJiBtb3VudF9wb2ludCAmJiAhIElT X0FCU09MVVRFX0ZJTEVfTkFNRSAobW91bnRfcG9pbnQpKQorICBpZiAoIWZvcmNlX2ZzdSAm JiAhIElTX0FCU09MVVRFX0ZJTEVfTkFNRSAobW91bnRfcG9pbnQpKQogICAgIHJldHVybjsK IAotICAvKiBJZiBNT1VOVF9QT0lOVCBpcyBudWxsLCB0aGVuIHRoZSBmaWxlIHN5c3RlbSBp cyBub3QgbW91bnRlZCwgYW5kIHRoaXMKKyAgLyogSWYgU1RBVF9GSUxFIGlzIG51bGwsIHRo ZW4gdGhlIGZpbGUgc3lzdGVtIGlzIG5vdCBtb3VudGVkLCBhbmQgdGhpcwogICAgICBwcm9n cmFtIHJlcG9ydHMgb24gdGhlIGZpbGUgc3lzdGVtIHRoYXQgdGhlIHNwZWNpYWwgZmlsZSBp cyBvbi4KICAgICAgSXQgd291bGQgYmUgYmV0dGVyIHRvIHJlcG9ydCBvbiB0aGUgdW5tb3Vu dGVkIGZpbGUgc3lzdGVtLAogICAgICBidXQgc3RhdGZzIGRvZXNuJ3QgZG8gdGhhdCBvbiBt b3N0IHN5c3RlbXMuICAqLwogICBpZiAoIXN0YXRfZmlsZSkKLSAgICBzdGF0X2ZpbGUgPSBt b3VudF9wb2ludCA/IG1vdW50X3BvaW50IDogZGV2aWNlOworICAgIHN0YXRfZmlsZSA9IG1v dW50X3BvaW50OwogCiAgIHN0cnVjdCBmc191c2FnZSBmc3U7CiAgIGlmIChmb3JjZV9mc3Up Ci0tIAoyLjQ4LjEKCg== --------------f6Ju6jJIVZW4G6rmMgKtTElT-- From unknown Thu Sep 11 02:37:31 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: yubiao hu Subject: bug#79336: closed (Re: bug#79336: [PATCH] df: fix potential null pointer dereference) Message-ID: References: X-Gnu-PR-Message: they-closed 79336 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 79336@debbugs.gnu.org Date: Sat, 30 Aug 2025 17:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1756576382-27615-1" This is a multi-part message in MIME format... ------------=_1756576382-27615-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #79336: [PATCH] df: fix potential null pointer dereference which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 79336@debbugs.gnu.org. --=20 79336: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D79336 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1756576382-27615-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 79336-done) by debbugs.gnu.org; 30 Aug 2025 17:52:54 +0000 Received: from localhost ([127.0.0.1]:49709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usPl0-0007B5-EC for submit@debbugs.gnu.org; Sat, 30 Aug 2025 13:52:54 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:60683) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1usPkv-0007Ab-Nn for 79336-done@debbugs.gnu.org; Sat, 30 Aug 2025 13:52:52 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-45b873a2092so3923445e9.1 for <79336-done@debbugs.gnu.org>; Sat, 30 Aug 2025 10:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756576363; x=1757181163; darn=debbugs.gnu.org; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:sender:from:to:cc:subject:date :message-id:reply-to; bh=d5v3i4f6RI6WyarXKYO/A1MLjampVY/w2/Kmz6qtuYs=; b=G7k1f2s+di7XYpYOXHLe1JHsL/UNYwRnBlq5YVhTg/iWKz6yVaU8u7k4fy65nF3mTw T90jxT8RNBj2eTA1/zfuwxhTHyYZt03cH2M7Z51qT2og+z0T81PezSQVngs1MZGKH+Rg kiacsxSAZtpZTDwP4nhzk60d6XN3GmWd3S/MOsRFS89Qt+90k1jZXKqsvZ/dm/zpcWDW Qi9Kx4gR16FZgkgmKPZ7RW3e11o9w/UwuCHpt1Uu3fsa/EtsA2mbmrdAek3j7iF71S3x UNw9oOZ+yIDQFEE24NFxczm7yaCrGZxPVgOzYooRjg5j4XS3+32MiDkSdomVhHfz/3UM 0OGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756576363; x=1757181163; h=in-reply-to:from:content-language:references:to:subject:user-agent :mime-version:date:message-id:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d5v3i4f6RI6WyarXKYO/A1MLjampVY/w2/Kmz6qtuYs=; b=CtbqF+hwBPqlrIwlAZ8Ry78aNv5TuFO2G/RsCQBw1NuX4lQc8meiOornteJkHuzmFc ZeoptNMCkTlfIjewIUWUuAFmNy92pUZRhsWdOtsgFPNBvZJypaa2nJpOK0ETYRwyTeBN O05wYPR0lTU7liFvFRWlmkmhOkbHJKSpfrjdSiL0CYbTZDr6SkzKJn3g6jB1kGn4b0ku fSJ8DnaHFNQMifyvJNG4s2jEKk/wGusm8v8XpiH6XCK/MjVXUhApNQG6MOMe4W5+DeSN qpnTt7kgcp+o0iA4DfGYc3b6Rm/2BXxzFj2zHVJq09j0OTdeMUKOrwz+cQKcXNLt0dBS E6DQ== X-Forwarded-Encrypted: i=1; AJvYcCW/skFntMQttTBdXGbdmGUQ66aJ/3Jg+J46Kph1Y/H/hdNDr8af42hMCxtMn+brD4iHeoNGXX6VKDvv@debbugs.gnu.org X-Gm-Message-State: AOJu0YzFTvEORsLRehjFWUOVO/Lhv7Csxbyj4LQTCj7vlaZMj4A1urc9 gcefMgHksNDCxUMnR+G2vsxFZG9grMgcOu4CwtKWRD9ZE+Uzz38M3VQP X-Gm-Gg: ASbGncsujMSvlM1FMiDRoGGq1/h/nMjqoSsjqTVL5Gzk8aV+ona2vp2+pypk2QgIsAL eOxFtxO2PIQ9bbgOCEYyt6JldpUzwp0yjO6Vpab+MwQqQD+9P+RzX19Cls9d/chjePhxE55sApo pkTgsD8PZmGk1oAVE0Kcju5EZKUEhnjkzK1P20itxeQqeBQydQGK9cmFHO00Xp0BuPS4nJiHCLb 2AW4aV1YnAEbW8q2FX7/498Aj6qs6o729P9WUCRo706tGmxkjXkU0+jJ670p814PUflcN3Lxi87 xehsdRP/kzPUFl2JFoxGZmR075gydMsPuC59Kj87zAwRwFyU8ptzkYPyG72uc49Jp1n7tL/HooM gGUrIPc1Vz1WVVF3ah1JPu0eM0VNVym2uq2iTUoF6seNB9MYajYJuDqihZE5XlddXcrNMgFJs9X 0sUj6DLNQJHEl7 X-Google-Smtp-Source: AGHT+IHnLAsPa+SVgKrE/A5QCHba6oQBTaX+MXHHd92cO/aHsz48T2eRwqvbfgJ59H+ttXWOn5caxA== X-Received: by 2002:a05:600c:3153:b0:458:bda4:43df with SMTP id 5b1f17b1804b1-45b85570996mr23869555e9.17.1756576362772; Sat, 30 Aug 2025 10:52:42 -0700 (PDT) Received: from [192.168.1.31] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-45b66bbcf19sm102057585e9.4.2025.08.30.10.52.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Aug 2025 10:52:41 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------zwLEKonwhUpZnGQbfTxZZBkZ" Message-ID: Date: Sat, 30 Aug 2025 18:52:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: bug#79336: [PATCH] df: fix potential null pointer dereference To: yubiao hu , 79336-done@debbugs.gnu.org References: Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig_Brady?= In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79336-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------zwLEKonwhUpZnGQbfTxZZBkZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/08/2025 02:45, yubiao hu wrote: > * src/df.c (get_dev): Fix potential null pointer dereference > - Avoid dereferencing stat_file when both device and > mount_point are NULL > - Handle allocation failure for cell when mount_point > is NULL These are valid concerns. I also see potential null dereferences of device. The attached patch takes a different approach by ensuring arguments are initialized earlier. Marking this as done. Will push the attached later. cheers, Padraig --------------zwLEKonwhUpZnGQbfTxZZBkZ Content-Type: text/x-patch; charset=UTF-8; name="df-null-pointers.patch" Content-Disposition: attachment; filename="df-null-pointers.patch" Content-Transfer-Encoding: base64 RnJvbSAxM2ExNTRjZDQzYjI0MWEyNGRmYmIzYzZhOWQ2NmJmYjBhMjg1MTBlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/ PSA8UEBkcmFpZ0JyYWR5LmNvbT4KRGF0ZTogU2F0LCAzMCBBdWcgMjAyNSAxODo0ODozOCAr MDEwMApTdWJqZWN0OiBbUEFUQ0hdIGRmOiBlbnN1cmUgbm8gbnVsbCBwb2ludGVyIGRlcmVm ZXJlbmNlcwoKKiBzcmMvZGYuYyAoZ2V0X2Rldik6IEluaXRpYWxpc2UgYXJndW1lbnRzIHRv IG5vbiBudWxsLAp0byBlbnN1cmUgd2UgbmV2ZXIgZGVyZWZlcmVuY2UgbnVsbCBwb2ludGVy LgpGaXhlcyBodHRwczovL2J1Z3MuZ251Lm9yZy83OTMzNgotLS0KIHNyYy9kZi5jIHwgMTUg KysrKysrKysrLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCA2IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9kZi5jIGIvc3JjL2RmLmMKaW5kZXggZmUy ZTBlMzhmLi44Y2ZiZWI0MTkgMTAwNjQ0Ci0tLSBhL3NyYy9kZi5jCisrKyBiL3NyYy9kZi5j CkBAIC0xMDMwLDYgKzEwMzAsMTIgQEAgZ2V0X2RldiAoY2hhciBjb25zdCAqZGV2aWNlLCBj aGFyIGNvbnN0ICptb3VudF9wb2ludCwgY2hhciBjb25zdCAqZmlsZSwKICAgaWYgKCFzdGF0 X2ZpbGUpCiAgICAgc3RhdF9maWxlID0gbW91bnRfcG9pbnQgPyBtb3VudF9wb2ludCA6IGRl dmljZTsKIAorICBpZiAoISBtb3VudF9wb2ludCkKKyAgICBtb3VudF9wb2ludCA9ICItIjsJ CS8qIHVuc3BlY2lmaWVkICovCisKKyAgaWYgKCEgZGV2aWNlKQorICAgIGRldmljZSA9ICIt IjsJCS8qIHVua25vd24gKi8KKwogICBzdHJ1Y3QgZnNfdXNhZ2UgZnN1OwogICBpZiAoZm9y Y2VfZnN1KQogICAgIGZzdSA9ICpmb3JjZV9mc3U7CkBAIC0xMDg0LDEyICsxMDkwLDYgQEAg Z2V0X2RldiAoY2hhciBjb25zdCAqZGV2aWNlLCBjaGFyIGNvbnN0ICptb3VudF9wb2ludCwg Y2hhciBjb25zdCAqZmlsZSwKIAogICBhbGxvY190YWJsZV9yb3cgKCk7CiAKLSAgaWYgKCEg ZGV2aWNlKQotICAgIGRldmljZSA9ICItIjsJCS8qIHVua25vd24gKi8KLQotICBpZiAoISBm aWxlKQotICAgIGZpbGUgPSAiLSI7CQkJLyogdW5zcGVjaWZpZWQgKi8KLQogICBjaGFyICpk ZXZfbmFtZSA9IHhzdHJkdXAgKGRldmljZSk7CiAgIGNoYXIgKnJlc29sdmVkX2RldjsKIApA QCAtMTEwNyw2ICsxMTA3LDkgQEAgZ2V0X2RldiAoY2hhciBjb25zdCAqZGV2aWNlLCBjaGFy IGNvbnN0ICptb3VudF9wb2ludCwgY2hhciBjb25zdCAqZmlsZSwKICAgICAgIGRldl9uYW1l ID0gcmVzb2x2ZWRfZGV2OwogICAgIH0KIAorICBpZiAoISBmaWxlKQorICAgIGZpbGUgPSAi LSI7CQkJLyogdW5zcGVjaWZpZWQgKi8KKwogICBpZiAoISBmc3R5cGUpCiAgICAgZnN0eXBl ID0gIi0iOwkJLyogdW5rbm93biAqLwogCi0tIAoyLjUwLjEKCg== --------------zwLEKonwhUpZnGQbfTxZZBkZ-- ------------=_1756576382-27615-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Aug 2025 01:46:16 +0000 Received: from localhost ([127.0.0.1]:40884 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uroBz-0007sM-8x for submit@debbugs.gnu.org; Thu, 28 Aug 2025 21:46:16 -0400 Received: from lists.gnu.org ([2001:470:142::17]:39304) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uroBu-0007qX-1h for submit@debbugs.gnu.org; Thu, 28 Aug 2025 21:46:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uroBn-0004M5-RG for bug-coreutils@gnu.org; Thu, 28 Aug 2025 21:46:03 -0400 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uroBl-0005DG-0b for bug-coreutils@gnu.org; Thu, 28 Aug 2025 21:46:03 -0400 Received: by mail-pj1-x1041.google.com with SMTP id 98e67ed59e1d1-32783de3e87so1625483a91.0 for ; Thu, 28 Aug 2025 18:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756431958; x=1757036758; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=MZBolQzK5vqT10JvgYwzwA8XTyRibApJSabcfwx12e8=; b=c6rRoJx27kd1xUxdhuxcjmvkBTpKitszR6jocW1/yxOoXuIISIKxfw9CdW8WCpkmt2 zo0ekbZ5IK9nCyyuLckWqKmjFAc6Cfe2goGekG0q5dPRDe64apkSOgwAuW35KGWxfk3i +HnRdMmUlXFWn+2LwFnW4vQ/qeh0wQuMOTChNeoHcwgsKvGmNZHI0waqoQV9hVDejUWv o1bEcoTV8IMlOGOhojzXvI2SmzLXJLUiH+8jNwaq5W1kNtHRxRG06XeI8EJ5ldxjqy3x EMivuwQLaaUaRtdngPwirVO6SsMXUFb14+fE35eIjE/jcVQa/Ph0soKzvBjsvphGazMr 7QbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756431958; x=1757036758; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MZBolQzK5vqT10JvgYwzwA8XTyRibApJSabcfwx12e8=; b=JoRmGs31y3PKHBRmn3Yq/AIWscZXL4/gxG2ejVaAWHvAt/kXIlnCE785E9I+Hhz54e PSgxwsuaEJu1E1R4Ni7/92aq7DKqQ/iOCXP+MgiFZ7+bydpAlRfVH78LhaiYmvEQ+Ne8 NJL0PSVx6fq5MHe9MxRxjZpSzInVvwQeXgWPZq23os7jMtJGH0ENubh1iSilqtgITQEq PJ8CZvUJKXnOjW2ebGAHVQavj1cqwILqtPpk+VeEEDUWt/4JqAXN7JVQUEZZFtYXFBJy NVSIzJTr70iihPkpjBQgIh/urweAPry9kraCi+iIKgPRhERaC8sns0NZ0+9VrkDIHj/Q CY7Q== X-Gm-Message-State: AOJu0Yw9tvtb8RIQaMAbipFXwv+bKYywf4eGM02o7xtyH2jrInApopTv xG/HCc+sK0BoFjZhgYV3gEaBi/YYVEO8A5eyae3ZBwLbJx/5sI5KYtHBTqPswnJxeQ5hVY/obtU BiL7od/3jeirB9tM9zOS5xks/RTTs1HD79lrMD2IVvA== X-Gm-Gg: ASbGncu4NhljcUhXPRunfkZryTj91LCoddAS1KrDQChwssHalLWoSTaqqJCAn5MhNLX sVMIsIPHD5dpO8nX+T1JGL4La9pOG6i6uUfRYY1rRQmC+HChYNbne3ofu2Evy+7CPqN9qrO6hD8 3CG3Rf3V7U8R3BYCnDelvhgv7lXetX4BbAYVP/YcnaUqrAzB/p0VWQKEtqvd7UP+HpelMeJS0No /7GXriWyg== X-Google-Smtp-Source: AGHT+IHFmOtE5suJ00qg01lqkQfN3B3Ynzcb6wKG3oAcz2b5o/7Gb5WSUEXp9puFMkJAtiPYwqDhwW+CIdgxiNV0K6A= X-Received: by 2002:a17:90b:50c6:b0:325:2a77:bf5d with SMTP id 98e67ed59e1d1-3275085d3e8mr14781539a91.0.1756431957997; Thu, 28 Aug 2025 18:45:57 -0700 (PDT) MIME-Version: 1.0 From: yubiao hu Date: Fri, 29 Aug 2025 09:45:46 +0800 X-Gm-Features: Ac12FXwbqCHiN-p4EY7SZxUcZjKvzwIccS63BrKcbAl-_b60q0Ed8rVo0gy8INY Message-ID: Subject: [PATCH] df: fix potential null pointer dereference To: bug-coreutils@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=huyubiaox@gmail.com; helo=mail-pj1-x1041.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * src/df.c (get_dev): Fix potential null pointer dereference - Avoid dereferencing stat_file when both device and mount_point are NULL - Handle allocation failure for cell when mount_point is NULL --- src/df.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/src/df.c b/src/df.c index fe2e0e3..f60319c 100644 --- a/src/df.c +++ b/src/df.c @@ -1050,7 +1050,7 @@ get_dev (char const *device, char const *mount_point, char const *file, } else { - error (0, errno, "%s", quotef (stat_file)); + error (0, errno, "%s", quotef (stat_file ? stat_file : "-")); exit_status = EXIT_FAILURE; return; } @@ -1215,17 +1215,23 @@ get_dev (char const *device, char const *mount_point, char const *file, break; case TARGET_FIELD: + { + if (! mount_point) { + cell = xstrdup ("-"); + break; + } #ifdef HIDE_AUTOMOUNT_PREFIX - /* Don't print the first directory name in MOUNT_POINT if it's an - artifact of an automounter. This is a bit too aggressive to be - the default. */ - if (STRNCMP_LIT (mount_point, "/auto/") == 0) - mount_point += 5; - else if (STRNCMP_LIT (mount_point, "/tmp_mnt/") == 0) - mount_point += 8; + /* Don't print the first directory name in MOUNT_POINT if it's an + artifact of an automounter. This is a bit too aggressive to be + the default. */ + if (STRNCMP_LIT (mount_point, "/auto/") == 0) + mount_point += 5; + else if (STRNCMP_LIT (mount_point, "/tmp_mnt/") == 0) + mount_point += 8; #endif - cell = xstrdup (mount_point); - break; + cell = xstrdup (mount_point); + break; + } case INVALID_FIELD: default: -- 2.33.0 ------------=_1756576382-27615-1-- From unknown Thu Sep 11 02:37:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79336: [PATCH] df: fix potential null pointer dereference Resent-From: Collin Funk Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 30 Aug 2025 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 79336@debbugs.gnu.org, yubiao hu Received: via spool by 79336-submit@debbugs.gnu.org id=B79336.175657728230406 (code B ref 79336); Sat, 30 Aug 2025 18:09:01 +0000 Received: (at 79336) by debbugs.gnu.org; 30 Aug 2025 18:08:02 +0000 Received: from localhost ([127.0.0.1]:49737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usPze-0007uL-6Z for submit@debbugs.gnu.org; Sat, 30 Aug 2025 14:08:02 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:45503) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1usPzb-0007tm-Kr for 79336@debbugs.gnu.org; Sat, 30 Aug 2025 14:08:00 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-7723cf6e4b6so477931b3a.3 for <79336@debbugs.gnu.org>; Sat, 30 Aug 2025 11:07:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756577273; x=1757182073; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NVLch3z9+ctY9kfClh/pOYLHKxIaas1fLGvMouZC70Y=; b=VhToIss8xufGHztSOj5e5Zkk51h1xc6wcI3jSRpXYjyRhCtaULgwVcSLQZYiU2ftV+ MxS1kVorPvD5whVlmnDmX00x1Vu3vp9AhMtyRfGvZYlgkvPqWAD3E/GiKUwkbczyDBI2 B1FXtvha959Yx5JAE6pea5ukw6zp4ftwyzWD6lCKeXH1UUv5FmO3W8FIzG3oLTZijNWV zvI2/9zj5h2bQZVA/r000kFSCTK5t8LfZ2dSwyrNsYe+W04WPzdG7CC+jBEO8VjtfnT0 xoLhMahB52Yu5G6DLsX8oN+OPl6K7M5mpaD8BclrXDM6Qum1jru9ymYWLBIV5LC02rVD GMGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756577273; x=1757182073; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NVLch3z9+ctY9kfClh/pOYLHKxIaas1fLGvMouZC70Y=; b=TKVpCrvuFSADqSomPrIfVvFWUi7zxzgrAF71dTW1KYyxULME2gjbxJittJbl4Icw7l BeNk/MJ2spxIILo4JjGxuwUPGciESiu4W3GkDOL1Ffhz6R5KxfLgiAsEHLwDaVjjePcW Hg47SNmek2fNdTmgkgRPYTlhQromSPSlc+GeZH+BsFU3dO//iSAD1i7z+NlDQAatPRrP Fvdl4+/ne8PWEJVlJKQsmjl2RH/cINHjCo7Iin7lafDqTkeojkMRbo0BFW9r+HhmqKMJ VoFj0wTG5y2DUiOID55l2XIIftJU06SrErLzXRzKqvQvTvohIct8Mq6hgwgV9jlpSA97 fugQ== X-Forwarded-Encrypted: i=1; AJvYcCV2Oqfb7wBA1uB3BSYTq3Wr+2hymovQPQn9Hk/2qet9m6HiBMogEK4c0fOsJ4DA7eW4Wb7CRQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx4M4KHGQhVte7ml6UxWh53W4zLSALJeP/iTtish6SfhNLjPNMG LIvqnJcAVzq7JHijg2CQk195Z+W2v0BtiDhUDek3t2wwkeZoUnOiIrFvdyU48q15 X-Gm-Gg: ASbGncuqyupxZHpqOyz+zYxjjT72Sbi7BgyM735dzWjbg5053hXEr23pOOMlwv9r2hh qVimjpEKcluE5gLU7kVX4uvvpl7wOIdXA8yKj1dXc8j4aQmUTuSvknwONqPDUOGSxEs8a+WMyeZ Rb2RCJJzFdyZ54hcIz8tMYmiQ8NWLPBR6D+vLZt7wyYFJt8bmF0ifaiWWw6MK1drfoFMpwHCt19 fZjT9IJpuSWPXtNMy51E8KKXPI70KJNhGfNr/7Ty7/dDzPmyfRMzvqKiLnadFsSj8X502Yef3AX oznpc+pCTZTsjvaFpVMSAipKOz6vBx1ydzzJAKnrcoHDdhH9LMeBYyGWF3p/jz0eluRTVv+y0/D aWUK4Gc6FEN+zmHQ= X-Google-Smtp-Source: AGHT+IGtsleTs0bUuO6z4OgNUmaoQ82T4kxbj0oxZAmEFmmzjPSUvIUuhM7zpJmhZeAF8ZmEBHv8vQ== X-Received: by 2002:a05:6a20:2443:b0:243:bcbf:4fdb with SMTP id adf61e73a8af0-243d6e5f679mr4083553637.27.1756577273169; Sat, 30 Aug 2025 11:07:53 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::aac3]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b4d6cde2f0fsm4344642a12.13.2025.08.30.11.07.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Aug 2025 11:07:52 -0700 (PDT) From: Collin Funk In-Reply-To: <28259158-445c-4769-9d11-b43594ced9e2@cs.ucla.edu> References: <28259158-445c-4769-9d11-b43594ced9e2@cs.ucla.edu> Date: Sat, 30 Aug 2025 11:07:51 -0700 Message-ID: <87qzws3cp4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Paul Eggert writes: > On 2025-08-28 18:45, yubiao hu wrote: >> * src/df.c (get_dev): Fix potential null pointer dereference >> - Avoid dereferencing stat_file when both device and >> mount_point are NULL >> - Handle allocation failure for cell when mount_point >> is NULL > > Why is this patch needed? Can you give an example df invocation in > which mount_point is null there? As far as I can see, that cannot > happen. That was my understanding as well. Since preceding that section there is: /* If MOUNT_POINT is null, then the file system is not mounted, and this program reports on the file system that the special file is on. It would be better to report on the unmounted file system, but statfs doesn't do that on most systems. */ if (!stat_file) stat_file = mount_point ? mount_point : device; I don't see why we would have a mount entry if both MOUNT_POINT and DEVICE are NULL. Collin From unknown Thu Sep 11 02:37:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79336: [PATCH] df: fix potential null pointer dereference Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Sat, 30 Aug 2025 18:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: yubiao hu , 79336@debbugs.gnu.org Received: via spool by 79336-submit@debbugs.gnu.org id=B79336.17565787412301 (code B ref 79336); Sat, 30 Aug 2025 18:33:01 +0000 Received: (at 79336) by debbugs.gnu.org; 30 Aug 2025 18:32:21 +0000 Received: from localhost ([127.0.0.1]:49763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usQNA-0000b3-Pg for submit@debbugs.gnu.org; Sat, 30 Aug 2025 14:32:21 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:48138) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1usQN8-0000ah-GG for 79336@debbugs.gnu.org; Sat, 30 Aug 2025 14:32:19 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-45b7e69570bso13166685e9.0 for <79336@debbugs.gnu.org>; Sat, 30 Aug 2025 11:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756578732; x=1757183532; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:sender:from :to:cc:subject:date:message-id:reply-to; bh=vgopdCie0eW0HPuEVKX+EYoLnAYNIue9iWJk24SnQJM=; b=KdYZhdWgYoXZVdFaa6bsoK2of8mEs6h/DHpLVhe8AgJ3GBK7JKYXF7CsKKOeaAqkgR gT1hgpxw5kj31X3UuaLV9NGx2hFOvGiiAmWGOpYdWEsstPnFaFlKawir3mKyvRKb8V7Y YYxmm30Pb/iPR78GJ+nlTObp2lPa/otiDAoHGkM6RpxdNkNgCVKICIFKIC4numtF7z1Q bZCYK65S9fQTeqLUIcIHwyq0pdnJKhpscgRcr15aOA8Q2hUn9PAtMjOr1G5bPF+k9KIa ZQwnUED/EyTL4RgDzn0C9AbnfgPVEE0u8QuPEcLYZMVFrxm6OVLDpbSSGTxUBasPmEzF h7Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756578732; x=1757183532; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vgopdCie0eW0HPuEVKX+EYoLnAYNIue9iWJk24SnQJM=; b=VVag9RenZFftAEbgXCNK2dK4p6uLph+KLBbKowiKpQRLaqQ3i/5zbitFBLTf5UWkE7 AQEn/SbJZoJ2KeYP+oZHEeWgk0qotRZzI8egUGp5NMGn1MEYFEVczgeL4TR+bAAMglXd YIoR+DHUHvV7YSzqOXpBysVp945C80vSDYpRGh8IZCby6Nw0svCCbawJD1qq0X9DYRXu DBzGvPIlki/REHwog1AwHaCgqH2bIc3ELgH0VBjQu68MseuOq4c+3YLPWwpbwEQ8aTPO Kbzi0G49GH5INmfY6OWwS36/dIfh3rdyocy8sguOOfdjRdDr+N4bcox/72IkpzkLMg1N cT6g== X-Forwarded-Encrypted: i=1; AJvYcCW8xIVJ3QCkGpkyGI/5MX2hqInLPhdWA5B5ttwvQei/VKMZao3UETqwcHq5bhyyXoP4ZNsVTw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzWNkazMgrs/h6XtkAh523ml1TPbgAEehTVNuGxHKkTT4kTRylK FeSwRK9J5lIEfCVGaHKnjHWaYdvUHfk2r/DcsUiBeg2FVOsF7z0Cw+TT X-Gm-Gg: ASbGnctZquka/2jJjemysbFkYrZAcYYJB8I1FqkcorYyxasI0aOMNis64+ePD0xdIRB G/lymLG6LklKkTiTaHaH9MdiKkqV5jeuDMqljJ1A1Bd5atW9QRYbf4H54je3AvORo0Dk3vjwCer pPGdWAgszsUb9ZmX8I9wxoBxBbMaJF6ofKo1QrSrzCheF7Fu4itu9rnn0G5mIcAWS3vts/5w4Gx gWJev7/nctLV0RRPEpBioigr/4c/aEB8vgIfvWwVZa9+dGHBtUaIo3TFDM0vMpFAsvLBNPU8aZi z/MDKymVjU7M0Tmchf05oFnjntAtkCNCPuNh+tNY7BuKrBR/jNFVV+vREUSpN2qLAikmDMz3ScX H+RFnv3niWpUuZqyrmG3HkoxjHmD2yiXZbU5k6wIBOl+1vBt2tA1dvj083SRlAhfr7adYB6YXI5 vAog== X-Google-Smtp-Source: AGHT+IG1YNOmDePAaITbHCa6dnveDZnb5Fj+UfP0Wc0K8ffSzXTg668uw3vWTKdXVpHvFzdnNCmc0w== X-Received: by 2002:a05:600c:3b24:b0:45b:7a21:9e96 with SMTP id 5b1f17b1804b1-45b8558b7bemr21820295e9.37.1756578731945; Sat, 30 Aug 2025 11:32:11 -0700 (PDT) Received: from [192.168.1.31] (86-44-211-146-dynamic.agg2.lod.rsl-rtd.eircom.net. [86.44.211.146]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-3cf1a2560c3sm7990442f8f.0.2025.08.30.11.32.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Aug 2025 11:32:11 -0700 (PDT) Message-ID: <172adcbe-1338-4718-99cc-7b2def37180b@draigBrady.com> Date: Sat, 30 Aug 2025 19:32:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta From: =?UTF-8?Q?P=C3=A1draig?= Brady References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 30/08/2025 18:52, Pádraig Brady wrote: > On 29/08/2025 02:45, yubiao hu wrote: >> * src/df.c (get_dev): Fix potential null pointer dereference >> - Avoid dereferencing stat_file when both device and >> mount_point are NULL >> - Handle allocation failure for cell when mount_point >> is NULL > > These are valid concerns. > I also see potential null dereferences of device. > The attached patch takes a different approach > by ensuring arguments are initialized earlier. I'll hold off on pushing this since until Paul's questions are answered. I did also think the issue was theoretical, so my changes should also be seen as just pacifying static analysis, and making the code a bit more defensive. cheers, Padraig From unknown Thu Sep 11 02:37:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79336: [PATCH] df: fix potential null pointer dereference References: In-Reply-To: Resent-From: yubiao hu Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 01 Sep 2025 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Paul Eggert Cc: 79336@debbugs.gnu.org Received: via spool by 79336-submit@debbugs.gnu.org id=B79336.17566919554682 (code B ref 79336); Mon, 01 Sep 2025 02:00:02 +0000 Received: (at 79336) by debbugs.gnu.org; 1 Sep 2025 01:59:15 +0000 Received: from localhost ([127.0.0.1]:55885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ustpC-0001DP-F7 for submit@debbugs.gnu.org; Sun, 31 Aug 2025 21:59:14 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:45451) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ustp9-0001D5-SE for 79336@debbugs.gnu.org; Sun, 31 Aug 2025 21:59:12 -0400 Received: by mail-pf1-x444.google.com with SMTP id d2e1a72fcca58-7723cf6e4b6so992323b3a.3 for <79336@debbugs.gnu.org>; Sun, 31 Aug 2025 18:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756691946; x=1757296746; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=ziLlW2uYv5F6OqMkrxTM8T/7wUdUqbB1rl5YfPdAKE0=; b=KQPTNXvO3fzablxTeI98Vq/gm7wOqB1LgnR1IMdB+YmEpAf9h4FIv/PG8e3Ov+a4Q+ KXt3BBDY0sbejS7odJK/Ji2WUTjhu/IHhQQRmFn0vPkcWTdXF62tU7WW8j3sTdjEASdu 8R77h+AmIhgRcGxT+VTAAvHqrMdn00gNBG/xnM+x2gfO5tSMZSX5VTXkofrkdVHI/w5J GxOOyRKyU97OsNwI+/Qupy4CwVKCHW4rZ9Z25MWbWJbQYHV2bqaqo6g6icuK/msJlYww TKW5RGaaft/cJ1K8AWJZZ1OA6OEhiWRZVnH7tTx95Psy77f+3u1tW8/EqPTK1W6JeCdm a9MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756691946; x=1757296746; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ziLlW2uYv5F6OqMkrxTM8T/7wUdUqbB1rl5YfPdAKE0=; b=GSJ2Ttdgq6xWB8yB/kKtnAK9VQhVU8LoDl3gRGGw6j3YeO0GxBo6V4tb1TycO4yKxp 4F4GZnQO552FhePrpW0mokioQKQ2HPw+g4F1ygSGA0iCmw2OCfaqlz88Oq6v/SvJCedO ono93x46bMF+sNgzdTA3V8tu1e05gTCVkfJgQI7/2n40ApJ2KbtygReT/6TLGoo9AzPR LvzybSv1hHC44lRq9akXS27RxChFoq4Qh0aXMCmaQNnjQA/H4QMg6H07UufWnnVXF1so h/1V+9cEXJP76RbOSWmT6ZkRjOI2z7EskzFrzdOSHppR7GNTrjqF4ubtdtOHUgVt283d FZeA== X-Gm-Message-State: AOJu0YxeMeEzA+5s+P72emcc8oT13THmumXyxM3uxpO4n0A0aOueugSW hJXIjZ/9XNUAXRQiQnXJCs0SQ5gzGUEi1FfUgX3rDNppFwaalvkvfqljqMuIATZq9+biQlZKnm4 iurjEMb78nOhv+vTtW6mKg5VOhCLr0kY= X-Gm-Gg: ASbGnctMI/qEDIPQeRwUF8vpDLl6DI6/huDQCd9X7AnUZYTP+34EFjTDHyYPiYcHcj1 0Ahvtrojx/fWfwYfrswCXUyR2JE/JTAfjhgeOWP7Gk3uRxeeRhugnvQLNa394yD5v7rZmZ090Ui tUfD6I1ARB49UggqJ5BvjXP0RbOhF6Cg83UpBad+xZ5elvtQMEF3ue+cqe8BZV4AgWVHZacbIic D+heb6BqhxHN0avnekYY37X X-Google-Smtp-Source: AGHT+IHueK7a7UeydJZN2rEry3YRmL+dho+wHaIIcDcawiryIYgUb4nVOq5fjpbphiEyR5wVO6A7exyDLNqZ3MLIiss= X-Received: by 2002:a05:6a21:99a0:b0:21c:faa4:9ab8 with SMTP id adf61e73a8af0-243d6dd4dc0mr9134006637.10.1756691945517; Sun, 31 Aug 2025 18:59:05 -0700 (PDT) MIME-Version: 1.0 From: yubiao hu Date: Mon, 1 Sep 2025 09:58:52 +0800 X-Gm-Features: Ac12FXwQJPZnSTjYwtR5uAUTwfqn8_bhKmiFrH-Ufa9FzZ-hFxBMAfe_KrOLniE Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On 2025-08-28 18:45, yubiao hu wrote: >> * src/df.c (get_dev): Fix potential null pointer dereference >> - Avoid dereferencing stat_file when both device and >> mount_point are NULL >> - Handle allocation failure for cell when mount_point >> is NULL > > Why is this patch needed? Can you give an example df invocation in which > mount_point is null there? As far as I can see, that cannot happen. > > Did your bug report come from static analysis? If so, which static > analyzer did you use and how did you use it? Does the attached patch > pacify your static analyzer? Yes, this bug was identified via static code analysis. The initial finding that core dump would occur in `cell = xstrdup (mount_point);` when mount_point is NULL. I attempted to inject code to set the mount_point of get_dev() to NULL, which still results in a core within IS_ABSOLUTE_FILE_NAME. From unknown Thu Sep 11 02:37:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79336: [PATCH] df: fix potential null pointer dereference References: In-Reply-To: Resent-From: yubiao hu Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 01 Sep 2025 02:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: "P@draigBrady.com" Received: via spool by 79336-submit@debbugs.gnu.org id=B79336.17566927657145 (code B ref 79336); Mon, 01 Sep 2025 02:13:01 +0000 Received: (at 79336) by debbugs.gnu.org; 1 Sep 2025 02:12:45 +0000 Received: from localhost ([127.0.0.1]:55902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usu2G-0001rA-Uc for submit@debbugs.gnu.org; Sun, 31 Aug 2025 22:12:45 -0400 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]:59474) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1usu2E-0001qv-UF for 79336@debbugs.gnu.org; Sun, 31 Aug 2025 22:12:43 -0400 Received: by mail-pf1-x443.google.com with SMTP id d2e1a72fcca58-772481b2329so1122068b3a.2 for <79336@debbugs.gnu.org>; Sun, 31 Aug 2025 19:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756692756; x=1757297556; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=KuhCrGSHz/C5QEUExgqlb7wBvzGWg9ehiPWKjfxdQMQ=; b=Jbbv8N7RV16JO5wG0F8L2kSTadCFBqz5dO+JFZswfcydiIRfrpU1kkS03NCyA5ZgK1 x+hXfmqMHqxoIf0t2GqiqjcrmAlBALOpnbGDVlSIcn57fB/wiTHe6pcAjvCJLwVwnvzp 9YDFtrQd6sST7xQM6WC3/5QrRvoaxa5gUcUkJvjRqoU613YJ4zOyT+g18Bgh/s9A7+4P qoT00ewgukOUWpQJxkr8Gd7BzZ4hObBAqTIeBodzg88PnDD8k3q6ruseEhMA1mrUi+Ki uJKHnJGOjW1XLNFCveqcoWiIuVWpaaGCxmGhyvwFedgImVf0w+2ddjIpk5oyAt6BQJV5 recg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756692756; x=1757297556; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=KuhCrGSHz/C5QEUExgqlb7wBvzGWg9ehiPWKjfxdQMQ=; b=LZNkwWj9FRF0QWG2w6CvpZBe96Tu9NFdYvPxZn2y6WHo/9EgtACz/YXxgt5q/8Oggt Dz3Y8YICvHScFoG+wNEBjh9FUlgj/p4q7zGXZERJcqbUSZkAHH3DDqzcCdd0YsRAuXoo MlmRC4CHRMXnmG1ZkFQMBuA862Zm4Xu5jTEEyVsjrXATJhmHFEJDeOqAOppVRD4MRqGH auOMKHPwvZFswRqVuSNApSkrZJIRbHCtKz6n7k3S+R4rxLp7TvkXPx9ltwlOu0sJgljF zDZnuSTq0thIhvyGkD1MDs1RgpKNKpCV0OjLMOSA3cSc3W0ex+6kbOSZUabi5heuW1B2 2YXw== X-Forwarded-Encrypted: i=1; AJvYcCVlC3P8nphpjKMqqcbrT2jkTCSsF+4umHnmp1TV06Gyo46X4FPUYjmlVNFvC4lKlB3ObsIbBQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxccmjF0mQ39MLCFu2UX0WF1Rl2T4+e06zeAWF5jVWdxTxOE2aU sZs5gmWLouu1jVyfeu2P9rqvwsz9iPA1Yj9GTKXit5+iqKnLqQRfttOpw3YcDQ+cGOp6wZ7stZ3 zWxrrZXK7tmRYrtdpyd/h62da/Nc6Lao= X-Gm-Gg: ASbGnct3Q3kG+bnubvrS0/4QDkICh9WFBPNXVWvgf0SIXKBchGL49CQhjGZRxMdVw9U 8lzb+SZf3B4WTgYbfvfLnvy3rn6oSOOTNSF4SQmimReAWN4EVoPhxCYh7/Eqjf/6BRGARZy9tO6 8PNgpwRK7CTl8q5X+J3fkuqaSgJCBW5aYLtxD0x0MAcCbOgqhxMzm+fDfuhAeZw4qVGrlYVKQAA 2cJCEMQmtn8qd2LRD26s8K6RdmcZ1zre8o= X-Google-Smtp-Source: AGHT+IHTvJ7UVrb1K/oo0uVdpoiReQEf2IH2cYvTUz1hpxO1+feRhCEx5TmDA4BX6xkczDXizgf2xE0FWMUeHoO/wSs= X-Received: by 2002:a05:6a20:12c5:b0:243:cf4c:6667 with SMTP id adf61e73a8af0-243d6efefe4mr8788664637.35.1756692756321; Sun, 31 Aug 2025 19:12:36 -0700 (PDT) MIME-Version: 1.0 From: yubiao hu Date: Mon, 1 Sep 2025 10:12:23 +0800 X-Gm-Features: Ac12FXy28mrNoF8ODpT-npNQIMVD0b5Sj6omiMslSKn24PCew_UmLc-7Rv-m08A Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On 29/08/2025 02:45, yubiao hu wrote: >> * src/df.c (get_dev): Fix potential null pointer dereference >> - Avoid dereferencing stat_file when both device and >> mount_point are NULL >> - Handle allocation failure for cell when mount_point >> is NULL > > These are valid concerns. > I also see potential null dereferences of device. > The attached patch takes a different approach > by ensuring arguments are initialized earlier. > > Marking this as done. > > Will push the attached later. Thank you for the code optimization. I would like to highlight a potential issue: if both mount_point and device are NULL, stat_file still end up being NULL. This could lead to a core dump at the `error(0, errno, "%s", quotef(stat_file));` However, there may never be a situation where both mount_point and device are null at the same time. From unknown Thu Sep 11 02:37:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79336: [PATCH] df: fix potential null pointer dereference Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 01 Sep 2025 02:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: yubiao hu Cc: 79336@debbugs.gnu.org Received: via spool by 79336-submit@debbugs.gnu.org id=B79336.17566937209789 (code B ref 79336); Mon, 01 Sep 2025 02:29:02 +0000 Received: (at 79336) by debbugs.gnu.org; 1 Sep 2025 02:28:40 +0000 Received: from localhost ([127.0.0.1]:55922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1usuHf-0002Xp-W7 for submit@debbugs.gnu.org; Sun, 31 Aug 2025 22:28:40 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:39396) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1usuHb-0002XU-Sa for 79336@debbugs.gnu.org; Sun, 31 Aug 2025 22:28:38 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id D20003C2E8B7A; Sun, 31 Aug 2025 19:28:24 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id TlBbNKzhiIva; Sun, 31 Aug 2025 19:28:24 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id AA54E3C2E8B7D; Sun, 31 Aug 2025 19:28:24 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu AA54E3C2E8B7D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1756693704; bh=8lDthACSp5N2dD5RSb6vaqeQ24HodY8fzrVaIqtIY2M=; h=Message-ID:Date:MIME-Version:To:From; b=H9WDhGZ5qm+su+cwjksz9Fr/LYxpFfr+qVtGvMpu/1C+zo3PJTPgk+Knvo93HZQD7 SxSgS5t0/D7YUU2kg4LuVIA+kjQ/x1LPR2R/kopNLTZGVUXurWt14e1/6NoQZXfhcZ IX/A6iRUeWMZxX0UXwZt28NTjVy8eMCF4DpWS8FIUxNXgSCPZ9kIYLwousXk+/udn4 CUdwZjCwgBXjecmUNlgWHYhKtKO1oRArkw9P/LXG2r8kckoyA98e/z4dlwWcO6uK2s a4k6jnNSeKkcR6gvPkjmr18PHsXRnQOWa7I+ZCHS1LgBSBe+LpOQnnX5CKCVZLkyeg xvMRixW3uHNAA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id AOIbARQBlm_o; Sun, 31 Aug 2025 19:28:24 -0700 (PDT) Received: from [100.115.92.201] (47-154-18-19.fdr01.snmn.ca.ip.frontiernet.net [47.154.18.19]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 793803C2E8B7A; Sun, 31 Aug 2025 19:28:24 -0700 (PDT) Message-ID: Date: Sun, 31 Aug 2025 19:28:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: Content-Language: en-US From: Paul Eggert In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/31/25 18:58, yubiao hu wrote: > Yes, this bug was identified via static code analysis. The initial > finding that core dump would occur in `cell = xstrdup (mount_point);` > when mount_point is NULL. It appears that the static analysis is reporting a false positive. Which static analyzer are you using? Or are you doing this by hand? Do you get a false positive if you install the patch I sent you earlier? You can find that patch again here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=79336#8 From unknown Thu Sep 11 02:37:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79336: [PATCH] df: fix potential null pointer dereference References: In-Reply-To: Resent-From: yubiao hu Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 01 Sep 2025 12:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: "eggert@cs.ucla.edu" Cc: 79336@debbugs.gnu.org Received: via spool by 79336-submit@debbugs.gnu.org id=B79336.175673105316272 (code B ref 79336); Mon, 01 Sep 2025 12:51:01 +0000 Received: (at 79336) by debbugs.gnu.org; 1 Sep 2025 12:50:53 +0000 Received: from localhost ([127.0.0.1]:57004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ut3zo-0004EN-5J for submit@debbugs.gnu.org; Mon, 01 Sep 2025 08:50:52 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:60664) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ut3zi-0004E1-GZ for 79336@debbugs.gnu.org; Mon, 01 Sep 2025 08:50:48 -0400 Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-7724cacc32bso979658b3a.0 for <79336@debbugs.gnu.org>; Mon, 01 Sep 2025 05:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756731039; x=1757335839; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=/agP2gtO7VqLkpVRz7QprL5uN/R39gchOp/X7DMdb9U=; b=FykmhXM+Y1ky2B/GaAj154rJoliv3Fo/wr75oDPagw8GI2xssacMeIkBI50THPcYyb H4UhhRQAi1jz/CgwANDRuFVWFBLgIi9ESglVy0c3d6IEIWBJKvLIZuSpp0ioqQVYzCX/ eObYv4JRunzIQmyIczusBztwf4jhYexHTpmrvf6YeDWP7nuuMYh6fHJ7Et+b4XYVoHP/ A6B0DJEX/2lYz7kCAenuZNs/OjYI9d411YJB13nH/1FLnpj6bXnbXSNCd4SGe/rKxyMl dGnKfAiYIQsXB5Eom5NigIJppNO2xzH4N8wLLY9w+rip3iZgq7RwEcDs8FCzMJwHbmqd vx9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756731039; x=1757335839; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/agP2gtO7VqLkpVRz7QprL5uN/R39gchOp/X7DMdb9U=; b=XQ9xmI//XyZIwrX8LH+LhZbclssApAZn5GpdHiDvmwzJAfLzL4G9zatoWOAMogj4Iw zzk3QGfivzOKuhSoKn5W5of/tKi3HpMheLrxt2rGoDdD83Gl+gVWov1mQRk8Kos0Jvj3 GAwG+o+KNSnikXkxGVUJH2S8Dq6O73Sl0jeUwFr/NOcA217VEaI7Bu9EO4SJ4j0rDwBi GOR/X5GEPHuek4BtbgsFpUINHAXcyMz33kN3WQ9DMWLv4vGxOcIb5/LE4BK+0233nayq 5fWNMjtbJD5HkH2D2ihqWz1O02xhBxTF5OlE76pHokAfR0X2QaUQTaYqPebFNWvuCJYJ S2Eg== X-Gm-Message-State: AOJu0YyrgWVSAn5/eP288dSbnHr/g3/6jGjy1Yy/M+m6FMV9aETBSH3a J5qum9fig6urQcbUoPF43yalxoJm0WqSdJDchQC3ac/gszeWaNK4WrIrjOznNOJkK6mbmtUqP3l PxIfJ2xC1zy38Jr07iwAEvDCo42LtfXQ= X-Gm-Gg: ASbGnctJqeL7uf5gwMKr6rJ0msZo/fpzXq/Tr2VFb8QzpKEt6LCKXvCwQ9NM94bT8Ep IUfzCH4Wugw/n+35Nnz6LRZ+3gLwJLoXZwz4cXxfb2+qKyHdoLC4lXq7lcoOJKrH9gO6dH3vjD3 0XPDUx1bnhGfKfCoood7E15hck+C6bxEQawG0JXB3LztVGvwhJTwjThl3mS287a7Ws5us5oOZ/Y Vw2qnCHVrYjKA7lLPnrAMzm X-Google-Smtp-Source: AGHT+IElNyglx30oO77nvc6wVQ5Oz0xz/RdTENpqiIUUTxuYWHA0+1Cxg6IOVVGX6REjl5NZn4+r41qFFMz8OBh8N2k= X-Received: by 2002:a05:6a20:3d07:b0:243:b190:d139 with SMTP id adf61e73a8af0-243d6f1003cmr10828106637.39.1756731039190; Mon, 01 Sep 2025 05:50:39 -0700 (PDT) MIME-Version: 1.0 From: yubiao hu Date: Mon, 1 Sep 2025 20:50:25 +0800 X-Gm-Features: Ac12FXy9aJ3ZvH49ZT0SOwROXsF9AKatDoNA9Pl1mcjjQTj3c4qSmukjRPdOn24 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On 8/31/25 18:58, yubiao hu wrote: >> Yes, this bug was identified via static code analysis. The initial >> finding that core dump would occur in `cell = xstrdup (mount_point);` >> when mount_point is NULL. > > It appears that the static analysis is reporting a false positive. Which > static analyzer are you using? Or are you doing this by hand? > > Do you get a false positive if you install the patch I sent you earlier? > You can find that patch again here: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=79336#8 The analysis was conducted using our internally-developed static analysis tool. My apologies, but I am unable to share the tool itself or its usage methodology. I have tested the patch, and it can pacify my static analyzer. From unknown Thu Sep 11 02:37:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79336: [PATCH] df: fix potential null pointer dereference Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Mon, 01 Sep 2025 17:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79336 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: yubiao hu Cc: 79336-done@debbugs.gnu.org Received: via spool by 79336-done@debbugs.gnu.org id=D79336.17567464528150 (code D ref 79336); Mon, 01 Sep 2025 17:08:01 +0000 Received: (at 79336-done) by debbugs.gnu.org; 1 Sep 2025 17:07:32 +0000 Received: from localhost ([127.0.0.1]:58372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ut80C-00027N-6R for submit@debbugs.gnu.org; Mon, 01 Sep 2025 13:07:32 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:51176) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ut808-000273-Fr for 79336-done@debbugs.gnu.org; Mon, 01 Sep 2025 13:07:29 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id C9C653C32B0EF; Mon, 1 Sep 2025 10:07:21 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id uk0VpBijvtf9; Mon, 1 Sep 2025 10:07:21 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id A13273C32B0F0; Mon, 1 Sep 2025 10:07:21 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu A13273C32B0F0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1756746441; bh=Clga1f51rZSQRPWYi6gz6GFTtR5rC5pUn97ZW5zoZPY=; h=Message-ID:Date:MIME-Version:To:From; b=fMzcV/mOdpjK4+6Yo40IKwvr5/uLhEIFekmCPz0Q+IldZcSppcLYIaGsZQuFZGbuG oEsIyPjbCQ5rz9F2/iwN64s6V1M+T0GCn6NLccqLWu/b2omuPehGSOk/305G7dcVKi dgkCdqEkXuE1K/VZxGVrRPBo6h7laD52JjVInQ/uNmXqpomLclZ+TFbFh6+PnQnNlt fP4F5oEkLyUodSnMGnhI35zYK5shuSR3JbSHXbbe965tgRg0aYgy/U7AlJEiGTKh/p Gzts1+yYouvtZ0j/6Yjm0qpAgcqfkanJNgvn47R5hy1YbvPucVSE74fzFRGTJKrfmk ME1qPIC50jOiA== X-Virus-Scanned: amavis at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id sT68zaB4C02c; Mon, 1 Sep 2025 10:07:21 -0700 (PDT) Received: from penguin.cs.ucla.edu (47-154-18-19.fdr01.snmn.ca.ip.frontiernet.net [47.154.18.19]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 835CD3C32B0EF; Mon, 1 Sep 2025 10:07:21 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------kreDZiEP69Xzw6mmF9s8xNOq" Message-ID: <348425e4-9ef0-42e5-856f-b65f64b07061@cs.ucla.edu> Date: Mon, 1 Sep 2025 10:07:21 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird References: Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------kreDZiEP69Xzw6mmF9s8xNOq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-09-01 05:50, yubiao hu wrote: > I have tested the patch, and it can pacify my static analyzer. Thanks for checking. I installed the attached patch, which is the same except with a comment fixed. It's typically better not to patch merely to pacify a false positive from static analysis, if the patch introduces makework code that complicates the work of humans (and of other static analyzers) and that slows down execution. But here the patch streamlines the code (and caused me to review and fix commentary errors) so it's a clear win. Thanks for reporting the issue. Closing the bug report. --------------kreDZiEP69Xzw6mmF9s8xNOq Content-Type: text/x-patch; charset=UTF-8; name="0001-df-pacify-static-analysis.patch" Content-Disposition: attachment; filename="0001-df-pacify-static-analysis.patch" Content-Transfer-Encoding: base64 RnJvbSBjNjM5N2QwODcyNWU2NTFmZTgxZmJiZDkxZGYyMDQzNjc0MjA2ODY1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDEgU2VwIDIwMjUgMDk6NTU6MjkgLTA3MDAKU3ViamVjdDogW1BBVENI XSBkZjogcGFjaWZ5IHN0YXRpYyBhbmFseXNpcwoKUHJvYmxlbSByZXBvcnRlZCBieSBZdWJp YW8gSHUgPGh0dHBzOi8vYnVncy5nbnUub3JnLzc5MzM2Pi4KKiBzcmMvZGYuYyAoZ2V0X2Rl dik6IEFzc3VtZSBNT1VOVF9QT0lOVCBpcyBub24tbnVsbC4KLS0tCiBzcmMvZGYuYyB8IDE0 ICsrKysrLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCA5IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9kZi5jIGIvc3JjL2RmLmMKaW5kZXggZmUy ZTBlMzhmLi5kYjUyODcxNTcgMTAwNjQ0Ci0tLSBhL3NyYy9kZi5jCisrKyBiL3NyYy9kZi5j CkBAIC05ODgsMTUgKzk4OCwxNSBAQCBhZGRfdG9fZ3JhbmRfdG90YWwgKHN0cnVjdCBmaWVs ZF92YWx1ZXNfdCAqYnYsIHN0cnVjdCBmaWVsZF92YWx1ZXNfdCAqaXYpCiB9CiAKIC8qIE9i dGFpbiBhIHNwYWNlIGxpc3RpbmcgZm9yIHRoZSBkZXZpY2Ugd2l0aCBhYnNvbHV0ZSBmaWxl IG5hbWUgREVWSUNFLgotICAgSWYgTU9VTlRfUE9JTlQgaXMgbm9uLW51bGwsIGl0IGlzIHRo ZSBuYW1lIG9mIHRoZSByb290IG9mIHRoZQotICAgZmlsZSBzeXN0ZW0gb24gREVWSUNFLgor ICAgTU9VTlRfUE9JTlQgbmFtZXMgdGhlIHJvb3Qgb2YgdGhlIGZpbGUgc3lzdGVtIG9uIERF VklDRS4KKyAgIEZJTEUgaXMgdGhlIG5hbWUgdG8gbGlzdDsgaWYgbnVsbCwgaXQgZGVmYXVs dHMgdG8gIi0iLgogICAgSWYgU1RBVF9GSUxFIGlzIG5vbi1udWxsLCBpdCBpcyB0aGUgbmFt ZSBvZiBhIGZpbGUgd2l0aGluIHRoZSBmaWxlCiAgICBzeXN0ZW0gdGhhdCB0aGUgdXNlciBv cmlnaW5hbGx5IGFza2VkIGZvcjsgdGhpcyBwcm92aWRlcyBiZXR0ZXIKICAgIGRpYWdub3N0 aWNzLCBhbmQgc29tZXRpbWVzIGl0IHByb3ZpZGVzIGJldHRlciByZXN1bHRzIG9uIG5ldHdv cmtlZAogICAgZmlsZSBzeXN0ZW1zIHRoYXQgZ2l2ZSBkaWZmZXJlbnQgZnJlZS1zcGFjZSBy ZXN1bHRzIGRlcGVuZGluZyBvbgogICAgd2hlcmUgaW4gdGhlIGZpbGUgc3lzdGVtIHlvdSBw cm9iZS4KICAgIElmIEZTVFlQRSBpcyBub24tbnVsbCwgaXQgaXMgdGhlIHR5cGUgb2YgdGhl IGZpbGUgc3lzdGVtIG9uIERFVklDRS4KLSAgIElmIE1PVU5UX1BPSU5UIGlzIG5vbi1udWxs LCB0aGVuIERFVklDRSBtYXkgYmUgbnVsbCAtLSBjZXJ0YWluIHN5c3RlbXMgbWF5CisgICBE RVZJQ0UgbWF5IGJlIG51bGwgLS0gY2VydGFpbiBzeXN0ZW1zIG1heQogICAgbm90IGJlIGFi bGUgdG8gcHJvZHVjZSBzdGF0aXN0aWNzIGluIHRoaXMgY2FzZS4KICAgIE1FX0RVTU1ZIGFu ZCBNRV9SRU1PVEUgYXJlIHRoZSBtb3VudCBlbnRyeSBmbGFncy4KICAgIENhbGxlciBtdXN0 IHNldCBQUk9DRVNTX0FMTCB0byB0cnVlIHdoZW4gaXRlcmF0aW5nIG92ZXIgYWxsIGVudHJp ZXMsIGFzCkBAIC0xMDIwLDE1ICsxMDIwLDExIEBAIGdldF9kZXYgKGNoYXIgY29uc3QgKmRl dmljZSwgY2hhciBjb25zdCAqbW91bnRfcG9pbnQsIGNoYXIgY29uc3QgKmZpbGUsCiAKICAg LyogSWdub3JlIHJlbGF0aXZlIE1PVU5UX1BPSU5Ucywgd2hpY2ggYXJlIHByZXNlbnQgZm9y IGV4YW1wbGUKICAgICAgaW4gL3Byb2MvbW91bnRzIG9uIExpbnV4IHdpdGggbmV0d29yayBu YW1lc3BhY2VzLiAgKi8KLSAgaWYgKCFmb3JjZV9mc3UgJiYgbW91bnRfcG9pbnQgJiYgISBJ U19BQlNPTFVURV9GSUxFX05BTUUgKG1vdW50X3BvaW50KSkKKyAgaWYgKCFmb3JjZV9mc3Ug JiYgISBJU19BQlNPTFVURV9GSUxFX05BTUUgKG1vdW50X3BvaW50KSkKICAgICByZXR1cm47 CiAKLSAgLyogSWYgTU9VTlRfUE9JTlQgaXMgbnVsbCwgdGhlbiB0aGUgZmlsZSBzeXN0ZW0g aXMgbm90IG1vdW50ZWQsIGFuZCB0aGlzCi0gICAgIHByb2dyYW0gcmVwb3J0cyBvbiB0aGUg ZmlsZSBzeXN0ZW0gdGhhdCB0aGUgc3BlY2lhbCBmaWxlIGlzIG9uLgotICAgICBJdCB3b3Vs ZCBiZSBiZXR0ZXIgdG8gcmVwb3J0IG9uIHRoZSB1bm1vdW50ZWQgZmlsZSBzeXN0ZW0sCi0g ICAgIGJ1dCBzdGF0ZnMgZG9lc24ndCBkbyB0aGF0IG9uIG1vc3Qgc3lzdGVtcy4gICovCiAg IGlmICghc3RhdF9maWxlKQotICAgIHN0YXRfZmlsZSA9IG1vdW50X3BvaW50ID8gbW91bnRf cG9pbnQgOiBkZXZpY2U7CisgICAgc3RhdF9maWxlID0gbW91bnRfcG9pbnQ7CiAKICAgc3Ry dWN0IGZzX3VzYWdlIGZzdTsKICAgaWYgKGZvcmNlX2ZzdSkKLS0gCjIuNDguMQoK --------------kreDZiEP69Xzw6mmF9s8xNOq--