From unknown Wed Sep 10 20:06:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79331 <79331@debbugs.gnu.org> To: bug#79331 <79331@debbugs.gnu.org> Subject: Status: [PATCH] expr: fix memory leaks Reply-To: bug#79331 <79331@debbugs.gnu.org> Date: Thu, 11 Sep 2025 03:06:17 +0000 retitle 79331 [PATCH] expr: fix memory leaks reassign 79331 coreutils submitter 79331 yubiao hu severity 79331 normal tag 79331 notabug patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 28 11:05:22 2025 Received: (at submit) by debbugs.gnu.org; 28 Aug 2025 15:05:22 +0000 Received: from localhost ([127.0.0.1]:39547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ureBl-0005qO-43 for submit@debbugs.gnu.org; Thu, 28 Aug 2025 11:05:22 -0400 Received: from lists.gnu.org ([2001:470:142::17]:58486) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1urXQh-0002P7-3H for submit@debbugs.gnu.org; Thu, 28 Aug 2025 03:52:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urXQb-0001x0-7V for bug-coreutils@gnu.org; Thu, 28 Aug 2025 03:52:13 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1urXQZ-0001HX-7f for bug-coreutils@gnu.org; Thu, 28 Aug 2025 03:52:12 -0400 Received: by mail-pf1-x444.google.com with SMTP id d2e1a72fcca58-7718408baf7so673344b3a.3 for ; Thu, 28 Aug 2025 00:52:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756367529; x=1756972329; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=k/vdDsLJzv4keXsuJo+et18p1sesGscgQymMdgDA/tk=; b=FotOnlEqdsGqg5ei55/3OQXXvhP1XsSvRYSQALkY8tn2ewkFXeR4W+xEZ7SdMHf9J4 PmYZ/CS4zMuT/ERj93snYJfXtG2OGN3HhYPYSm8E10bNRRiW6MclAYDfHrINCnxevFCx Op9zs19ALnLYCyGZi3GLFKzsbymZCE5AVr1M5blZLEIlXqfdiGRIQQkrnPmMr7hpQCBk 8ztojpl+F1OHGaqcmPfU4jIpqhKxUT1tNnLbPBIfg+Etqq6VfPZvKm8FaAOMn43eq9IN Dq6SBVlS/6hFrmp6pb7+CA9h7qv4DLlDjqAF8F30aw35XRhUfWDWk4+TuIUJv9T/+pAZ k26A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756367529; x=1756972329; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=k/vdDsLJzv4keXsuJo+et18p1sesGscgQymMdgDA/tk=; b=KK7lMjHFuOZ+g43BURGfgv7KQ+L5UtAYI1Y/hqFoEktmdmImV5W6K/O5Ktpwk+pvBY kUYp6hz/46W9+Ap16/ZN76HOUvgj9GzkNMH8uZBoDOCNWEy8rKGJ5FcFx+uPIJi+53Ww n5vQ5Isd8wvNt9E1+froHUOiaeNRHcRe85nCzhs++QThxx6VybOD1JmsZggzx0SSRfGg 4GFpgBKT8VKadbtlBD5wfvdhTUqqgUq9POLIRjSS0Ke9NapXMtI+tSIVwXN5iMCOozyW GtTOzvGz6akSvVqoj68yOZc7FEa3XMSLpMgaJlAnjWez1/ilo1YnB2tBErZJJLx0Lxpy I91w== X-Gm-Message-State: AOJu0YxL3pJqzK7aFtPf8NUjiGauTk4dgdnHidY0tizgY9cWhTv7ljLE 1E/LH9tL+S3S5zdqPeXkuYpomO0tDiC9HpKa9KwZKknXm9+a18Icwi+83TCd7AypligyB/td1dF yjgUsutzSbqfsobHxkJnBx2uKWwe8Hf2t/xsmViw= X-Gm-Gg: ASbGnctiIAXFSOkOz6UooCp1OwBgUr8X/XYlRFugSLKeASbdyIGa1owIqRHUO+mOhoI rJu8kr+0/DdUNprEjKqro87aAhoKQCuJN1gzb6vpLC57vMRCt6/kkUx4HlfiiIsbEbsi1vRv4IJ G+ATa9eCHAD1KMHBS/lxTWJ9FXaRTTF7uvSUrYfCDw57COR4Ga8Uqn5OUjKmjgPrSoAF7zmzTEB LI1PTLrFeCmvm7qhdHLEqu0ItCOfzDTEik= X-Google-Smtp-Source: AGHT+IEwuySQl+c5X42MGqgt9zMMmPriqk/v0W6XuM5ZSkBED3AgbaqpkC8+5yKb2QVz6fsjPxGVEej0LV/FXHayDUU= X-Received: by 2002:a05:6a20:7fa0:b0:21f:5598:4c2c with SMTP id adf61e73a8af0-24340b01969mr35054281637.13.1756367528987; Thu, 28 Aug 2025 00:52:08 -0700 (PDT) MIME-Version: 1.0 From: yubiao hu Date: Thu, 28 Aug 2025 15:51:56 +0800 X-Gm-Features: Ac12FXyL2k3i6TWLovsk3QXwZW7T-i2kWpMzbagnd6fjnE4kJkiwfShbK_LW79A Message-ID: Subject: [PATCH] expr: fix memory leaks To: bug-coreutils@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::444; envelope-from=huyubiaox@gmail.com; helo=mail-pf1-x444.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 28 Aug 2025 11:05:19 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) fix: https://lists.gnu.org/archive/html/bug-coreutils/2025-08/msg00094.html --- src/expr.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/expr.c b/src/expr.c index cd87763..534bb44 100644 --- a/src/expr.c +++ b/src/expr.c @@ -93,6 +93,7 @@ static VALUE *eval (bool); static bool nomoreargs (void); static bool null (VALUE *v); static void printv (VALUE *v); +static void freev (VALUE *v); /* @@ -307,6 +308,7 @@ int main (int argc, char **argv) { VALUE *v; + bool exit_status = true; initialize_main (&argc, &argv); set_program_name (argv[0]); @@ -343,7 +345,11 @@ main (int argc, char **argv) printv (v); - main_exit (null (v)); + exit_status = null (v); + + freev (v); + + main_exit (exit_status); } /* Return a VALUE for I. */ -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 28 22:30:13 2025 Received: (at control) by debbugs.gnu.org; 29 Aug 2025 02:30:13 +0000 Received: from localhost ([127.0.0.1]:40972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1urosW-0005rd-KJ for submit@debbugs.gnu.org; Thu, 28 Aug 2025 22:30:12 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:53493) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1urosS-0005po-Vy for control@debbugs.gnu.org; Thu, 28 Aug 2025 22:30:09 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-7720f23123dso1627466b3a.2 for ; Thu, 28 Aug 2025 19:30:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756434602; x=1757039402; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=jckIONQ10R7Nb8dX5ha11QBVtOKiepSK7OyHrQ0hs6M=; b=XbEahtY8Ef0E1hW1kVqe4YfItrYu2ksl9BQ9eRqLqdOohrzbO5ljFUFfvfsMhCjSnr TPlBSs+0VxdAB+I+NAk5yEMUuanBuY2skgZLPC0Y/pjaPkUvvAgG17tyYp/LtBM6QH0g To/3c3bfMLQdOEUBsGL65gFfsi1/3VcAJPQ6bEIKm096Bm0ESxRhC7NkWYP4P2cQHlm8 6HhdKQwlFugLdcgL///r5iJeRo4tWXfe2IWp0NtGWYptgywDWY2PSqgej6NayTofjtXo DWX4Gw+CYMeKLyBzew8GsOhBla0EbhqWaMOCP7vPe8E7LplwXUF1jHB/ivO3iCFnGK18 Kw+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756434602; x=1757039402; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jckIONQ10R7Nb8dX5ha11QBVtOKiepSK7OyHrQ0hs6M=; b=HcOjple5nmchvp52CFeWEJlcV55UpUA49Yz0fvv9F5MfmLQQuJcx0rBtqLmjZEEZjs rWU5cwiC/Ly4iJXyavm7FqSnkpLu+LwtOa59VL+dg1sJKgN/MV7A7Rc+8XbVhLQaQKuP M883Fo3KjSKu+jbNCHMeCgIQbz1fG34m4TeUCIYNsIi34S2waq8yPrxZPkE3InnvJXEu aHfhkvXRvkGjVV7tsCsUxVPP2Ta9lMK4dc/LkUr98YwuDNthEdpFywBXmWxEtl5bFlx+ UaMDtNpt3p92LJIfsHuF/6qe5uSsr/AHlwhj2VeuPmU6vOYX7WIselIIZB9jNKPs9V/+ F3PQ== X-Gm-Message-State: AOJu0Yw4z/zOBf38tdAepR2DMQhEPr/q0FuOFTkRkfG+kzBBHuz+oR1V XtXaf86YgvsCXC5gzwSaqy5UdmvZ/1wnG7wy4qxRQU8b5eo2rdXk9/oz8eQ1Ggvq X-Gm-Gg: ASbGncvyeyNZQGhekl+3a5gKXv6HH0vSwwMkN3AaL+RCFg5xXTWIZKj2XHxbDJYdima b0pHph5qiB1ZHtpiATZNjllfdWVn3ObCLXyujHkGo3BFEhU9myLRmSaIP5Ecv8xsll3v8+h8soq ReQIIktH+0cavnnCElXeNFfJkK3GPsBaAxA8xrEW0poQoFyHo6+CnvqOEPIYxBlAXpcEvbP5dZY 2Xv8i51Ki4JloX6BD0lrW0MlJoOsrLD6Oi1OzHHPdaz5XhGtjI45mnXiee7G1gqQv+Tu+UFE+ND rsAXTcYCkNavP74U//8KLfJcF50XlXHYX9REd4m+ezbSZyTw2wfMag1tKJDLwzbCUppr4OzRoJy UY8spPDPqmvTt1opWcakWwprv X-Google-Smtp-Source: AGHT+IEc6ZTR8/JJPucFMbi65qArRVawksh3bUrDgDUrwr3YKkBzZewavRXaFfQ+QBX7aVzAZ7ANBA== X-Received: by 2002:a05:6a20:7486:b0:243:b565:8c1 with SMTP id adf61e73a8af0-243b5650b25mr4998632637.6.1756434602172; Thu, 28 Aug 2025 19:30:02 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::a299]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3276f57b227sm6607963a91.6.2025.08.28.19.30.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 19:30:01 -0700 (PDT) From: Collin Funk To: control@debbugs.gnu.org Subject: 79331 is not a bug. Date: Thu, 28 Aug 2025 19:30:00 -0700 Message-ID: <87ldn2yi53.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 79331 notabug close 79331 Collin From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 28 22:33:59 2025 Received: (at control) by debbugs.gnu.org; 29 Aug 2025 02:33:59 +0000 Received: from localhost ([127.0.0.1]:40990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1urowA-0006SM-Lp for submit@debbugs.gnu.org; Thu, 28 Aug 2025 22:33:59 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:54746) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1urovx-0006QM-T9 for control@debbugs.gnu.org; Thu, 28 Aug 2025 22:33:46 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-7722f2f2aa4so153691b3a.1 for ; Thu, 28 Aug 2025 19:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756434819; x=1757039619; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=euzP98p/78ULVhf+K0WczEUk0bLvXX+y3AYkC2I2pQA=; b=VarLDkLeQEiJ0Crcta/1SsjNkv+UTMOOtAYtsGcy9dHVb/V2JBm4pEz60QLCQanCoy k1DPZl8FoBUavSJ8ooGq/cDxPLARSYD+2mHVqdE1jvp07OGt8iefjuAV9xpElS7Nh0mI 40jreLTnsG/eeTwS6A1fCAD/Xrumkq+QVkFTa2m/FTg7HTXXBBy5A9Vr6QW+kiiYBgXU l7VBz5ordBU/Zlv6dc8xjGU3wKJ1SdPJjDCdSFWbhIKHcJYz781CHyJkV6AR+LY5fJ9T dMKMeYhPuwbyJzkL638mNFx7wrGqy2Ptcs2wpNXrJARO7KSkUb/Et01fgHDfMm0KTX2m YE4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756434819; x=1757039619; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=euzP98p/78ULVhf+K0WczEUk0bLvXX+y3AYkC2I2pQA=; b=fTa0GRWPpXsVYMXtt9bYlFm44iQVEun5lcqomHpLU7ssoKniUDkCE22ch/BtgeK9UU rFEemRHwF3rEeCeDNC9A65SRjiZK0IWGk1aGZMB2tC71rjnfEBpl7utcBG0JVlsMD2M5 mMSsjk9juG6CtlWQi3YUQ1ErHcH4FgK2tJes1Q0dRWzR75vhqOR1cRI5tTFamTh822rL sTYlhT1XRNeu6BBqcVdFzWmkknIEoSBF9RvoUDPtFUk7SOngWm5hmLLAG97MX2Y740je 3exx3hrghhPa/UQq5gKkAxIpsgHv9d88gkUL3eU8aJA5c1zROI1rO/kVXCwJ/nLOJqHl T/Mw== X-Gm-Message-State: AOJu0YxFICk0sWUOpGEHkVm1Aj8qJ1EE8921pNOl2OuOEvVL+VsL5VNH EoYUfYUAmSXInBrAZEs5VbTaKpXNg/3UYorWL/u6OiZV5EJigjayCH8IBDy3GvES X-Gm-Gg: ASbGnct582sr8DYChNDzTptqq43Bo2YH8OirCACIIaPLjvWDSSAbKCgzwacPVIZmFE1 AXNepMomUawkiWd/RpxujTD9TgOgz2zOycb+GLW872UUJ424R2U5YP4m6fwLeVrwqirxBQxUOgE PW7DJF6iYuX2qDF5ZF/MPlqcA4i0LWXtwixaKldGTcfqLE2SCXpiK8BuW8ZTXoZUZqzuTbo+Vjk Hfa9O9SrpC403oUJgo1mx9VTWxiRVT6MGIiUZtK+D93kEGgybmVz6kdXxjRSV99M9jwgd+NLrBC uMrC/IWdhK3cluyY4mUopZM7HHgNdgyT+NjPBTII9SKCXKTEv0dhlxODoiJfshAlPyLcIz1WV1Q Jaw773y2shzOz4MHr5OF+ciaC X-Google-Smtp-Source: AGHT+IFojZwmb8WNa2R4qWxNfWo0BqSwdCTnvERg7Lt1aI2QNA2Zq4XrJWeAJW4QmqsBAIRNylVE0g== X-Received: by 2002:a17:903:187:b0:235:ec11:f0ee with SMTP id d9443c01a7336-2462eded8bbmr337799025ad.14.1756434818897; Thu, 28 Aug 2025 19:33:38 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::a299]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-24903705defsm9197765ad.27.2025.08.28.19.33.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 19:33:38 -0700 (PDT) From: Collin Funk To: control@debbugs.gnu.org Subject: 79331 is a duplicate. Date: Thu, 28 Aug 2025 19:33:37 -0700 Message-ID: <87ecsuyhz2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) merge 79331 79328 thanks Collin