GNU bug report logs - #79330
misleading ring-convert-sequence-to-ring

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Liu Hui <liuhui1610 <at> gmail.com>
Cc: 79330 <at> debbugs.gnu.org
Subject: bug#79330: misleading ring-convert-sequence-to-ring
Date: Thu, 28 Aug 2025 13:59:33 +0300

--text follows this line-
> From: Liu Hui <liuhui1610 <at> gmail.com>
> Date: Thu, 28 Aug 2025 18:47:00 +0800
> 
> The docstring of ring-convert-sequence-to-ring says it "convert
> sequence SEQ to a ring", but it actually ignores any item equal to the
> first item, which is not mentioned:
> 
> ELISP> (ring-convert-sequence-to-ring '(a a a))
> (2 1 . [nil nil a])
> 
> ELISP> (ring-convert-sequence-to-ring '(a b c a b c))
> (1 5 . [nil c b c b a])
> 
> I think either the function or the docstring need to be fixed.

To decide whether we can fix the code would need to look at the
existing users of this function (not only in our tree), since it works
like it works for the last 18 years.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.