GNU bug report logs - #79329
Fix duplicate inputs in comint-read-input-ring

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#79329: closed (Fix duplicate inputs in comint-read-input-ring)
Date: Sat, 06 Sep 2025 08:28:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 06 Sep 2025 11:27:28 +0300
with message-id <861pokgf4f.fsf <at> gnu.org>
and subject line Re: bug#79329: Fix duplicate inputs in comint-read-input-ring
has caused the debbugs.gnu.org bug report #79329,
regarding Fix duplicate inputs in comint-read-input-ring
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
79329: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=79329
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liu Hui <liuhui1610 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Fix duplicate inputs in comint-read-input-ring
Date: Thu, 28 Aug 2025 18:02:00 +0800

[Message part 3 (text/plain, inline)]

1. create a temp history file:
cat > /tmp/history <<EOF
foo
foo
bar
other
bar
EOF

2. HISTFILE=/tmp/history emacs -Q

3. (setq comint-input-ignoredups t)

4. M-x shell

The expected history (ring-elements comint-input-ring) is ("bar"
"other" "bar" "foo"), but the actual result is ("bar" "other" "foo"
"foo").


The reason is comint-read-input-ring uses 0 as the index of the last
input. But the last input is actually inserted by
ring-insert-at-beginning, and it is the oldest item.

[0001-Fix-duplicate-inputs-in-comint-read-input-ring.patch (application/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Liu Hui <liuhui1610 <at> gmail.com>
Cc: 79329-done <at> debbugs.gnu.org
Subject: Re: bug#79329: Fix duplicate inputs in comint-read-input-ring
Date: Sat, 06 Sep 2025 11:27:28 +0300

> From: Liu Hui <liuhui1610 <at> gmail.com>
> Date: Thu, 28 Aug 2025 18:02:00 +0800
> 
> 1. create a temp history file:
> cat > /tmp/history <<EOF
> foo
> foo
> bar
> other
> bar
> EOF
> 
> 2. HISTFILE=/tmp/history emacs -Q
> 
> 3. (setq comint-input-ignoredups t)
> 
> 4. M-x shell
> 
> The expected history (ring-elements comint-input-ring) is ("bar"
> "other" "bar" "foo"), but the actual result is ("bar" "other" "foo"
> "foo").
> 
> 
> The reason is comint-read-input-ring uses 0 as the index of the last
> input. But the last input is actually inserted by
> ring-insert-at-beginning, and it is the oldest item.

Thanks, your changes are now installed on the master branch, and I'm
therefore closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.