GNU bug report logs - #79329
Fix duplicate inputs in comint-read-input-ring

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liu Hui <liuhui1610 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Fix duplicate inputs in comint-read-input-ring
Date: Thu, 28 Aug 2025 18:02:00 +0800

[Message part 1 (text/plain, inline)]

1. create a temp history file:
cat > /tmp/history <<EOF
foo
foo
bar
other
bar
EOF

2. HISTFILE=/tmp/history emacs -Q

3. (setq comint-input-ignoredups t)

4. M-x shell

The expected history (ring-elements comint-input-ring) is ("bar"
"other" "bar" "foo"), but the actual result is ("bar" "other" "foo"
"foo").


The reason is comint-read-input-ring uses 0 as the index of the last
input. But the last input is actually inserted by
ring-insert-at-beginning, and it is the oldest item.

[0001-Fix-duplicate-inputs-in-comint-read-input-ring.patch (application/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.