From unknown Wed Sep 10 20:06:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#79329 <79329@debbugs.gnu.org> To: bug#79329 <79329@debbugs.gnu.org> Subject: Status: Fix duplicate inputs in comint-read-input-ring Reply-To: bug#79329 <79329@debbugs.gnu.org> Date: Thu, 11 Sep 2025 03:06:15 +0000 retitle 79329 Fix duplicate inputs in comint-read-input-ring reassign 79329 emacs submitter 79329 Liu Hui severity 79329 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 28 06:03:09 2025 Received: (at submit) by debbugs.gnu.org; 28 Aug 2025 10:03:09 +0000 Received: from localhost ([127.0.0.1]:38379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1urZTI-0004zr-Tw for submit@debbugs.gnu.org; Thu, 28 Aug 2025 06:03:09 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56124) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1urZTF-0004yI-MH for submit@debbugs.gnu.org; Thu, 28 Aug 2025 06:03:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1urZT8-0006G3-Hj for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2025 06:02:58 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1urZT6-0002zP-Pk for bug-gnu-emacs@gnu.org; Thu, 28 Aug 2025 06:02:58 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3c79f0a5b8bso590690f8f.1 for ; Thu, 28 Aug 2025 03:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756375374; x=1756980174; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=ReCtJb7pBdMQEebQTVYTnP/AR7H+ucpXA5d5j3ZvyK4=; b=YZuVq/XiZHscHPJMX4KOpT5A5m1fX4ycPDxX9kXJayslam7evFbPVp5n8+MNkGdRft 5LjAdfAWyR/teoBtby0nN2bemP/R/yX8f/GlFWhngxg52wD8CmhOWz7dtvKJ2FDyJOx0 kcR5LYpa6ldCmbCgwX2Jl0zK7vkiJVx3+PKyq9nVaKjQzMgnYCAUERGN9GejZuk7q/z7 tTLwVHYK1jINcEVzsVfc0wsomU3NOv3ei7I3znYsgqGhLM9uu6MBlCY2y0xS/60sZrwf uu+O+GLEyzVKqGQCbjfpAkXAGtx+4Gy5DuyQzWiqiet8GzsVrImnHG96au8O+dh1rkbW vQ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756375374; x=1756980174; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ReCtJb7pBdMQEebQTVYTnP/AR7H+ucpXA5d5j3ZvyK4=; b=FikJhp3SlOBgJUglKa7caYmmzg7NLiT29FNHZV1c98Y14UUOfc1IzSEnM4Ba2mmqJ5 IrrLZnW1pfv4/1F+ToZwX3ppSxDAiCUtASk0MftTMoBBLnc+VXAHTZC8wUHoft/ZZ8BW enWf1/tisRl4trjAGCUIxaEHr2f3JrEzv+S40ZGg/40SFsnqLBD8t1RxhS4hAab5eQBU MbU2ptnKAjkqBxE6DSZ1onJNpHQekbcDwBepcmha1BX+PI35yliJZLPsPyahXbUP1ZmW kBksowVos14Urc05rUAM34sjSpE1QwzpX1w2zBvPEHd8M43J4TQUD72HIQlSlw4hFgIW IirA== X-Gm-Message-State: AOJu0YyjIMsUwq68JX7eG+z7gah1Oia36RG4WxWEbEAm6543LUM1YDQr m6o8tS1lDbo+/ubNJZhGfPXY6XgCxYrMIzXBRTQWUdEpPW/ogCL2Iu64go3UQKZj/qp18O7p10U WIJHhBs2oBhK0sBNGZNQ4TiibBFDgZCUp8AywPlU= X-Gm-Gg: ASbGncvVtyLG7X+HjfAa9N12ADbX/QwhGIh+6cXnyEprGgTUd1/focjBCn+9ysL/bQJ 8W3BikHXAVhYHyZzU7fJtdyRGT4QSjxqsH+z7ZKrmIAEjjgJx+W1k5tO294+Qj3vV3pKTyJtX14 WwsizKtfRHiA82vTlzvXeYKRv3U8MGq7698q8iT6/3s+yabTOVMvqjKBhy9bFkGgepYdZI5UTKZ HX3IqM= X-Google-Smtp-Source: AGHT+IEV1juzNdQc5bR230DmBdfD8LZnT1kkTlfQDitAxQfwhGUlZum2ZYrE9Ayh6mMDjmvHN0xAuCUFGPaEkACTySs= X-Received: by 2002:a5d:5887:0:b0:3c4:2005:fb9d with SMTP id ffacd0b85a97d-3c5dcdfd700mr17893312f8f.31.1756375373968; Thu, 28 Aug 2025 03:02:53 -0700 (PDT) MIME-Version: 1.0 From: Liu Hui Date: Thu, 28 Aug 2025 18:02:00 +0800 X-Gm-Features: Ac12FXwBp-_wADH8WUiTL8Fntp1EvFHNcuhyqr5o0CIvdOgR8LDxX_8DVoAzBz8 Message-ID: Subject: Fix duplicate inputs in comint-read-input-ring To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000422952063d6a027b" Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=liuhui1610@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 1. create a temp history file: cat > /tmp/history < List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --000000000000422952063d6a027b Content-Type: text/plain; charset="UTF-8" 1. create a temp history file: cat > /tmp/history < X-Attachment-Id: f_mev48m8w0 RnJvbSA0NjdkNGQ3YWE4ZGMwNWE4YzdjYzBjMWMzMDYwMzU4MjY0N2M1NTIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMaXUgSHVpIDxsaXVodWkxNjEwQGdtYWlsLmNvbT4KRGF0ZTog VGh1LCAyOCBBdWcgMjAyNSAxNzo1NzoyMSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBkdXBs aWNhdGUgaW5wdXRzIGluIGNvbWludC1yZWFkLWlucHV0LXJpbmcKCiogbGlzcC9jb21pbnQuZWwg KGNvbWludC1yZWFkLWlucHV0LXJpbmcpOiBGaXggdGhlIGluZGV4IG9mIHRoZQpsYXN0IGlucHV0 IGluIHRoZSByaW5nLgotLS0KIGxpc3AvY29taW50LmVsIHwgNSArKystLQogMSBmaWxlIGNoYW5n ZWQsIDMgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2Nv bWludC5lbCBiL2xpc3AvY29taW50LmVsCmluZGV4IGJiYjk4MjBjMTZhLi5kZjFjMDhjMzY0NyAx MDA2NDQKLS0tIGEvbGlzcC9jb21pbnQuZWwKKysrIGIvbGlzcC9jb21pbnQuZWwKQEAgLTEwOTAs OCArMTA5MCw5IEBAIGNvbWludC1yZWFkLWlucHV0LXJpbmcKICAgICAgICAgICAgICAgICAgKHdo ZW4gKGFuZCAobm90IChzdHJpbmctbWF0Y2ggaGlzdG9yeS1pZ25vcmUgaGlzdG9yeSkpCiAJCQkg ICAgKG9yIChudWxsIGlnbm9yZWR1cHMpCiAJCQkJKHJpbmctZW1wdHktcCByaW5nKQotCQkJCShu b3QgKHN0cmluZy1lcXVhbCAocmluZy1yZWYgcmluZyAwKQotCQkJCQkJICAgaGlzdG9yeSkpKSkK KwkJCQkobm90IChzdHJpbmctZXF1YWwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKHJpbmctcmVmIHJpbmcgKDEtIChyaW5nLWxlbmd0aCByaW5nKSkpCisJCQkJICAgICAg aGlzdG9yeSkpKSkKIAkJICAgKHdoZW4gKD0gY291bnQgcmluZy1zaXplKQogCQkgICAgIChyaW5n LWV4dGVuZCByaW5nIChtaW4gKC0gcmluZy1tYXgtc2l6ZSByaW5nLXNpemUpCiAJCQkJCSAgICBy aW5nLXNpemUpKQotLSAKMi4yNS4xCgo= --000000000000422952063d6a027b-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 06 04:27:50 2025 Received: (at 79329-done) by debbugs.gnu.org; 6 Sep 2025 08:27:50 +0000 Received: from localhost ([127.0.0.1]:34088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uuoGz-0002cz-Sq for submit@debbugs.gnu.org; Sat, 06 Sep 2025 04:27:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46020) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1uuoGw-0002ca-Dr for 79329-done@debbugs.gnu.org; Sat, 06 Sep 2025 04:27:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uuoGp-0003lK-SL; Sat, 06 Sep 2025 04:27:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=X9cFlZx4jIbCCTfyp7C2PwQ5zgAcgvz3t1CUsPv7GJY=; b=c0DsVDMCWQ7j JAPiY5Si/1RJ9c6LgWCMtAfcRryvYANmnL81ym8oikrlddM/JRIzaVzZBn9MQONiT1URCQiEVh2Ds 1Qk8MgZLflIh7pTV7JlV6q9QMwTCgjWp5VbXZbJHfEMjjSvi17d98s3VRylpEIocYbkqIpXQLNLly AhWvS9UYqC3YfI4Q3BiJY8fa/PUfkgu4CM4Ti0BUOKsyXj5HJZYizEvnafx8LIVaGfgH7pf4Q14tZ CqC9j1JHVANDeq5Wlugo13ASYglqNkbFeXoLt0jlI0YIjVd1zc3vbwp26ejUz9dkyIq9WMgicEWXs qnbrTD63cdcxEibBeXI3ww==; Date: Sat, 06 Sep 2025 11:27:28 +0300 Message-Id: <861pokgf4f.fsf@gnu.org> From: Eli Zaretskii To: Liu Hui In-Reply-To: (message from Liu Hui on Thu, 28 Aug 2025 18:02:00 +0800) Subject: Re: bug#79329: Fix duplicate inputs in comint-read-input-ring References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 79329-done Cc: 79329-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Liu Hui > Date: Thu, 28 Aug 2025 18:02:00 +0800 > > 1. create a temp history file: > cat > /tmp/history < foo > foo > bar > other > bar > EOF > > 2. HISTFILE=/tmp/history emacs -Q > > 3. (setq comint-input-ignoredups t) > > 4. M-x shell > > The expected history (ring-elements comint-input-ring) is ("bar" > "other" "bar" "foo"), but the actual result is ("bar" "other" "foo" > "foo"). > > > The reason is comint-read-input-ring uses 0 as the index of the last > input. But the last input is actually inserted by > ring-insert-at-beginning, and it is the oldest item. Thanks, your changes are now installed on the master branch, and I'm therefore closing the bug.