GNU bug report logs - #79319
[PATCH] * lisp/vc/vc-dispatcher.el (vc-buffer-sync): Check buffer-file-name

Previous Next

Full log

View this message in rfc822 format

From: Lin Sun <sunlin7 <at> hotmail.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: "79319 <at> debbugs.gnu.org" <79319 <at> debbugs.gnu.org>
Subject: bug#79319: [PATCH] * lisp/vc/vc-dispatcher.el (vc-buffer-sync): Check buffer-file-name
Date: Sat, 30 Aug 2025 03:46:01 +0000

From: Sean Whitton <spwhitton <at> spwhitton.name>
Sent: Thursday, August 28, 2025 01:57 AM
>> Hi,
>>
>> I got an error when try to revert a buffer:
>> vc-revert: Wrong type argument: stringp, nil
>>
>> Here is the backtrace:
>> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>>   vc-buffer-sync(nil)
>>   vc-revert()
>>   funcall-interactively(vc-revert)
>>   command-execute(vc-revert)
>>
>>
>> It caused by reverting a buffer which has no file name (like create a buffer but not saving it).
>>
>> This patch will check the `` bebuffer-file-name` before call subsequent function.
>> Please help review the patch, thanks
>
>I think that vc-revert should probably error out sooner for
>non-file-visiting buffers, before it gets to calling vc-buffer-sync.

With this patch, emacs will give user friendly message: "File is not under version control".

Without the patch, it gives an unexpected error message "Wrong type argument: stringp, nil".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.