GNU bug report logs - #79305
31.0.50; MODE-set-explicitly change caused regressions in bind-map

Previous Next

Full log

Message #50 received at 79305 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Aaron Jensen" <aaronjensen <at> gmail.com>
Cc: Justin Burkett <justin <at> burkett.cc>, Jonas Bernoulli <jonas <at> bernoul.li>,
 79305 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused
 regressions in bind-map
Date: Wed, 03 Sep 2025 23:07:49 -0400

> You can try it interactively, but the steps are a little different. If you
> comment everything below the scenario 1 hooks and then run:
>
> emacs -Q -l scripts/repro-evil-local-override-race.el
>
> Then M-x evil-mode
>
> Then C-x C-f somefile
>
> Then SPC x
>
> It will not invoke the binding.
>
> If you then comment the Scenario 1 hooks and comment the Scenario 2 hooks
> and try the same thing, SPC x will be bound.

I don't understand enough of what these things mean to know what is
supposed to be the right behavior (and why).

Is this `SPC x` key supposed to be bound if and only if the
`repro-override-mode` is enabled?

>> Also, the `repro-override-mode` is not enabled in that buffer, so IIUC the
>> `repro-key` binding should not be active, so it would be a bug if
>> 
>> (repro-installed-p) to returned non-nil, right?
>
> It's globalized and is enabled via:
>
> (global-repro-override-mode 1)

Right, but that just means the buffer-local mode should be enabled in
some buffers according to some rule.  In your tests, you run the tests
in a temp buffer where the globalized mode hasn't even had a chance to
enable the buffer-local minor mode, so the buffer-local minor is off.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.