GNU bug report logs - #79305
31.0.50; MODE-set-explicitly change caused regressions in bind-map

Previous Next

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Aaron Jensen" <aaronjensen <at> gmail.com>
Cc: Justin Burkett <justin <at> burkett.cc>, Jonas Bernoulli <jonas <at> bernoul.li>, 79305 <at> debbugs.gnu.org, Sean Whitton <spwhitton <at> spwhitton.name>
Subject: bug#79305: 31.0.50; MODE-set-explicitly change caused regressions in bind-map
Date: Wed, 03 Sep 2025 18:43:12 -0400

> ;; Common sequence for both tests (identical order):
> ;; - New buffer
> ;; - Do NOT touch the per-buffer mode var (it is naturally nil here)
> ;; - Enable Evil locally (hook fires while per-buffer mode is still nil)
>
> ;; Scenario 1: Broken path misses install due to requiring buffer-local mode
> (remove-hook 'evil-local-mode-hook #'repro-broken-install)
> (remove-hook 'evil-local-mode-hook #'repro-fixed-install)
> (add-hook 'evil-local-mode-hook #'repro-broken-install)
>
> (with-temp-buffer
>   (evil-local-mode 1)
>   (repro-log "BROKEN installed? %S" (repro-installed-p)))

I don't understand the intention behind this test: a temp buffer is not
expected to be exposed to the user, so the specific way `evil-mode`
behaves in it doesn't seem very relevant.

Also, the `repro-override-mode` is not enabled in that buffer, so IIUC
the `repro-key` binding should not be active, so it would be a bug if
(repro-installed-p) to returned non-nil, right?


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.