GNU bug report logs - #79305
31.0.50; MODE-set-explicitly change caused regressions in bind-map

Previous Next

Full log

Message #17 received at 79305 <at> debbugs.gnu.org (full text, mbox):

From: "Aaron Jensen" <aaronjensen <at> gmail.com>
To: "Stefan Monnier" <monnier <at> iro.umontreal.ca>
Cc: Jonas Bernoulli <jonas <at> bernoul.li>, 79305 <at> debbugs.gnu.org,
 Sean Whitton <spwhitton <at> spwhitton.name>
Subject: Re: bug#79305: 31.0.50; MODE-set-explicitly change caused
 regressions in bind-map
Date: Fri, 29 Aug 2025 16:23:31 +0000

[Message part 1 (text/plain, inline)]

On Fri, Aug 29, 2025 at 7:43 AM, Stefan Monnier < monnier <at> iro.umontreal.ca > wrote:

> 
> 
>> 
>> 
>> bind-map shouldn't use an internal variable like that.
>> 
>> 
>> 
> 
> 
> 
> +1, tho maybe bind-map has a good reason to do that. Does anyone know
> something about that?
> 
> 
> 
> 

It was in a commit with this message:

Fix evil-local-mode-hook logic

Can't be sure that the override modes are enabled before this hook is

run so we check if the global mode is enabled and if the local mode is

set explicitly in a prior hook (presumably a major mode hook).

https://github.com/justbur/emacs-bind-map/commit/89747f7240e5f51084fd94aad502d67f426e03b4

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.