GNU bug report logs - #79276
[PATCH] Pass remote name explicitly in bug-reference-try-setup-from-vc

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: André A. Gomes <andremegafone <at> gmail.com>
Subject: bug#79276: closed (Re: bug#79276: [PATCH] Pass remote name
 explicitly in bug-reference-try-setup-from-vc)
Date: Mon, 25 Aug 2025 14:14:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#79276: [PATCH] Pass remote name explicitly in bug-reference-try-setup-from-vc

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 79276 <at> debbugs.gnu.org.

-- 
79276: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=79276
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tassilo Horn <tsdh <at> gnu.org>
To: André A. Gomes <andremegafone <at> gmail.com>
Cc: Philip Kaludercic <philipk <at> posteo.net>, Eli Zaretskii <eliz <at> gnu.org>,
 "Basil L. Contovounesios" <basil <at> contovou.net>, 79276-done <at> debbugs.gnu.org
Subject: Re: bug#79276: [PATCH] Pass remote name explicitly in
 bug-reference-try-setup-from-vc
Date: Mon, 25 Aug 2025 16:13:22 +0200

André A. Gomes <andremegafone <at> gmail.com> writes:

Hi André,

>>> That sounds reasonable to me.  Perhaps a comment above that line
>>> explaining the meaning of nil would be sensible.
>>
>> Yes, a comment would be utmost welcome.
>
> Tassilo, I'm attaching a new version of the patch.  It should be ready
> to be pushed.  Thank you.

Yes, it's fine.  I took your commit but amended it slightly so that your
commit message also references this bug report and I extended the new
comment in bug-reference.el a bit.  Pushed to master.  I'm closing this
issue.

Thanks a lot!
  Tassilo

[Message part 3 (message/rfc822, inline)]

From: André A. Gomes <andremegafone <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Pass remote name explicitly in bug-reference-try-setup-from-vc
Date: Wed, 20 Aug 2025 12:16:26 +0300

[Message part 4 (text/plain, inline)]

Tags: patch

Hi,

I investigated why bug-reference-mode's automatic setup wasn't doing
what I expected for some git repositories when the mode is enabled on
Magit buffers.  It turned out that, unsurprisingly, the inference
mechanism requires one of the remotes to the called "upstream" or
"origin" (since this condition didn't hold for the aforementioned
repositories, the conclusion follows).

Please find a trivial patch attached that makes this condition clearer.

It would make sense for Tassilo Horn or Basil L. Contovounesios to take
a look at the patch since they have touched on this functionality
recently.

Thank you.


-- 
André A. Gomes
"You cannot even find the ruins..."

[0001-Pass-remote-name-explicitly-in-bug-reference-try-set.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.