GNU bug report logs - #79259
[PATCH] Fix arg doc off-by-one bug of eglot signature help

Previous Next

Full log

View this message in rfc822 format

From: João Távora <joaotavora <at> gmail.com>
To: Lin Jian <me <at> linj.tech>
Cc: 79259 <at> debbugs.gnu.org
Subject: bug#79259: [PATCH] Fix arg doc off-by-one bug of eglot signature help
Date: Sat, 16 Aug 2025 23:02:22 +0100

[Message part 1 (text/plain, inline)]

On Sat, Aug 16, 2025 at 10:48 PM Lin Jian <me <at> linj.tech> wrote:

> Tags: patch
>
> `parlabel' is 0-indexed.  Arguments of `substring' are also
> 0-indexed.  No need to add 1 to `parlabel' before passing it to
> `substring'.
>

Thanks, but I (or whoever) added the 1+ there probably did so for
a reason.

Maybe they were mistaken, but you have to supply a reproduction recipe
that demonstrates there's a problem with that, so we can check the
before and after, else I could be fixing it for you and breaking it for
someone else.

Please see https://joaotavora.github.io/eglot/#Reporting-bugs-1 for how to
report an Emacs -Q recipe (including a LSP server setup).

Thanks,
João

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.