GNU bug report logs - #79259
[PATCH] Fix arg doc off-by-one bug of eglot signature help

Previous Next

Full log

Message #25 received at 79259-done <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Lin Jian <me <at> linj.tech>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 79259-done <at> debbugs.gnu.org
Subject: Re: bug#79259: [PATCH] Fix arg doc off-by-one bug of eglot
 signature help
Date: Wed, 03 Sep 2025 08:20:56 +0100

Lin Jian <me <at> linj.tech> writes:

>> Anyway, I pushed a slightly simpler fix.
>
> That slightly simpler "fix" changes an unrelated line of code.  It
> introduces a new off-by-1 bug while keeping the off-by-1 bug my patch
> indents to fix unchanged.

Thanks.  You're right, I pushed another fix.

> My patch fixes the mis-match of 2 and 3, while the slightly simpler
> "fix" changes the correct match of 1 and 3.

Should be taken care of now.  BTW, what I meant by "slightly simpler" is
that there's no need for tricks to transform vector to lists, just in
case a misunderstanding of that is why you're quoting "slightly simpler
fix" repeatedly.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.