GNU bug report logs - #79258
[PATCH] Face-ify all comment delimiters in 'lua-ts-mode'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#79258: closed ([PATCH] Face-ify all comment delimiters in
 'lua-ts-mode')
Date: Sat, 30 Aug 2025 08:33:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 30 Aug 2025 11:32:36 +0300
with message-id <864itpqkez.fsf <at> gnu.org>
and subject line Re: bug#79258: [PATCH] Face-ify all comment delimiters in 'lua-ts-mode'
has caused the debbugs.gnu.org bug report #79258,
regarding [PATCH] Face-ify all comment delimiters in 'lua-ts-mode'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
79258: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=79258
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Face-ify all comment delimiters in 'lua-ts-mode'
Date: Sat, 16 Aug 2025 15:43:56 -0500

[Message part 3 (text/plain, inline)]

Tags: patch

Add font-lock-comment-delimiter face to all the initial dashes in single
line comments. Some popular documentation styles recommend triple dashes
and it looks better to have all the dashes in the same face.

[0001-Face-ify-all-comment-delimiters-in-lua-ts-mode.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: 79258-done <at> debbugs.gnu.org
Subject: Re: bug#79258: [PATCH] Face-ify all comment delimiters in
 'lua-ts-mode'
Date: Sat, 30 Aug 2025 11:32:36 +0300

> From: john muhl <jm <at> pub.pink>
> Cc: 79258 <at> debbugs.gnu.org
> Date: Sat, 23 Aug 2025 11:32:48 -0500
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: john muhl <jm <at> pub.pink>
> >> Date: Sat, 16 Aug 2025 15:43:56 -0500
> >> 
> >> Add font-lock-comment-delimiter face to all the initial dashes in single
> >> line comments. Some popular documentation styles recommend triple dashes
> >> and it looks better to have all the dashes in the same face.
> >
> > Thanks, but shouldn't the code which moves point be in save-excursion
> > in this case?  If not, why not?
> 
> I thought the font-lock machinery took care of it. If I followed
> the code correctly then we eventually end up in
> font-lock-default-fontify-syntactically which uses save-excursion.
> 
> Checking the position of point at the beginning of
> lua-ts--comment-font-lock shows that it has already been moved (to
> the end of the line/comment) before there is any chance to call
> save-excursion from here so the position it would restore isn’t
> where the user has the point at anyway.

Thanks, now installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.