GNU bug report logs - #79236
30.1; file-directory-p in read-file-name prevents TRAMP protocol, user, and host completions

Previous Next

Full log

Message #17 received at 79236 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 79236 <at> debbugs.gnu.org, tmiller <at> mitre.org,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#79236: 30.1; file-directory-p in read-file-name prevents
 TRAMP protocol, user, and host completions
Date: Mon, 18 Aug 2025 09:03:05 +0200

[Message part 1 (text/plain, inline)]

Michael Albinus <michael.albinus <at> gmx.de> writes:

Hi,

I'm adding Stefan.

> I've debugged the recipe, and the problem isn't Tramp related. It seems
> to be in function completion-file-name-table, which contains the
> following code:
>
>               ;; Check the predicate, if necessary.
>               (unless (memq pred '(nil file-exists-p))
>                 (let ((comp ())
>                       (pred
>                        (if (eq pred 'file-directory-p)
>                            ;; Brute-force speed up for directory checking:
>                            ;; Discard strings which don't end in a slash.
>                            (lambda (s)
>                              (let ((len (length s)))
>                                (and (> len 0) (eq (aref s (1- len)) ?/))))
>                          ;; Must do it the hard (and slow) way.
>                          pred)))
>                   (let ((default-directory (expand-file-name realdir)))
>                     (dolist (tem all)
>                       (if (funcall pred tem) (push tem comp))))
>                   (setq all (nreverse comp))))
>
> Hmmm. Every hit like "/ssh:" is discarded, when the predicate is file-directory-p.

The appended patch seems to fix it. But I don't know whether this is the
way to go. Stefan?

Best regards, Michael.

[Message part 2 (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.