GNU bug report logs - #79235
31.0.50; Async checkin for Mercurial isn't async enough when checking in a patch

Previous Next

Package: emacs;

Reported by: Sean Whitton <spwhitton <at> spwhitton.name>

Date: Thu, 14 Aug 2025 12:17:02 UTC

Severity: normal

Found in version 31.0.50

Fixed in version 31.1

Done: Sean Whitton <spwhitton <at> spwhitton.name>

Full log


View this message in rfc822 format

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Sean Whitton <spwhitton <at> spwhitton.name>, 79235 <at> debbugs.gnu.org
Cc: sbaugh <at> janestreet.com, arne_bab <at> web.de, oub <at> mat.ucm.es
Subject: bug#79235: 31.0.50; Async checkin for Mercurial isn't async enough when checking in a patch
Date: Fri, 15 Aug 2025 01:23:40 +0300
Hi!

On 14/08/2025 15:15, Sean Whitton wrote:
> But why are we using 'hg import --bypass' in the first place?  If we
> didn't use --bypass then it would just be a single 'hg import' command,
> I think, and that could easily be made asynchronous.
> 
> I looked at the thread from Dmitry was first working on this feature and
> I couldn't see a definitive reason to by passing --bypass.
> Dmitry, do you know why you did it in that way?
> 
> [1]https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg01533.html

The idea was to have the same behavior that we have with Git when using 
the checkin-patch feature: creating a commit on top of the tip without 
affecting the current directory tree.

So for example if you edited the 'vc-diff' buffer before checking it in, 
and the alterations intersect with the current changes in the working 
directory (current file, etc), there is no need to resolve any conflicts 
- they will just show up as differences when you call 'vc-diff' later.

And I'm not even sure you can 'hg import' without '--bypass' unless you 
stash all changes first - which means calling another hg command anyway 
(or doing it manually, which probably will be more work).




This bug report was last modified 23 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.