From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 14 08:16:13 2025 Received: (at submit) by debbugs.gnu.org; 14 Aug 2025 12:16:13 +0000 Received: from localhost ([127.0.0.1]:33069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1umWsO-0006O5-OU for submit@debbugs.gnu.org; Thu, 14 Aug 2025 08:16:13 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55062) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1umWsI-0006N7-7U for submit@debbugs.gnu.org; Thu, 14 Aug 2025 08:16:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1umWrn-00022S-1f for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2025 08:15:36 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1umWrf-0006Op-WA for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2025 08:15:34 -0400 DKIM-Signature: a=rsa-sha256; b=cgUL8bwpW1Sid74N90lcQ3LtJH7hneKSjDy/ttGvKRia4T2dCU2eY7AHD4G71Te86Jt8dSUg+/WO+MArNpshSnHJkkctrP+M5Ut1/QTEWyNnoE7UYwu6dAGduV6+fYXJds718L37Sg6sFLdtVhMwoeI/I1bGsdH2UiTumH+0cnAsDSJOzxkGUd+wjH5eT3I1JYe8JJeTrwDE61eCdCV2SA321QvZ3UyH55AHBl5aC1BO7LCoiYyLcKdeRcqwqY+wTN9yvUbdjZXkNaRUPzus6svfjI+vkdeXnMqyS2mn7Zlm8MdVH8TmQWmYWniU9ej/YTqPP12dN2voYuPKvavbbA==; s=purelymail2; d=spwhitton.name; v=1; bh=t2sZq1OjJBgYWv4E2IfzJ4y6KzJ9IsTC4tLcsZ7QBrw=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=R862Q3r/PXS41syUdxOleRj43h+ZUQcqN5dOe194+fhb6oCM5fcPiCN0U3fGfb6S+zplwFg3erPlkAC1C1WAeCns1xGuac3mdc/QXh0D4C+rSYzvr6msJtmOafuwdZF3LA8hrJ59woWwUarcE6gCEO2drdqguDAfvGLWkMojs3WOcsN0vTuyijgaBMK3Jr0gZtqOF+9ZtrWg0yMpg3IIH8dbRzxL+c+0taveTNBy2hItfZzK0i07kDibxEORQcVAIRGENDybiuGy5o2yQ7ZjcQmaqTqGSWXjI8dwbNrlMbmHgPw7R+AYCvPutjsy8jzoEUb0I4d+N9BOlcXOl72JoA==; s=purelymail2; d=purelymail.com; v=1; bh=t2sZq1OjJBgYWv4E2IfzJ4y6KzJ9IsTC4tLcsZ7QBrw=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: bug-gnu-emacs@gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -155158431 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 14 Aug 2025 12:15:20 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 61C8A940329; Thu, 14 Aug 2025 13:15:18 +0100 (BST) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 31.0.50; Async checkin for Mercurial isn't async enough when checking in a patch Date: Thu, 14 Aug 2025 13:15:18 +0100 Message-ID: <875xeq9k15.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=34.202.193.197; envelope-from=spwhitton@spwhitton.name; helo=sendmail.purelymail.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) X-debbugs-cc: dmitry@gutov.dev, sbaugh@janestreet.com, arne_bab@web.de, oub@mat.ucm.es Hello, vc-hg-checkin-patch runs two commands to effect committing the patch, 'hg import' to create the commit artefact, and 'hg update' to fast-forward the working tree up to the new commit. But currently when vc-async-checkin is non-nil, only the 'hg update' command is run asynchronously. This might be okay if the 'hg import' is always fast and 'hg update' can be slow. But I doubt that's the case in reality. I would assume that they could both be slow in certain repositories. If we want to both commands asynchronously then we need to extend the way async checkins are done to support multiple processes or write out a tiny shell script to chain the two commands together. I think I prefer the latter. But why are we using 'hg import --bypass' in the first place? If we didn't use --bypass then it would just be a single 'hg import' command, I think, and that could easily be made asynchronous. I looked at the thread from Dmitry was first working on this feature and I couldn't see a definitive reason to by passing --bypass. Dmitry, do you know why you did it in that way? [1] https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg01533.html -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 14 18:23:55 2025 Received: (at 79235) by debbugs.gnu.org; 14 Aug 2025 22:23:55 +0000 Received: from localhost ([127.0.0.1]:34886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1umgMU-0004Cq-Is for submit@debbugs.gnu.org; Thu, 14 Aug 2025 18:23:54 -0400 Received: from fhigh-a4-smtp.messagingengine.com ([103.168.172.155]:40297) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1umgMQ-0004CU-SB for 79235@debbugs.gnu.org; Thu, 14 Aug 2025 18:23:53 -0400 Received: from phl-compute-04.internal (phl-compute-04.internal [10.202.2.44]) by mailfhigh.phl.internal (Postfix) with ESMTP id 8330914001CD; Thu, 14 Aug 2025 18:23:44 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-04.internal (MEProxy); Thu, 14 Aug 2025 18:23:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1755210224; x=1755296624; bh=3d5Axc4fQBQ2vC8NhUsrBVZ3PSQOWgFApWU0AkAZafI=; b= d+W7f4nsgvSnDAVpne6PqxWz41lw0BqlKxVn2wof+Yh9aoQb16y62a2lvaewJ828 EOQp2Ntyi7CDdw38gRfo/rWJ7nvoAZ/yuOQtRZo/iWhYDpaNxi9Rtn5gLN2NrWbL aJNXZpRYiKbTlktQqZA9rhOWwF1y3BghWb11vcB9bJJhDG5sEn+dW2K6RoMzTEf/ pmEBP/gOhTsiqqJ5IB9oX73qcLfiAOirRd4TkivOGDIKAcPgcbJZm3krE1sKC/iN FIMAhCk1JVhNUQTTvHDfRaL3Z1I3mFqJqJ7bhs8IlnxzSChVlKSyxHJdnGCpdJga 97m6ipZPfj0IhBfqETCYUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1755210224; x= 1755296624; bh=3d5Axc4fQBQ2vC8NhUsrBVZ3PSQOWgFApWU0AkAZafI=; b=n NSXthvkLb4oQeZrwToj29vyVkZXBRpmeGd6XdkKDcsNmC/RB0SvfjxTotxTJNHff vTcEiw5mM2CUAZDMnltRaDnh5c3gM1DKF8Jws9hb2RNyndpndOr3QU0hK+ud0iqw NM51tUoPbq6OKRspYT4bRMTxpl/S6h7Yf77BtSVKc9ytGbY5YpVC4txzdYCwFPrY 4HqIouhup4QOKIe90kSVWIfD1BFUgetA39hlsPfK52svH0y4M3zPzSnqcZUR0lAg pPchqsLR9rayLM07/a++nXTGc6nkrUdAGENKhGLw09uaIEczVbDntuiXPk3VsR6g 0weohc/Qi4K8QPhyz34uw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddugedvvdejucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhithhr hicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvg hrnhepffeifedvleeukedtgfelieegudfgveekfeejveejffetffeuueeugefhveeiuddv necuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgt phhtthhopeehpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsphifhhhithhtoh hnsehsphifhhhithhtohhnrdhnrghmvgdprhgtphhtthhopeejledvfeehseguvggssghu ghhsrdhgnhhurdhorhhgpdhrtghpthhtohepshgsrghughhhsehjrghnvghsthhrvggvth drtghomhdprhgtphhtthhopegrrhhnvggpsggrsgesfigvsgdruggvpdhrtghpthhtohep ohhusgesmhgrthdruhgtmhdrvghs X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Aug 2025 18:23:42 -0400 (EDT) Message-ID: <2d505489-3795-47e6-89cb-83e0d43a3bcb@gutov.dev> Date: Fri, 15 Aug 2025 01:23:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#79235: 31.0.50; Async checkin for Mercurial isn't async enough when checking in a patch To: Sean Whitton , 79235@debbugs.gnu.org References: <875xeq9k15.fsf@zephyr.silentflame.com> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <875xeq9k15.fsf@zephyr.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 79235 Cc: sbaugh@janestreet.com, arne_bab@web.de, oub@mat.ucm.es X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi! On 14/08/2025 15:15, Sean Whitton wrote: > But why are we using 'hg import --bypass' in the first place? If we > didn't use --bypass then it would just be a single 'hg import' command, > I think, and that could easily be made asynchronous. > > I looked at the thread from Dmitry was first working on this feature and > I couldn't see a definitive reason to by passing --bypass. > Dmitry, do you know why you did it in that way? > > [1]https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg01533.html The idea was to have the same behavior that we have with Git when using the checkin-patch feature: creating a commit on top of the tip without affecting the current directory tree. So for example if you edited the 'vc-diff' buffer before checking it in, and the alterations intersect with the current changes in the working directory (current file, etc), there is no need to resolve any conflicts - they will just show up as differences when you call 'vc-diff' later. And I'm not even sure you can 'hg import' without '--bypass' unless you stash all changes first - which means calling another hg command anyway (or doing it manually, which probably will be more work). From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 16 08:04:32 2025 Received: (at 79235) by debbugs.gnu.org; 16 Aug 2025 12:04:32 +0000 Received: from localhost ([127.0.0.1]:41475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1unFeB-0006D2-Ol for submit@debbugs.gnu.org; Sat, 16 Aug 2025 08:04:32 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:56726) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1unFe8-0006Ci-Si for 79235@debbugs.gnu.org; Sat, 16 Aug 2025 08:04:29 -0400 DKIM-Signature: a=rsa-sha256; b=vFNx8wrdUXrtsbO/YCZkSNc8P0UqXVAKZggZ7eUHm9CqVVESaMHJ35mrBp7cEiGrGLqRldcW2VtkHpiSBxj3kZjzg671Enzz0/cjjUVMJy9TbdKSbTIV/ZE+OAzobB0kkQfGH0Nvh2pV1i8M5XkUCYersjRbHB79Zavm8fQ6Ltrj5R9E/yEirnXrMjj2G6vX/4iVG8Ear3aDCthCFgoqfSc/Tfp1TqPJvciDeozFDSgg9zBh6oDzJ7LnQpCckA6FcUsoZ5x24ek3j6BzPLycyws5gsuPCh6T4ixsFnj4lG8rOQxGjDfQvKK1lR+BRojTXI7E5tBR0hOrJhy7dIAVnw==; s=purelymail2; d=spwhitton.name; v=1; bh=Z7+maRcfJZ0qR42Mh/sfVMeA61wdoLxxwnMxfLZ9XP4=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=rmk2iKeVL62AhjDPigEnhEoIE5JKx8ukYJ6eypvLNdpJMnCccLVvxdEh7jaUYBo5CWHlccfGSWswnXi3rEWOnGdRsH78RRt/zyCkoFRHrZy3FzksyXiIvq9Bv2JYgsvdsLJkcG5Eu/P3BArbM4hijyQgBlzk1eSYalkNLB8QsL3n73BNDvAP4x14DYPyrfajstGESZtnU+cJrh0r6vk+xRIvMGzKap21Fr4yStz6InbLa03CKR15HaRSOONfKvwH8ABGHD8II0wKKUwzgmNJBgul2AmqC103kXurkT9fJdgGRRTmie7zHxmXPaN67/X2Uhi2I3vmcjovNkibtj0Hbg==; s=purelymail2; d=purelymail.com; v=1; bh=Z7+maRcfJZ0qR42Mh/sfVMeA61wdoLxxwnMxfLZ9XP4=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79235@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1507326636; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 16 Aug 2025 12:04:21 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id AB14C94061E; Sat, 16 Aug 2025 13:04:20 +0100 (BST) From: Sean Whitton To: Dmitry Gutov Subject: Re: bug#79235: 31.0.50; Async checkin for Mercurial isn't async enough when checking in a patch In-Reply-To: <2d505489-3795-47e6-89cb-83e0d43a3bcb@gutov.dev> References: <875xeq9k15.fsf@zephyr.silentflame.com> <2d505489-3795-47e6-89cb-83e0d43a3bcb@gutov.dev> Date: Sat, 16 Aug 2025 13:04:20 +0100 Message-ID: <877bz3jwvv.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79235 Cc: 79235@debbugs.gnu.org, arne_bab@web.de, oub@mat.ucm.es, sbaugh@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Fri 15 Aug 2025 at 01:23am +03, Dmitry Gutov wrote: > Hi! > > On 14/08/2025 15:15, Sean Whitton wrote: >> But why are we using 'hg import --bypass' in the first place? If we >> didn't use --bypass then it would just be a single 'hg import' command, >> I think, and that could easily be made asynchronous. >> I looked at the thread from Dmitry was first working on this feature and >> I couldn't see a definitive reason to by passing --bypass. >> Dmitry, do you know why you did it in that way? >> [1]https://lists.gnu.org/archive/html/emacs-devel/2022-10/msg01533.html > > The idea was to have the same behavior that we have with Git when using the > checkin-patch feature: creating a commit on top of the tip without affecting > the current directory tree. > > So for example if you edited the 'vc-diff' buffer before checking it in, and > the alterations intersect with the current changes in the working directory > (current file, etc), there is no need to resolve any conflicts - they will > just show up as differences when you call 'vc-diff' later. > > And I'm not even sure you can 'hg import' without '--bypass' unless you stash > all changes first - which means calling another hg command anyway (or doing it > manually, which probably will be more work). Thanks. That's behaviour worth preserving. How does the following plan seem to you: - make the import command be the one that's done async, not the update - leave a note saying if they are both potentially slow, we should do some messing about to make them both done asynchronously. But don't do that yet in the absence of evidence. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 16 11:20:36 2025 Received: (at 79235) by debbugs.gnu.org; 16 Aug 2025 15:20:36 +0000 Received: from localhost ([127.0.0.1]:43161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1unIhv-000328-R1 for submit@debbugs.gnu.org; Sat, 16 Aug 2025 11:20:36 -0400 Received: from fhigh-a5-smtp.messagingengine.com ([103.168.172.156]:45873) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1unIht-00031l-C9 for 79235@debbugs.gnu.org; Sat, 16 Aug 2025 11:20:34 -0400 Received: from phl-compute-06.internal (phl-compute-06.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 4932A14000D5; Sat, 16 Aug 2025 11:20:27 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-06.internal (MEProxy); Sat, 16 Aug 2025 11:20:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1755357627; x=1755444027; bh=hNFdNbeYVmipFCLhK98qw0Nxm3VUjEvetBLc7tbMj0Q=; b= a6kBBXhFauhcK95nJ7OaaULX2wEdV/PXsnAVQMMQZn2bLwzrbOdMxqg+bYSSEe7H uPeX7kZZva/KXB+GJ4bdfXO6wnF8sdNhrdVDBIVN90J944TMXcaU/Kj7PQgASG4M E8lCwuektV5Uevh6bMjEy0wOSSyNo9y4l5taz27w7iE9Uuxoz+F6/Ka1EzPTOvpX mdnw1XufBNVqDpxHKEh2/3G4jEHg376grTIuj+ETBeGa0Mq6/RUyEOIn4zqlltMh pElvW9+3HS6I1GJB7CkzZF74KEYl15l4Z8X1Aqc6N1huZr5wt0Q30Q3oO9I5RtnY NB81i8kKx7nCnClA+ywqGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1755357627; x= 1755444027; bh=hNFdNbeYVmipFCLhK98qw0Nxm3VUjEvetBLc7tbMj0Q=; b=g MYw+720jYJvDPlEj64hrnxO4z/fXwjV3CcQGW6ZZ6a+e5RJ9d8m0SFRJ5WDxgm6t ztLkzc2TkKK5l83NuzbPYCuEGjeS3g6iVTW/lyPLHnRdV4YzCPqhdi56TfuXt6cp /Q0Sk+3xJ0i/YyeTRY0BK18KPfFeqhPwtwm21yWMl0Hqh46tPb2wQsxe6wqKsOkd yrdFyu9O161W/IvZqrtxfXjan7aqbgoWC+sS5Q58ycVp2ptTh5qCuAfOLVblvYs8 DCPTw2edX7MAL/HpNVc9FqmkBHM6mI6JN5spNSwjupux4cvifRigEONpBT+0c+Et Dyry3K949Z927trKTnESA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddugeejvddtucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhithhr hicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvg hrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedujeeh necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmih htrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthhopeehpdhmohguvgepshhmthhp ohhuthdprhgtphhtthhopehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg dprhgtphhtthhopeejledvfeehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthht ohepshgsrghughhhsehjrghnvghsthhrvggvthdrtghomhdprhgtphhtthhopegrrhhnvg gpsggrsgesfigvsgdruggvpdhrtghpthhtohepohhusgesmhgrthdruhgtmhdrvghs X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Aug 2025 11:20:25 -0400 (EDT) Message-ID: <847895ee-2c68-4aeb-b36a-0a56fd1eb217@gutov.dev> Date: Sat, 16 Aug 2025 18:20:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#79235: 31.0.50; Async checkin for Mercurial isn't async enough when checking in a patch To: Sean Whitton References: <875xeq9k15.fsf@zephyr.silentflame.com> <2d505489-3795-47e6-89cb-83e0d43a3bcb@gutov.dev> <877bz3jwvv.fsf@zephyr.silentflame.com> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <877bz3jwvv.fsf@zephyr.silentflame.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 79235 Cc: 79235@debbugs.gnu.org, arne_bab@web.de, oub@mat.ucm.es, sbaugh@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 16/08/2025 15:04, Sean Whitton wrote: > Thanks. That's behaviour worth preserving. > > How does the following plan seem to you: > > - make the import command be the one that's done async, not the update > > - leave a note saying if they are both potentially slow, we should do > some messing about to make them both done asynchronously. But don't > do that yet in the absence of evidence. Yep, sounds good to me. So your measurements say that 'hg import' is often slower than the subsequent 'hg update'? Could be because of cold/warm disk cache, I suppose. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 16 14:44:00 2025 Received: (at 79235) by debbugs.gnu.org; 16 Aug 2025 18:44:00 +0000 Received: from localhost ([127.0.0.1]:43503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1unLsl-0004nq-O5 for submit@debbugs.gnu.org; Sat, 16 Aug 2025 14:44:00 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:48768) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1unLsj-0004nZ-LU for 79235@debbugs.gnu.org; Sat, 16 Aug 2025 14:43:58 -0400 DKIM-Signature: a=rsa-sha256; b=vaJ6Y1TDMbVa1Gvf/JOc9TJBFRsAsicDI7qXP9IdLB5pTAwzv6nUOVEke/GljqBSYjgnu5fqmHJogT/7FNag6FAAi0yKyyE5IRHphqo10serpuNdvAY7STXQgHBNS26SWH3qK3c4xfyqN2dTSA1rCj2fblnww0r68bjw7d7j/972nKOCDMMkfHrPbrLb2pGA/L5m/PDs0F5nqOrnx//sN3YND3q0fMxBkn5jAiqckk3SvsEsfm2DSWUW8uPZAXR/+XQmKo5OqlEEH4wXWpjaiwWT8RrE+4fGvp8dYCK866BjSOtDE4eUXzuPiIphLeONngOBClexZD7/M3t1ki2UKg==; s=purelymail2; d=spwhitton.name; v=1; bh=6iMB5sJWGEiSumPnlQghVg6/WxK1K3+vj/JekZu6K5k=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=dD4X6YWfCCZA/yD9qtwHOYx/1SCxxf4PbrUfeFapCJ91IbG//msq1EHfgYKlFaSRCMGrMyvL2o4eLZLMgSvTEksxXJsIZX281v+QBwFy6TVWnT6k+LtyeMDxgT77/WZCeePXs4wgx2gLbvAX05P6Pq4DomI5PGOro00oxTcpdeujApVghOIuw81DSfguIy5cYLmOLSJykod+Kor0dN07AegfaGTDIKegzMSwZ6lxaS6iMjArSTJBPdXLeuhnNDbitq8bvyrk+9PCDZfD72Kvz+olH33jeWBn+EqNEQKrHCpmigaB50r42pN82yTcOhbDP8inRDfDuQF0/CRKSxgHHg==; s=purelymail2; d=purelymail.com; v=1; bh=6iMB5sJWGEiSumPnlQghVg6/WxK1K3+vj/JekZu6K5k=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79235@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1696061783; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 16 Aug 2025 18:43:50 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 4224294053D; Sat, 16 Aug 2025 19:43:50 +0100 (BST) From: Sean Whitton To: Dmitry Gutov Subject: Re: bug#79235: 31.0.50; Async checkin for Mercurial isn't async enough when checking in a patch In-Reply-To: <847895ee-2c68-4aeb-b36a-0a56fd1eb217@gutov.dev> References: <875xeq9k15.fsf@zephyr.silentflame.com> <2d505489-3795-47e6-89cb-83e0d43a3bcb@gutov.dev> <877bz3jwvv.fsf@zephyr.silentflame.com> <847895ee-2c68-4aeb-b36a-0a56fd1eb217@gutov.dev> Date: Sat, 16 Aug 2025 19:43:50 +0100 Message-ID: <87zfbzgl95.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79235 Cc: 79235@debbugs.gnu.org, arne_bab@web.de, sbaugh@janestreet.com, oub@mat.ucm.es X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Sat 16 Aug 2025 at 06:20pm +03, Dmitry Gutov wrote: > On 16/08/2025 15:04, Sean Whitton wrote: >> Thanks. That's behaviour worth preserving. >> How does the following plan seem to you: >> - make the import command be the one that's done async, not the update >> - leave a note saying if they are both potentially slow, we should do >> some messing about to make them both done asynchronously. But don't >> do that yet in the absence of evidence. > > Yep, sounds good to me. > > So your measurements say that 'hg import' is often slower than the subsequent > 'hg update'? Could be because of cold/warm disk cache, I suppose. No measurements, I'm afraid. It's just that when I implement vc-async-checkin I didn't stop to consider which of the commands should be asynchronous and just picked the one that runs later. Actually stopping to think about it, creating a new commit object seems likely to be more computationally intensive than moving the record of where the tree is at. This is fallible mostly because it's based on understanding Git fairly well and assuming that Mercurial is just like Git in this respect, which may or may not be true. Thanks for the feedback, I'll work on it. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 17 06:38:19 2025 Received: (at 79235-done) by debbugs.gnu.org; 17 Aug 2025 10:38:19 +0000 Received: from localhost ([127.0.0.1]:45479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1unamI-0000kC-W2 for submit@debbugs.gnu.org; Sun, 17 Aug 2025 06:38:19 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:35868) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1unamG-0000js-Aq for 79235-done@debbugs.gnu.org; Sun, 17 Aug 2025 06:38:17 -0400 DKIM-Signature: a=rsa-sha256; b=dEl0zDLgctbNG9JXAC02dheZfjnVLbiwoYrFP+bh+SvebPpVsQ1gkFCJmjknVJVb+UpoO4ZrzExpwv+CMrufEldnYLw7E0C4FhoaDUVQhuGJ57u2TXVFZmvI50cK2POwy515VBYsMXBTft4tOojsq69L3OgXVlTMEE9UX3lz7YZFffTzGp+QQAOJMAD4pppWzfkZz34UgNQFnUf+wPqoMJYa+mpJ30qET9iyYQtto4Z1inZlZF5+/m4KqRKavSobkKbxclvL9VHchhQwA34gZO1nL5J633GTHy/Arc+5EAkRMMHnVYQTU98RHcoiXGQesLH4eIdArcCwUbb/15RSTQ==; s=purelymail2; d=spwhitton.name; v=1; bh=2dd8aloST0y+GkcU6TG29Ku4dGBvJMUBV8aWaWjVDpA=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=GV+w4TXf4+pRwtDQI5/87gXLKBDacWIJVWtHebvVkeqWCsyvyqRBqP2JL2JgQ7rHTb09KdDE9DsRQTzpwXhKZA7NIrVqFzgA5uODIdeLy7kZ1t42nalTukjwwJfT3map2hYZD+S2wwpviSisNkMYQYedlYjr8emwawSoDqn7KcsEXzLkEDmFgPEYo0pUml5Wztf9zYxYM2AFPy6D/bzy//+CqHgURdbKDIRqNWrtacsafqxuOqo+kQxUP8pdF7MqMU14+iftY1+J/ufDDcy1B13e2cMyfyhcYxR3uYr4jJpFiQVe+gI7yiqlkHr5Lwq6K3nF9sdDpVd2+ysDr1mCbw==; s=purelymail2; d=purelymail.com; v=1; bh=2dd8aloST0y+GkcU6TG29Ku4dGBvJMUBV8aWaWjVDpA=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 79235-done@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 804546626 for <79235-done@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 17 Aug 2025 10:38:09 +0000 (UTC) Received: by zephyr.silentflame.com (Postfix, from userid 1000) id D6125942201; Sun, 17 Aug 2025 11:38:08 +0100 (BST) From: Sean Whitton To: 79235-done@debbugs.gnu.org Subject: Now fixed Date: Sun, 17 Aug 2025 11:38:08 +0100 Message-ID: <87tt26dyi7.fsf@zephyr.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 79235-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Version: 31.1 Hello, The refactoring is complete. -- Sean Whitton