GNU bug report logs - #79227
30.1.90; run-with-timer should error if REPEAT is not a number or nil

Previous Next

To reply to this bug, email your comments to 79227 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.1.90; run-with-timer should error if REPEAT is not a number or nil
Date: Tue, 12 Aug 2025 17:26:14 -0400

The docstring of run-with-timer says REPEAT must be a number or nil, but
it doesn't error if REPEAT is, for example, t.  This is likely to happen
with run-with-idle-timer accepts REPEAT=t.

Message #8 received at 79227 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 79227 <at> debbugs.gnu.org
Subject: Re: bug#79227: 30.1.90;
 run-with-timer should error if REPEAT is not a number or nil
Date: Sat, 16 Aug 2025 10:56:03 +0300

> Date: Tue, 12 Aug 2025 17:26:14 -0400
> From:  Spencer Baugh via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> 
> The docstring of run-with-timer says REPEAT must be a number or nil, but
> it doesn't error if REPEAT is, for example, t.  This is likely to happen
> with run-with-idle-timer accepts REPEAT=t.

Thanks, should be fixed now on the master branch.

I don't understand your reference to run-with-idle-timer, though: for
idle timers, it is perfectly valid to use REPEAT = t.  Did you mean
run-with-timer instead?

Message #11 received at 79227 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 79227 <at> debbugs.gnu.org
Subject: Re: bug#79227: 30.1.90; run-with-timer should error if REPEAT is not
 a number or nil
Date: Sat, 16 Aug 2025 08:55:23 -0400

[Message part 1 (text/plain, inline)]

On Sat, Aug 16, 2025, 3:56 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Date: Tue, 12 Aug 2025 17:26:14 -0400
> > From:  Spencer Baugh via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >
> >
> > The docstring of run-with-timer says REPEAT must be a number or nil, but
> > it doesn't error if REPEAT is, for example, t.  This is likely to happen
> > with run-with-idle-timer accepts REPEAT=t.
>
> Thanks, should be fixed now on the master branch.
>
> I don't understand your reference to run-with-idle-timer, though: for
> idle timers, it is perfectly valid to use REPEAT = t.  Did you mean
> run-with-timer instead?
>

I mean when code previously used run-with-idle-timer and is changed to use
run-with-timer instead, without looking closely at the arguments.

>

[Message part 2 (text/html, inline)]

Message #16 received at 79227-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 79227-done <at> debbugs.gnu.org
Subject: Re: bug#79227: 30.1.90; run-with-timer should error if REPEAT is not
 a number or nil
Date: Sat, 16 Aug 2025 16:19:39 +0300

> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Date: Sat, 16 Aug 2025 08:55:23 -0400
> Cc: 79227 <at> debbugs.gnu.org
> 
> On Sat, Aug 16, 2025, 3:56 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>  > Date: Tue, 12 Aug 2025 17:26:14 -0400
>  > From:  Spencer Baugh via "Bug reports for GNU Emacs,
>  >  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>  > 
>  > 
>  > The docstring of run-with-timer says REPEAT must be a number or nil, but
>  > it doesn't error if REPEAT is, for example, t.  This is likely to happen
>  > with run-with-idle-timer accepts REPEAT=t.
> 
>  Thanks, should be fixed now on the master branch.
> 
>  I don't understand your reference to run-with-idle-timer, though: for
>  idle timers, it is perfectly valid to use REPEAT = t.  Did you mean
>  run-with-timer instead?
> 
> I mean when code previously used run-with-idle-timer and is changed to use run-with-timer instead, without
> looking closely at the arguments. 

OK, thanks.  Then I guess we can close this bug now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.