GNU bug report logs - #79212
31.0.50; Malformed C-h m output

Previous Next

Full log

Message #25 received at control <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 79212 <at> debbugs.gnu.org
Subject: Re: bug#79212: 31.0.50; Malformed C-h m output
Date: Tue, 12 Aug 2025 13:57:31 +0200

close 79212 31.1
quit

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>> Good points, here's a slightly DRYer diff:
>>> 
>>> diff --git a/lisp/help-fns.el b/lisp/help-fns.el
>>> index 9cd30107002..e9601d52e33 100644
>>> --- a/lisp/help-fns.el
>>> +++ b/lisp/help-fns.el
>>> @@ -2253,13 +2253,14 @@ describe-mode
>>>                       (describe-function major))))
>>>            (insert " mode")
>>>            (when-let* ((file-name (find-lisp-object-file-name major nil)))
>>> -	    (insert (format " defined in %s:\n\n"
>>> +	    (insert (format " defined in %s"
>>>                              (buttonize
>>>                               (help-fns-short-filename file-name)
>>>                               (lambda (_)
>>>                                 (help-function-def--button-function
>>>                                  major file-name))))))
>>> -          (insert (help-split-fundoc (documentation major) nil 'doc)
>>> +          (insert ":\n\n"
>>> +                  (help-split-fundoc (documentation major) nil 'doc)
>>>                    (with-current-buffer buffer
>>>                      (help-fns--list-local-commands)))
>>>            (ensure-empty-lines 1)
>>> 
>>
>> Thanks, LGTM.
>
> +1

Great, now pushed to master in commit ae5287c37b7.  Closing.


Thanks,

Eshel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.