GNU bug report logs - #79212
31.0.50; Malformed C-h m output

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Eshel Yaron <me <at> eshelyaron.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 79212 <at> debbugs.gnu.org
Subject: bug#79212: 31.0.50; Malformed C-h m output
Date: Mon, 11 Aug 2025 16:45:38 +0300

> From: Eshel Yaron <me <at> eshelyaron.com>
> Cc: 79212 <at> debbugs.gnu.org
> Date: Mon, 11 Aug 2025 15:01:09 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Thanks, but do we really need to have two copies of \n\n?  And why
> > there's no colon if the mode is not defined in any file?
> 
> Good points, here's a slightly DRYer diff:
> 
> diff --git a/lisp/help-fns.el b/lisp/help-fns.el
> index 9cd30107002..e9601d52e33 100644
> --- a/lisp/help-fns.el
> +++ b/lisp/help-fns.el
> @@ -2253,13 +2253,14 @@ describe-mode
>                       (describe-function major))))
>            (insert " mode")
>            (when-let* ((file-name (find-lisp-object-file-name major nil)))
> -	    (insert (format " defined in %s:\n\n"
> +	    (insert (format " defined in %s"
>                              (buttonize
>                               (help-fns-short-filename file-name)
>                               (lambda (_)
>                                 (help-function-def--button-function
>                                  major file-name))))))
> -          (insert (help-split-fundoc (documentation major) nil 'doc)
> +          (insert ":\n\n"
> +                  (help-split-fundoc (documentation major) nil 'doc)
>                    (with-current-buffer buffer
>                      (help-fns--list-local-commands)))
>            (ensure-empty-lines 1)
> 

Thanks, LGTM.

Stefan, any comments or suggestions?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.