From unknown Thu Sep 11 14:10:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79212: 31.0.50; Malformed C-h m output Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Aug 2025 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 79212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 79212@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.175485076424212 (code B ref -1); Sun, 10 Aug 2025 18:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Aug 2025 18:32:44 +0000 Received: from localhost ([127.0.0.1]:45920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ulAqZ-0006IS-QV for submit@debbugs.gnu.org; Sun, 10 Aug 2025 14:32:44 -0400 Received: from lists.gnu.org ([2001:470:142::17]:36508) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ulAqX-0006IE-SE for submit@debbugs.gnu.org; Sun, 10 Aug 2025 14:32:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulAqG-0004RM-L4 for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2025 14:32:27 -0400 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulAqC-0002Wi-Tb for bug-gnu-emacs@gnu.org; Sun, 10 Aug 2025 14:32:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1754850740; bh=Affw0AYf+k4ZA162o09srW7mh8j4P9Tc/7+Fdj8wmCY=; h=From:To:Subject:Date:From; b=mq8WnaSgSIiE3zDEH9eMJ3sJW2zyHiWw+W1J6u1drvJQAhrQKKZEsJmamhF2PQqqC w7dCnh8PtuRsQpfhTYkWur8RqjK7R20z4K8w5vaAYTf9/HZqJ90xjzxAFvuUSVSWtw LoRDexZsGtNe8kTJ5OuidzHiZoPTf+Q0otKqwLY8rQ3ym4BNJqzokBdJZKpSTAcmOR jMwqxr5rktxVMYjZIsgUk9zT3c8Ugm3sMY5ZLfjkZ4vUWwezqTXyDWPC3nU6Np27iq V3+7kdRbHFgvC45losff3JpZBeO6+y3LL39kVNWLtMHpg7giU2XN4nYQ/6LjI6fzz+ G6alTYEP+ZLsw== From: Eshel Yaron Date: Sun, 10 Aug 2025 20:32:16 +0200 Message-ID: <87sehz10zz.fsf@mail.eshelyaron.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Hi, With emacs -Q, evaluate the following form: (define-derived-mode foo-mode nil "Foo" "Major mode for bar.") Now switch to a new buffer (C-x b foo RET) and put it in foo-mode with M-x foo-mode, and then hit C-h m to describe the current major mode. The Help buffer starts with the following malformed line: The major mode is Foo modeMajor mode for bar. Whereas I would expect something like: The major mode is Foo mode. Major mode for bar. The following diff seems to do the trick: diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 9cd30107002..5f4734fb69d 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -2252,13 +2252,14 @@ describe-mode (lambda (_) (describe-function major)))) (insert " mode") - (when-let* ((file-name (find-lisp-object-file-name major nil))) - (insert (format " defined in %s:\n\n" - (buttonize - (help-fns-short-filename file-name) - (lambda (_) - (help-function-def--button-function - major file-name)))))) + (if-let* ((file-name (find-lisp-object-file-name major nil))) + (insert (format " defined in %s:\n\n" + (buttonize + (help-fns-short-filename file-name) + (lambda (_) + (help-function-def--button-function + major file-name))))) + (insert ".\n\n")) (insert (help-split-fundoc (documentation major) nil 'doc) (with-current-buffer buffer (help-fns--list-local-commands))) From unknown Thu Sep 11 14:10:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79212: 31.0.50; Malformed C-h m output Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Aug 2025 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eshel Yaron Cc: 79212@debbugs.gnu.org Received: via spool by 79212-submit@debbugs.gnu.org id=B79212.17549134048560 (code B ref 79212); Mon, 11 Aug 2025 11:57:02 +0000 Received: (at 79212) by debbugs.gnu.org; 11 Aug 2025 11:56:44 +0000 Received: from localhost ([127.0.0.1]:47366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ulR8t-0002Dz-Tm for submit@debbugs.gnu.org; Mon, 11 Aug 2025 07:56:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50246) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ulR8q-0002Dl-DF for 79212@debbugs.gnu.org; Mon, 11 Aug 2025 07:56:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulR8k-0001rP-Nm; Mon, 11 Aug 2025 07:56:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JkC7haT/diHYE9FfdctHrTaDf6E1rKel/ExvskHr/7I=; b=oPgeFcBmPdi8 lfz0FGG5c5aJlhaBBadPUAtgfcJh4JPpBQzMoGkvR/S1o00BFYc5SqlQZcmJWeAW+m91kWGd26Vqw fZZ2cq6UlNCHgP81TJ+lDdywgdT8i4eBX7FD9jnTwmhVKMGclsiTEn2lKQM8m2KXd9HpHGgCFKrWJ 6xgl1pWyjOd6s1Zd9/jPeWKxpOT2WNz8X9mvTKuud6a/uYEIn7NLnrhj4Dflw6yJwplnwgd/Ja0DL m+ubhNRCzeN0NZX++87koUpTgbYUS2lxjaHAfhSjLEHyQo/esszULlj2F10zTbbgwCdEfykfa/TUT ubGw52QGzHm4GpYvE6O3VA==; Date: Mon, 11 Aug 2025 14:56:31 +0300 Message-Id: <861ppijcls.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87sehz10zz.fsf@mail.eshelyaron.com> (bug-gnu-emacs@gnu.org) References: <87sehz10zz.fsf@mail.eshelyaron.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 10 Aug 2025 20:32:16 +0200 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > Hi, > > With emacs -Q, evaluate the following form: > > (define-derived-mode foo-mode nil "Foo" "Major mode for bar.") > > Now switch to a new buffer (C-x b foo RET) and put it in foo-mode with > M-x foo-mode, and then hit C-h m to describe the current major mode. > > The Help buffer starts with the following malformed line: > > The major mode is Foo modeMajor mode for bar. > > Whereas I would expect something like: > > The major mode is Foo mode. > > Major mode for bar. > > The following diff seems to do the trick: > > diff --git a/lisp/help-fns.el b/lisp/help-fns.el > index 9cd30107002..5f4734fb69d 100644 > --- a/lisp/help-fns.el > +++ b/lisp/help-fns.el > @@ -2252,13 +2252,14 @@ describe-mode > (lambda (_) > (describe-function major)))) > (insert " mode") > - (when-let* ((file-name (find-lisp-object-file-name major nil))) > - (insert (format " defined in %s:\n\n" > - (buttonize > - (help-fns-short-filename file-name) > - (lambda (_) > - (help-function-def--button-function > - major file-name)))))) > + (if-let* ((file-name (find-lisp-object-file-name major nil))) > + (insert (format " defined in %s:\n\n" > + (buttonize > + (help-fns-short-filename file-name) > + (lambda (_) > + (help-function-def--button-function > + major file-name))))) > + (insert ".\n\n")) > (insert (help-split-fundoc (documentation major) nil 'doc) > (with-current-buffer buffer > (help-fns--list-local-commands))) Thanks, but do we really need to have two copies of \n\n? And why there's no colon if the mode is not defined in any file? From unknown Thu Sep 11 14:10:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79212: 31.0.50; Malformed C-h m output Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Aug 2025 13:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 79212@debbugs.gnu.org Received: via spool by 79212-submit@debbugs.gnu.org id=B79212.175491728120871 (code B ref 79212); Mon, 11 Aug 2025 13:02:02 +0000 Received: (at 79212) by debbugs.gnu.org; 11 Aug 2025 13:01:21 +0000 Received: from localhost ([127.0.0.1]:47565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ulS9Q-0005QY-Er for submit@debbugs.gnu.org; Mon, 11 Aug 2025 09:01:20 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:55228 helo=eshelyaron.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ulS9L-0005QL-0V for 79212@debbugs.gnu.org; Mon, 11 Aug 2025 09:01:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1754917273; bh=K8km+ZTQCFOB9pOiJVqm3DRNrjmG/52kdtjXVkn9iuE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ZKA+ZhlULY193BOFv8Oew/ssQ3cmu6WSYorKherqcjSHL6p96BPRATkNowbfSfWMx 6cMKOGzZTrHRajs73HVrAmSd0/ecFGyTxbM4h6ji+8AGAFyxEfaCgsWsXKBtqjYZ4v mFhZW/WdwPbmpSFuulpPo9XX100cn4qt/NJ1oT+FPzM8gIa0zCvUCNWm1ZCiBcRnV/ LMbajxhIKqys28UGbyg0QsgxNZcz0fsQuBmyUL44qHfIqzechAPaeVEWEn51ME0Xt9 xmk9vuIBkYAI5azNrRJDKmHWs6/JqCeRSPE+VV6lSTC1snNSR7NfS2aKCpYyhN/wM4 FP0SdLPu7AfWQ== From: Eshel Yaron In-Reply-To: <861ppijcls.fsf@gnu.org> References: <87sehz10zz.fsf@mail.eshelyaron.com> <861ppijcls.fsf@gnu.org> Date: Mon, 11 Aug 2025 15:01:09 +0200 Message-ID: <87v7muypuy.fsf@mail.eshelyaron.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Sun, 10 Aug 2025 20:32:16 +0200 >> From: Eshel Yaron via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> With emacs -Q, evaluate the following form: >> >> (define-derived-mode foo-mode nil "Foo" "Major mode for bar.") >> >> Now switch to a new buffer (C-x b foo RET) and put it in foo-mode with >> M-x foo-mode, and then hit C-h m to describe the current major mode. >> >> The Help buffer starts with the following malformed line: >> >> The major mode is Foo modeMajor mode for bar. >> >> Whereas I would expect something like: >> >> The major mode is Foo mode. >> >> Major mode for bar. >> >> The following diff seems to do the trick: >> >> diff --git a/lisp/help-fns.el b/lisp/help-fns.el >> index 9cd30107002..5f4734fb69d 100644 >> --- a/lisp/help-fns.el >> +++ b/lisp/help-fns.el >> @@ -2252,13 +2252,14 @@ describe-mode >> (lambda (_) >> (describe-function major)))) >> (insert " mode") >> - (when-let* ((file-name (find-lisp-object-file-name major nil))) >> - (insert (format " defined in %s:\n\n" >> - (buttonize >> - (help-fns-short-filename file-name) >> - (lambda (_) >> - (help-function-def--button-function >> - major file-name)))))) >> + (if-let* ((file-name (find-lisp-object-file-name major nil))) >> + (insert (format " defined in %s:\n\n" >> + (buttonize >> + (help-fns-short-filename file-name) >> + (lambda (_) >> + (help-function-def--button-function >> + major file-name))))) >> + (insert ".\n\n")) >> (insert (help-split-fundoc (documentation major) nil 'doc) >> (with-current-buffer buffer >> (help-fns--list-local-commands))) > > Thanks, but do we really need to have two copies of \n\n? And why > there's no colon if the mode is not defined in any file? Good points, here's a slightly DRYer diff: diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 9cd30107002..e9601d52e33 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -2253,13 +2253,14 @@ describe-mode (describe-function major)))) (insert " mode") (when-let* ((file-name (find-lisp-object-file-name major nil))) - (insert (format " defined in %s:\n\n" + (insert (format " defined in %s" (buttonize (help-fns-short-filename file-name) (lambda (_) (help-function-def--button-function major file-name)))))) - (insert (help-split-fundoc (documentation major) nil 'doc) + (insert ":\n\n" + (help-split-fundoc (documentation major) nil 'doc) (with-current-buffer buffer (help-fns--list-local-commands))) (ensure-empty-lines 1) From unknown Thu Sep 11 14:10:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79212: 31.0.50; Malformed C-h m output Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Aug 2025 13:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eshel Yaron , Stefan Monnier Cc: 79212@debbugs.gnu.org Received: via spool by 79212-submit@debbugs.gnu.org id=B79212.175491989829297 (code B ref 79212); Mon, 11 Aug 2025 13:45:02 +0000 Received: (at 79212) by debbugs.gnu.org; 11 Aug 2025 13:44:58 +0000 Received: from localhost ([127.0.0.1]:47789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ulSpe-0007cT-7K for submit@debbugs.gnu.org; Mon, 11 Aug 2025 09:44:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45060) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ulSpZ-0007c2-8g for 79212@debbugs.gnu.org; Mon, 11 Aug 2025 09:44:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulSpQ-0007aN-RE; Mon, 11 Aug 2025 09:44:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=; b=Cpvcs/tFCPxm tqYArFJXllci1w3nGm0Hy7SmXJda2LMqsRCOAy33NZJv6ipqhw9J9sUrQ1XzjSKfrIXuvzA97acsY umCmFrPBD+T+ItXG3yF6q3REda1CG4OZ21YIzRlHd0Jeip3PnTvQvd/FW93jevNP128UWs57PcHwI tfaMwc0v0N7GEuruP9kjKohJnRogAXLUKVt9j4wfRBKz0iQPGmLvXi5jSbU/th2Hfv7DhqOMr4OO+ iLxaR7HxWwVloFjWzW2jysVA+OVBf7roD5sT3aC++uzL5ovYzQ4pg4TE3n+pJByg3RmR9vbsPVYcB wRzzVu/r8fFXOn0LJaZS8Q==; Date: Mon, 11 Aug 2025 16:44:41 +0300 Message-Id: <867bzaas6u.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87v7muypuy.fsf@mail.eshelyaron.com> (message from Eshel Yaron on Mon, 11 Aug 2025 15:01:09 +0200) References: <87sehz10zz.fsf@mail.eshelyaron.com> <861ppijcls.fsf@gnu.org> <87v7muypuy.fsf@mail.eshelyaron.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) From unknown Thu Sep 11 14:10:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79212: 31.0.50; Malformed C-h m output Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Aug 2025 13:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eshel Yaron , Stefan Monnier Cc: 79212@debbugs.gnu.org Received: via spool by 79212-submit@debbugs.gnu.org id=B79212.175491997830112 (code B ref 79212); Mon, 11 Aug 2025 13:47:01 +0000 Received: (at 79212) by debbugs.gnu.org; 11 Aug 2025 13:46:18 +0000 Received: from localhost ([127.0.0.1]:47800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ulSqv-0007pb-Mi for submit@debbugs.gnu.org; Mon, 11 Aug 2025 09:46:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46640) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ulSqr-0007pI-OJ for 79212@debbugs.gnu.org; Mon, 11 Aug 2025 09:46:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ulSqi-0007yG-0n; Mon, 11 Aug 2025 09:46:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ju8wkL83lj6VpzJgsANAAS3+gmzagTH703G8WCp83Eg=; b=XdX91yhyQNim NvYt+BD8mWloluqZ/gYCYIOj1s+/XaYXaiyGMJ46nHwf+QD5RnmvGRJBGxCx+znNJ4CO3qCAJnM8K wr9xwc7gVzuT0r2YvUvcTyd1aELpcX2lyjS5pT8g+95GO2700zb22zCLanToFrk6jL5cW3nB5cUmz fucV9YKFPlMDgCYD0XjqpydpcbMI5AFOELpobAY5am+JBzo/ZmVheVUWgetwfYZNYXyBTQn2PhqUy 1t6fe+jnBWc+ROg05dldFqc+w7aGtvrPVqFQKDcT0uKiiDuyD4cohMWUYlvweulB8pDYSFqIvu0Up 4NahZw02zfMNUqJfcev0qQ==; Date: Mon, 11 Aug 2025 16:45:38 +0300 Message-Id: <865xeuas59.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87v7muypuy.fsf@mail.eshelyaron.com> (message from Eshel Yaron on Mon, 11 Aug 2025 15:01:09 +0200) References: <87sehz10zz.fsf@mail.eshelyaron.com> <861ppijcls.fsf@gnu.org> <87v7muypuy.fsf@mail.eshelyaron.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eshel Yaron > Cc: 79212@debbugs.gnu.org > Date: Mon, 11 Aug 2025 15:01:09 +0200 > > Eli Zaretskii writes: > > > Thanks, but do we really need to have two copies of \n\n? And why > > there's no colon if the mode is not defined in any file? > > Good points, here's a slightly DRYer diff: > > diff --git a/lisp/help-fns.el b/lisp/help-fns.el > index 9cd30107002..e9601d52e33 100644 > --- a/lisp/help-fns.el > +++ b/lisp/help-fns.el > @@ -2253,13 +2253,14 @@ describe-mode > (describe-function major)))) > (insert " mode") > (when-let* ((file-name (find-lisp-object-file-name major nil))) > - (insert (format " defined in %s:\n\n" > + (insert (format " defined in %s" > (buttonize > (help-fns-short-filename file-name) > (lambda (_) > (help-function-def--button-function > major file-name)))))) > - (insert (help-split-fundoc (documentation major) nil 'doc) > + (insert ":\n\n" > + (help-split-fundoc (documentation major) nil 'doc) > (with-current-buffer buffer > (help-fns--list-local-commands))) > (ensure-empty-lines 1) > Thanks, LGTM. Stefan, any comments or suggestions? From unknown Thu Sep 11 14:10:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79212: 31.0.50; Malformed C-h m output Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Aug 2025 08:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 79212@debbugs.gnu.org, Eshel Yaron Received: via spool by 79212-submit@debbugs.gnu.org id=B79212.175498646519312 (code B ref 79212); Tue, 12 Aug 2025 08:15:02 +0000 Received: (at 79212) by debbugs.gnu.org; 12 Aug 2025 08:14:25 +0000 Received: from localhost ([127.0.0.1]:51624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ulk9J-00051Q-AH for submit@debbugs.gnu.org; Tue, 12 Aug 2025 04:14:25 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11332) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ulk9F-000518-Lr for 79212@debbugs.gnu.org; Tue, 12 Aug 2025 04:14:22 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1305A10025E; Tue, 12 Aug 2025 04:14:16 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1754986454; bh=oh+/p7Rl1cZK6EJKIL3S7Kn4Ce3u/XExf7JdduNlIxs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BxFgb6VoMg2kgjJaDOJyPxn63cuTRWSmbXOXlyy2PkqYbzRnCOZf+Abad+Opy60sY vkLAvja75Ar3Vqet6nkcrnmTH9a7IEzOx7vy1BSWVJPsQVLEEmmW2CDa5RRAj1eC65 eKdJVilJH48RLiOVXtOEPqxnTFDacyBPvFvX+zE6VDClN/zk0uvILgp568LdLGXmaM F37G9uau3X7dm5At5sF0arr9xbJ390BYcdvuCSx7HXixi1zlQgubUnUBOrRwJ9Z26T Sk0UZDjcAj4tzwFHeL0dbrtvn5SCc5Gyiw1pkLXDsxR2aJCDQ/FlRwCwvecP42d7SW cPbiAFA+Q6uoQ== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E8A641000BC; Tue, 12 Aug 2025 04:14:14 -0400 (EDT) Received: from asado (dyn.144-85-254-173.dsl.vtx.ch [144.85.254.173]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AAF92120B16; Tue, 12 Aug 2025 04:14:13 -0400 (EDT) From: Stefan Monnier In-Reply-To: <865xeuas59.fsf@gnu.org> Message-ID: References: <87sehz10zz.fsf@mail.eshelyaron.com> <861ppijcls.fsf@gnu.org> <87v7muypuy.fsf@mail.eshelyaron.com> <865xeuas59.fsf@gnu.org> Date: Tue, 12 Aug 2025 04:14:11 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.012 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Good points, here's a slightly DRYer diff: >> >> diff --git a/lisp/help-fns.el b/lisp/help-fns.el >> index 9cd30107002..e9601d52e33 100644 >> --- a/lisp/help-fns.el >> +++ b/lisp/help-fns.el >> @@ -2253,13 +2253,14 @@ describe-mode >> (describe-function major)))) >> (insert " mode") >> (when-let* ((file-name (find-lisp-object-file-name major nil))) >> - (insert (format " defined in %s:\n\n" >> + (insert (format " defined in %s" >> (buttonize >> (help-fns-short-filename file-name) >> (lambda (_) >> (help-function-def--button-function >> major file-name)))))) >> - (insert (help-split-fundoc (documentation major) nil 'doc) >> + (insert ":\n\n" >> + (help-split-fundoc (documentation major) nil 'doc) >> (with-current-buffer buffer >> (help-fns--list-local-commands))) >> (ensure-empty-lines 1) >> > > Thanks, LGTM. +1 Stefan From unknown Thu Sep 11 14:10:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#79212: 31.0.50; Malformed C-h m output Resent-From: Eshel Yaron Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Aug 2025 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 79212 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Eli Zaretskii , 79212@debbugs.gnu.org Received: via spool by 79212-submit@debbugs.gnu.org id=B79212.17549998678049 (code B ref 79212); Tue, 12 Aug 2025 11:58:02 +0000 Received: (at 79212) by debbugs.gnu.org; 12 Aug 2025 11:57:47 +0000 Received: from localhost ([127.0.0.1]:52435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ulndS-00025j-Qi for submit@debbugs.gnu.org; Tue, 12 Aug 2025 07:57:47 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:33602 helo=eshelyaron.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ulndI-00025O-BT; Tue, 12 Aug 2025 07:57:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1754999855; bh=RzFlan2Ttzn8Tln7og0gUfn11UfcuVvhXBphx2PmjeU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SLNfUPb6mngnwxDfhte3dOUizQqubLh6gIAobCoKdirb4gJ1oo+yDdLNYQ1+3bhJU 28YTfFmoLA2Kl5b7blprM4WcIIYojxWFmoSkNW/E/rvKW5u246fbcJU+FQiX6mDONE G7JeD8EnxuIFiqxqbK4gAsMvdosZXDqvjF8WweQwxeDyI6E0bEyUM8DfbloRZSwvg8 xylfqssgGSVHienS5TUbSMQYIsC1S7kigt1LhHmp9XPFZ+PdHCTR6uywRiLs9zGja9 4agdV3KYcBGID+BbZor94fb66DWDeWlcVtby7dT+tgpnFEvyNE0vWcCgpCW8JFXwF+ JfWkgAaxFNHrg== From: Eshel Yaron In-Reply-To: References: <87sehz10zz.fsf@mail.eshelyaron.com> <861ppijcls.fsf@gnu.org> <87v7muypuy.fsf@mail.eshelyaron.com> <865xeuas59.fsf@gnu.org> Date: Tue, 12 Aug 2025 13:57:31 +0200 Message-ID: <87y0ro69ck.fsf@mail.eshelyaron.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 79212 31.1 quit Stefan Monnier writes: >>> Good points, here's a slightly DRYer diff: >>> >>> diff --git a/lisp/help-fns.el b/lisp/help-fns.el >>> index 9cd30107002..e9601d52e33 100644 >>> --- a/lisp/help-fns.el >>> +++ b/lisp/help-fns.el >>> @@ -2253,13 +2253,14 @@ describe-mode >>> (describe-function major)))) >>> (insert " mode") >>> (when-let* ((file-name (find-lisp-object-file-name major nil))) >>> - (insert (format " defined in %s:\n\n" >>> + (insert (format " defined in %s" >>> (buttonize >>> (help-fns-short-filename file-name) >>> (lambda (_) >>> (help-function-def--button-function >>> major file-name)))))) >>> - (insert (help-split-fundoc (documentation major) nil 'doc) >>> + (insert ":\n\n" >>> + (help-split-fundoc (documentation major) nil 'doc) >>> (with-current-buffer buffer >>> (help-fns--list-local-commands))) >>> (ensure-empty-lines 1) >>> >> >> Thanks, LGTM. > > +1 Great, now pushed to master in commit ae5287c37b7. Closing. Thanks, Eshel