GNU bug report logs - #79199
[PATCH] Add 'lexical-binding' cookie in nnrss output

Previous Next

To reply to this bug, email your comments to 79199 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add 'lexical-binding' cookie in nnrss output
Date: Fri, 08 Aug 2025 18:12:22 +0200

[Message part 1 (text/plain, inline)]

Tags: patch

Hi,

Here's a patch that add the lexical-binding cookie in files generated by
nnrss.el.



In GNU Emacs 31.0.50 (build 12, x86_64-unknown-openbsd7.7) of 2025-08-08
 built on computer
Repository revision: 68b466ab7fc65c3412178fd598091d37921ee2d7
Repository branch: mgi/nnrss-lexical-binding
Windowing system distributor 'The X.Org Foundation', version 11.0.12101018
System Description: OpenBSD computer 7.7 GENERIC.MP#78 amd64

Configured using:
 'configure CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib
 MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=no
 --with-toolkit-scroll-bars=no --without-cairo --without-dbus
 --without-gconf --without-gsettings --without-compress-install'

[0001-Add-lexical-binding-cookie-in-nnrss-output.patch (text/patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Message #8 received at 79199 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: Shenghuo Zhu <zsh <at> cs.rochester.edu>, 79199 <at> debbugs.gnu.org
Subject: Re: bug#79199: [PATCH] Add 'lexical-binding' cookie in nnrss output
Date: Fri, 08 Aug 2025 19:00:02 +0200

>>>>> On Fri, 08 Aug 2025 18:12:22 +0200, Manuel Giraud <manuel <at> ledu-giraud.fr> said:

    Manuel> Tags: patch
    Manuel> Hi,

    Manuel> Here's a patch that add the lexical-binding cookie in files generated by
    Manuel> nnrss.el.

Thanks for that. Does Gnus produce a warning about the missing cookie
when loading those files? If so it would be worth suppressing.

Robert
-- 

Message #11 received at 79199 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Shenghuo Zhu <zsh <at> cs.rochester.edu>, 79199 <at> debbugs.gnu.org
Subject: Re: bug#79199: [PATCH] Add 'lexical-binding' cookie in nnrss output
Date: Fri, 08 Aug 2025 19:14:06 +0200

Robert Pluim <rpluim <at> gmail.com> writes:

>>>>>> On Fri, 08 Aug 2025 18:12:22 +0200, Manuel Giraud <manuel <at> ledu-giraud.fr> said:
>
>     Manuel> Tags: patch
>     Manuel> Hi,
>
>     Manuel> Here's a patch that add the lexical-binding cookie in files generated by
>     Manuel> nnrss.el.
>
> Thanks for that. Does Gnus produce a warning about the missing cookie
> when loading those files? If so it would be worth suppressing.

Yes it does and that was my reason for this patch.  But I don't know how
to suppress those specific warnings.
-- 
Manuel Giraud

Message #14 received at 79199 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: Shenghuo Zhu <zsh <at> cs.rochester.edu>, 79199 <at> debbugs.gnu.org
Subject: Re: bug#79199: [PATCH] Add 'lexical-binding' cookie in nnrss output
Date: Sat, 09 Aug 2025 16:02:23 +0200

>>>>> On Fri, 08 Aug 2025 19:14:06 +0200, Manuel Giraud <manuel <at> ledu-giraud.fr> said:

    Manuel> Robert Pluim <rpluim <at> gmail.com> writes:
    >>>>>>> On Fri, 08 Aug 2025 18:12:22 +0200, Manuel Giraud <manuel <at> ledu-giraud.fr> said:
    >> 
    Manuel> Tags: patch
    Manuel> Hi,
    >> 
    Manuel> Here's a patch that add the lexical-binding cookie in files generated by
    Manuel> nnrss.el.
    >> 
    >> Thanks for that. Does Gnus produce a warning about the missing cookie
    >> when loading those files? If so it would be worth suppressing.

    Manuel> Yes it does and that was my reason for this patch.  But I don't know how
    Manuel> to suppress those specific warnings.

stick a

             (let ((warning-inhibit-types '((files missing-lexbind-cookie))))

around the loading of the file.

Robert
-- 

Message #17 received at 79199 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: Shenghuo Zhu <zsh <at> cs.rochester.edu>, 79199 <at> debbugs.gnu.org
Subject: Re: bug#79199: [PATCH] Add 'lexical-binding' cookie in nnrss output
Date: Sun, 10 Aug 2025 12:33:32 +0200

Robert Pluim <rpluim <at> gmail.com> writes:

>>>>>> On Fri, 08 Aug 2025 19:14:06 +0200, Manuel Giraud <manuel <at> ledu-giraud.fr> said:
>
>     Manuel> Robert Pluim <rpluim <at> gmail.com> writes:
>     >>>>>>> On Fri, 08 Aug 2025 18:12:22 +0200, Manuel Giraud <manuel <at> ledu-giraud.fr> said:
>     >> 
>     Manuel> Tags: patch
>     Manuel> Hi,
>     >> 
>     Manuel> Here's a patch that add the lexical-binding cookie in files generated by
>     Manuel> nnrss.el.
>     >> 
>     >> Thanks for that. Does Gnus produce a warning about the missing cookie
>     >> when loading those files? If so it would be worth suppressing.
>
>     Manuel> Yes it does and that was my reason for this patch.  But I don't know how
>     Manuel> to suppress those specific warnings.
>
> stick a
>
>              (let ((warning-inhibit-types '((files missing-lexbind-cookie))))
>
> around the loading of the file.

Thanks.  Do you know if we need to have both the fix at write time and
the fix at read time?  Because FWIW, with only the fix at write time I
don't see any warnings anymore.
-- 
Manuel Giraud

Message #20 received at 79199 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: rpluim <at> gmail.com, 79199 <at> debbugs.gnu.org, zsh <at> cs.rochester.edu
Subject: Re: bug#79199: [PATCH] Add 'lexical-binding' cookie in nnrss output
Date: Sun, 10 Aug 2025 14:55:04 +0300

> Cc: Shenghuo Zhu <zsh <at> cs.rochester.edu>, 79199 <at> debbugs.gnu.org
> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Date: Sun, 10 Aug 2025 12:33:32 +0200
> 
> Robert Pluim <rpluim <at> gmail.com> writes:
> 
> > stick a
> >
> >              (let ((warning-inhibit-types '((files missing-lexbind-cookie))))
> >
> > around the loading of the file.
> 
> Thanks.  Do you know if we need to have both the fix at write time and
> the fix at read time?  Because FWIW, with only the fix at write time I
> don't see any warnings anymore.

The fix at read time is for when Emacs loads a file written by an
older version of Emacs.  If that could happen (e.g., when Emacs 31 is
first run after being installed), then we need also the read-time fix.

Message #23 received at 79199 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rpluim <at> gmail.com, 79199 <at> debbugs.gnu.org, zsh <at> cs.rochester.edu
Subject: Re: bug#79199: [PATCH] Add 'lexical-binding' cookie in nnrss output
Date: Sun, 10 Aug 2025 15:20:18 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Shenghuo Zhu <zsh <at> cs.rochester.edu>, 79199 <at> debbugs.gnu.org
>> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
>> Date: Sun, 10 Aug 2025 12:33:32 +0200
>> 
>> Robert Pluim <rpluim <at> gmail.com> writes:
>> 
>> > stick a
>> >
>> >              (let ((warning-inhibit-types '((files missing-lexbind-cookie))))
>> >
>> > around the loading of the file.
>> 
>> Thanks.  Do you know if we need to have both the fix at write time and
>> the fix at read time?  Because FWIW, with only the fix at write time I
>> don't see any warnings anymore.
>
> The fix at read time is for when Emacs loads a file written by an
> older version of Emacs.  If that could happen (e.g., when Emacs 31 is
> first run after being installed), then we need also the read-time fix.

Ok.  Here is, I think, a complete version.

[0001-Handle-lexical-binding-cookie-in-nnrss-output.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.