GNU bug report logs - #79197
[PATCH] ; * lisp/simple.el (yank): Update docstring.

Previous Next

Full log

View this message in rfc822 format

From: James Thomas <jimjoe <at> gmx.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 79197 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: bug#79197: [PATCH] ; * lisp/simple.el (yank): Update docstring., Re: bug#79197: [PATCH] ; * lisp/simple.el (yank): Update docstring., Re: bug#79197: [PATCH] ; * lisp/simple.el (yank): Update docstring.
Date: Fri, 15 Aug 2025 01:55:28 +0530

[Message part 1 (text/plain, inline)]

James Thomas <> writes:

> Eli Zaretskii <eliz <at> gnu.org> writes:
>
>>> From: James Thomas <>
>>> Cc: 79197 <at> debbugs.gnu.org,  monnier <at> iro.umontreal.ca
>>> Date: Mon, 11 Aug 2025 18:37:38 +0530
>>> 
>>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>> 
>>> > OK, so given these observations, how do you propose to continue?  Do
>>> > you have a patch to propose, either for the doc string or for the code
>>> > or both? if so, please show the patch, and let's take it from there.
>>> 
>>> 
>>> diff --git a/lisp/simple.el b/lisp/simple.el
>>> index cd13e0a55f4..97701ead69d 100644
>>> --- a/lisp/simple.el
>>> +++ b/lisp/simple.el
>>> @@ -5758,9 +5758,10 @@ kill-new
>>>  	  (setcar kill-ring string)
>>>          (let ((history-delete-duplicates nil))
>>>            (add-to-history 'kill-ring string kill-ring-max t))))
>>> -    (setq kill-ring-yank-pointer kill-ring)
>>> +    (prog1
>>> +        (setq kill-ring-yank-pointer kill-ring)
>>>      (if interprogram-cut-function
>>> -        (funcall interprogram-cut-function string))))
>>> +        (funcall interprogram-cut-function string)))))
>>
>> Why do we need this hunk?
>
> For the correct return value?

Mea culpa:

[0001-Bugfix-79197-yank-does-not-insert-earliest-kill-cons.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

>
>>
>>>  ;; It has been argued that this should work like `self-insert-command'
>>>  ;; which merges insertions in `buffer-undo-list' in groups of 20
>>> @@ -6399,7 +6400,8 @@ yank
>>>    (push-mark)
>>>    (insert-for-yank (current-kill (cond
>>>  				  ((listp arg) 0)
>>> -				  ((eq arg '-) -1)
>>> +				  ((eq arg '-) (- (length kill-ring)
>>> +                                                  (length kill-ring-yank-pointer)))
>>>  				  (t (1- arg)))))
>>
>> So, once again "C-u -" and "C-u - 1" will produce different results?
>>
>> And what about documenting the effect of a negative arg?
>>
>> Thanks.
>
> It was final only for yesterday. :D
>
> A docstring update that turned out to be a bugfix for a faeture that
> wasn't:
>
>
>
>
> Also, my personal wishlist has a new entry: A similar -ve prefix for
> yank-pop equivalent to -1: would be useful after this...

--

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.