GNU bug report logs - #79179
[PATCH 0/2] mariadb-connector-c: Fix build problems

Previous Next

To reply to this bug, email your comments to 79179 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Frederick Muriuki Muriithi <fredmanglis <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] mariadb-connector-c: Fix build problems
Date: Tue,  5 Aug 2025 14:06:10 -0500

The two patches fix 2 issues I encountered with mariadb-connector-c
package - these are:
- The URI used to retrieve sources has changed
- With newer guix (commit 29c8c15), the package build was failing with
  the error `... [-Wimplicit-function-declaration]` for the 'close' and
  'lseek' functions.

Frederick Muriuki Muriithi (2):
  mariadb-connector-c: Update source URI
  Add the line '#include <unistd.h>' to specific files

 gnu/packages/databases.scm | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)


base-commit: 6f40f2b8fbaa5c725eb45ecee25c015172e192ff
prerequisite-patch-id: e31c8304efe52d200986606d6a2e2815c1ea0e7a
prerequisite-patch-id: 051e12f3da5f72398459e9a8abe7f5c2694d941f
prerequisite-patch-id: 5bb6e2921c1048a9ad2558570d0763c7888104ab
prerequisite-patch-id: 4a752a5a6f35199d9f8a1778ad287eff57540817
prerequisite-patch-id: faa0054a0c760116f9ac4ebca9a5d51bf10b82d5
prerequisite-patch-id: 58c3542b0cd70823448872a359ab324784504624
prerequisite-patch-id: 39abf1757381399fb5d9c8c62bbf301c73a59868
prerequisite-patch-id: 437fa13c65ad62eecfe1907454422bbcd6daedc5
prerequisite-patch-id: 7df6adcbe68c3069e2cb0b7fe418d8b43ea8f104
prerequisite-patch-id: d6fa7e1935f01d0fe33e24c56efe6858573981aa
prerequisite-patch-id: c02a779afaac91b6e6b48f9be5702586217dffe5
prerequisite-patch-id: 9763cbd341c402e6af72831626c2d6dac115848e
prerequisite-patch-id: 13f5676484b8aa857b372e58c4549b1337e7d346
prerequisite-patch-id: 0c0a94a83c14782baf63cb1cda4fa65b8186e08d
prerequisite-patch-id: 97a2b9161ad62d2053fca70ac2b28516eb459353
prerequisite-patch-id: d04e8324f7cf1ae58e1349627ffc66b66768b868
prerequisite-patch-id: aeed888bb397fc72ee53ea0aa9ca6f64e12672a5
prerequisite-patch-id: 30d151aab72210a1db16e13b10fbbdb769602748
-- 
2.41.0

Message #8 received at 79179 <at> debbugs.gnu.org (full text, mbox):

From: Frederick Muriuki Muriithi <fredmanglis <at> gmail.com>
To: 79179 <at> debbugs.gnu.org
Subject: [PATCH 1/2] mariadb-connector-c: Update source URI
Date: Tue,  5 Aug 2025 14:09:30 -0500

Mariadb Corporation has changed the download URIs for their products,
therefore this commit updates the source uri.

Change-Id: If439860ea58dbb5a5ab257f9fe5414ed1a684742
---
 gnu/packages/databases.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index dac5178fb0e..a13dcd2c178 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1315,9 +1315,8 @@ (define-public mariadb-connector-c
      (origin
        (method url-fetch)
        (uri (string-append
-             "https://downloads.mariadb.org/f/connector-c-" version
-             "/mariadb-connector-c-" version "-src.tar.gz"
-             "/from/https%3A//mirrors.ukfast.co.uk/sites/mariadb/?serve"))
+             "https://downloads.mariadb.org/rest-api/connector-c/"
+             version "/mariadb-connector-c-" version "-src.tar.gz"))
        (file-name (string-append name "-" version ".tar.gz"))
        (sha256
         (base32 "0xb8fiissblxb319y5ifqqp86zblwis789ipb753pcb4zpnsaw82"))))
-- 
2.41.0

Message #11 received at 79179 <at> debbugs.gnu.org (full text, mbox):

From: Frederick Muriuki Muriithi <fredmanglis <at> gmail.com>
To: 79179 <at> debbugs.gnu.org
Subject: [PATCH 2/2] Add the line '#include <unistd.h>' to specific files
Date: Tue,  5 Aug 2025 14:09:31 -0500

Without the '#include <unistd.h>' in these files, the build phase fails with
the `[-Wimplicit-function-declaration]` error, specifically for the `lseek`
and `close` functions.

This commit adds the line to the following files just before the build phase:
- zlib/gzlib.c
- zlib/gzread.c
- zlib/gzwrite.c

Change-Id: I4bc4ee8e54bc39051b4fa19cf05b70233284e5b6
---
 gnu/packages/databases.scm | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index a13dcd2c178..79051c5d8fd 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1324,7 +1324,20 @@ (define-public mariadb-connector-c
      (list openssl))
     (build-system cmake-build-system)
     (arguments
-     '(#:tests? #f))                    ; no tests
+     `(#:tests? #f                      ; no tests
+       #:phases (modify-phases %standard-phases
+                  (add-before 'build 'include-unistd-h
+                    (lambda* (#:key source #:allow-other-keys)
+                      (substitute* (map (lambda (filename)
+                                          (string-append "../mariadb-connector-c-"
+                                                              ,version
+                                                              "-src/zlib/"
+                                                              filename))
+                                        '("gzlib.c" "gzread.c" "gzwrite.c"))
+                        (("#include \"gzguts.h\"")
+                         (string-append "#include <unistd.h>"
+                                        "\n"
+                                        "#include \"gzguts.h\""))))))))
     (home-page "https://mariadb.com/kb/en/mariadb-connector-c/")
     (synopsis "Client library to connect to MySQL or MariaDB")
     (description "The MariaDB Connector/C is used to connect applications
-- 
2.41.0

Message #16 received at 79179-done <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Frederick Muriuki Muriithi <fredmanglis <at> gmail.com>
Cc: 79179-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] mariadb-connector-c: Update source URI
Date: Wed, 6 Aug 2025 11:04:15 +0200

Hello Frederick,

thanks a lot for your patches!

I have applied the first one after adapting the commit message to our
conventions.

Concerning the second one, it looked good as well, but it was even
easier to update the package; I hope it works as expected.
If not, please feel free to open an issue (preferably on codeberg).

Andreas

Message #19 received at 79179-done <at> debbugs.gnu.org (full text, mbox):

From: Frederick Muriithi <fredmanglis <at> gmail.com>
To: Andreas Enge <andreas <at> enge.fr>
Cc: 79179-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] mariadb-connector-c: Update source URI
Date: Thu, 7 Aug 2025 14:29:35 -0500

It works just fine. Thank you.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.